[GitHub] [beam] damondouglas commented on issue #11340: [BEAM-9678] Create Go SDK introduction kata

2020-04-15 Thread GitBox
damondouglas commented on issue #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#issuecomment-614425499 @henryken I think everything is ok and if you could help uploading this to Stepik that would be really helpful. I'll email you about

[GitHub] [beam] damondouglas commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata

2020-04-15 Thread GitBox
damondouglas commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#discussion_r409292176 ## File path: learning/katas/go/Introduction/Hello Beam/Hello Beam Test/go.mod ## @@ -0,0 +1,25 @@

[GitHub] [beam] damondouglas commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata

2020-04-15 Thread GitBox
damondouglas commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#discussion_r409285045 ## File path: learning/katas/go/Introduction/Hello Beam/Hello Beam/pkg/task/task.go ## @@ -0,0

[GitHub] [beam] amaliujia commented on issue #11333: [BEAM-9418] Support ANY_VALUE aggregation functions

2020-04-15 Thread GitBox
amaliujia commented on issue #11333: [BEAM-9418] Support ANY_VALUE aggregation functions URL: https://github.com/apache/beam/pull/11333#issuecomment-614417914 All tests have failed due to programming style violation. Run `./gradlew spotlessApply` can fix that.

[GitHub] [beam] henryken commented on issue #11340: [BEAM-9678] Create Go SDK introduction kata

2020-04-15 Thread GitBox
henryken commented on issue #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#issuecomment-614414805 If everything is okay, I can help to upload this course to Stepik. This is

[GitHub] [beam] henryken commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata

2020-04-15 Thread GitBox
henryken commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#discussion_r409279710 ## File path: learning/katas/go/Introduction/Hello Beam/Hello Beam Test/go.mod ## @@ -0,0 +1,25 @@ +//

[GitHub] [beam] henryken commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata

2020-04-15 Thread GitBox
henryken commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#discussion_r409279364 ## File path: learning/katas/go/Introduction/Hello Beam/Hello Beam/pkg/task/task.go ## @@ -0,0 +1,24 @@

[GitHub] [beam] reuvenlax opened a new pull request #11436: document schemas

2020-04-15 Thread GitBox
reuvenlax opened a new pull request #11436: document schemas URL: https://github.com/apache/beam/pull/11436 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] chunyang edited a comment on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
chunyang edited a comment on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614377074 Hmm interesting, I agree keeping JSON as default is probably the safer bet. We have seen a case

[GitHub] [beam] chunyang commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
chunyang commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614377074 Hmm interesting, I agree keeping JSON as default is probably the safer bet. We have seen a case internally

[GitHub] [beam] pabloem merged pull request #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem merged pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614374497 And liftoff This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614374425 Run Python PreCommit This is an automated message

[GitHub] [beam] pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614373975 It may still be reasonable to merge this, so that we can be 100% sure that results will be consistent... but you're

[GitHub] [beam] pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614372823 hmm uf - this is truly embarrassing. I inadvertently ran my tests in a branch with changes to the BQ Source. This

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] Fhir io

2020-04-15 Thread GitBox
jaketf edited a comment on issue #11339: [BEAM-9468] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-614332334 @lastomato I added [GroupIntoBatches](https://beam.apache.org/releases/javadoc/2.19.0/org/apache/beam/sdk/transforms/GroupIntoBatches.html) in the

[GitHub] [beam] chunyang commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
chunyang commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614360925 Were there some tests you run to notice the data type incompatibilities? Just curious how you spotted them.

[GitHub] [beam] jaketf edited a comment on issue #11339: [BEAM-9468] Fhir io

2020-04-15 Thread GitBox
jaketf edited a comment on issue #11339: [BEAM-9468] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-614332334 @lastomato I added [GroupIntoBatches](https://beam.apache.org/releases/javadoc/2.19.0/org/apache/beam/sdk/transforms/GroupIntoBatches.html) in the

[GitHub] [beam] pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614358273 Run Python 3.6 PostCommit This is an automated

[GitHub] [beam] chunyang commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
chunyang commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614357801 Gotcha, thanks for the heads up This is an

[GitHub] [beam] pabloem opened a new pull request #11435: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
pabloem opened a new pull request #11435: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11435 Cherry-pick of https://github.com/apache/beam/pull/11433 onto branch for 2.21.0 release Thank

[GitHub] [beam] chjkw commented on issue #11434: Fix typo

2020-04-15 Thread GitBox
chjkw commented on issue #11434: Fix typo URL: https://github.com/apache/beam/pull/11434#issuecomment-614353336 R: @mxm This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] chamikaramj commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
chamikaramj commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614353272 LGTM. Thanks. This is an automated message from

[GitHub] [beam] chjkw opened a new pull request #11434: Fix typo

2020-04-15 Thread GitBox
chjkw opened a new pull request #11434: Fix typo URL: https://github.com/apache/beam/pull/11434 **Please** add a meaningful description for your change here Fix typo "consumer_config" to "producer_config" in the comment Thank you for your

[GitHub] [beam] pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614349385 All tests have passed. I'm now adding change docs to CHANGES.md

[GitHub] [beam] pabloem removed a comment on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
pabloem removed a comment on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614340906 Run Python 2.7 PostCommit This is an

[GitHub] [beam] pabloem removed a comment on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
pabloem removed a comment on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614343489 Run Python 2 PostCommit This is an

[GitHub] [beam] pabloem commented on issue #11358: [BEAM-9729, BEAM-8486] Runner-side bundle registration cleanup.

2020-04-15 Thread GitBox
pabloem commented on issue #11358: [BEAM-9729, BEAM-8486] Runner-side bundle registration cleanup. URL: https://github.com/apache/beam/pull/11358#issuecomment-614345351 For my edification - what happened here? Are bundles registered with the process bundle request?

[GitHub] [beam] pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614343489 Run Python 2 PostCommit This is an automated

[GitHub] [beam] robertwb commented on issue #11432: [BEAM-9577] Small fixes to portable runner staging.

2020-04-15 Thread GitBox
robertwb commented on issue #11432: [BEAM-9577] Small fixes to portable runner staging. URL: https://github.com/apache/beam/pull/11432#issuecomment-614342813 Run Python2_PVR_Flink PreCommit This is an automated message from

[GitHub] [beam] robertwb commented on issue #11430: [BEAM-9768] Gradle command for Python ULR.

2020-04-15 Thread GitBox
robertwb commented on issue #11430: [BEAM-9768] Gradle command for Python ULR. URL: https://github.com/apache/beam/pull/11430#issuecomment-614342080 Run PythonDocker PreCommit This is an automated message from the Apache Git

[GitHub] [beam] pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614340906 Run Python 2.7 PostCommit This is an automated

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614340970 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614340844 3.6 PC: https://builds.apache.org/job/beam_PostCommit_Python36_PR/60/

[GitHub] [beam] boyuanzz commented on a change in pull request #11414: [BEAM-5605, BEAM-2939] Add support for FnApiDoFnRunner to handle split calls.

2020-04-15 Thread GitBox
boyuanzz commented on a change in pull request #11414: [BEAM-5605, BEAM-2939] Add support for FnApiDoFnRunner to handle split calls. URL: https://github.com/apache/beam/pull/11414#discussion_r409204369 ## File path:

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614337532 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614337568 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] reuvenlax closed pull request #10767: Document Beam Schemas

2020-04-15 Thread GitBox
reuvenlax closed pull request #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] jaketf commented on issue #11339: [BEAM-9468] Fhir io

2020-04-15 Thread GitBox
jaketf commented on issue #11339: [BEAM-9468] Fhir io URL: https://github.com/apache/beam/pull/11339#issuecomment-614332334 @lastomato I added [GroupIntoBatches](https://beam.apache.org/releases/javadoc/2.19.0/org/apache/beam/sdk/transforms/GroupIntoBatches.html) in the FhirIO.Import

[GitHub] [beam] amaliujia commented on a change in pull request #11333: [BEAM-9418] Support ANY_VALUE aggregation functions

2020-04-15 Thread GitBox
amaliujia commented on a change in pull request #11333: [BEAM-9418] Support ANY_VALUE aggregation functions URL: https://github.com/apache/beam/pull/11333#discussion_r409190482 ## File path:

[GitHub] [beam] amaliujia commented on a change in pull request #11333: [BEAM-9418] Support ANY_VALUE aggregation functions

2020-04-15 Thread GitBox
amaliujia commented on a change in pull request #11333: [BEAM-9418] Support ANY_VALUE aggregation functions URL: https://github.com/apache/beam/pull/11333#discussion_r409187920 ## File path:

[GitHub] [beam] amaliujia commented on issue #11333: [BEAM-9418] Support ANY_VALUE aggregation functions

2020-04-15 Thread GitBox
amaliujia commented on issue #11333: [BEAM-9418] Support ANY_VALUE aggregation functions URL: https://github.com/apache/beam/pull/11333#issuecomment-614326216 retest this please This is an automated message from the Apache

[GitHub] [beam] amaliujia commented on a change in pull request #11333: [BEAM-9418] Support ANY_VALUE aggregation functions

2020-04-15 Thread GitBox
amaliujia commented on a change in pull request #11333: [BEAM-9418] Support ANY_VALUE aggregation functions URL: https://github.com/apache/beam/pull/11333#discussion_r409188033 ## File path:

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614325022 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] amaliujia commented on issue #11429: [BEAM-9765] Exclude module-info.class from vendored Calcite.

2020-04-15 Thread GitBox
amaliujia commented on issue #11429: [BEAM-9765] Exclude module-info.class from vendored Calcite. URL: https://github.com/apache/beam/pull/11429#issuecomment-614325133 LGTM Also cc @lukecwik in case there is other opinion.

[GitHub] [beam] tvalentyn commented on a change in pull request #11431: [BEAM-8646] Fix external environment on OS X as well.

2020-04-15 Thread GitBox
tvalentyn commented on a change in pull request #11431: [BEAM-8646] Fix external environment on OS X as well. URL: https://github.com/apache/beam/pull/11431#discussion_r409186220 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/worker_handlers.py ##

[GitHub] [beam] pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
pabloem commented on issue #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433#issuecomment-614320399 Run Python 3.6 PostCommit This is an automated

[GitHub] [beam] pabloem opened a new pull request #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink

2020-04-15 Thread GitBox
pabloem opened a new pull request #11433: [BEAM-9769] Ensuring JSON is the default export format for BQ sink URL: https://github.com/apache/beam/pull/11433 TODOs: - [ ] Document the changes in CHANGES.md - [ ] Ensure Pydoc makes sense - [ ] Run PostCommits

[GitHub] [beam] amaliujia merged pull request #11285: Add new release 2.20.0 to beam website

2020-04-15 Thread GitBox
amaliujia merged pull request #11285: Add new release 2.20.0 to beam website URL: https://github.com/apache/beam/pull/11285 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] amaliujia merged pull request #11298: add 2.20.0 blog post

2020-04-15 Thread GitBox
amaliujia merged pull request #11298: add 2.20.0 blog post URL: https://github.com/apache/beam/pull/11298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614313665 @pabloem reshuffle added and ITs passing locally as of c50df5f This is an automated message from

[GitHub] [beam] jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614311975 @pabloem please do not retest this until I say so. reshuffle is messing up something to do w/ coders in my ITs. will investigate and let you know when it's

[GitHub] [beam] chamikaramj commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
chamikaramj commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614310149 You can also consider adding an option to not add the Reshuffle to avoid adding any additional shuffle for anyone who already will have a GBK downstream. See

[GitHub] [beam] chamikaramj commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
chamikaramj commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614309223 You can ignore the deprecation warning for Reshuffle.viaRandomKey(). The deprecation was just because the behavior across runners for Reshuffle is not well

[GitHub] [beam] jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
jaketf commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614306261 >Yeah, this can be a performance bottleneck and this whole operation will be limited to a single machine. Usually sources need an additional level of parallelism

[GitHub] [beam] robertwb opened a new pull request #11432: [BEAM-9577] Small fixes to portable runner staging.

2020-04-15 Thread GitBox
robertwb opened a new pull request #11432: [BEAM-9577] Small fixes to portable runner staging. URL: https://github.com/apache/beam/pull/11432 * Create parent directories if not present in local filesystem. * Deep protobuf copy. R: @ihji

[GitHub] [beam] robertwb commented on issue #11431: [BEAM-8646] Fix external environment on OS X as well.

2020-04-15 Thread GitBox
robertwb commented on issue #11431: [BEAM-8646] Fix external environment on OS X as well. URL: https://github.com/apache/beam/pull/11431#issuecomment-614304091 R: @tvalentyn This is an automated message from the Apache Git

[GitHub] [beam] robertwb opened a new pull request #11431: [BEAM-8646] Fix external environment on OS X as well.

2020-04-15 Thread GitBox
robertwb opened a new pull request #11431: [BEAM-8646] Fix external environment on OS X as well. URL: https://github.com/apache/beam/pull/11431 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and

[GitHub] [beam] robertwb commented on issue #11430: [BEAM-9768] Gradle command for Python ULR.

2020-04-15 Thread GitBox
robertwb commented on issue #11430: [BEAM-9768] Gradle command for Python ULR. URL: https://github.com/apache/beam/pull/11430#issuecomment-614303398 R: @youngoli This is an automated message from the Apache Git Service. To

[GitHub] [beam] robertwb opened a new pull request #11430: [BEAM-9768] Gradle command for Python ULR.

2020-04-15 Thread GitBox
robertwb opened a new pull request #11430: [BEAM-9768] Gradle command for Python ULR. URL: https://github.com/apache/beam/pull/11430 One can now run ./gradlew startPortableRunner to build and start the Python ULR. Thank you for your

[GitHub] [beam] ibzib opened a new pull request #11429: [BEAM-9765] Exclude module-info.class from vendored Calcite.

2020-04-15 Thread GitBox
ibzib opened a new pull request #11429: [BEAM-9765] Exclude module-info.class from vendored Calcite. URL: https://github.com/apache/beam/pull/11429 cc @suztomo Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] Hannah-Jiang commented on issue #11428: [BEAM-9764] fix Java license failures with Python2_PVR_Flink PreCommit

2020-04-15 Thread GitBox
Hannah-Jiang commented on issue #11428: [BEAM-9764] fix Java license failures with Python2_PVR_Flink PreCommit URL: https://github.com/apache/beam/pull/11428#issuecomment-614301680 Run Python2_PVR_Flink PreCommit This is an

[GitHub] [beam] chamikaramj commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
chamikaramj commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r409150054 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@

[GitHub] [beam] chamikaramj commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
chamikaramj commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r409150823 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@

[GitHub] [beam] amaliujia commented on a change in pull request #11285: Add new release 2.20.0 to beam website

2020-04-15 Thread GitBox
amaliujia commented on a change in pull request #11285: Add new release 2.20.0 to beam website URL: https://github.com/apache/beam/pull/11285#discussion_r409151082 ## File path: website/src/get-started/downloads.md ## @@ -90,10 +90,15 @@ versions denoted `0.x.y`. ##

[GitHub] [beam] robertwb commented on issue #11427: Remove deprecated, unused SingleEnvironmentInstanceJobBundleFactory.java

2020-04-15 Thread GitBox
robertwb commented on issue #11427: Remove deprecated, unused SingleEnvironmentInstanceJobBundleFactory.java URL: https://github.com/apache/beam/pull/11427#issuecomment-614289358 Hmm... this does seem to be used by samza and the legacy dataflow worker. Wonder how IntelliJ missed that.

[GitHub] [beam] amaliujia commented on a change in pull request #11285: Add new release 2.20.0 to beam website

2020-04-15 Thread GitBox
amaliujia commented on a change in pull request #11285: Add new release 2.20.0 to beam website URL: https://github.com/apache/beam/pull/11285#discussion_r409143930 ## File path: website/src/get-started/downloads.md ## @@ -90,10 +90,15 @@ versions denoted `0.x.y`. ##

[GitHub] [beam] robertwb merged pull request #11358: [BEAM-9729, BEAM-8486] Runner-side bundle registration cleanup.

2020-04-15 Thread GitBox
robertwb merged pull request #11358: [BEAM-9729, BEAM-8486] Runner-side bundle registration cleanup. URL: https://github.com/apache/beam/pull/11358 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] boyuanzz commented on a change in pull request #11285: Add new release 2.20.0 to beam website

2020-04-15 Thread GitBox
boyuanzz commented on a change in pull request #11285: Add new release 2.20.0 to beam website URL: https://github.com/apache/beam/pull/11285#discussion_r409140298 ## File path: website/src/get-started/downloads.md ## @@ -90,10 +90,15 @@ versions denoted `0.x.y`. ##

[GitHub] [beam] tweise merged pull request #11399: Interpolate publish credentials as expected for Maven settings.xml

2020-04-15 Thread GitBox
tweise merged pull request #11399: Interpolate publish credentials as expected for Maven settings.xml URL: https://github.com/apache/beam/pull/11399 This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] amaliujia commented on issue #11298: add 2.20.0 blog post

2020-04-15 Thread GitBox
amaliujia commented on issue #11298: add 2.20.0 blog post URL: https://github.com/apache/beam/pull/11298#issuecomment-614284344 Run Website_Stage_GCS PreCommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] amaliujia commented on issue #11298: add 2.20.0 blog post

2020-04-15 Thread GitBox
amaliujia commented on issue #11298: add 2.20.0 blog post URL: https://github.com/apache/beam/pull/11298#issuecomment-614284389 Run Website PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] amaliujia commented on a change in pull request #11298: add 2.20.0 blog post

2020-04-15 Thread GitBox
amaliujia commented on a change in pull request #11298: add 2.20.0 blog post URL: https://github.com/apache/beam/pull/11298#discussion_r409137001 ## File path: website/src/_posts/2020-03-01-beam-2.20.0.md ## @@ -0,0 +1,76 @@ +--- +layout: post +title: "Apache Beam 2.20.0"

[GitHub] [beam] tweise commented on issue #11399: Interpolate publish credentials as expected for Maven settings.xml

2020-04-15 Thread GitBox
tweise commented on issue #11399: Interpolate publish credentials as expected for Maven settings.xml URL: https://github.com/apache/beam/pull/11399#issuecomment-614278012 Run Python2_PVR_Flink PreCommit This is an automated

[GitHub] [beam] pabloem commented on issue #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner

2020-04-15 Thread GitBox
pabloem commented on issue #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner URL: https://github.com/apache/beam/pull/11270#issuecomment-614275628 Run Python PreCommit This is an automated message from the Apache

[GitHub] [beam] soyrice commented on issue #11415: [BEAM-9650] Cleanup documentation on side inputs patterns

2020-04-15 Thread GitBox
soyrice commented on issue #11415: [BEAM-9650] Cleanup documentation on side inputs patterns URL: https://github.com/apache/beam/pull/11415#issuecomment-614275077 LGTM (modulo one last comment). Thanks again for opening this PR and doing an editorial review

[GitHub] [beam] soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns

2020-04-15 Thread GitBox
soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns URL: https://github.com/apache/beam/pull/11415#discussion_r409127336 ## File path: website/src/documentation/patterns/side-inputs.md ## @@ -46,29 +54,34 @@ For

[GitHub] [beam] rohdesamuel commented on a change in pull request #11335: [BEAM-9692]: Make CombineValues portable

2020-04-15 Thread GitBox
rohdesamuel commented on a change in pull request #11335: [BEAM-9692]: Make CombineValues portable URL: https://github.com/apache/beam/pull/11335#discussion_r409125734 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner_test.py ## @@ -566,6 +566,19 @@

[GitHub] [beam] soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns

2020-04-15 Thread GitBox
soyrice commented on a change in pull request #11415: [BEAM-9650] Cleanup documentation on side inputs patterns URL: https://github.com/apache/beam/pull/11415#discussion_r409124997 ## File path: website/src/documentation/patterns/side-inputs.md ## @@ -46,29 +54,36 @@ For

[GitHub] [beam] pabloem commented on issue #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner

2020-04-15 Thread GitBox
pabloem commented on issue #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner URL: https://github.com/apache/beam/pull/11270#issuecomment-614269899 Run Python PreCommit This is an automated message from the Apache

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614269167 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614268998 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on issue #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner

2020-04-15 Thread GitBox
pabloem commented on issue #11270: [BEAM-9639][BEAM-9608] Improvements for FnApiRunner URL: https://github.com/apache/beam/pull/11270#issuecomment-614268696 failed test is streaming wordcount test This is an automated

[GitHub] [beam] kmjung commented on a change in pull request #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size

2020-04-15 Thread GitBox
kmjung commented on a change in pull request #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size URL: https://github.com/apache/beam/pull/11292#discussion_r409118981 ## File path:

[GitHub] [beam] kmjung commented on a change in pull request #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size

2020-04-15 Thread GitBox
kmjung commented on a change in pull request #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size URL: https://github.com/apache/beam/pull/11292#discussion_r409117833 ## File path:

[GitHub] [beam] ibzib merged pull request #11426: [BEAM-9756] [cherry-pick] Nexmark: only use --region in Dataflow.

2020-04-15 Thread GitBox
ibzib merged pull request #11426: [BEAM-9756] [cherry-pick] Nexmark: only use --region in Dataflow. URL: https://github.com/apache/beam/pull/11426 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614263256 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] Hannah-Jiang opened a new pull request #11428: fix failures

2020-04-15 Thread GitBox
Hannah-Jiang opened a new pull request #11428: fix failures URL: https://github.com/apache/beam/pull/11428 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] chamikaramj commented on a change in pull request #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size

2020-04-15 Thread GitBox
chamikaramj commented on a change in pull request #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size URL: https://github.com/apache/beam/pull/11292#discussion_r409111886 ## File path:

[GitHub] [beam] chamikaramj commented on a change in pull request #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size

2020-04-15 Thread GitBox
chamikaramj commented on a change in pull request #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size URL: https://github.com/apache/beam/pull/11292#discussion_r409107026 ## File path:

[GitHub] [beam] Hannah-Jiang commented on issue #11428: fix failures

2020-04-15 Thread GitBox
Hannah-Jiang commented on issue #11428: fix failures URL: https://github.com/apache/beam/pull/11428#issuecomment-614261943 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614260458 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614251554 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614249032 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614243069 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-15 Thread GitBox
pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r409090101 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -610,7 +611,8 @@ def __init__(

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614241615 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614240401 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614239497 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-04-15 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-614238420 retest this please This is an automated message from the Apache Git Service. To respond to

  1   2   3   >