[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r426969362 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ## @@ -0,0 +1,162 @@ +/*

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r426968398 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java ## @@ -175,6 +185,37 @@ private

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r426967410 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/TVFStreamingUtils.java ## @@ -0,0 +1,24 @@ +/* + * Li

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r426966749 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ## @@ -0,0 +1,162 @@ +/*

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r424679323 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ## @@ -0,0 +1,162 @@ +/*

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r424679323 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ## @@ -0,0 +1,162 @@ +/*

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r422353370 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ## @@ -0,0 +1,157 @@ +/*

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r422352424 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/TVFScanConverter.java ## @@ -0,0 +1,

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r422352127 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/TVFScanConverter.java ## @@ -0,0 +1,

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r422351792 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java ## @@ -551,

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r422351792 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java ## @@ -551,

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r422350614 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java ## @@ -551,

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r422347543 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlWindowTableFunction.java ## @@ -0,0 +1,113 @@

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r422347071 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rule/BeamTableFunctionScanRule.java ## @@ -0,0 +1,60 @@ +/*

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r422345948 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/planner/BeamRuleSets.java ## @@ -133,7 +134,7 @@

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r422346192 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ## @@ -0,0 +1,157 @@ +/*

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r422346049 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ## @@ -0,0 +1,157 @@ +/*

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r422345657 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ## @@ -0,0 +1,157 @@ +/*

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF URL: https://github.com/apache/beam/pull/10946#discussion_r408351446 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ###

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF URL: https://github.com/apache/beam/pull/10946#discussion_r408351446 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ###