[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

ihji commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r427079698 ## File path: runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java ## @@ -53,9 +53,12 @@

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

ihji commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r426971999 ## File path: runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/util/PackageUtilTest.java ## @@ -195,7 +187,7 @@ public void

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

ihji commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r426924859 ## File path: runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/util/PackageUtilTest.java ## @@ -195,7 +187,7 @@ public void

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

ihji commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r421271157 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java ## @@ -442,45 +448,56 @@ public static

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

ihji commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r419841344 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py ## @@ -462,7 +462,8 @@ def run_pipeline(self, pipeline, options): use_fnapi =

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

ihji commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r419839927 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner_test.py ## @@ -102,7 +102,8 @@ def setUp(self): '--staging_location=ignored',

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

ihji commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r419838456 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java ## @@ -336,25 +323,26 @@ public

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

ihji commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r419838363 ## File path: model/pipeline/src/main/proto/beam_runner_api.proto ## @@ -1271,6 +1271,11 @@ message DeferredArtifactPayload { message

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

ihji commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r419832339 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java ## @@ -772,6 +783,88 @@ private Debuggee

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

ihji commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r419829971 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java ## @@ -784,7 +877,25 @@ public

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

ihji commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r419829659 ## File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java ## @@ -210,56 +209,55 @@ public