[GitHub] [beam] ElessarST commented on a change in pull request #16505: [BEAM-13527] [Playground] Pipeline options dialog

2022-01-28 Thread GitBox
ElessarST commented on a change in pull request #16505: URL: https://github.com/apache/beam/pull/16505#discussion_r794282660 ## File path: playground/frontend/lib/l10n/app_en.arb ## @@ -154,5 +154,41 @@ "clearOutput": "Clear Output", "@clearOutput": { "description":

[GitHub] [beam] ElessarST commented on a change in pull request #16505: [BEAM-13527] [Playground] Pipeline options dialog

2022-01-28 Thread GitBox
ElessarST commented on a change in pull request #16505: URL: https://github.com/apache/beam/pull/16505#discussion_r794286771 ## File path: playground/frontend/lib/modules/editor/components/pipeline_options_dropdown/pipeline_options_dropdown_body.dart ## @@ -0,0 +1,229 @@ +/* +

[GitHub] [beam] ElessarST commented on a change in pull request #16505: [BEAM-13527] [Playground] Pipeline options dialog

2022-01-28 Thread GitBox
ElessarST commented on a change in pull request #16505: URL: https://github.com/apache/beam/pull/16505#discussion_r794286859 ## File path: playground/frontend/lib/modules/editor/components/pipeline_options_dropdown/pipeline_options_dropdown_body.dart ## @@ -0,0 +1,229 @@ +/* +

[GitHub] [beam] emilymye commented on pull request #16632: [DO NOT MERGE] Run Python RC Validation Tests

2022-01-28 Thread GitBox
emilymye commented on pull request #16632: URL: https://github.com/apache/beam/pull/16632#issuecomment-1024009690 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] emilymye commented on pull request #16632: [DO NOT MERGE] Run Python RC Validation Tests

2022-01-28 Thread GitBox
emilymye commented on pull request #16632: URL: https://github.com/apache/beam/pull/16632#issuecomment-1024010372 Run Website_Stage_GCS PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] emilymye commented on pull request #16632: [DO NOT MERGE] Run Python RC Validation Tests

2022-01-28 Thread GitBox
emilymye commented on pull request #16632: URL: https://github.com/apache/beam/pull/16632#issuecomment-1024010586 Run Python ReleaseCandidate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] emilymye commented on pull request #16632: [DO NOT MERGE] Run Python RC Validation Tests

2022-01-28 Thread GitBox
emilymye commented on pull request #16632: URL: https://github.com/apache/beam/pull/16632#issuecomment-1024011311 Run Java Dataflow V2 ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [beam] roger-mike commented on pull request #16562: [WIP][BEAM-13051][D] Enable pylint warnings (no-name-in-module/no-value-for-parameter)

2022-01-28 Thread GitBox
roger-mike commented on pull request #16562: URL: https://github.com/apache/beam/pull/16562#issuecomment-1024345437 > The `no-value-for-parameter` warning could be fixed in some cases where there were some missing default values. > > The rest of the `no-value-for-parameter` warnings

[GitHub] [beam] thorbjorn444 opened a new pull request #16641: [BEAM-13760] Add random component to default python dataflow job name

2022-01-28 Thread GitBox
thorbjorn444 opened a new pull request #16641: URL: https://github.com/apache/beam/pull/16641 Currently, the dataflow runner creates collisions if two jobs are created at the same microsecond. This change adds eight random alphanumeric characters to the end of the job name, which i

[GitHub] [beam] roger-mike commented on pull request #16522: [WIP][BEAM-13051][B] Enable pylint warnings (import-error/invalid-unary-operand-type)

2022-01-28 Thread GitBox
roger-mike commented on pull request #16522: URL: https://github.com/apache/beam/pull/16522#issuecomment-1024369395 > > ``` > > init-hook="from pylint.config import find_pylintrc; import os, sys; sys.path.append(os.path.dirname(find_pylintrc()))" > > ``` Just commented what I t

[GitHub] [beam] MarcoRob commented on pull request #16634: [BEAM-8218] PulsarIO Connector

2022-01-28 Thread GitBox
MarcoRob commented on pull request #16634: URL: https://github.com/apache/beam/pull/16634#issuecomment-1024371980 FYI: First initial approach on PulsarIO [PR-15572](https://github.com/apache/beam/pull/15572) -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [beam] riteshghorse opened a new pull request #16642: [BEAM-13761] adds Debezium IO wrapper for Go SDK

2022-01-28 Thread GitBox
riteshghorse opened a new pull request #16642: URL: https://github.com/apache/beam/pull/16642 Adds Debezium IO wrapper. Currently tested with testcontainers-go against Flink and Universal Runner. Flink runner runs the test but after updating test validation `passert.Equals()` it fails with

[GitHub] [beam] roger-mike commented on pull request #16526: [WIP][BEAM-13051][C] Enable pylint warnings (misplaced-bare-raise/no-member)

2022-01-28 Thread GitBox
roger-mike commented on pull request #16526: URL: https://github.com/apache/beam/pull/16526#issuecomment-1024376474 @pabloem What do you think of the `no-member` warnings? Do you think some of them could be fixed? Most of them are false positives related to the `apache-beam` module, I thin

[GitHub] [beam] codecov[bot] commented on pull request #16642: [BEAM-13761] adds Debezium IO wrapper for Go SDK

2022-01-28 Thread GitBox
codecov[bot] commented on pull request #16642: URL: https://github.com/apache/beam/pull/16642#issuecomment-1024377522 # [Codecov](https://codecov.io/gh/apache/beam/pull/16642?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16522: [WIP][BEAM-13051][B] Enable pylint warnings (import-error/invalid-unary-operand-type)

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16522: URL: https://github.com/apache/beam/pull/16522#issuecomment-1013397583 # [Codecov](https://codecov.io/gh/apache/beam/pull/16522?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16642: [BEAM-13761] adds Debezium IO wrapper for Go SDK

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16642: URL: https://github.com/apache/beam/pull/16642#issuecomment-1024377522 # [Codecov](https://codecov.io/gh/apache/beam/pull/16642?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] jrmccluskey commented on a change in pull request #16622: [BEAM-7928] Allow users to specify worker disk type for Dataflow runner

2022-01-28 Thread GitBox
jrmccluskey commented on a change in pull request #16622: URL: https://github.com/apache/beam/pull/16622#discussion_r794663757 ## File path: sdks/go/pkg/beam/runners/dataflow/dataflow.go ## @@ -59,6 +59,7 @@ var ( numWorkers = flag.Int64("num_workers", 0, "Num

[GitHub] [beam] emilymye merged pull request #16630: Update Python SDK beam-master tags

2022-01-28 Thread GitBox
emilymye merged pull request #16630: URL: https://github.com/apache/beam/pull/16630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] mosche commented on pull request #15848: Sketching an any-type implementation for readWithPartitions for JdbcIO

2022-01-28 Thread GitBox
mosche commented on pull request #15848: URL: https://github.com/apache/beam/pull/15848#issuecomment-1024419181 @pabloem sure, I'll absolutely give this a look early next week! Sorry, didn't get to it today... -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] ryanthompson591 commented on a change in pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-28 Thread GitBox
ryanthompson591 commented on a change in pull request #16154: URL: https://github.com/apache/beam/pull/16154#discussion_r79429 ## File path: sdks/python/apache_beam/examples/complete/estimate_pi.py ## @@ -101,21 +101,27 @@ def expand(self, pcoll): | 'Sum' >> beam.C

[GitHub] [beam] ryanthompson591 commented on a change in pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-28 Thread GitBox
ryanthompson591 commented on a change in pull request #16154: URL: https://github.com/apache/beam/pull/16154#discussion_r794696465 ## File path: sdks/python/apache_beam/examples/complete/autocomplete.py ## @@ -40,7 +40,7 @@ def run(argv=None): # We use the save_main_session

[GitHub] [beam] pabloem commented on pull request #16592: [BEAM-13722][Playground] Add precompiling of the graph into examples CI/CD

2022-01-28 Thread GitBox
pabloem commented on pull request #16592: URL: https://github.com/apache/beam/pull/16592#issuecomment-1024442095 LGTM thanks all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] pabloem merged pull request #16592: [BEAM-13722][Playground] Add precompiling of the graph into examples CI/CD

2022-01-28 Thread GitBox
pabloem merged pull request #16592: URL: https://github.com/apache/beam/pull/16592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] codecov[bot] edited a comment on pull request #16642: [BEAM-13761] adds Debezium IO wrapper for Go SDK

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16642: URL: https://github.com/apache/beam/pull/16642#issuecomment-1024377522 # [Codecov](https://codecov.io/gh/apache/beam/pull/16642?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] pabloem commented on pull request #15848: Sketching an any-type implementation for readWithPartitions for JdbcIO

2022-01-28 Thread GitBox
pabloem commented on pull request #15848: URL: https://github.com/apache/beam/pull/15848#issuecomment-1024448196 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] codecov[bot] edited a comment on pull request #16642: [BEAM-13761] adds Debezium IO wrapper for Go SDK

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16642: URL: https://github.com/apache/beam/pull/16642#issuecomment-1024377522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] edited a comment on pull request #16642: [BEAM-13761] adds Debezium IO wrapper for Go SDK

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16642: URL: https://github.com/apache/beam/pull/16642#issuecomment-1024377522 # [Codecov](https://codecov.io/gh/apache/beam/pull/16642?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] robertwb commented on pull request #16638: Make num-stages counter into an internal counter.

2022-01-28 Thread GitBox
robertwb commented on pull request #16638: URL: https://github.com/apache/beam/pull/16638#issuecomment-1024454073 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] codecov[bot] edited a comment on pull request #16642: [BEAM-13761] adds Debezium IO wrapper for Go SDK

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16642: URL: https://github.com/apache/beam/pull/16642#issuecomment-1024377522 # [Codecov](https://codecov.io/gh/apache/beam/pull/16642?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16642: [BEAM-13761] adds Debezium IO wrapper for Go SDK

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16642: URL: https://github.com/apache/beam/pull/16642#issuecomment-1024377522 # [Codecov](https://codecov.io/gh/apache/beam/pull/16642?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] commented on pull request #16641: [BEAM-13760] Add random component to default python dataflow job name

2022-01-28 Thread GitBox
codecov[bot] commented on pull request #16641: URL: https://github.com/apache/beam/pull/16641#issuecomment-1024459011 # [Codecov](https://codecov.io/gh/apache/beam/pull/16641?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16641: [BEAM-13760] Add random component to default python dataflow job name

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16641: URL: https://github.com/apache/beam/pull/16641#issuecomment-1024459011 # [Codecov](https://codecov.io/gh/apache/beam/pull/16641?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] riteshghorse commented on pull request #16642: [BEAM-13761] adds Debezium IO wrapper for Go SDK

2022-01-28 Thread GitBox
riteshghorse commented on pull request #16642: URL: https://github.com/apache/beam/pull/16642#issuecomment-1024459964 R: @lostluck @youngoli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] TheNeuralBit commented on a change in pull request #16638: Make num-stages counter into an internal counter.

2022-01-28 Thread GitBox
TheNeuralBit commented on a change in pull request #16638: URL: https://github.com/apache/beam/pull/16638#discussion_r794732980 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py ## @@ -358,8 +358,11 @@ def run_stages(self, stage_cont

[GitHub] [beam] roger-mike edited a comment on pull request #16522: [WIP][BEAM-13051][B] Enable pylint warnings (import-error/invalid-unary-operand-type)

2022-01-28 Thread GitBox
roger-mike edited a comment on pull request #16522: URL: https://github.com/apache/beam/pull/16522#issuecomment-1024369395 > > ``` > > init-hook="from pylint.config import find_pylintrc; import os, sys; sys.path.append(os.path.dirname(find_pylintrc()))" > > ``` Hi @TheNeuralBit

[GitHub] [beam] codecov[bot] edited a comment on pull request #16641: [BEAM-13760] Add random component to default python dataflow job name

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16641: URL: https://github.com/apache/beam/pull/16641#issuecomment-1024459011 # [Codecov](https://codecov.io/gh/apache/beam/pull/16641?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16641: [BEAM-13760] Add random component to default python dataflow job name

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16641: URL: https://github.com/apache/beam/pull/16641#issuecomment-1024459011 # [Codecov](https://codecov.io/gh/apache/beam/pull/16641?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] kileys commented on pull request #16631: [BEAM-13741] Add Calcite to dependency

2022-01-28 Thread GitBox
kileys commented on pull request #16631: URL: https://github.com/apache/beam/pull/16631#issuecomment-1024490554 R: @TheNeuralBit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] kileys commented on pull request #16631: [BEAM-13741] Add Calcite to dependency

2022-01-28 Thread GitBox
kileys commented on pull request #16631: URL: https://github.com/apache/beam/pull/16631#issuecomment-1024491997 beam_Release_NightlySnapshot passes, but had to do a fix for whitespace https://ci-beam.apache.org/job/beam_Release_NightlySnapshot/1443/ -- This is an automated message

[GitHub] [beam] pabloem commented on pull request #16505: [BEAM-13527] [Playground] Pipeline options dialog

2022-01-28 Thread GitBox
pabloem commented on pull request #16505: URL: https://github.com/apache/beam/pull/16505#issuecomment-1024500445 thanks all this looks nice! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [beam] pabloem merged pull request #16505: [BEAM-13527] [Playground] Pipeline options dialog

2022-01-28 Thread GitBox
pabloem merged pull request #16505: URL: https://github.com/apache/beam/pull/16505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] codecov[bot] edited a comment on pull request #16638: Make num-stages counter into an internal counter.

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16638: URL: https://github.com/apache/beam/pull/16638#issuecomment-1023730417 # [Codecov](https://codecov.io/gh/apache/beam/pull/16638?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] kileys commented on pull request #16568: [BEAM-12240] Add Java 17 support

2022-01-28 Thread GitBox
kileys commented on pull request #16568: URL: https://github.com/apache/beam/pull/16568#issuecomment-1024504927 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] kileys commented on pull request #16568: [BEAM-12240] Add Java 17 support

2022-01-28 Thread GitBox
kileys commented on pull request #16568: URL: https://github.com/apache/beam/pull/16568#issuecomment-1024505036 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] damccorm opened a new pull request #16643: [BEAM-6744] Go Dataflow runner - support implicitly setting project id

2022-01-28 Thread GitBox
damccorm opened a new pull request #16643: URL: https://github.com/apache/beam/pull/16643 The dataflow.go runner currently requires a project to be set via a flag. However, this can be inferred from the users config if they have set the `GOOGLE_APPLICATION_CREDENTIALS` env var to point to

[GitHub] [beam] damccorm commented on pull request #16643: [BEAM-6744] Go Dataflow runner - support implicitly setting project id

2022-01-28 Thread GitBox
damccorm commented on pull request #16643: URL: https://github.com/apache/beam/pull/16643#issuecomment-1024513917 R: @lostluck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [beam] tvalentyn commented on a change in pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-28 Thread GitBox
tvalentyn commented on a change in pull request #16154: URL: https://github.com/apache/beam/pull/16154#discussion_r794164784 ## File path: sdks/python/apache_beam/examples/complete/autocomplete.py ## @@ -40,7 +40,7 @@ def run(argv=None): # We use the save_main_session option

[GitHub] [beam] codecov[bot] edited a comment on pull request #16568: [BEAM-12240] Add Java 17 support

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16568: URL: https://github.com/apache/beam/pull/16568#issuecomment-1016915370 # [Codecov](https://codecov.io/gh/apache/beam/pull/16568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] commented on pull request #16640: [BEAM-12240] Add Jenkins tests for Java 17

2022-01-28 Thread GitBox
codecov[bot] commented on pull request #16640: URL: https://github.com/apache/beam/pull/16640#issuecomment-1024527022 # [Codecov](https://codecov.io/gh/apache/beam/pull/16640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16640: [BEAM-12240] Add Jenkins tests for Java 17

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16640: URL: https://github.com/apache/beam/pull/16640#issuecomment-1024527022 # [Codecov](https://codecov.io/gh/apache/beam/pull/16640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16640: [BEAM-12240] Add Jenkins tests for Java 17

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16640: URL: https://github.com/apache/beam/pull/16640#issuecomment-1024527022 # [Codecov](https://codecov.io/gh/apache/beam/pull/16640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16640: [BEAM-12240] Add Jenkins tests for Java 17

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16640: URL: https://github.com/apache/beam/pull/16640#issuecomment-1024527022 # [Codecov](https://codecov.io/gh/apache/beam/pull/16640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16640: [BEAM-12240] Add Jenkins tests for Java 17

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16640: URL: https://github.com/apache/beam/pull/16640#issuecomment-1024527022 # [Codecov](https://codecov.io/gh/apache/beam/pull/16640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] TheNeuralBit commented on pull request #16631: [BEAM-13741] Add Calcite to dependency

2022-01-28 Thread GitBox
TheNeuralBit commented on pull request #16631: URL: https://github.com/apache/beam/pull/16631#issuecomment-1024538232 Do we know why this happens in Release_NightlySnapshot but we can't repro in local builds? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #16640: [BEAM-12240] Add Jenkins tests for Java 17

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16640: URL: https://github.com/apache/beam/pull/16640#issuecomment-1024527022 # [Codecov](https://codecov.io/gh/apache/beam/pull/16640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16640: [BEAM-12240] Add Jenkins tests for Java 17

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16640: URL: https://github.com/apache/beam/pull/16640#issuecomment-1024527022 # [Codecov](https://codecov.io/gh/apache/beam/pull/16640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16568: [BEAM-12240] Add Java 17 support

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16568: URL: https://github.com/apache/beam/pull/16568#issuecomment-1016915370 # [Codecov](https://codecov.io/gh/apache/beam/pull/16568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16601: [BEAM-13734] Support cache directories that use GCS buckets

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16601: URL: https://github.com/apache/beam/pull/16601#issuecomment-1020672508 # [Codecov](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] VictorPlusC commented on a change in pull request #16601: [BEAM-13734] Support cache directories that use GCS buckets

2022-01-28 Thread GitBox
VictorPlusC commented on a change in pull request #16601: URL: https://github.com/apache/beam/pull/16601#discussion_r794839138 ## File path: sdks/python/apache_beam/runners/interactive/interactive_environment.py ## @@ -675,3 +693,12 @@ def get_sql_chain(self, pipeline, set_use

[GitHub] [beam] VictorPlusC commented on a change in pull request #16601: [BEAM-13734] Support cache directories that use GCS buckets

2022-01-28 Thread GitBox
VictorPlusC commented on a change in pull request #16601: URL: https://github.com/apache/beam/pull/16601#discussion_r794840341 ## File path: sdks/python/apache_beam/runners/interactive/interactive_environment.py ## @@ -358,18 +361,33 @@ def get_cache_manager(self, pipeline, c

[GitHub] [beam] kennknowles opened a new pull request #16644: [BEAM-13768] Fix NullPointerException in BigQueryStorageSourceBase

2022-01-28 Thread GitBox
kennknowles opened a new pull request #16644: URL: https://github.com/apache/beam/pull/16644 This NullPointerException is preventable, easily caught by checkerframework, but it was disabled. So it hit a user. Thank you for your contribution! Follow thi

[GitHub] [beam] kileys commented on pull request #16631: [BEAM-13741] Add Calcite to dependency

2022-01-28 Thread GitBox
kileys commented on pull request #16631: URL: https://github.com/apache/beam/pull/16631#issuecomment-1024589177 No idea. I tried clearing my local ~/.m2 repo thinking Calcite was cached, but still passed -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [beam] codecov[bot] edited a comment on pull request #16568: [BEAM-12240] Add Java 17 support

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16568: URL: https://github.com/apache/beam/pull/16568#issuecomment-1016915370 # [Codecov](https://codecov.io/gh/apache/beam/pull/16568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16601: [BEAM-13734] Support cache directories that use GCS buckets

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16601: URL: https://github.com/apache/beam/pull/16601#issuecomment-1020672508 # [Codecov](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] ihji opened a new pull request #16645: Fix Java SDK container image name for load-tests and nexmark

2022-01-28 Thread GitBox
ihji opened a new pull request #16645: URL: https://github.com/apache/beam/pull/16645 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly a

[GitHub] [beam] kennknowles commented on pull request #16644: [BEAM-13768] Fix NullPointerException in BigQueryStorageSourceBase

2022-01-28 Thread GitBox
kennknowles commented on pull request #16644: URL: https://github.com/apache/beam/pull/16644#issuecomment-1024590553 R: @pabloem have a minute for this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [beam] VictorPlusC commented on a change in pull request #16601: [BEAM-13734] Support cache directories that use GCS buckets

2022-01-28 Thread GitBox
VictorPlusC commented on a change in pull request #16601: URL: https://github.com/apache/beam/pull/16601#discussion_r794851154 ## File path: sdks/python/apache_beam/runners/interactive/utils_test.py ## @@ -327,5 +345,29 @@ def test_create_var_in_main(self): self.assertIs(g

[GitHub] [beam] ihji commented on pull request #16645: Fix Java SDK container image name for load-tests and nexmark

2022-01-28 Thread GitBox
ihji commented on pull request #16645: URL: https://github.com/apache/beam/pull/16645#issuecomment-1024590823 Dataflow Runner V2 Nexmark Tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] VictorPlusC commented on a change in pull request #16601: [BEAM-13734] Support cache directories that use GCS buckets

2022-01-28 Thread GitBox
VictorPlusC commented on a change in pull request #16601: URL: https://github.com/apache/beam/pull/16601#discussion_r794839138 ## File path: sdks/python/apache_beam/runners/interactive/interactive_environment.py ## @@ -675,3 +693,12 @@ def get_sql_chain(self, pipeline, set_use

[GitHub] [beam] ihji removed a comment on pull request #16645: Fix Java SDK container image name for load-tests and nexmark

2022-01-28 Thread GitBox
ihji removed a comment on pull request #16645: URL: https://github.com/apache/beam/pull/16645#issuecomment-1024590823 Dataflow Runner V2 Nexmark Tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [beam] codecov[bot] edited a comment on pull request #16640: [BEAM-12240] Add Jenkins tests for Java 17

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16640: URL: https://github.com/apache/beam/pull/16640#issuecomment-1024527022 # [Codecov](https://codecov.io/gh/apache/beam/pull/16640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] kennknowles commented on pull request #16644: [BEAM-13768] Fix NullPointerException in BigQueryStorageSourceBase

2022-01-28 Thread GitBox
kennknowles commented on pull request #16644: URL: https://github.com/apache/beam/pull/16644#issuecomment-1024592537 Or also R: @kmjung -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [beam] ihji removed a comment on pull request #16645: Fix Java SDK container image name for load-tests and nexmark

2022-01-28 Thread GitBox
ihji removed a comment on pull request #16645: URL: https://github.com/apache/beam/pull/16645#issuecomment-1024592408 Dataflow Runner V2 Nexmark Tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [beam] ihji commented on pull request #16645: Fix Java SDK container image name for load-tests and nexmark

2022-01-28 Thread GitBox
ihji commented on pull request #16645: URL: https://github.com/apache/beam/pull/16645#issuecomment-1024592408 Dataflow Runner V2 Nexmark Tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #16601: [BEAM-13734] Support cache directories that use GCS buckets

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16601: URL: https://github.com/apache/beam/pull/16601#issuecomment-1020672508 # [Codecov](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] emilymye commented on pull request #16632: [DO NOT MERGE] Run Python RC Validation Tests

2022-01-28 Thread GitBox
emilymye commented on pull request #16632: URL: https://github.com/apache/beam/pull/16632#issuecomment-1024595790 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] emilymye commented on pull request #16632: [DO NOT MERGE] Run Python RC Validation Tests

2022-01-28 Thread GitBox
emilymye commented on pull request #16632: URL: https://github.com/apache/beam/pull/16632#issuecomment-1024595929 Run Python ReleaseCandidate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] ihji commented on pull request #16645: Fix Java SDK container image name for load-tests and nexmark

2022-01-28 Thread GitBox
ihji commented on pull request #16645: URL: https://github.com/apache/beam/pull/16645#issuecomment-1024596277 Run Dataflow Runner V2 Nexmark Tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] ihji removed a comment on pull request #16645: Fix Java SDK container image name for load-tests and nexmark

2022-01-28 Thread GitBox
ihji removed a comment on pull request #16645: URL: https://github.com/apache/beam/pull/16645#issuecomment-1024596277 Run Dataflow Runner V2 Nexmark Tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [beam] ihji commented on pull request #16645: Fix Java SDK container image name for load-tests and nexmark

2022-01-28 Thread GitBox
ihji commented on pull request #16645: URL: https://github.com/apache/beam/pull/16645#issuecomment-1024598827 Run Load Tests Java Combine Dataflow Batch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] ihji commented on pull request #16645: Fix Java SDK container image name for load-tests and nexmark

2022-01-28 Thread GitBox
ihji commented on pull request #16645: URL: https://github.com/apache/beam/pull/16645#issuecomment-1024598991 Run Dataflow Runner V2 Nexmark Tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] kileys commented on pull request #16634: [BEAM-8218] PulsarIO Connector

2022-01-28 Thread GitBox
kileys commented on pull request #16634: URL: https://github.com/apache/beam/pull/16634#issuecomment-1024600740 @johnjcasey Could you take a look please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [beam] ihji commented on pull request #16645: Fix Java SDK container image name for load-tests and nexmark

2022-01-28 Thread GitBox
ihji commented on pull request #16645: URL: https://github.com/apache/beam/pull/16645#issuecomment-1024601248 Run Dataflow Runner V2 Nexmark Tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] ihji removed a comment on pull request #16645: Fix Java SDK container image name for load-tests and nexmark

2022-01-28 Thread GitBox
ihji removed a comment on pull request #16645: URL: https://github.com/apache/beam/pull/16645#issuecomment-1024598991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [beam] ihji commented on pull request #16645: Fix Java SDK container image name for load-tests and nexmark

2022-01-28 Thread GitBox
ihji commented on pull request #16645: URL: https://github.com/apache/beam/pull/16645#issuecomment-1024602484 Run Load Tests Java 11 ParDo Dataflow V2 Batch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [beam] ihji removed a comment on pull request #16645: Fix Java SDK container image name for load-tests and nexmark

2022-01-28 Thread GitBox
ihji removed a comment on pull request #16645: URL: https://github.com/apache/beam/pull/16645#issuecomment-1024602484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [beam] codecov[bot] edited a comment on pull request #16601: [BEAM-13734] Support cache directories that use GCS buckets

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16601: URL: https://github.com/apache/beam/pull/16601#issuecomment-1020672508 # [Codecov](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] emilymye commented on pull request #16632: [DO NOT MERGE] Run Python RC Validation Tests

2022-01-28 Thread GitBox
emilymye commented on pull request #16632: URL: https://github.com/apache/beam/pull/16632#issuecomment-1024627750 Run Python ReleaseCandidate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #16601: [BEAM-13734] Support cache directories that use GCS buckets

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16601: URL: https://github.com/apache/beam/pull/16601#issuecomment-1020672508 # [Codecov](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] kmjung commented on a change in pull request #16644: [BEAM-13768] Fix NullPointerException in BigQueryStorageSourceBase

2022-01-28 Thread GitBox
kmjung commented on a change in pull request #16644: URL: https://github.com/apache/beam/pull/16644#discussion_r794888197 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageSourceBase.java ## @@ -107,17 +104,19 @@

[GitHub] [beam] johnjcasey commented on pull request #16634: [BEAM-8218] PulsarIO Connector

2022-01-28 Thread GitBox
johnjcasey commented on pull request #16634: URL: https://github.com/apache/beam/pull/16634#issuecomment-1024635840 Will Do. @MarcoRob is there a design document you could point me to for a bit of context on this change? -- This is an automated message from the Apache Git Service.

[GitHub] [beam] codecov[bot] commented on pull request #16636: Fix bug in the main_session unit test

2022-01-28 Thread GitBox
codecov[bot] commented on pull request #16636: URL: https://github.com/apache/beam/pull/16636#issuecomment-1024663700 # [Codecov](https://codecov.io/gh/apache/beam/pull/16636?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] johnjcasey commented on a change in pull request #16634: [BEAM-8218] PulsarIO Connector

2022-01-28 Thread GitBox
johnjcasey commented on a change in pull request #16634: URL: https://github.com/apache/beam/pull/16634#discussion_r794894441 ## File path: sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/PulsarWriter.java ## @@ -0,0 +1,41 @@ +package org.apache.beam.sdk.io.pul

[GitHub] [beam] johnjcasey commented on a change in pull request #16634: [BEAM-8218] PulsarIO Connector

2022-01-28 Thread GitBox
johnjcasey commented on a change in pull request #16634: URL: https://github.com/apache/beam/pull/16634#discussion_r794893960 ## File path: sdks/java/io/pulsar/src/main/java/org/apache/beam/sdk/io/pulsar/PulsarWriter.java ## @@ -0,0 +1,41 @@ +package org.apache.beam.sdk.io.pul

[GitHub] [beam] codecov[bot] edited a comment on pull request #16601: [BEAM-13734] Support cache directories that use GCS buckets

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16601: URL: https://github.com/apache/beam/pull/16601#issuecomment-1020672508 # [Codecov](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] andreykus opened a new pull request #16646: [BEAM-13643][Playground] Setup running backend to verify SCIO SDK examples

2022-01-28 Thread GitBox
andreykus opened a new pull request #16646: URL: https://github.com/apache/beam/pull/16646 Configured Docker build, terraform deploy app, git actions to run backend server to verify SCIO SDK examples Thank you for your contribution! Follow this checklist

[GitHub] [beam] AnandInguva commented on pull request #16633: [BEAM-4032]Support staging binary distributions of dependency packages

2022-01-28 Thread GitBox
AnandInguva commented on pull request #16633: URL: https://github.com/apache/beam/pull/16633#issuecomment-1024682094 cc @robertwb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] AnandInguva commented on a change in pull request #16633: [BEAM-4032]Support staging binary distributions of dependency packages

2022-01-28 Thread GitBox
AnandInguva commented on a change in pull request #16633: URL: https://github.com/apache/beam/pull/16633#discussion_r794916852 ## File path: sdks/python/container/piputil.go ## @@ -51,7 +51,7 @@ func pipInstallRequirements(files []string, dir, name string) error {

[GitHub] [beam] codecov[bot] edited a comment on pull request #16636: Fix bug in the main_session unit test

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16636: URL: https://github.com/apache/beam/pull/16636#issuecomment-1024663700 # [Codecov](https://codecov.io/gh/apache/beam/pull/16636?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16601: [BEAM-13734] Support cache directories that use GCS buckets

2022-01-28 Thread GitBox
codecov[bot] edited a comment on pull request #16601: URL: https://github.com/apache/beam/pull/16601#issuecomment-1020672508 # [Codecov](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

  1   2   >