parthchandra commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1607016398
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -734,6 +734,23 @@ class CometSparkSessionExtensions
} else {
andygrove merged PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@da
viirya commented on PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#issuecomment-2108661235
Looks good to me. Thanks @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
viirya commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1598996725
##
common/src/main/scala/org/apache/comet/CometConf.scala:
##
@@ -276,6 +276,14 @@ object CometConf {
.booleanConf
.createWithDefault(false)
+ va
andygrove commented on PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#issuecomment-2108650216
@viirya I have 2 approvals but need a committer approval to be able to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
andygrove commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1598990652
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -734,6 +734,23 @@ class CometSparkSessionExtensions
} else {
andygrove commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1598990211
##
spark/src/main/scala/org/apache/comet/ExtendedExplainInfo.scala:
##
@@ -45,7 +45,7 @@ class ExtendedExplainInfo extends ExtendedExplainGenerator {
}
andygrove commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1598983161
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -734,6 +734,23 @@ class CometSparkSessionExtensions
} else {
kazuyukitanimura commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1598977339
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -734,6 +734,23 @@ class CometSparkSessionExtensions
} else {
andygrove commented on PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#issuecomment-2107544060
@viirya @parthchandra This PR is ready for another review. I simplified the
logic and removed the check to see if the top level operator is native or not.
Instead, if we have rec
andygrove commented on PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#issuecomment-2101359037
I am moving this to draft for now while I test with TPC-H queries and make
some improvements
--
This is an automated message from the Apache Git Service.
To respond to the mess
viirya commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1593204526
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -734,6 +734,22 @@ class CometSparkSessionExtensions
} else {
var
andygrove commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1593196216
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -734,6 +734,22 @@ class CometSparkSessionExtensions
} else {
andygrove commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1593066417
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -734,6 +734,22 @@ class CometSparkSessionExtensions
} else {
parthchandra commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1592975258
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -734,6 +734,22 @@ class CometSparkSessionExtensions
} else {
andygrove commented on PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#issuecomment-2099111247
@parthchandra How does this look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove commented on code in PR #397:
URL: https://github.com/apache/datafusion-comet/pull/397#discussion_r1592900908
##
common/src/main/scala/org/apache/comet/CometConf.scala:
##
@@ -276,6 +276,14 @@ object CometConf {
.booleanConf
.createWithDefault(false)
+
andygrove opened a new pull request, #397:
URL: https://github.com/apache/datafusion-comet/pull/397
## Which issue does this PR close?
Closes https://github.com/apache/datafusion-comet/issues/385
## Rationale for this change
As a user, I would like to unde
18 matches
Mail list logo
