Re: [PR] feat: Add support for TryCast expression in Spark 3.2 and 3.3 [datafusion-comet]

viirya commented on code in PR #416: URL: https://github.com/apache/datafusion-comet/pull/416#discussion_r1603936564 ## spark/src/test/scala/org/apache/comet/CometCastSuite.scala: ## @@ -948,10 +948,7 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {

Re: [PR] feat: Add support for TryCast expression in Spark 3.2 and 3.3 [datafusion-comet]

andygrove merged PR #416: URL: https://github.com/apache/datafusion-comet/pull/416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@da

Re: [PR] feat: Add support for TryCast expression in Spark 3.2 and 3.3 [datafusion-comet]

vaibhawvipul commented on code in PR #416: URL: https://github.com/apache/datafusion-comet/pull/416#discussion_r1602047397 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -617,50 +663,17 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde

Re: [PR] feat: Add support for TryCast expression in Spark 3.2 and 3.3 [datafusion-comet]

kazuyukitanimura commented on code in PR #416: URL: https://github.com/apache/datafusion-comet/pull/416#discussion_r1602041813 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -617,50 +663,17 @@ object QueryPlanSerde extends Logging with ShimQueryPlanS

Re: [PR] feat: Add support for TryCast expression in Spark 3.2 and 3.3 [datafusion-comet]

vaibhawvipul commented on code in PR #416: URL: https://github.com/apache/datafusion-comet/pull/416#discussion_r160202 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -617,50 +663,17 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde

Re: [PR] feat: Add support for TryCast expression in Spark 3.2 and 3.3 [datafusion-comet]

vaibhawvipul commented on code in PR #416: URL: https://github.com/apache/datafusion-comet/pull/416#discussion_r1602021543 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -617,50 +663,17 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde

Re: [PR] feat: Add support for TryCast expression in Spark 3.2 and 3.3 [datafusion-comet]

kazuyukitanimura commented on code in PR #416: URL: https://github.com/apache/datafusion-comet/pull/416#discussion_r1602009700 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -617,50 +663,17 @@ object QueryPlanSerde extends Logging with ShimQueryPlanS

Re: [PR] feat: Add support for TryCast expression in Spark 3.2 and 3.3 [datafusion-comet]

vaibhawvipul commented on code in PR #416: URL: https://github.com/apache/datafusion-comet/pull/416#discussion_r1601993517 ## spark/src/test/scala/org/apache/comet/CometCastSuite.scala: ## @@ -948,10 +948,8 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHel

Re: [PR] feat: Add support for TryCast expression in Spark 3.2 and 3.3 [datafusion-comet]

andygrove commented on code in PR #416: URL: https://github.com/apache/datafusion-comet/pull/416#discussion_r1601983256 ## spark/src/test/scala/org/apache/comet/CometCastSuite.scala: ## @@ -948,10 +948,8 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper

Re: [PR] feat: Add support for TryCast expression in Spark 3.2 and 3.3 [datafusion-comet]

vaibhawvipul commented on code in PR #416: URL: https://github.com/apache/datafusion-comet/pull/416#discussion_r1601865299 ## spark/src/test/scala/org/apache/comet/CometCastSuite.scala: ## @@ -950,7 +950,8 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelp

Re: [PR] feat: Add support for TryCast expression in Spark 3.2 and 3.3 [datafusion-comet]

andygrove commented on code in PR #416: URL: https://github.com/apache/datafusion-comet/pull/416#discussion_r1601786519 ## spark/src/test/scala/org/apache/comet/CometCastSuite.scala: ## @@ -950,7 +950,8 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper

Re: [PR] feat: Add support for TryCast expression in Spark 3.2 and 3.3 [datafusion-comet]

andygrove commented on code in PR #416: URL: https://github.com/apache/datafusion-comet/pull/416#discussion_r1601785741 ## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ## @@ -617,50 +663,17 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde wi

[PR] feat: Add support for TryCast expression in Spark 3.2 and 3.3 [datafusion-comet]

vaibhawvipul opened a new pull request, #416: URL: https://github.com/apache/datafusion-comet/pull/416 ## Which issue does this PR close? Closes #374 . ## Rationale for this change ## What changes are included in this PR? ## How are these ch