Re: [PR] feat: Only allow supported and tested cast operations to be converted to native [datafusion-comet]

andygrove commented on code in PR #362: URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1588329000 ## spark/src/test/scala/org/apache/comet/CometCastSuite.scala: ## @@ -825,19 +839,26 @@ class CometCastSuite extends CometTestBase with

Re: [PR] feat: Only allow supported and tested cast operations to be converted to native [datafusion-comet]

andygrove commented on code in PR #362: URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1588328731 ## spark/src/test/scala/org/apache/comet/CometCastSuite.scala: ## @@ -559,6 +569,12 @@ class CometCastSuite extends CometTestBase with

Re: [PR] feat: Only allow supported and tested cast operations to be converted to native [datafusion-comet]

andygrove commented on code in PR #362: URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1588328011 ## spark/pom.xml: ## @@ -58,6 +58,11 @@ under the License. org.scala-lang scala-library + + org.scala-lang + scala-reflect +

Re: [PR] feat: Only allow supported and tested cast operations to be converted to native [datafusion-comet]

andygrove commented on code in PR #362: URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1588326789 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -625,36 +628,3 @@ private[comet] case class ConfigBuilder(key: String) { private object

Re: [PR] feat: Only allow supported and tested cast operations to be converted to native [datafusion-comet]

andygrove commented on code in PR #362: URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1588326109 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -376,12 +376,15 @@ object CometConf { .booleanConf .createWithDefault(false) -

Re: [PR] feat: Only allow supported and tested cast operations to be converted to native [datafusion-comet]

andygrove commented on code in PR #362: URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1588326109 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -376,12 +376,15 @@ object CometConf { .booleanConf .createWithDefault(false) -

Re: [PR] feat: Only allow supported and tested cast operations to be converted to native [datafusion-comet]

andygrove commented on code in PR #362: URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1587967643 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -1042,10 +1042,10 @@ object CometSparkSessionExtensions extends Logging {

Re: [PR] feat: Only allow supported and tested cast operations to be converted to native [datafusion-comet]

andygrove commented on code in PR #362: URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r158786 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -1042,10 +1042,10 @@ object CometSparkSessionExtensions extends Logging {

Re: [PR] feat: Only allow supported and tested cast operations to be converted to native [datafusion-comet]

andygrove commented on code in PR #362: URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1586473138 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -1042,10 +1042,10 @@ object CometSparkSessionExtensions extends Logging {

Re: [PR] feat: Only allow supported and tested cast operations to be converted to native [datafusion-comet]

andygrove commented on code in PR #362: URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r1586401340 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -1042,10 +1042,10 @@ object CometSparkSessionExtensions extends Logging {