Does it include #3865?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1331#issuecomment-2132441626
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3865#pullrequestreview-2079821073
You are receiving this because you are subscribed to this thread.
Message ID:
Meanwhile, back in the world of US-105 keyboards ... :frowning_face:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/discussions/3887#discussioncomment-9564508
You are receiving this because you are subscribed to this thread.
Message ID:
> LGTM, apart possibly the inline comments.
I've made the changes, amended the previous commit with it and force-pushed the
result.
> Sad we have to do that in several functions, but makes sense.
The crash itself would probably not require all the places but better to have
it handled everywher
@techee commented on this pull request.
> + kindDefinition *def;
+
+ if (lang == TM_PARSER_NONE)
+ return "unknown";
+
+ def = getLanguageKindForLetter(lang, kind);
Yes, that's better - done at both places.
--
Reply to this email directly or view it on GitHub:
ht
@techee pushed 1 commit.
dcd46bbe62e32d3ed1f6f25b977cdfeecd95ee2d Protect tm_ctags_*() functions
against TM_PARSER_NONE language parameter
--
View it on GitHub:
https://github.com/geany/geany/pull/3865/files/5bb09fbd2a0a6aa4d4fec8a187e3b4f171cdbe0e..dcd46bbe62e32d3ed1f6f25b977cdfeecd95ee2d
You
> Wanna laugh? https://github.com/universal-ctags/ctags/pull/4008 😄
No problem. I've just included the updated jscript parser (without updating the
rest). We can update the parsers individually if there are some fixes that
should be present in the release.
--
Reply to this email directly or vi
>> So shouldn't we rather map it to tm_tag_undef_t?
> Hum yeah if it's gonna tag every variable assignment in the file regardless
> of scope, it's probably better to disable indeed, otherwise the more useful
> tags are likely gonna be hard to find. Maybe tm_local_var_t if we want, to
> still ha
@techee commented on this pull request.
> @@ -951,6 +951,7 @@ static TMParserMapEntry map_POWERSHELL[] = {
{'c', tm_tag_class_t}, // class
{'i', tm_tag_function_t}, // filter
{'g', tm_tag_enum_t}, // enum
+ {'e', tm_tag_undef_t}, // enumlabel
Done.
-
@techee pushed 3 commits.
834d81ce2b8ddcc495f70eb65ed2809689a7b47d Map powershell enumlabel to
tm_tag_enumerator_t
ca9789473ad32a696d8f6bc712b4631bbf86f159 Map Matlab variables back to
tm_tag_undef_t
e01d7c4f00f0c168326568cdc17e2b3d6341351a Update to the latest jscript parser
which contains
@techee approved this pull request.
LGTM, thanks!
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1353#pullrequestreview-2079775916
You are receiving this because you are subscribed to this thread.
Message ID:
> I guess it's some sort of left-over because it wasn't as buggy as the full
> file dialogs and so they were out of my focus.
Thanks for cleaning up my dirt :D.
By the way, there's also native message dialog on Windows
(`win32_message_dialog()`) called at several places inside `dialog.c`
(hard-
@techee pushed 1 commit.
a808e99dd4459a3aba72f3a19933bbb26089c111 Update config options for pylsp
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1331/files/da98abcd538db01d0740e326ab0b2a0367e3a7d9..a808e99dd4459a3aba72f3a19933bbb26089c111
You are receiving this because you ar
> Just to confirm geany-lsp is Geany with #3849 and this plugin, all previous
> versions removed? If so I think I'll just get a new clone [end lazy git user]
> :-)
It's:
1. Geany
2. This PR
3. [#3850](https://github.com/geany/geany/pull/3850), i.e. including the symbol
tree patches. But you can
Another solution is to have a keyboard layout with this available, e.g.
`fr:oss` does. Possibly using Compose is also an option, yet I didn't check.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/discussions/3887#discussioncomment-9562152
You are receiving t
@frlan commented on this pull request.
> @@ -16,7 +16,7 @@ More than financial support, the Geany project needs help
> with:
If you want to donate money to the Geany project, it will be used to support
further development of Geany, to pay running costs for hosting and domains and
support pre
LGTM given the comments you guys made. We should just squash those commits
together when merging.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3886#issuecomment-2132216459
You are receiving this because you are subscribed to this thread.
Message ID:
> For some reason, since the latest MSYS2 update on my Windows system, I got
> compiler errors that g_stat() requires a GStatBuf type as second argument.
On windows there are many MS `stat` calls and `struct stat` is a structure that
changes depending on platform, compiler, target os, wind direc
For some reason, since the latest MSYS2 update on my Windows system, I got
compiler errors that `g_stat()` requires a `GStatBuf` type as second argument.
According to the docs, https://docs.gtk.org/glib/func.stat.html, this is
correct and in Geany we also use `GStatBuf` in all places.
You can vi
One last remark: could we add `AS` to the keywords? It's not strictly a
directive on its own but is part of the `FROM` directive, e.g. `FROM
debian:bullseye-slim AS builder` and without the highlighting looks a bit
broken.
--
Reply to this email directly or view it on GitHub:
https://github.co
> @eht16 you're the de-facto expert here, remember you did some work on it, now
> you're doomed 😁
Remember, this is certainly at least one decade ago and since then I
successfully managed to avoid doing any PowerShell :).
> I'll try and update this, but feel also free to take this PR over fixin
@eht16 pushed 1 commit.
7707c7a346a585bbb79e766bae912d389ad90b2b PowerShell: Add keyword "clean" and
aliases "foreach" and "where"
--
View it on GitHub:
https://github.com/geany/geany/pull/3886/files/5a2a436e69550bed35fdc215baffb8c09a0fa25f..7707c7a346a585bbb79e766bae912d389ad90b2b
You are rec
@b4n approved this pull request.
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1352#pullrequestreview-2079595790
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
> @@ -152,6 +152,8 @@ Section "Dependencies" SEC04
SectionEnd
Section -Post
+ Exec '"$INSTDIR\bin\glib-compile-schemas.exe"
"$INSTDIR\share\glib-2.0\schemas"'
Ok yeah it's probably at least good enough.
--
Reply to this email directly or view it
> Alright, I made the suggested changes:
>
> 1. I made GtkFileChooserNative configurable, by default enabled on macOS
> and Windows, disabled on Linux.
Sweet, works perfectly.
> 3. Not sure if intentional or if it's some left-over but `ui_utils.c`
> still contains native win32 dialogs:
@eht16 you're the de-facto expert here, remember you did some work on it, now
you're doomed 😁
I'll try and update this, but feel also free to take this PR over fixing
whatever you think makes sense. Again, all I did was looking at (possibly an
older version of) the link and came up with this ju
@eht16 commented on this pull request.
> @@ -152,6 +152,8 @@ Section "Dependencies" SEC04
SectionEnd
Section -Post
+ Exec '"$INSTDIR\bin\glib-compile-schemas.exe"
"$INSTDIR\share\glib-2.0\schemas"'
> OK. If `$INSTDIR` ought to be the same, maybe just make the 2.1 installer
> depend
To the removed ones:
- "default" - no idea
- "where" - according to http://xahlee.info/powershell/powershell_aliases.html
and https://superuser.com/a/1397265, "where" is an alias
So, we could add "where" to the aliases list. I checked the aliases in
PowerShell on my Windows 7 machine, there are
First a general comment, the idea of a general idiom that allows items of Geany
functionality to be substituted by plugins is a good one. It has the potential
to be expanded for many uses. For example you may remember a "discussion" some
time ago between me and @b4n about auto indentation and
@eht16 , thank you for your suggestion, but I was looking for something which
will be more simple/faster.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1306#issuecomment-2132187449
You are receiving this because you are subscribed to this thr
@eht16 pushed 1 commit.
5298197dbef2ae5ac5047d461aa521b8b32406c4 Windows: Make installer depend on
Geany 2.1
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1352/files/c145a8c902356cb43ec9439e87124de52cabc4ab..5298197dbef2ae5ac5047d461aa521b8b32406c4
You are receiving this be
> I don't think clangd will ever work without a project - it really just
> compiles it behind the scenes - so testing it on individual files won't work
> and better to use TM for those.
Well, although in theory it is possible to not have `compile_commands.json` but
really clangd is a pain witho
Making such into a snippet with an appropriate keybinding is left as an
exercise for the reader of the manual :grinning:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/discussions/3887#discussioncomment-9560521
You are receiving this because you are subscrib
Presuming your "dash" is actually an "em-dash" (the things you put two of are
technically "dash"es) then `ctrl+shift+u`2014`enter` will insert one.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/discussions/3887#discussioncomment-9560509
You are receiving th
@b4n Ping 2 :-)
Basically this is the API I currently propose. I believe it's quite nice also
that it doesn't serve for LSP only but it could be used by other plugins too. I
for instance noticed https://github.com/geany/geany/issues/3858 and if somebody
wanted they could use this API for implem
@b4n Ping :-)
I think I'm pretty much done with the plugin and I'd like some feedback. I
tried to address most of the complaints you had in
https://github.com/geany/geany/pull/3571#issuecomment-1817205646:
The config file now contains these settings with these default values:
```ini
# Defines w
When typing text in Geany, I use often a dash. Till now I use LibreOffice for
this by creating a dash to copy and paste it in Geany. So, I asked myself if
there is not a faster way.
In LibreOffice, if I type this:
`hello --world !`
the text will be automatically transformed to this:
`hello –worl
37 matches
Mail list logo