Isn't the question rendered moot by #3861? It's gonna be in 2.1, whenever
that's released.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3219#issuecomment-2331332586
You are receiving this because you are subscribed to this thread.
Message ID:
You can also use the [`PKG_CONFIG_PATH`](
https://manpages.debian.org/testing/pkg-config/pkg-config.1.en.html#PKG_CONFIG_PATH)
environment variable to tell pkg-config where to look for .pc files.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues
There are two issues with using Geany as root, and via sudo:
* the general issue of running a complex GUI program as root, where mistakes
are easier to make, and especially one with plugins of various quality. And
also note that it probably hasn't been tested in that very situation.
* the sudo-s
Merged #3921 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3921#event-13732321223
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n approved this pull request.
LGTM and the warnings I saw are indeed gone :+1:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3921#pullrequestreview-2213995809
You are receiving this because you are subscribed to this thread.
Message ID:
> @b4n How does the PR look to you? OK to merge?
IIUC there was no code changes since my review, so looks good. And history
looks OK as well :+1:
> @b4n, IIRC you were the last one to touch it, so how hard is it to extend the
> API/ABI versioning system to version the extension interface sepa
@b4n approved this pull request.
LGTM now, and squashing doesn't seem necessary (but ok if you want)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#pullrequestreview-2202788270
You are receiving this because you are subscribed to this thread.
Me
@b4n approved this pull request.
Looks good through cursory inspection
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/www.geany.org/pull/53#pullrequestreview-2197809733
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #1365 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1365#event-13411927639
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 3 commits.
63cd681d4e3cdb9d79b5eacd8aebf20d09500419 geanygendoc: Fix crash if trying to
document an unknown type
7a2f1dc667da9e488c12cd299d53d230302a1da7 geanygendoc: Sort tag types
alphabetically
8043a678b69c3ad3dcb58e4826a2232e97072ebf geanygendoc: Add support for types
"includ
Merged #1361 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1361#event-13411706468
You are receiving this because you are subscribed to this thread.
Message ID:
@frlan IMO we *need* this for 2.1, see
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2171361614. I'll
merge this in a few days unless somebody complains.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-22117923
I'm a tad worried about the second commit where the `document_array` doesn't
seem to match the notebook content… I'll try and have a quick look whenever I
can to see if the deeper cause isn't too problematic (unless you beat me to it
:wink: :wink: )
--
Reply to this email directly or view it o
@caclark you can give #1365 a try, it should fix it properly.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1362#issuecomment-2211750701
You are receiving this because you are subscribed to this thread.
Message ID:
Fix crash when encountering an unknown tag type, which fixes #1362.
Also add support for a couple more tag types Geany can report.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1365
-- Commit Summary --
* geanygendoc: Fix crash if
@caclark OK I can reproduce with the file containing only a single include,
I'll look into it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1362#issuecomment-2211733894
You are receiving this because you are subscribed to this thread.
Messa
I can't seem to reproduce, but:
* if the signature you report is a prototype, OK, I see the issue. It sounds
like a bug in the C parser (why generate a local tag for a prototype??), but
there is probably also an issue in the plugin as the rule `local.policy =
FORWARD` should make it ignore it…
The type being "local" really suggests if you have a crash it ought to be the
issue from the mentioned PR… I'll try and reproduce later tonight though.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1362#issuecomment-2198619328
You are receivi
@b4n commented on this pull request.
> + gboolean (*goto_perform)(GeanyDocument *doc, gint pos, gboolean
> definition, gpointer data);
+
+ /**
+* Pointer to function called by Geany to check whether the plugin
implements
+* additional symbol (e.g. type) highlighting i
That's quite a few questions, but…
> * The Help link https://www.geany.org/manual/2.1/index.html in Help is 404.
> * The home page https://www.geany.org/ promotes version 2.0.
Geany 2.1 isn't released yet (don't trust the milestone date, it's not closed
yet)
> * Please add a link to the HTML ve
> @b4n If it's kind of alright, what should I do now - squash into a single
> commit or try to preserve the history and squash just the various fixes?
I'd like
https://github.com/geany/geany/pull/3849/commits/d34a0a36e761cb2844ae50ffaceaee18fee0d348
(and its fix(es?)) be separate; for the rest
@b4n approved this pull request.
LGTM. I didn't re-test it extensively, but not much has changed in the code
anyway. A little squashing after @elextr's last proofread if he wants, and we
should be golden
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/p
@b4n commented on this pull request.
> + * cd plugins
+ * make demopluginext.so
Ah OK, fair enough then. Doesn't matter much indeed anyway.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3849#discussion_r1659970274
You are receiving this because you
If you install Geany from source, we recommend you uninstall the distribution
packages because it's a little too easy to run the wrong binary, or worse, have
one version load bits from the other. In theory it should work, but we've seen
both users getting slightly confused, and distros making t
@b4n requested changes on this pull request.
I don't think that following the plugin activation order makes much sense, OK
it allows you to trick this, but it would feel pretty random to me (and applies
to the prefs and other things as well).
If this is a real issue, maybe there could be a real
@b4n commented on this pull request.
> + *
+ * Then copy or symlink the plugins/demopluginext.so file to
~/.config/geany/plugins
+ * - it will be loaded at next startup.
+ */
+
+#include
+
+static gboolean autocomplete_provided(GeanyDocument *doc, gpointer data)
+{
+return doc->file_type->
This sounds like a packaging issue, our sources don't have anything regarding
`geany-plugin-gendoc`.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/992#issuecomment-2198203526
You are receiving this because you are subscribed to this thread.
Maybe it is https://github.com/geany/geany-plugins/pull/1294?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1362#issuecomment-2198202589
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n approved this pull request.
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3916#pullrequestreview-2149035001
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
Minor nitpicks, but looks pretty good now I'd say :+1:
> + Geany built-in functionality.
+
+When the plugin returns @c TRUE from the function assigned to the @c _provided
+member of @c PluginExtension, it indicates
+it wants to take control of the particula
@cwendling commented on this pull request.
> + */
+#define CALL_PROVIDED(f, doc, ext)
\
+ G_STMT_START {
@b4n commented on this pull request.
> +
+/**
+ * Registers the provided extension in Geany. There can be multiple extensions
+ * registered in Geany - these are stored in a list sorted by the priporty
+ * parameter. When executing @c _perform() functions, Geany goes through
+ * the list and exe
@b4n commented on this pull request.
> +static gboolean autocomplete_provided(GeanyDocument *doc, gpointer data)
+{
+/* Check whether the plugin provides the feature for the passed document */
+return doc->file_type->id == GEANY_FILETYPES_PYTHON;
+}
+
+
+static void autocomplete_perform(
@b4n commented on this pull request.
> + * Plugins wishing to re-register themselves, e.g. with a different priority,
+ * should first unregister themselves using @c plugin_extension_unregister()
+ * and call @c plugin_extension_register() afterwards.
+ *
+ * @param extension The @c PluginExten
@b4n commented on this pull request.
> + * the list and executes the @c _perform() function of the first extension in
+ * the list whose @c _provided() function returns @c TRUE.
+ *
+ * This function is typically called in the plugin @c init() function.
+ *
+ * Plugins wishing to re-register t
@b4n commented on this pull request.
> + g_return_if_fail(ext_name != NULL);
+
+ entry = g_malloc(sizeof *entry);
+ entry->extension = extension;
+ entry->data = data;
+ entry->priority = priority;
+
+ all_extensions = g_list_insert_sorted(all_extensions, entry,
As said above, I'm OK with this, but we at least need to bump the Meson
dependency
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#issuecomment-2186238235
You are receiving this because you are subscribed to this thread.
Message ID:
(no time for this right now, but…)
GObjects are nice for language inteop with GI indeed, but they aren't as cheap
as e.g. a boxed type (just think about all the bells and whistles like
properties, signals, private data, etc) and AFAIK a boxed type that has its own
refcount works fine (just lies
@elextr I agree with @techee that this is not plugins doing careless stuff,
it's just this MRU handling is fairly poor regarding corner cases. How comes
one can actually open a menu while it's running? And should it really cause
problems? Should we *really* leave an ominous popup over everyth
@techee I shamelessly pushed 2 more commits, please see if that works better
for you as well (your commit didn't seem to work really well for me…)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3907#issuecomment-2174413854
You are receiving this because
@techee I don't see a neat solution (after trying several things) apart from
grabbing events so the situation in the OP doesn't happen. I shamelessly
pushed to #3907 with something that seems to work for me. Note that I didn't
try with a dialog popping up out of nowhere though, but I guess it
@b4n pushed 2 commits.
c8a9249e7a4a7587185fe49a472ffe0b10234cc2 Fix stuck MRU dialog when Geany main
window loses focus, for realsies
aac6b16d3eee1093b1a846320304992be85877c1 Close MRU dialog on Escape as well
--
View it on GitHub:
https://github.com/geany/geany/pull/3907/files/7decdde6e8cc43
Also happens if you e.g. switch windows or workspace while holding
Ctrl -- and this is entirely out of our control.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3330#issuecomment-2173404246
You are receiving this because you are subscribed to this t
@xiota see #1361 which might help
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#issuecomment-2171883257
You are receiving this because you are subscribed to this thread.
Message ID:
The pasted data might contain sensitive information and the pastebin service
might be public and might not allow deleting a paste (at least not in a way the
plugin supports). Thus, ask confirmation by default in case the user
accidentally triggered the action.
@xiota does this make you a tad m
> That way users can set it in a GUI in Geany
No sure modifying filetypes.common is a great GUI 😅
Anyway, if you guys like this and it defaults to system settings, sure.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3901#issuecomment-2171408415
You a
@frlan I think this should really land (or be rejected if need be) before 2.1
so we have libsoup3 support for every relevant plugin.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2171361614
You are receiving this because you a
I rebased this on master now #1342 is merged, as it has CI infrastructure
changes for building with libsoup3. Apart from that it's unchanged from the
previous version.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2171361210
@b4n pushed 4 commits.
c33ef2e6940770b4e191d587eac305c1fe99dd4a updatechecker: Port to libsoup3
c30ab99f05e2cd9b94981d95fe82db6b7ad8a729 updatechecker: Don't leak the libsoup
session
ce1e698249706bf49682032d29c519e316a18dc8 updatechecker: Avoid a deprecated call
e1c9ac30375ca025366472b6bd07542
Merged #1231 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1231#event-13174915933
You are receiving this because you are subscribed to this thread.
Message ID:
> And on macOS or Windows I don't expect it would respect any system settings.
I guess this depends on whether GTK gets its default from the system there, or
just has its own default.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3901#issuecomment-217
Merged, so we're one step closer to libsoup3 everywhere.
This doesn't mean we can't still drop the plugin if people want, I still don't
mind even if I spent some time on this :slightly_smiling_face:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pu
Merged #1342 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#event-13174864827
You are receiving this because you are subscribed to this thread.
Message ID:
> I could imagine this could be still useful when users want different settings
> for Geany and the rest of the DE.
…but do people want this? In the related issue, I don't see if the OP wants
this specific to Geany (or why), and the other user seems happy with changing
the system setting, so s
@eht16 done (in case you didn't see the commit)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#issuecomment-2170670511
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n approved this pull request.
Builds fine, and indeed the lua 5.1 header seems to define this as compat only
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1231#pullrequestreview-2120866385
You are receiving this because you are subscribed
I guess #3861 will help with this?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3868#issuecomment-2170638507
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3877 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3877#event-13171649289
You are receiving this because you are subscribed to this thread.
Message ID:
> Anyway, tested on native Windows and works.
I think the question is more "is it OK to drop it" :)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3903#issuecomment-2170593935
You are receiving this because you are subscribed to this thread.
Message ID
@b4n approved this pull request.
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/www.geany.org/pull/51#pullrequestreview-2120828844
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 1 commit.
7a2fa7c889b29f132f7f182eebd24e0fe515a754 fixup! Update CI for libsoup3
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1342/files/9c0e16f3b469501f8d69e476026755fb4d444e8d..7a2fa7c889b29f132f7f182eebd24e0fe515a754
You are receiving this because you are sub
@eht16 sure, done.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#issuecomment-2169452082
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 9 commits.
cbfa9112df4dec824cf6101907299a164d4006c2 geniuspaste: Port to libsoup3
31caf0bb044f94bb172fd57f06fa13a7fdc05200 geniuspaste: Remove use of deprecated
GTK API
0e9ac44e6612150caa89fddd6d7ef7be022d25d2 geniuspaste: Enable HTTPS for
paste.debian.net
f466e89548c2c85c9036560e
…and I'd think it should definitely stop on unmap, there's no point in keeping
tabs on the animation at that point I don't think.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3902#issuecomment-2168831492
You are receiving this because you are subscrib
@elextr BTW, do you use Wayland? I have no idea of the details of the frame
clock thingy, by possibly the surface/windows getting shown/hidden could
influence, given I would expect Wayland to *have* a frame clock, while X11
likely hasn't. Anyway, that could potentially be a factor. Or maybe W
> then the blinking caret
When Geany is focused, I indeed gets it oscillating between 0% and 0.3%, which
I'd blame on the blinking caret. When it's not focused and the caret isn't
visible, it stays at 0%.
PS: we should really use better metrics than top's CPU percentage :grin:
--
Reply to t
Merged #3902 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3902#event-13165833353
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n approved this pull request.
At first I thought you were silly indeed, because I couldn't reproduce the
issue with a very simple build, and because I know the GTK API doesn't pulsate
by itself, so it didn't make sense to me (and your OP wasn't clear enough for
me to understand what's actual
Closed #3684 as completed via 293157c7a99880523900e29a1e3191800c2018fe.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3684#event-13165577321
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3891 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3891#event-13165577345
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 1 commit.
293157c7a99880523900e29a1e3191800c2018fe Fix emission of document-activate
signal and associated UI glitches
--
View it on GitHub:
https://github.com/geany/geany/pull/3891/files/6e1cbed8d6050dbd224b53dc9360b2d51d921fea..293157c7a99880523900e29a1e3191800c2018fe
You are rec
I was about to merge, but spotted a potential bug: in the unlikely case
`closing_call` (that's *not* quitting, which mislead me) is set when the idle
callback runs, it would fail to rested the callback ID yet remove the callback.
This could lead to failing to trigger the callback (if next run i
@b4n commented on this pull request.
> + const PluginExtensionEntry *entry_b = b;
+
+ return entry_b->priority - entry_a->priority;
+}
+
+
+GEANY_API_SYMBOL
+void plugin_extension_register(PluginExtension *extension, const gchar
*plugin_name,
+ gint priority, gpointer data)
+{
+
@b4n commented on this pull request.
> + plugin_extension_calltips_show(editor->document, FALSE);
+ plugin_extension_autocomplete_perform(editor->document, FALSE);
OK, if you think extensions implementing those will basically never have to re
do this separately because they have some
Merged #3650 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3650#event-13137254499
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n approved this pull request.
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3572#pullrequestreview-2114190980
You are receiving this because you are subscribed to this thread.
Message ID:
Anybody else wanting to test this? If not, I'll merge this in a couple days
and you'll all be *forced* to test it :smiling_imp:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3891#issuecomment-2163852052
You are receiving this because you are subscrib
Anyway, apart from those two fairly little things, I think I'm happy with how
this looks :slightly_smiling_face:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3849#issuecomment-2163848773
You are receiving this because you are subscribed to this threa
@b4n pushed 1 commit.
052eb37425a3ec32535de35b0712f01bf9488317 fixup! Move
plugin_extension_calltips_provided() check inside on_editor_notify()
--
View it on GitHub:
https://github.com/geany/geany/pull/3849/files/09295cea1d13e849f8269da666a96db519e08d6c..052eb37425a3ec32535de35b0712f01bf948831
@b4n commented on this pull request.
> + const PluginExtensionEntry *entry_b = b;
+
+ return entry_b->priority - entry_a->priority;
+}
+
+
+GEANY_API_SYMBOL
+void plugin_extension_register(PluginExtension *extension, const gchar
*plugin_name,
+ gint priority, gpointer data)
+{
+
@b4n commented on this pull request.
> + plugin_extension_calltips_show(editor->document, FALSE);
+ plugin_extension_autocomplete_perform(editor->document, FALSE);
Hum… do we actually want the calls here? I'm fine with them, don't get me
wrong, but does this actually help the extens
I'm all for it, but given I don't use Windows I don't think my vote is fair
:slightly_smiling_face:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3903#issuecomment-2163337152
You are receiving this because you are subscribed to this thread.
Message I
> I wouldn't do that, extensions should just behave correctly.
OK. Indeed I don't want this to be *necessary*, but if it's there for safety
people will start relying on it (and rightfully so, otherwise it's just dead
code, right?)
> And if the plugin is unloaded and the extension is still regi
@b4n commented on this pull request.
> {
+ GeanyDocument *doc = document_get_current();
+
+ if (plugin_extension_goto_provided(doc, NULL))
+ return plugin_extension_goto_perform(doc, pos, definition);
I'd say 2 or 3 (definitely not 1). I just pushed a version of 3, g
@b4n pushed 1 commit.
09295cea1d13e849f8269da666a96db519e08d6c Honor selection again in
symbols_goto_tag()
--
View it on GitHub:
https://github.com/geany/geany/pull/3849/files/b7c6b84ee0d77af826994bce8c59073d1f363dd8..09295cea1d13e849f8269da666a96db519e08d6c
You are receiving this because you
@elextr and yesterday it was just not running anything, but a retry a bit later
worked for the non-windows jobs…
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2162774034
You are receiving this because you are subscribed to this thread
> Keep the string, its for _human_ consumption and use, and a pointer isn't.
Is it? It might be if it's for showing messages or having a list of priorities
in a config file, but as @techee said we could do more with a `GeanyPlugin`
instance. I'm still not sure if it's needed, but the idea to e
@b4n commented on this pull request.
>
if (plugin_extension_goto_provided(doc, NULL))
return plugin_extension_goto_perform(doc, pos, definition);
+ editor_find_current_word(doc->editor, pos,
+ editor_info.current_word, GEANY_MAX_WORD_LENGTH, NULL);
@techee yeah, the only thing is whether to pass `GeanyPlugin*` to the register
function, the rest looks good to me.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3849#issuecomment-2161709815
You are receiving this because you are subscribed to this thr
@b4n commented on this pull request.
> {
+ GeanyDocument *doc = document_get_current();
+
+ if (plugin_extension_goto_provided(doc, NULL))
+ return plugin_extension_goto_perform(doc, pos, definition);
…or just use `get_current_word_or_sel()`? Not tested, but the clic
@b4n commented on this pull request.
> {
+ GeanyDocument *doc = document_get_current();
+
+ if (plugin_extension_goto_provided(doc, NULL))
+ return plugin_extension_goto_perform(doc, pos, definition);
Ah, right, it calls `get_current_word_or_sel()`, and is indeed diff
@b4n commented on this pull request.
>
if (plugin_extension_goto_provided(doc, NULL))
return plugin_extension_goto_perform(doc, pos, definition);
+ editor_find_current_word(doc->editor, pos,
+ editor_info.current_word, GEANY_MAX_WORD_LENGTH, NULL);
(getting a build could be nice, but apparently GA has had some issues…)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2161693458
You are receiving this because you are subscribed to this thread.
Message ID:
@techee merging as is is fine here I think, the history could be cleaned but
it's not bad either. So I'd rather not worry about squashing smartly, which
might prove harder than necessary.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecommen
@b4n approved this pull request.
LGBI with a little squashing
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1358#pullrequestreview-2111542923
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n approved this pull request.
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#pullrequestreview-2111404817
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 1 commit.
3106a938506c3b73e775d055025fb774aa828b80 Do not create empty file filters
--
View it on GitHub:
https://github.com/geany/geany/pull/3861/files/f1a2870609d855c4ba3acbfc341bb314cc96b687..3106a938506c3b73e775d055025fb774aa828b80
You are receiving this because you are subscrib
> Still thinking a bit about the symbol tree - it would be nice not to have a
> separate tab that users have to switch to. What about:
>
> * allowing the plugin to access the GtkTreeView of the symbol tree so it can
> put whatever it wants there
Could the extension be called once (per document,
> Now thinking, instead of `name`, shouldn't rather `GeanyPlugin *` be passed
> as an argument of `register()`? The function can read from it whatever it
> wants.
I thought of it, but I don't know… on one hand it indeed allows accessing a lot
more stuff if need be, and we could even make sure t
@b4n commented on this pull request.
> {
+ GeanyDocument *doc = document_get_current();
+
+ if (plugin_extension_goto_provided(doc, NULL))
+ return plugin_extension_goto_perform(doc, pos, definition);
there's still the question of whether this should really be guarded
1 - 100 of 831 matches
Mail list logo
