[Github-comments] [geany/geany-plugins] geanynumberedbookmarks: Fix README typos and add headings (#1096)

2021-08-07 Thread Enrico Tröger
Also add license information (based on COPYING). You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1096 -- Commit Summary -- * geanynumberedbookmarks: Fix README typos and add headings -- File Changes -- M

Re: [Github-comments] [geany/geany-plugins] Make numbered bookmarks work with numlock on (#1093)

2021-08-07 Thread Enrico Tröger
Looks good to me, tested and works (on my German keyboard) with and without Numlock turned on. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1093#issuecomment-894628143

Re: [Github-comments] [geany/geany] Create julia lexer and tags parser (#2584)

2021-08-07 Thread Enrico Tröger
Hopefully it will happen in September, if not at least this year :). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2584#issuecomment-894624269

Re: [Github-comments] [geany/geany] Add reload all keybinding (#2859)

2021-08-07 Thread Enrico Tröger
@eht16 requested changes on this pull request. Looks good and works as expected. Beside my other minor comments, adding the keybinding to https://github.com/geany/geany/blob/master/doc/geany.txt#file-keybindings would be cool. > @@ -244,6 +244,8 @@ gboolean

Re: [Github-comments] [geany/geany-plugins] Make numbered bookmarks work with numlock on (#1093)

2021-07-21 Thread Enrico Tröger
> The Geany-plugins CI is still using an olde distro to build on, Trusty, Geany > itself has been updated to use a supported distro because of problems with > Trusty, and it was upgraded to Bionic. (Xenial having reached end of standard > life the month before the upgrade). > > What has

Re: [Github-comments] [geany/geany-plugins] Use Ubuntu Bionic for Travis builds (#1094)

2021-07-21 Thread Enrico Tröger
@eht16 pushed 1 commit. 8a4bf38524f762d5b99dc6e45fcd0c25ea0853ec Use Ubuntu Bionic for Travis builds -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[Github-comments] [geany/geany-plugins] Use Ubuntu Bionic for Travis builds (#1094)

2021-07-21 Thread Enrico Tröger
And remove now obsolete self built libgit2. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1094 -- Commit Summary -- * Use Ubuntu Bionic for Travis builds -- File Changes -- M .travis.yml (39) -- Patch Links --

Re: [Github-comments] [geany/geany] Half of interface frozen, very slow loading of files (Windows 10) (#2844)

2021-07-21 Thread Enrico Tröger
The slow file loading might be the same reason as in #2649. The interface freezing sounds like the initial problem in #2837. I have no idea what this might be (except blaming GTK). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [Github-comments] [geany/geany-plugins] 4 mistakes in spellcheck (#1035)

2021-07-11 Thread Enrico Tröger
> @eht16 > to mistake 1 you write: > > > Be aware, if you start Geany with a couple of documents opened from the > > last session, those documents will not be checked. > > That's a pity, because after a start of Geany I need always to click 2 times > the spellcheck-symbol FOR EACH document to

Re: [Github-comments] [geany/geany] Windows: Geany doesn't redraw its canvas after start. (#2837)

2021-07-08 Thread Enrico Tröger
JFTR: the current nightly builds for Windows are not compatible with the releases (as you already noticed). I don't think there is any combination of randomly chosed DLL files to make it work, the nightly builds are cross compiled and also with a different toolchain than the release builds. I

Re: [Github-comments] [geany/geany] Save project on file open/close (#1860)

2021-06-27 Thread Enrico Tröger
Should be implemented via #2114. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1860#issuecomment-869226170

Re: [Github-comments] [geany/geany] Save project on file open/close (#1860)

2021-06-27 Thread Enrico Tröger
Closed #1860. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1860#event-4944336399

[Github-comments] [geany/geany-plugins] Replace Sourceforge references (#1087)

2021-06-27 Thread Enrico Tröger
See also #1049. There are two occurrences left: `scope/docs/scope.html:pA. Your Geany does not support this signal. Either apply the patch from Geany sourceforge patch tracker a href=http://sourceforge.net/tracker/?func=detailamp;aid=3594050amp;...` The referenced issue exists

[Github-comments] [geany/geany-plugins] README: Update travis-ci.com badge URLs (#1086)

2021-06-22 Thread Enrico Tröger
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1086 -- Commit Summary -- * README: Update travis-ci.com badge URLs -- File Changes -- M README (4) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1086.patch

Re: [Github-comments] [geany/geany] No localization in Windows version (#2831)

2021-06-22 Thread Enrico Tröger
> > I can't find how to change the IDE language **from Arabic** to English, > > **it selected depending my system** (Windows here) > > No `LANG` set, the UI is _Arabic_, not English. > > > 08:12:31: Geany INFO: Geany 1.37, English_United States.1252 > > 15:04:33: Geany INFO :

Re: [Github-comments] [geany/geany-plugins] geniuspaste plugin missing TLS certificate verification (#1078)

2021-06-16 Thread Enrico Tröger
Ok, I don't want to argue about this. Also I don't know enough about the "Windows trust". If it does work automagically, it's fine. If not, we probably will receive a couple of bug reports. Don't get me wrong, not using TLS is no better. -- You are receiving this because you are subscribed

Re: [Github-comments] [geany/geany-plugins] geniuspaste plugin missing TLS certificate verification (#1078)

2021-06-15 Thread Enrico Tröger
> > On Linux there's usually a central cert-db, but not sure there's such on > > Windows. > > I'm pretty sure that's not true. Or it just depends on how you define "central cert-db". Usually there is a system wide certificate store with common public root certificates and this store is

[Github-comments] [geany/www.geany.org] Bye bye IRC @ Freenode, RIP. (#30)

2021-06-15 Thread Enrico Tröger
You can view, comment on, or merge this pull request online at: https://github.com/geany/www.geany.org/pull/30 -- Commit Summary -- * Bye bye IRC @ Freenode, RIP. -- File Changes -- M README.dev.md (1) M README.md (1) M docker/Dockerfile (2) M

Re: [Github-comments] [geany/geany-plugins] 4 mistakes in spellcheck (#1035)

2021-06-13 Thread Enrico Tröger
Each of the "mistakes" is based on a misunderstanding of the toolbar symbol: it is meant as a switch to enable or disable the spell checking while you are typing. Clicking the icon is not meant as "check the document now". For this, there is the menu item and keybindings. > mistake 1 >

Re: [Github-comments] [geany/geany] settable in key bindings but not usable in editor pane (#2826)

2021-06-13 Thread Enrico Tröger
![geany_super_modifier](https://user-images.githubusercontent.com/617017/121808935-558ecc00-cc4a-11eb-904c-0e1495de45bd.png) Interestingly, for me it seems the Super key is named "Super_L" and most importantly can be used as a single key. The keybinding Primary+Super_L actually works on its own.

Re: [Github-comments] [geany/geany] Added 3 More Keybindings (#2536)

2021-06-12 Thread Enrico Tröger
Do you actually continously use more than ten commands with 'Send Selection To'? I'm wondering if this is really necessary or if maybe the "Commander" plugin (https://plugins.geany.org/commander.html) could be an alternative. Otherwise we might end up with 20 or more keybindings for this in the

Re: [Github-comments] [geany/geany-plugins] Addons: Bookmarks: Prevent duplicating bookmarks when editing line (#1040)

2021-06-12 Thread Enrico Tröger
*friendly-ping* -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1040#issuecomment-860026069

Re: [Github-comments] [geany/geany] No Symbols Found for PHP (#2823)

2021-06-12 Thread Enrico Tröger
Current master *does* show symbols for me. @DevynCJohnson would you mind to share some example code which is not working? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-plugins] Spelling suggestion drop down like auto-complete (#1081)

2021-06-12 Thread Enrico Tröger
Closed #1081. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1081#event-4880950354

Re: [Github-comments] [geany/geany-plugins] Spelling suggestion drop down like auto-complete (#1081)

2021-06-12 Thread Enrico Tröger
There is already a list of suggestions in the context menu (just right-click on underlined word): ![spellcheck_suggestions](https://user-images.githubusercontent.com/617017/121768319-2e9ea000-cb4d-11eb-9b2b-8bf924c2a869.png) This feature can be activated in the plugin preferences dialog. I

Re: [Github-comments] [geany/geany] SaveActions: Add configurable target directory for instantly saved files (#2769)

2021-05-30 Thread Enrico Tröger
@elextr anything left? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2769#issuecomment-850973048

Re: [Github-comments] [geany/geany] SaveActions: Add configurable target directory for instantly saved files (#2769)

2021-05-30 Thread Enrico Tröger
@eht16 pushed 1 commit. e024932856886f8beca486434fbc244d97217eb8 Use "ft" variable consistently -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/geany] WIP: Meson build system (#2761)

2021-05-30 Thread Enrico Tröger
> @eht16 In fact, `gawk` is not a new depedency, it's already needed by > `geany-i18n-m4`. but I still replaced the offending statement because meson > discourages from listing source files via wildcards. Almost. `geany-i18n-m4` requires `AC_PROG_AWK` which supports also other `awk` variants

Re: [Github-comments] [geany/geany] [Feature request] Sorting text (#2782)

2021-04-12 Thread Enrico Tröger
Not sure what exactly you imagine by "by given by the user criteria" but simple sorting can be done easily (without plugins) as described on: https://wiki.geany.org/config/customcmds/sort-selection. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [Github-comments] [geany/geany] WIP: Meson build system (#2761)

2021-04-04 Thread Enrico Tröger
I support @elextr's request for docs, https://github.com/geany/geany/pull/2761#issuecomment-809698447 helped. On configure, I got: ``` po/meson.build:6:4: ERROR: Problem encountered: /bin/sh: 1: gawk: not found ``` which seems to be a new dependency. As it is just used (AFAIK) to generate a

Re: [Github-comments] [geany/geany] SaveActions: Add configurable target directory for instantly saved files (#2769)

2021-04-04 Thread Enrico Tröger
@eht16 commented on this pull request. > if (ft == NULL || ft->id == GEANY_FILETYPES_NONE) /* ft is NULL when a new file without template was opened, so use the * configured default file type */ ft =

Re: [Github-comments] [geany/geany] SaveActions: Add configurable target directory for instantly saved files (#2769)

2021-04-04 Thread Enrico Tröger
@eht16 commented on this pull request. > SETPTR(new_filename, g_strconcat(new_filename, ".", > ft->extension, NULL)); + /* create new file */ + fd = g_mkstemp(new_filename); + if (fd == -1) + { +

Re: [Github-comments] [geany/geany] SaveActions: Add configurable target directory for instantly saved files (#2769)

2021-04-04 Thread Enrico Tröger
@eht16 pushed 1 commit. f64374ec57c9e704b0f1d588d24edce2194da249 SaveActions: Fix memory leak and possible invalid access -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/geany] SaveActions: Add configurable target directory for instantly saved files (#2769)

2021-03-29 Thread Enrico Tröger
> Not part of this PR, but related, how is it possible to create a new file > with no filename but a filetype that is not none? Using `New (with template)` > gives the new file a name `untitled.ext` so it doesn't instant save, is that > intended?. I don't remember all cases where new files

Re: [Github-comments] [geany/geany] SaveActions: Add configurable target directory for instantly saved files (#2769)

2021-03-29 Thread Enrico Tröger
@eht16 commented on this pull request. > gchar *new_filename; gint fd; GeanyFiletype *ft = doc->file_type; - fd = g_file_open_tmp("gis_XX", _filename, NULL); + directory = !EMPTY(instantsave_target_dir) ?

Re: [Github-comments] [geany/geany] SaveActions: Add configurable target directory for instantly saved files (#2769)

2021-03-29 Thread Enrico Tröger
@eht16 pushed 1 commit. 0c4a35692cf9fdbfa300df0570cfa2426e3be391 SaveActions: Handle g_mkstemp() errors and prevent duplicate files -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/geany] SaveActions: Add configurable target directory for instantly saved files (#2769)

2021-03-29 Thread Enrico Tröger
@eht16 commented on this pull request. > { gchar *tmp; + if (target == NULL) + { + SETPTR(*target, NULL); This didn't make sense. Thanks for the pointer. I rewrote the code to return `FALSE` as it should no valid case when the target variable is `NULL`.

Re: [Github-comments] [geany/geany] SaveActions: Add configurable target directory for instantly saved files (#2769)

2021-03-29 Thread Enrico Tröger
@eht16 pushed 2 commits. e74d71c1a8e0e4a97f0c816ae90c351f2b448042 SaveActions: Fix resetting Instant Save target directory b4cedb37ee5ac9c3f88b09547e0aaad0a5c2a347 SaveActions: Handle g_mkstemp() errors and prevent duplicate files -- You are receiving this because you are subscribed to

Re: [Github-comments] [geany/geany] WIP: Meson build system (#2761)

2021-03-29 Thread Enrico Tröger
I don't know Meson and didn't review the Meson related changes. But the rest looks OK, I guess preferring `PACKAGE_VERSION` over `VERSION` is better for Meson and doesn't matter for Autotools? Would it help for the Windows part to merge it first? -- You are receiving this because you are

Re: [Github-comments] [geany/geany] Loading temporary files from the last session at startup does not work after a server reboot (#640)

2021-03-22 Thread Enrico Tröger
It was actually pretty easy to implement using `g_mkstemp()` as done in #2769. The directory for instantly saved files can then be configured and if not configured, the default temporary directory is used, as before. I added a note in the plugin's preferences that the user is responsible for

Re: [Github-comments] [geany/geany] SaveActions: Add configurable target directory for instantly saved files (#2769)

2021-03-22 Thread Enrico Tröger
@eht16 pushed 2 commits. f96a84dbecdec6fae9d4536448aaad05f52d7fc4 SaveActions: Add configurable target directory for instantly saved files ead067be9153871713813c501439b0200ccf9af9 SaveActions: Fix trailing dot on InstantSave filenames for filetype None -- You are receiving this because you

[Github-comments] [geany/geany] SaveActions: Add configurable target directory for instantly saved files (#2769)

2021-03-22 Thread Enrico Tröger
Closes #640. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2769 -- Commit Summary -- * SaveActions: Add configurable target directory for instantly saved files -- File Changes -- M plugins/saveactions.c (96) -- Patch Links --

Re: [Github-comments] [geany/www.geany.org] Update tips about change language on unix (#28)

2021-03-21 Thread Enrico Tröger
Merged #28 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/28#event-4486805459

Re: [Github-comments] [geany/www.geany.org] Geany e. V. General Assembly 2020 was done (#27)

2021-03-21 Thread Enrico Tröger
Merged #27 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/27#event-4486803106

Re: [Github-comments] [geany/www.geany.org] Geany e. V. General Assembly 2020 was done (#27)

2021-03-21 Thread Enrico Tröger
I like ""None scheduled". @frlan would you mind updating it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/27#issuecomment-803590333

Re: [Github-comments] [geany/www.geany.org] Add imprint on Geany e.V. association page (#29)

2021-03-21 Thread Enrico Tröger
@eht16 pushed 1 commit. b846da6bbdb30506ee47abe4f5ea6803595e813d Add imprint on Geany e.V. association page -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/www.geany.org] Add imprint on Geany e.V. association page (#29)

2021-03-21 Thread Enrico Tröger
@frlan any objections? I'm not completely sure we need it but probably we do as we accept donations. The law (§ 5 TMG) is quite fuzzy about this. As it doesn't expose anything new except my already publicly known address, I guess this should help. -- You are receiving this because you are

[Github-comments] [geany/www.geany.org] Add imprint on Geany e.V. association page (#29)

2021-03-21 Thread Enrico Tröger
We probably need this for German law and so add it to be safe. It doesnt expose that much new information except for an already present address. You can view, comment on, or merge this pull request online at: https://github.com/geany/www.geany.org/pull/29 -- Commit Summary -- * Add imprint

Re: [Github-comments] [geany/geany] Fix startup speed (#2747)

2021-02-07 Thread Enrico Tröger
I think releasing it is a good idea. Basically, I wouldn't mind whether we call it 1.37.2 or 1.38 except that just "ctags_sync" has landed. So yes, 1.37.2 seems sensible. However, I personally won't be able to do the Windows builds until approx. mid of March. -- You are receiving this because

Re: [Github-comments] [geany/geany-plugins] geany-plugins sourceforge site should be maintained or removed (#1049)

2021-01-17 Thread Enrico Tröger
The files http://geany-plugins.sourceforge.net/ were just there generated files from the READMEs in GIT and the non-generated part of the website is in https://github.com/geany/plugins.geany.org versioned. So, after my SSH pubkey worked today on SF, I deleted the old web content and put a

Re: [Github-comments] [geany/geany-plugins] geany-plugins sourceforge site should be maintained or removed (#1049)

2021-01-17 Thread Enrico Tröger
Closed #1049. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1049#event-4214927553

Re: [Github-comments] [geany/geany-plugins] GeanyVC git commit not working (Windows) (#1056)

2021-01-17 Thread Enrico Tröger
Running `geany -v` revealed the underlying GIT error: ``` Author identity unknown *** Please tell me who you are. Run git config --global user.email "y...@example.com" git config --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only

Re: [Github-comments] [geany/geany-plugins] GeanyVC git commit not working (Windows) (#1056)

2021-01-17 Thread Enrico Tröger
Just tested on a Windows box: I can confirm the commit action fails. But it is unrelated to any spell checking issues. Though we also cannot see why it is failing at all, the plugin doesn't log the process result :(. For this to work, we need https://github.com/geany/geany-plugins/pull/1026 to

Re: [Github-comments] [geany/geany-plugins] GeanyVC git commit not working (Windows) (#1056)

2021-01-16 Thread Enrico Tröger
@Morusec did you try to disable spellchecking for GeanyVC by setting the language option to an empty string in the plugin preferences? The posted warnings about aspell and voikkpo libraries are rather harmless and I even think the mixed slashes would work. But Enchant on Windows doesn't work

Re: [Github-comments] [geany/geany-plugins] geany-plugins sourceforge site should be maintained or removed (#1049)

2021-01-16 Thread Enrico Tröger
- I added some badge to the top of the SF project page with a link to https://plugins.geany.org. - Also disabled the trackers by removing permissions to create tickets and posts. - Updated the default support URL to point to the issue tracker at SF - http://geany-plugins.sourceforge.net still

Re: [Github-comments] [geany/geany] Link to the change log per #2701 (#2714)

2021-01-16 Thread Enrico Tröger
@eht16 commented on this pull request. > @@ -27,6 +27,10 @@ The basic features of Geany are: - embedded terminal emulation - extensibility through plugins +Changelog +- +See the release notes on `the website `_ or `on GitHub

Re: [Github-comments] [geany/geany] Link to the change log per #2701 (#2714)

2021-01-16 Thread Enrico Tröger
@eht16 commented on this pull request. > @@ -27,6 +27,10 @@ The basic features of Geany are: - embedded terminal emulation - extensibility through plugins +Changelog +- +See the release notes on `the website `_ or `on GitHub

Re: [Github-comments] [geany/geany] "make check" unittests fail on Windows (#2677)

2020-12-11 Thread Enrico Tröger
> From what I understood, when you change line endings from CRLF to LF in the > test, this diff goes away. But then it means that the CRLFs in the test are > the cause of the missing tags and there's some problem with parsing. You are completely right. I was somewhat confused because the

Re: [Github-comments] [geany/geany-plugins] Splitting a snowman in half crashes Geany with Spell Check (inserting a space before Unicode VARIATION SELECTOR-16) (#1041)

2020-12-05 Thread Enrico Tröger
> > Also, my snowman is always in the uncolored variant > > To copy into Geany, I had to "Edit" this issue description and copy/paste > from there (and then cancel the edit). I think you also need a fallback font > that provides it to be installed like [Noto Color >

Re: [Github-comments] [geany/geany-plugins] Splitting a snowman in half crashes Geany with Spell Check (inserting a space before Unicode VARIATION SELECTOR-16) (#1041)

2020-12-05 Thread Enrico Tröger
I don't have the "DejaVu Sans Mono Regular" font variant :(. Also, my snowman is always in the uncolored variant, even when not "split": ![geany_snowman](https://user-images.githubusercontent.com/617017/101240684-c6c45400-36e8-11eb-8b2f-5ccc0c6785d9.png) Not sure why this is. Still, no matter

Re: [Github-comments] [geany/geany-plugins] Splitting a snowman in half crashes Geany with Spell Check (inserting a space before Unicode VARIATION SELECTOR-16) (#1041)

2020-12-02 Thread Enrico Tröger
> Goodness @eht16 your Arch is 0.0.1 behind on Glib, I thought Arch was totally > bleeding edge grin Arch is totally bleeding egde as you'D expect it (https://www.archlinux.org/packages/core/x86_64/glib2/), just my local system isn't so much because of my personal lazyness :). > Its still

Re: [Github-comments] [geany/geany] "make check" unittests fail on Windows (#2677)

2020-12-02 Thread Enrico Tröger
I still think reading the source files is not the problem. Tag parsing works fine on Windows, for LF and CRLF source files. Anyway, I added some code in https://github.com/geany/geany/blob/c5303c9499bb6f0d632e0ca5b42e15f84d64ac52/ctags/main/read.c#L845 to print the return value of

Re: [Github-comments] [geany/geany-plugins] Splitting a snowman in half crashes Geany with Spell Check (inserting a space before Unicode VARIATION SELECTOR-16) (#1041)

2020-12-02 Thread Enrico Tröger
I'm using DejaVu Sans Mono Book 8 with ``` 23:24:25: Geany INFO: Geany 1.38 (git >= 00ca7e7a), en_US.utf8 23:24:25: Geany INFO: GTK 3.24.23, GLib 2.66.2 23:24:25: Geany INFO: OS: Arch Linux ``` Pango: 1.48.0-1 -- You are receiving this because you are

Re: [Github-comments] [geany/geany] Ctags sync rebased (#2666)

2020-11-30 Thread Enrico Tröger
Guys, don't panic :). Maybe I wasn't clear above: I do *not* want to change the line endings of any input files! In my tests, it didn't matter if the input file had LF or CRLF line endings, the generated tags were correct. I was just talking about converting the unittest tags files against we

Re: [Github-comments] [geany/geany-plugins] Splitting a snowman in half crashes Geany with Spell Check (inserting a space before Unicode VARIATION SELECTOR-16) (#1041)

2020-11-30 Thread Enrico Tröger
Don't split snowmen!!! How dare you? More seriously, the difference to #1022 and #1036 is that @hroncok seems to be using 1.37 and not 1.36. The backtrace shows the more or less obvious: the crash seems to happen while drawing the indicator in Scintilla. It might be there is a bug in the start

Re: [Github-comments] [geany/geany] Ctags sync rebased (#2666)

2020-11-29 Thread Enrico Tröger
> > The good news is: without the --strip-trailing-cr change, the binary mode > > actually fixes all the tests except the six failures. > > Great! I think changing the mode to binary is such a trivial change that I > could addd it as a commit to this pull request, what do you think? Sure, why

Re: [Github-comments] [geany/geany-plugins] Addons: Bookmarks: Prevent duplicating bookmarks when editing line (#1040)

2020-11-29 Thread Enrico Tröger
To test: set a bookmark in a C file, find the bookmark in the bookmark list sidebar, edit the bookmark line and see how the bookmark is duplicated in the list. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany-plugins] Addons: Bookmarks: Prevent duplicating bookmarks when editing line (#1040)

2020-11-29 Thread Enrico Tröger
For some filetypes (more specifically some Scintilla lexers) it might happen that an event with modificationType SC_MOD_CHANGEMARKER is sent and so the current line is added as bookmark again. To avoid this, check if the current line has already a bookmark and update it in this case. Might be

Re: [Github-comments] [geany/geany] Ctags sync rebased (#2666)

2020-11-29 Thread Enrico Tröger
> > No, I don't. I just ran the checks now with this PR as I thought it might > > help. > > The tests fail in the same way for Geany master, so you are absolutely > > right: it's not new and not related to this PR. > > Ctags uses appveyor for CI on Windows so it might be worth considering to

[Github-comments] [geany/geany] "make check" unittests fail on Windows (#2677)

2020-11-29 Thread Enrico Tröger
When running the unittests on Windows, all Ctags tests fail because TagManager writes the tag files with CRLF line endings but the tests compare against the test samples which have LF line endings (most of them). There is a probably easy solution: as @techee pointed out in

Re: [Github-comments] [geany/geany] Fix wrong format specifier in debug message (#2645)

2020-11-29 Thread Enrico Tröger
Merged #2645 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2645#event-4049007973

Re: [Github-comments] [geany/geany] Do not convert filename when opening files from command line on Windows (#2660)

2020-11-29 Thread Enrico Tröger
> Just committed it but will try to add some more descriptive comments and > commit message in the next days Finally done. I will squash the commits and take the last one's message. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [Github-comments] [geany/geany] Do not convert filename when opening files from command line on Windows (#2660)

2020-11-29 Thread Enrico Tröger
@eht16 pushed 1 commit. 3fd57630d001b066ed0e0e794c9039d77852a47f Convert working directory from UTF-8 to locale on Windows -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/geany] Ctags sync rebased (#2666)

2020-11-28 Thread Enrico Tröger
> @eht16 Just curious, do you run `make check` when you make Windows releases? No, I don't. I just ran the checks now with this PR as I thought it might help. The tests fail in the same way for Geany master, so you are absolutely right: it's not new and not related to this PR. Sorry, I should

Re: [Github-comments] [geany/www.geany.org] Update tips about change language on unix (#28)

2020-11-28 Thread Enrico Tröger
LGTM. @elextr? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/28#issuecomment-735234129

Re: [Github-comments] [geany/geany] Ctags sync rebased (#2666)

2020-11-26 Thread Enrico Tröger
Good idea. Here is Geany's and Ctags' `config.h` on my Windows system: https://gist.github.com/eht16/e15e74e5f7bffebdf5f4ada38077ea59 I used `./autogen.sh && ./configure && make` on MSYS2 instead of the `mk_mingw.mak`. https://github.com/universal-ctags/ctags/blob/master/docs/windows.rst maybe

Re: [Github-comments] [geany/geany] Ctags sync rebased (#2666)

2020-11-25 Thread Enrico Tröger
> @eht16 yay, thanks! I just committed your fix slightly modified to improve > overall ordering of the checks, but it should have the same result. Confirmed. Your changes work fine ! > @eht16 however, did the bundled regex got used, or did your MSYS have > `regcomp()`? Same question for

Re: [Github-comments] [geany/geany] Ctags sync rebased (#2666)

2020-11-22 Thread Enrico Tröger
Tested on Windows: https://download.geany.org/snapshots/geany-1.38_setup-pr2666.exe I got: ``` /bin/sh ../libtool --silent --tag=CC --mode=compile ccache gcc -DHAVE_CONFIG_H -I. -I.. -I./main -I./parsers -DEXTERNAL_PARSER_LIST_FILE=\"../src/tagmanager/tm_parsers.h\"

Re: [Github-comments] [geany/geany] Can not open files from unicode-named folders under Windows (#2652)

2020-11-16 Thread Enrico Tröger
@WhatWhereWhyler please use https://download.geany.org/snapshots/geany-1.38_setup-pr2660-2.exe for testing. The previous test installer contained a fix which fixed only opening files with ASCII filenames but not filenames with non-ASCII characters. -- You are receiving this because you are

Re: [Github-comments] [geany/geany] Do not convert filename when opening files from command line on Windows (#2660)

2020-11-16 Thread Enrico Tröger
Btw, I tested successfully: - working directory with German umlaut, relative ASCII filename - working directory with German umlaut, relative filename with German umlaut - working directory with German umlaut, absolute path with German umlaut in directory, ASCII filename - working directory with

Re: [Github-comments] [geany/geany] Do not convert filename when opening files from command line on Windows (#2660)

2020-11-16 Thread Enrico Tröger
This works if we use `g_locale_from_utf8()` instead of `utils_get_locale_from_utf8()` (the latter is just a no-op on Windows). Just committed it but will try to add some more descriptive comments and commit message in the next days, so my future me won't wonder so much in the next 12 years :).

Re: [Github-comments] [geany/geany] Do not convert filename when opening files from command line on Windows (#2660)

2020-11-16 Thread Enrico Tröger
@eht16 pushed 1 commit. 30706ad8ea2bcff39ebddd89cd72ae6d7d765368 Convert working directory from UTF-8 to locale on Windows -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/geany] Can not open files from unicode-named folders under Windows (#2652)

2020-11-15 Thread Enrico Tröger
#1095 is unrelated. The problem was "introduced" in https://github.com/geany/geany/commit/f31899538d9cf548cecb8dcdd5fc2cb67893d832. It's 12 years ago and I don't remember what exactly I tried to fix and why today it is rather broken than fixed. There are good chances that this change fixes the

Re: [Github-comments] [geany/geany-plugins] Windows installer: ignore patch level version when checking for Geany (#1031)

2020-11-15 Thread Enrico Tröger
Yes, I did. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1031#issuecomment-727581962

Re: [Github-comments] [geany/geany] Fix wrong format specifier in debug message (#2645)

2020-11-15 Thread Enrico Tröger
> I trust you have actually tested this on Windows, with and without initial > config wink Oh yes. I'm constantly trying to do the same mistake only once :). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany] Do not convert filename when opening files from command line on Windows (#2660)

2020-11-15 Thread Enrico Tröger
Its unclear why the previous was added (by me) 12 years ago. Maybe the code in main_handle_filename() or after has been changed/improved so that it works now or the previous test case for opening files from the command line was wrong. This happens only when starting a new instance of Geany from

[Github-comments] [geany/geany-plugins] Windows installer: ignore patch level version when checking for Geany (#1031)

2020-11-15 Thread Enrico Tröger
Loosen the G-P Windows installer version check for Geany to require only a matching major and minor version, i.e. we now ignore the patch level. So for example, Geany-Plugins 1.37 can be installed for Geany 1.37.1 without warnings. As discussed in geany/geany/issues/2655. You can view, comment

Re: [Github-comments] [geany/geany] Add microseconds to timestamp in debug log messages (#2659)

2020-11-15 Thread Enrico Tröger
@eht16 pushed 1 commit. cd10ef4996642ed80d6b21d6addcdd002f06a9b4 Add microseconds to timestamp in debug log messages -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[Github-comments] [geany/geany] Add microseconds to timestamp in debug log messages (#2659)

2020-11-15 Thread Enrico Tröger
This could help to debug the reported slow startup times but is also useful in general. Starting Geany from the command line with `--verbose` already logs milliseconds. But most users (and maybe developers) usually dont do this. Thanks to GLib, we dont need to do much for it and it actually

Re: [Github-comments] [geany/geany] Fix wrong format specifier in debug message (#2645)

2020-11-15 Thread Enrico Tröger
@eht16 commented on this pull request. > @@ -406,7 +406,7 @@ static gint get_windows_socket_port(void) if (! g_file_test(configfile, G_FILE_TEST_IS_REGULAR)) Done in 58c5e34a3b3763bd0f22152a6df02db68bd7c8ab. Thanks! -- You are receiving this because you are subscribed to this thread.

Re: [Github-comments] [geany/geany] Fix wrong format specifier in debug message (#2645)

2020-11-15 Thread Enrico Tröger
@eht16 pushed 1 commit. 58c5e34a3b3763bd0f22152a6df02db68bd7c8ab Remove unnecessary code when reading IPC socket port on Windows -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/geany] Refs #2615 - Convert create_py_tags.py to Python 3 (#2630)

2020-11-15 Thread Enrico Tröger
@eht16 requested changes on this pull request. Thanks! A few remarks: - `scripts/create_py_tags.py:26: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses`scripts/create_py_tags.py:26: DeprecationWarning: the imp module

Re: [Github-comments] [geany/geany] Slow startup (#2649)

2020-11-11 Thread Enrico Tröger
> > since it seems already to happen with 1.36, it might have a lot more causes > > :(. > > Does it? IIUC what "issue exists in 1.36" is totally unrelated and about > whether or not one can create more than one "untitled" files at once. Yeah, seems I mixed them up. Sorry. -- You are

Re: [Github-comments] [geany/geany] Slow startup (#2649)

2020-11-11 Thread Enrico Tröger
> Sorry if it's a silly question, it just hit me: which GTK version are we > using on OSX and Windows for 1.37 and before? As the default switched to 3.x, > do we use that? If 1.37 is the first GTK3 release there, it might very well > be that… 1.37 for Windows was still GTK2 and since it seems

Re: [Github-comments] [geany/geany] windows, 1.37.1 , no plugin available (#2655)

2020-11-11 Thread Enrico Tröger
Closed #2655. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2655#event-3985317329

Re: [Github-comments] [geany/geany] windows, 1.37.1 , no plugin available (#2655)

2020-11-11 Thread Enrico Tröger
> Sounds like we should allow any version matching X.Y.* instead of only X.Y.Z > in the GP installer. Yes but it was too late for 1.37.1. As @fyah noticed in the meantime, the warning is harmless in this case but useful in general and should be loosen up to major.minor. I took it on my

Re: [Github-comments] [geany/geany] Slow startup (#2649)

2020-11-08 Thread Enrico Tröger
@frlan reported also slowiness on startup. His debug message log indicated the startup itself is as fast as expected but opening session files takes from 100ms to 300ms per file. IIRC he had similar times on Linux und MacOS. Besides that, I agree with @elextr: this either needs some detailed

Re: [Github-comments] [geany/geany] geany would not open (Windows 10) (#2639)

2020-11-08 Thread Enrico Tröger
@ndroock1, @Rasbats and all who still had problems: we've just releases Geany 1.37 (https://github.com/geany/geany/releases/tag/1.37.1) with a fix for the startup crash. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

2020-11-07 Thread Enrico Tröger
@eht16 commented on this pull request. > ls $cachedir/mingw-w64-${ABI}-${1}-${package_version}-* | sort > -V | tail -n 1 else - pacman -Sp mingw-w64-${ABI}-${1} + # -dd to ignore dependencies as we listed them already above in $packages Even

Re: [Github-comments] [geany/geany] Windows cross, GTK3 and x86_64 build preparations (#2590)

2020-11-07 Thread Enrico Tröger
@eht16 commented on this pull request. > @@ -1,43 +1,51 @@ -#!/bin/sh +#!/bin/bash There are a couple of `$(command...)` in there even though I might added them after I set it to bash :+1: The reason is this way we don't need to care whether to use bashisms or not. And shell portability

<    6   7   8   9   10   11   12   13   14   15   >