Re: keywords in desktop files, again

2014-01-27 Thread Andre Klapper
(One year later, anyway:) On Fri, 2013-03-22 at 10:24 -0400, Matthias Clasen wrote: > I sent a mail about this in January already[1], but we are still > seeing a steady stream of broken syntax in translations for the > Keywords field in desktop files. A pre-commit check for po files could refuse

Re: keywords in desktop files, again

2013-03-24 Thread Ask Hjorth Larsen
Thanks, the one in Danish has been corrected :) 2013/3/24 Daniel Mustieles García : > Hi all, > > Here is the report I've generated about the missing «;» in the Keywords > translated string. > > Translation team coordinator: As this is an important fix we should do > before the new release, please

Re: keywords in desktop files, again

2013-03-24 Thread Daniel Mustieles García
Hi all, Here is the report I've generated about the missing «;» in the Keywords translated string. Translation team coordinator: As this is an important fix we should do before the new release, please let me know if you won't be able to fix it, so I'll review and fix it for you. Best regards 20

Re: keywords in desktop files, again

2013-03-24 Thread Philip Withnall
El vie, 22-03-2013 a las 15:46 +0100, Olav Vitters escribió: > On Fri, Mar 22, 2013 at 02:42:39PM +, Philip Withnall wrote: > > We already have validation of .po files in a pre-receive git hook[1]. > > Might it be an idea to add validation of .desktop files? > > Any idea how that could be impl

Re: keywords in desktop files, again

2013-03-24 Thread Daniel Mustieles García
Hi Ask, You can use this script to get all the PO files for the most relevant languages. The script also has the ability to get all the language codes from DL, sou you can get all the PO files from all the languages. Cheers! 2013/3/23 Ask Hjorth Larsen > Hi > > What is the easiest way to downl

Re: keywords in desktop files, again

2013-03-23 Thread Ask Hjorth Larsen
Hi What is the easiest way to download all the translations in all languages? Regards Ask 2013/3/22 Daniel Mustieles García : > It works great!! > > I've detected (and fixed) an error in gnome-control-center. Thanks!! > > This weekend ill try to clean the output to be less verbose and I'll creat

Re: keywords in desktop files, again

2013-03-22 Thread Daniel Mustieles García
It works great!! I've detected (and fixed) an error in gnome-control-center. Thanks!! This weekend ill try to clean the output to be less verbose and I'll create a report with it. Stay tuned!! Again, many thanks! 2013/3/22 Ask Hjorth Larsen > It can be used like this: > > askhl@mime:~/transla

Re: keywords in desktop files, again

2013-03-22 Thread Ask Hjorth Larsen
It can be used like this: askhl@mime:~/translate$ find -name "*.po" | xargs desktopfilecheck.py ./gdm-and-friends/gnome-control-center.gnome-3-8.da.po ERROR, bad syntax line 6684: #. Translators: those are keywords for the wacom tablet control-center panel #: ../panels/wacom/gnome-wacom-panel.desk

Re: keywords in desktop files, again

2013-03-22 Thread Ask Hjorth Larsen
Hi, here's a script (uses pyg3t): http://www.student.dtu.dk/~ashj/opendir/desktopfilecheck.py I'm actually at work at the moment, but someone can run it or I'll do it tomorrow or so when I have time. Let me know about any issues or if it needs to check for anything else. Regards Ask 2013/3/2

Re: keywords in desktop files, again

2013-03-22 Thread Daniel Mustieles García
Hi Ask, The Keywords string just has to end with ";" to be ok, no need to have the same number of words Many thanks fin advance for your script! 2013/3/22 Ask Hjorth Larsen > Hi > > Could someone specify how these files *should* be translated? Must > there be the same number of elements in th

Re: keywords in desktop files, again

2013-03-22 Thread Ask Hjorth Larsen
Hi Could someone specify how these files *should* be translated? Must there be the same number of elements in the list? I suppose the most obvious thing is that it should end with ;. I'll write a script and check it on all the files, then send a complete list. Regards Ask 2013/3/22 Daniel Mus

Re: keywords in desktop files, again

2013-03-22 Thread Daniel Mustieles García
In bash it may be tricky to do this check, but I guess Python could help. I tried to do it in bash and I wasted my time :( 2013/3/22 Andre Klapper > On Fri, 2013-03-22 at 15:46 +0100, Olav Vitters wrote: > > Any idea how that could be implemented? I am willing to make it happen, > > just don't s

Re: keywords in desktop files, again

2013-03-22 Thread Andre Klapper
On Fri, 2013-03-22 at 15:46 +0100, Olav Vitters wrote: > Any idea how that could be implemented? I am willing to make it happen, > just don't see how. E.g. figure out exactly which line is the Keywords > line, etc. Grep for a line that starts with #: ../ and includes the string .d

Re: keywords in desktop files, again

2013-03-22 Thread Philip Withnall
El vie, 22-03-2013 a las 15:46 +0100, Olav Vitters escribió: > On Fri, Mar 22, 2013 at 02:42:39PM +, Philip Withnall wrote: > > We already have validation of .po files in a pre-receive git hook[1]. > > Might it be an idea to add validation of .desktop files? > > Any idea how that could be impl

Re: keywords in desktop files, again

2013-03-22 Thread matthias.clasen
If you have a jhbuild build, you can run desktop-file-validate on the desktop files in the module. You'll have to rebuild after making translation changes to regenerate those files. Sent from my Samsung Galaxy Note™, an AT&T LTE smartphonerafael ff1 wrote:Is there a easy way to track down t

Re: keywords in desktop files, again

2013-03-22 Thread Olav Vitters
On Fri, Mar 22, 2013 at 02:42:39PM +, Philip Withnall wrote: > We already have validation of .po files in a pre-receive git hook[1]. > Might it be an idea to add validation of .desktop files? Any idea how that could be implemented? I am willing to make it happen, just don't see how. E.g. figur

Re: keywords in desktop files, again

2013-03-22 Thread Philip Withnall
El vie, 22-03-2013 a las 10:24 -0400, Matthias Clasen escribió: > I sent a mail about this in January already[1], but we are still > seeing a steady stream of broken syntax in translations for the > Keywords field in desktop files. Please, try to educate your fellow > translators about this issue,

Re: keywords in desktop files, again

2013-03-22 Thread rafael ff1
Is there a easy way to track down this bug in every module, except for going in and out of each one? I'd love to make sure it doesn't happen to my language. Rafael Ferreira 2013/3/22 Matthias Clasen : > I sent a mail about this in January already[1], but we are still > seeing a steady stream of b

Re: Keywords in desktop files

2013-01-23 Thread Ask Hjorth Larsen
2013/1/23 Ask Hjorth Larsen : (...) > > Presently it's a very simple heuristic. It checks whether the English > message looks like XML, by looking for the character '<' and checking > if it is valid XML. If the English message fulfills those criteria > and the translation isn't valid XML, then a

Re: Keywords in desktop files

2013-01-23 Thread Ask Hjorth Larsen
Hi 2013/1/23 Shaun McCance : > On Thu, 2013-01-17 at 14:04 +0100, Daniel Mustieles García wrote: >> Another check that should be implemented is the XML syntax check done >> in gtxml [1]. It checks the documentation PO files syntax, and is >> really useful to avoid errors in malfomed or wrong tags

Re: Keywords in desktop files

2013-01-23 Thread Shaun McCance
On Thu, 2013-01-17 at 14:04 +0100, Daniel Mustieles García wrote: > Another check that should be implemented is the XML syntax check done > in gtxml [1]. It checks the documentation PO files syntax, and is > really useful to avoid errors in malfomed or wrong tags in doc files. > > [1] https://laun

Re: Keywords in desktop files

2013-01-19 Thread Daniel Mustieles García
Check desktop files is easy to do with find and grep... just need to have all the modules cloned in your local computer. Yesterday i reviewd some of them, and just found an error in Rhythmbox, but I don't have a local copy of all the modules... maybe sysadmins could help us with this? About the XM

Re: Keywords in desktop files

2013-01-18 Thread Александър Шопов
Speaking of keywords: When translating - I add the Bulgarian translation and then copy and add the English original because people will search and expect both the translated and the original version. Is there any problem with this strategy? Kind regards: al_shopov _

Re: Keywords in desktop files

2013-01-18 Thread Christian Kirbach
Wouldn't both tasks - XML syntax check and keyword check in desktop files - make a fine GnomeGoal? Am Donnerstag, den 17.01.2013, 14:04 +0100 schrieb Daniel Mustieles García: > Another check that should be implemented is the XML syntax check done > in gtxml [1]. It checks the documentation PO fil

Re: Keywords in desktop files

2013-01-17 Thread Daniel Mustieles García
Another check that should be implemented is the XML syntax check done in gtxml [1]. It checks the documentation PO files syntax, and is really useful to avoid errors in malfomed or wrong tags in doc files. [1] https://launchpad.net/pyg3t 2013/1/17 Matthias Clasen > On Thu, Jan 17, 2013 at 3:5

Re: Keywords in desktop files

2013-01-17 Thread Olav Vitters
On Thu, Jan 17, 2013 at 05:55:18AM -0500, Matthias Clasen wrote: > On Thu, Jan 17, 2013 at 3:55 AM, Olav Vitters wrote: > > On Wed, Jan 16, 2013 at 02:31:41PM -0500, Matthias Clasen wrote: > >> In trying to build 3.7.4 in Fedora, I've come across a few modules > >> where translations got this wron

Re: Keywords in desktop files

2013-01-17 Thread Matthias Clasen
On Thu, Jan 17, 2013 at 3:55 AM, Olav Vitters wrote: > On Wed, Jan 16, 2013 at 02:31:41PM -0500, Matthias Clasen wrote: >> In trying to build 3.7.4 in Fedora, I've come across a few modules >> where translations got this wrong. Here is an example: > > I usually just commit fixes for that, but Mage

Re: Keywords in desktop files

2013-01-17 Thread Olav Vitters
On Wed, Jan 16, 2013 at 02:31:41PM -0500, Matthias Clasen wrote: > In trying to build 3.7.4 in Fedora, I've come across a few modules > where translations got this wrong. Here is an example: I usually just commit fixes for that, but Mageia is sticking with 3.6 for now. Any way to check this on th

Re: Keywords in desktop files

2013-01-16 Thread Daniel Mustieles García
Thanks Matthias for your advice. I've also noticed this same error in some originals strings, and I've fixed it, but It would be great if there were a way to check it without reviewing all the PO files. I'll investigate it and will post here the results. I'd also like to comment that adding this k