Re: [Gnustep-cvs] r27911 - in /libs/gui/trunk: ChangeLog Source/GSNibLoading.m Source/NSDrawer.m

2009-03-02 Thread Gregory Casamento
Fred, The alternate menu issue is not void, but it's not really relevant to the reorganization discussion and, perhaps, we should talk about it separately. What I was trying to say is that we should handle alternate menu items to prevent them from appearing in the menu since, to the user, they

Re: [Gnustep-cvs] r27911 - in /libs/gui/trunk: ChangeLog Source/GSNibLoading.m Source/NSDrawer.m

2009-03-01 Thread Riccardo Mottola
Hi, 1. duplication of code for handling menu rearrangement. I think I wrote the original code for this for switching between vertical and horizontal menus, but that' so long ago I don't remember any detail. It sounds like Greg wrote different code to do a similar job at the point when a nib

Re: [Gnustep-cvs] r27911 - in /libs/gui/trunk: ChangeLog Source/GSNibLoading.m Source/NSDrawer.m

2009-03-01 Thread Fred Kiefer
Richard Frith-Macdonald wrote: 3. Some code has some other glitches in it that I don't understand/follow? That was the menu reorganization not working for FlexiSheet that has a German NIB file. Now with the added and corrected localization in gui this is working nicely and remove the last

Re: [Gnustep-cvs] r27911 - in /libs/gui/trunk: ChangeLog Source/GSNibLoading.m Source/NSDrawer.m

2009-03-01 Thread Gregory Casamento
Your code isn't duplicating the item. It's including items which are alternates which are (by definition) duplications of the items they serve as alternates for. :) What I was saying is that I believe that we need to implement handling for alternate menu items. :) I am aware that my code

Re: [Gnustep-cvs] r27911 - in /libs/gui/trunk: ChangeLog Source/GSNibLoading.m Source/NSDrawer.m

2009-02-27 Thread Richard Frith-Macdonald
On 27 Feb 2009, at 09:03, Fred Kiefer wrote: Now you left me puzzled. Which menu items get duplicated by my reorganisation code? I tried to reproduce this with FlexiSheet and Bean and I am very sure that each item only appears once. In FlexiSheet I see an issue with the missing German

Re: [Gnustep-cvs] r27911 - in /libs/gui/trunk: ChangeLog Source/GSNibLoading.m Source/NSDrawer.m

2009-02-26 Thread Fred Kiefer
Hi Greg, this look was what I actually wanted to achive :-) Looks like we don't have a case of not working code, but different goals. We better start out by defining the problem, listing possible solutions and then arguing for or against them. The problem I see is that we have a duplication of

Re: [Gnustep-cvs] r27911 - in /libs/gui/trunk: ChangeLog Source/GSNibLoading.m Source/NSDrawer.m

2009-02-25 Thread Gregory Casamento
Fred, I have attached how it looks using the new code (Flexisheet_organizeMenu.jpg). I'm not seeing any difference between that and how it looked before. For reference, with my code, it looks like the attached file Flexisheet_gsnibcode.jpg. Thanks, GC On Tue, Feb 24, 2009 at 5:35 PM, Fred

Re: [Gnustep-cvs] r27911 - in /libs/gui/trunk: ChangeLog Source/GSNibLoading.m Source/NSDrawer.m

2009-02-24 Thread Fred Kiefer
Gregory Casamento wrote: Author: gcasa Date: Wed Feb 18 08:38:02 2009 New Revision: 27911 URL: http://svn.gna.org/viewcvs/gnustep?rev=27911view=rev Log: * Source/GSNibLoading.m: Rollback of previous change. Found a minor problem. Modified: libs/gui/trunk/ChangeLog

Re: [Gnustep-cvs] r27911 - in /libs/gui/trunk: ChangeLog Source/GSNibLoading.m Source/NSDrawer.m

2009-02-24 Thread Gregory Casamento
Hey Fred, When I removed my code, the menu started rendering as it had before (i.e. messy with all but a few items in the top level). As you can see, the date was the 18th, so it was just before SCALE, I figured it would be better to roll back the change until I could take a better look at it.