Re: [go-nuts] [ANN] httpsnoop, an easy way to capture http related metrics (response time, bytes written, and http status code)

2016-11-11 Thread Felix Geisendörfer
> On 11 Nov 2016, at 12:57, atd...@gmail.com wrote: > > Now, I don't know if it solves your issue but that's a quick thought. No, as explained in my previous e-mail, this doesn’t fit my requirements. Anyway, thanks for your input. :) -- You received this message because you are subscribed to

Re: [go-nuts] Re: [ANN] httpsnoop, an easy way to capture http related metrics (response time, bytes written, and http status code)

2016-11-11 Thread Felix Geisendörfer
p.go#L44-L163> > > Please let me know if you have suggestions for simpler approaches and/or spot > any bugs in my implementation. > > Thanks a lot! > Felix Geisendörfer > > -- > You received this message because you are subscribed to a topic in the Google > Groups &

Re: [go-nuts] Re: [ANN] httpsnoop, an easy way to capture http related metrics (response time, bytes written, and http status code)

2016-11-10 Thread Felix Geisendörfer
e "Why this package > exists" section of the README, as well as the horrible hack required to make > things work: > > https://github.com/felixge/httpsnoop/blob/master/wrap.go#L44-L163 > <https://github.com/felixge/httpsnoop/blob/master/wrap.go#L44-L163> > >

Re: [go-nuts] Re: [ANN] httpsnoop, an easy way to capture http related metrics (response time, bytes written, and http status code)

2016-11-10 Thread Felix Geisendörfer
Tong, I may have misread your e-mail. I missed the “s” in http(s). I don’t see anything that would be special about http requests, so they should just work. Cheers Felix > On 10 Nov 2016, at 17:02, Felix Geisendörfer wrote: > > Hi Tong, > > the README example shows logging

Re: [go-nuts] Re: [ANN] httpsnoop, an easy way to capture http related metrics (response time, bytes written, and http status code)

2016-11-10 Thread Felix Geisendörfer
section of the README, as well as the horrible hack required to make > things work: > > https://github.com/felixge/httpsnoop/blob/master/wrap.go#L44-L163 > <https://github.com/felixge/httpsnoop/blob/master/wrap.go#L44-L163> > > Please let me know if you have sugge

Re: [go-nuts] [ANN] httpsnoop, an easy way to capture http related metrics (response time, bytes written, and http status code)

2016-11-10 Thread Felix Geisendörfer
> On 10 Nov 2016, at 16:44, Ian Davis wrote: > > You can't in the general case. You cover the interfaces that you currently > know about but you don't know what other interfaces people are relying on. > Sipporting those becomes a combinatorial problem of whack-a-mole. I think Go 1.7 allows fo

Re: [go-nuts] [ANN] httpsnoop, an easy way to capture http related metrics (response time, bytes written, and http status code)

2016-11-10 Thread Felix Geisendörfer
ount of boilerplate? Cheers Felix > > > On Thu, Nov 10, 2016, at 02:37 PM, Felix Geisendörfer wrote: >> There are a few problems with the Kubernetes implementation. >> >> The first thing I noticed is that they seem to have copied their code from >> the prometheu

Re: [go-nuts] [ANN] httpsnoop, an easy way to capture http related metrics (response time, bytes written, and http status code)

2016-11-10 Thread Felix Geisendörfer
Cheers Felix > On 10 Nov 2016, at 15:25, Ian Davis wrote: > > > On Thu, Nov 10, 2016, at 02:21 PM, Felix Geisendörfer wrote: >> Yes, I thought about it :). >> >> Did you read the "Why this package exists” section of the README? > > Yes but obviously not c

Re: [go-nuts] [ANN] httpsnoop, an easy way to capture http related metrics (response time, bytes written, and http status code)

2016-11-10 Thread Felix Geisendörfer
Yes, I thought about it :). Did you read the "Why this package exists” section of the README? The problem with this approach is that an application’s behavior might change merely because the method is present. E.g. imagine an application doing this: ``` _, ok := w.(http.Flusher) if ok { w.Wri