Re: UiBinder: ClientBundle with ImageResource ui:style. How?

2010-09-07 Thread marius.andreiana
On Sep 7, 5:53 am, Andrew Hughes ahhug...@gmail.com wrote: Seems like I can kinda answer two of these questions myself now... Q: How can loader1.gwt-image be loading.gif? ui:with type=blah.client.MyClientBundle field=cb/ ui:image field=loading resource={cb.loading}/ ui:style   �...@sprite

GWT 2.x/Jboss/Seam gen

2010-09-07 Thread Flori
Hey all, did someone manage to run a seam generated application with gwt compilied sources in hosted mode on JBoss? http://community.jboss.org/wiki/UseJBossToolswithGoogleGWTPlugin - does not help really in my case - its the wrong order ;) I already have my application and want to ADD a gwt

Re: problems with auto-complete form login

2010-09-07 Thread Magnus
On 6 Sep., 19:59, Thomas Broyer t.bro...@gmail.com wrote: But honestly, I don't understand how this design is any different from redirecting to the login page (unless maybe you have a cancel button that leaves you in the app, i.e. without reload) Well, from my point of view it would be nice if

Re: showing all the elements from SuggestOracle in suggestionBox

2010-09-07 Thread Santosh kumar
Hi , I am adding the items to the suggestoracle on onmodule load. Its working fine if the match is found for the key pressed (alphabet) . But i want to show *all Existing Items* from the suggestoracle when their is no match found for the key pressed (alphabet) by the user ??? Pls let me know if

GWT + Spring - different functionality development approach

2010-09-07 Thread M. Eduard
Hi, Say I have Spring web application. Some functionality where I need JavaScript is developed using GWT under Eclipse. What is the approach of project organizing ? As I see for each functionality I need, for example some menu, tree-menu, some widgets, I must create each separate project, then

Re: problems with auto-complete form login

2010-09-07 Thread Magnus
Just for the completeness: I recall what was the problem with the GWT integration: As I said I had an iframe with the src attribute pointing to a separate html file with the login form. Then, to inject the JS code for form submission I needed to wrap the form. But I did not get access to the

Re: Memory Leak IE7 GWT 2.0.4

2010-09-07 Thread chrisr
Does the issue that you're working on now give you any reason to believe it could be an issue in the browser as well, under some similar circumstances? On Sep 3, 2:18 pm, Chris Conroy con...@google.com wrote: Okay, well if it's *in* hosted mode (read: the JVM), then it's a known issue that I'm

how to transmit an image over rpc?

2010-09-07 Thread Magnus
Hi, I tried to pass an Image object via RPC, but it doesn't work: com.google.gwt.user.client.ui.Image is not assignable to 'com.google.gwt.user.client.rpc.IsSerializable' or 'java.io.Serializable' nor does it have a custom field serializer (reached via com.google.gwt.user.client.ui.Image How

how to use modal dialog boxes?

2010-09-07 Thread Magnus
Hi, I want to use a modal DialogBox and used setModal. The GUI makes it modal, but my code after dialog.center (); gets executed immediately. How can I do it so that code execution waits? Must I do this with asynchronous calls? Can you give an example? The application is a chess game. When a

declaring both a GWT and a javascript event handler on a html element

2010-09-07 Thread GWT noob
When I declare a event handler on a html element both at the GWT level(using ClickHandler's onclick) and at the external Javascript levele(by using the onlclick attribute of the html element), the GWT event handler is overriding the event handler in the external javascript. Is there a way to have

DisclosurePanel, class-name content

2010-09-07 Thread Jaroslav Záruba
Hello There is one quite unfortunate class-name in the DisclosurePanel DOM. The widget serving for content gets class-name content assigned. Such generic name is very collision prone, which situation I'm currently facing. Is there any special reason why this element did not get gwt-prefixed

Re: unable to add gwt sdk

2010-09-07 Thread Nirav Joshi
hi Vik I think the sufficient help is available on the Google's Site. Wouldn't it sufficient to resolve your issue ? Thanks and Regards Nirav Joshi On Mon, Sep 6, 2010 at 10:56 PM, Vik vik@gmail.com wrote: Hie gwt sdk is missing in my project and when i try to add there is a red cross

Upgrading from GWT 1.4 to 2.0

2010-09-07 Thread Jesper Christensen
I am trying to upgrade a GWT 1.4 application to 2.0 but I am having a problem with the welcome file. The 1.4 application uses a servlet as the welcome file. The servlet checks the user credentials and forwards to the HTML page that loads the GWT application if the user has the right credentials.

Re: Calling methods from GWT script in existing HTML

2010-09-07 Thread Søren Kyndi-Wiuff
Or better yet, do it the cool way: http://code.google.com/p/gwt-exporter/ Cheers Søren -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this

How to block click event?

2010-09-07 Thread ulgerang
Hi, I am making 'ImageButton' that extends 'Image' and implemented 'HasEnabled' interface. I made 3 state, disable,mouseover, enable. When I was making disable, I have to block the click event from the widget. but I couldn't find the way. Is there any way to block the click event? -- You

Re: Expenses Sample project

2010-09-07 Thread superdama
Hi guys, I got the same issue. Still don't know how to solve the problem. Frustrating. -Zack On Aug 25, 9:22 pm, tc camec...@gmail.com wrote: Does anyone know why I would get this error when trying to run the samples/expensesapp via maven. : java.lang.NoClassDefFoundError:

com.google.gwt.user.client.rpc.SerializationException

2010-09-07 Thread Costa
Please help with error below. Is this mean that the class com.voxbone.voxAPI.Country could not be serialize or it is just simple NoClassDefFoundError ? Exception while dispatching incoming RPC call com.google.gwt.user.client.rpc.SerializationException: Type 'org.dozer.MappingException' was not

Require Help to have multiple HTML Pages with one Entrypoint in my GWT App

2010-09-07 Thread Nirav Joshi
Hi all i am new user of the GWT app. I want help from you guys to guide me for having multiple html/jsp page with one entry point. Let us i want to have two pages page1.html,page2.html. page1.html is a login page. when i logged in then it should redirect to page2.html. How will i do it with the

Authorization/Authentication in GWT

2010-09-07 Thread Arachnida
Hello, I'm currently developing a Spring/GWT application most things are going just fine but I've experienced some troubles integrating with Spring Security. It looks like there is no way to install global handlers for asyncCallback failures to handle 401/403 errors. As I've found there's

GWT - database, authentication, session

2010-09-07 Thread pionas
Hi, i would like to create a login panel, when i must enter username and password. Next I check if the data are correct. When the data are correct I reload home page and I see message Hi username! etc When I refresh site i logged on. Now I have something like this: Test.java (default):

GWT + Spring 3.0 + hibernate references and easy guides

2010-09-07 Thread aces2805
Hi, I'm just new with GWT would like to ask if there are some references that I can follow in integrating spring 3.0 and hibernate with gwt. The usual sites that I go in uses maven, well I just think I just need a plain and simple example. Hope some of you guys can help me. Really appreciate it

Almost impossible to extend CellTable

2010-09-07 Thread legion
Hi all I checked out the code for gwt 2.1, i wanted to see the last changes in the CellTable component. A nice addition is the SafeHtmlTemplate. But one drawback of the current implementation of the CellTable component is that you cannot reuse the code from the CellTable by extending it. For

Issue with using com.google.gwt.xml.client package with GWT 1.5.3

2010-09-07 Thread Nik
Hello, I am trying to use the com.google.gwt.xml.client module with my GWT-1.5.3. I want to basically fetch data, from an XML File and store it in a document. Document document = XMLParser.parse(xmlContent); XMLParser.removeWhitespace(document); Everything works fine in Hosted mode. In the web

Adding headings to a RichTextArea

2010-09-07 Thread HenrikA
Hi, I have this problem that is nearly driving me crazy. We need a RichTextEditor that will give us some basic functionality like the RichTextArea combined with the RichTextToolbar from the examples give us. But we have one requirement that is not met by the example, and that is the possibility

Cross Site Requests for JSON : Invalid Label

2010-09-07 Thread kudos
I have followed the steps here: http://code.google.com/webtoolkit/doc/1.6/tutorial/Xsite.html to create a call to another server for JSON data. Firebug shows an invalid label error when i run the application. I had a search for solutions and all I could find was things about adding parenthesis

Dynamic Tree (RPC calls for nodes)

2010-09-07 Thread pksiazek
Hi. I'm trying to implement dynamic tree. During creation it contains only root node. When I click open - it fetch nodes data via RPC call. How I can pass information to which parent I should add nodes? I defined AsyncCallback handler to parse response, but it has no access to parent node. I was

Re: how to use modal dialog boxes?

2010-09-07 Thread Thomas Broyer
On Sep 7, 3:28 pm, Magnus alpineblas...@googlemail.com wrote: Hi, I want to use a modal DialogBox and used setModal. The GUI makes it modal, but my code after dialog.center (); gets executed immediately. modal != blocking The only blocking dialogs are Window.alert, Window.confirm and

Re: GWT + Spring - different functionality development approach

2010-09-07 Thread lmolinero
Hi, Why don't you just use multiple gwt modules in the same GWT proyect in eclipse. One module for each functionality, i mean. On Sep 7, 8:51 am, M. Eduard emoroz...@gmail.com wrote: Hi, Say I have Spring web application. Some functionality where I need JavaScript is developed using GWT under

Re: Expenses Sample project

2010-09-07 Thread Travis Camechis
try running tools/scripts/maven_script.sh from the root of the GWT checkout. This will build a current copy of GWT and them to your local maven repo. You should then be able to do a mvn compile, mvn gwt:compile, mvn gw:run. On Sun, Sep 5, 2010 at 9:08 AM, superdama zack...@gmail.com wrote: Hi

Re: How to get Scaffold GWT in STS to run Dev server -i tried to copy link and run on local browser

2010-09-07 Thread Thomas Broyer
On Sep 6, 8:26 am, blueJ lawsearch...@gmail.com wrote: http://127.0.0.1:/ApplicationScaffold.html?gwt.codesvr=127.0.0.1:... Here is what happened--for me--this is not trivial--thanks Loading modules    com.lawo.demo1.gwt.ApplicationCommon       Loading inherited module

Re: How to block click event?

2010-09-07 Thread Chad
Instead of trying to block the event, why not just eat it. In your widget, on the click event, check the state of the widget. If the state is enable, only then fire the click event to any registered listeners. HTH, Chad On Sep 6, 10:06 am, ulgerang ulger...@gmail.com wrote: Hi, I am making

change css without reload the page

2010-09-07 Thread jimmy6
How to change CSS without reload the page? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-tool...@googlegroups.com. To unsubscribe from this group, send email to

Removing / Adding nested LayoutPanels from DockLayoutPanel

2010-09-07 Thread Maurice
Hi, I have a UIBinder that looks like this: g:DockLayoutPanel unit='EM' g:north size='12' g:HorizontalPanel g:LabelSome/g:Label g:LabelStuff/g:Label /g:HorizontalPanel /g:north g:center

Re: Memory Leak IE7 GWT 2.0.4

2010-09-07 Thread Chris Conroy
No. This particular issue is isolated to the DevMode JVM. On Tue, Sep 7, 2010 at 8:18 AM, chrisr chris.robert.rowl...@gmail.comwrote: Does the issue that you're working on now give you any reason to believe it could be an issue in the browser as well, under some similar circumstances? On

Re: declaring both a GWT and a javascript event handler on a html element

2010-09-07 Thread Chris Conroy
You could have your GWT handler call your javascript handler using JSNI. On Mon, Sep 6, 2010 at 12:42 PM, GWT noob karthik.ele...@gmail.com wrote: When I declare a event handler on a html element both at the GWT level(using ClickHandler's onclick) and at the external Javascript levele(by

Re: Strange behaviour

2010-09-07 Thread Tanguy Le Barzic
Hi Jeff, I did try to use it, but I still need to know the position of the element I want the popup to appear below. It's when I try to find this position that the problem arises (due to scrolling apparently not taken into account). -- Tanguy 2010/9/6 Jeff Chimene jchim...@gmail.com On

Re: GWT + Spring - different functionality development approach

2010-09-07 Thread M. Eduard
Hm, seems I didn't noticed this thing. Thanks for advice. On Sep 7, 5:03 pm, lmolinero lmolin...@gmail.com wrote: Hi, Why don't you just use multiple gwt modules in the same GWT proyect in eclipse. One module for each functionality, i mean. On Sep 7, 8:51 am, M. Eduard emoroz...@gmail.com

Re: GWT + Spring 3.0 + hibernate references and easy guides

2010-09-07 Thread M. Eduard
Hibernate will be integrated withing your Spring application. So I think you should first learn Spring if going use one... As GWT application in result is no more than JavaScript, GWT will never know anything about hibernate. On Sep 7, 11:16 am, aces2805 ace...@gmail.com wrote: Hi, I'm just new

Re: Removing / Adding nested LayoutPanels from DockLayoutPanel

2010-09-07 Thread Thomas Broyer
On Sep 7, 5:34 pm, Maurice maurice.ocon...@gmail.com wrote: Hi, I have a UIBinder that looks like this:   g:DockLayoutPanel unit='EM'         g:north size='12'            g:HorizontalPanel               g:LabelSome/g:Label               g:LabelStuff/g:Label            

Re: How to block click event?

2010-09-07 Thread Thomas Broyer
On Sep 6, 5:06 pm, ulgerang ulger...@gmail.com wrote: Hi, I am making 'ImageButton' that extends 'Image' and implemented 'HasEnabled' interface. I made 3 state, disable,mouseover, enable. When I was making disable,  I have to block the click event  from the widget. but  I couldn't find

Re: GWT with GAE Blobstore

2010-09-07 Thread App Engine Notifications
Here's a sample project I'm working on that does an upload to blobstore as well as uses the high performance image serving framework: http://github.com/ikai/gwt-gae-image-gallery Warning: This is still a work in progress, but the upload/image serving bits are there. On Mon, Sep 6, 2010 at 9:54

Re: GWT with GAE Blobstore

2010-09-07 Thread Ikai Lan
Here's a sample project I'm working on that does an upload to blobstore as well as uses the high performance image serving framework: http://github.com/ikai/gwt-gae-image-gallery Warning: This is still a work in progress, but the upload/image serving bits are there. On Sep 6, 9:54 am, Brandon

Re: GWT + Spring 3.0 + hibernate references and easy guides

2010-09-07 Thread George Georgovassilis
The answer is not that easy. You can bring hibernate managed objects (almost) transparently to GWT applications, have a look at Gilead [1] Much has been said about Spring and GWT, a quick forum search will surely bring something up [1] http://noon.gilead.free.fr/gilead/index.php?page=gwt On Sep

Re: Require Help to have multiple HTML Pages with one Entrypoint in my GWT App

2010-09-07 Thread Deepak Singh
Hi Nirav Just right click on project(Eclipse IDE) and create new html. It auotomatically configures this new html. Now u can put div element here and then RootPanel.get(div id).add() will work. Regards Deepak On Sun, Sep 5, 2010 at 9:08 PM, Nirav Joshi joshi.nira...@gmail.com wrote: Hi all i

How to add a widget to a CaptionPanel?

2010-09-07 Thread Kiarash
CaptionPanel panel = new CaptionPanel(myWidget) which is not possible... only String and HTML is possible. How can I add a widget as a CheckBox to a caption of a CaptionPanel? Thank you for any suggestion -- You received this message because you are subscribed to the Google Groups Google Web

Re: Problems with gwt plugin and eclipse

2010-09-07 Thread TBirch
Hi Rajeev, I have the same error using either eclipse or Springsource Sts with Roo. I am not sure if any of what follows helps but these two sections are from my error log. Thanks, Terry java.lang.ClassCastException: org.eclipse.jdt.internal.core.JavaModel cannot be cast to

Re: showing all the elements from SuggestOracle in suggestionBox

2010-09-07 Thread ciosbel
Instead defining your own oracle (which is, indeed, the best solution), just use a MultiWordSuggestOracle. There you can find methods like: setDefaultSuggestions(CollectionSuggestOracle.Suggestion suggestionList) or setDefaultSuggestionsFromText(Collectionjava.lang.String suggestionList) You can

Re: Dev plugin for firefox 3.7

2010-09-07 Thread csillag
Hi John, On aug. 11, 18:06, John Tamplin j...@google.com wrote: On Wed, Aug 11, 2010 at 10:46 AM, Chris Conroy con...@google.com wrote: The short answer is that after preliminary support went in, the supporting libraries changed upstream. Also, when the prelim support went in Windows dev

Can't Set App Engine SDK - Eclipse Plugin

2010-09-07 Thread sdoca
Hi, I have been trying to set up a Maven/GWT/Eclipse project and keep running into road blocks. I have Eclipse 3.6 (Helios) with m2eclipse and GWT plugins installed. I was trying with Eclipse 3.5 (Galileo) but thought I may have messed up some config thing and figured I'd start clean and

Re: Cross Site Requests for JSON : Invalid Label

2010-09-07 Thread lineman78
In other words you are using JSONP client code to hit a JSON service. Without more info I am assuming this is your problem. In order to make cross site requests using the method described on the page you referenced you service needs to output JSONP, that is wrapping the JSON with a call to the

Re: How to block click event?

2010-09-07 Thread lineman78
you can try adding different handlers such as a click handler or mouse down handler and call event.preventDefault(). On Sep 6, 9:06 am, ulgerang ulger...@gmail.com wrote: Hi, I am making 'ImageButton' that extends 'Image' and implemented 'HasEnabled' interface. I made 3 state,

Re: DisclosurePanel, class-name content

2010-09-07 Thread lineman78
It is because content and header all both children of the gwt- DisclosurePanel class and they expect you to use child selectors. Here is what they expect you use so that you don't end up with collisions: .gwt-DisclosurePanel .content { border: 2px solid black; } On Sep 5, 11:08 am, Jaroslav

Re: Memory Leak IE7 GWT 2.0.4

2010-09-07 Thread ckendrick
Just a note on SmartGWT - Built-in GWT widgets rely on the browser to garbage collect a detached DOM tree. In older browsers like IE6/7 we found a number of cases where this didn't work completely, so we opted for manual destroy(). It's possible that as of IE8/9 all such leaks are gone

Problem of collecting GWT client Code coverage

2010-09-07 Thread Qi Zhang
We are trying to use the emma library to measure the code coverage of gwt client code, our test case is driven by Selenium RC. But we observed that some event handler code is never covered although we are pretty sure the event is triggered and handled. We did some hack to GWT source code and add

Re: Require Help to have multiple HTML Pages with one Entrypoint in my GWT App

2010-09-07 Thread suersh babu
Use Window.Location.assign(url) inside the gwt Entry point module so that you can redirect to different page Regards Suresh Babu G On Wed, Sep 8, 2010 at 12:19 AM, Deepak Singh deepaksingh...@gmail.comwrote: Hi Nirav Just right click on project(Eclipse IDE) and create new html. It

Re: DisclosurePanel, class-name content

2010-09-07 Thread Jaroslav Záruba
When you're creating a component to existing web-site it is quite likely someone has used the content class name. Therefore his CSS will merge with your .gwt-DisclosurePanel .content. There seem to be a naming convention in GWT. This just shows that there's a good reason to have one. On Wed, Sep

Re: DisclosurePanel, class-name content

2010-09-07 Thread Jaroslav Záruba
On Wed, Sep 8, 2010 at 2:43 AM, lineman78 linema...@gmail.com wrote: It is because content and header all both children of the gwt- DisclosurePanel class and they expect you to use child selectors. Here is what they expect you use so that you don't end up with collisions:

Re: GWT + Spring 3.0 + hibernate references and easy guides

2010-09-07 Thread aces2805
I have look for some various approaches, i have also tried the one posted in one of the forums, thanks to the link ^^ On Sep 8, 1:59 am, George Georgovassilis g.georgovassi...@gmail.com wrote: The answer is not that easy. You can bring hibernate managed objects (almost) transparently to GWT

Re: [gwt-contrib] Re: Eclipse: GDT - Scala plugin cooperation problem

2010-09-07 Thread Martin Mauch
Ok, so I did the following: I had an Eclipse installation with the Scala Development Tools running. I installed the GPE (Google Plugin and GWT, no GAE) and restarted Eclipse. When starting, Eclipse hung on the boot-up screen when Loading org.eclipse.jdt.core consuming one of the two CPU cores with

[gwt-contrib] [google-web-toolkit] r8721 committed - Remove -dumpSignatures in favor of a simpler command line invocation t...

2010-09-07 Thread codesite-noreply
Revision: 8721 Author: sco...@google.com Date: Tue Sep 7 04:40:43 2010 Log: Remove -dumpSignatures in favor of a simpler command line invocation to get GWT's JRE support. http://gwt-code-reviews.appspot.com/844801/show Review by: fabb...@google.com

Re: [gwt-contrib] Let MenuItem implement HasEnabled (issue846801)

2010-09-07 Thread Joel Webber
@rjrjr: I notice you own the bug -- do you have time to look at this, or would you like me to take it off your hands? Le 6 septembre 2010 04:48, johan.rydb...@gmail.com a écrit : Reviewers: , Description: Let MenuItem implement HasEnabled and update MenuBar to use this information when

[gwt-contrib] Re: Public: First pass at generating a GWT Validator. (issue845801)

2010-09-07 Thread bobv
http://gwt-code-reviews.appspot.com/845801/diff/5001/6008 File user/src/com/google/gwt/validation/rebind/BeanHelper.java (right): http://gwt-code-reviews.appspot.com/845801/diff/5001/6008#newcode24 user/src/com/google/gwt/validation/rebind/BeanHelper.java:24: private final Class? clazz; Could

Re: [gwt-contrib] Let MenuItem implement HasEnabled (issue846801)

2010-09-07 Thread Ray Ryan
Please! On Tue, Sep 7, 2010 at 8:01 AM, Joel Webber j...@google.com wrote: @rjrjr: I notice you own the bug -- do you have time to look at this, or would you like me to take it off your hands? Le 6 septembre 2010 04:48, johan.rydb...@gmail.com a écrit : Reviewers: , Description: Let

[gwt-contrib] [google-web-toolkit] r8722 committed - Continuation of r8542. Fixes double click where it was broken and adds...

2010-09-07 Thread codesite-noreply
Revision: 8722 Author: fre...@google.com Date: Tue Sep 7 06:57:03 2010 Log: Continuation of r8542. Fixes double click where it was broken and adds tests to ensure that events are sunk. Fix double click in the following widgets (and their subclasses): -

[gwt-contrib] Re: Implement keyboard navigation for CellBrowser (issue843801)

2010-09-07 Thread rice
http://gwt-code-reviews.appspot.com/843801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] UiBinder. Design time tweaks for @UiField and @UiHandler (issue834802)

2010-09-07 Thread Konstantin . Scheglov
Reviewers: rjrjr, Description: It turns out that previous patch was not enough. In new one instead of preventing failing when no owner or field found, we disable assigning to fields and support for event handlers at all. However we can not disable them globally, for all UiBinder templates, we

[gwt-contrib] Re: Provides support for fix of (issue841803)

2010-09-07 Thread rjrjr
http://gwt-code-reviews.appspot.com/841803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Provides support for fix of (issue841803)

2010-09-07 Thread rjrjr
Only real changes in the last patch are in AbstractJsonListRequest and AbstractJsonObjectRequest to work around http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6437894 Submitting. On 2010/09/07 19:14:54, rjrjr wrote: http://gwt-code-reviews.appspot.com/841803/show --

[gwt-contrib] [google-web-toolkit] r8723 committed - Rolling back due load test failures....

2010-09-07 Thread codesite-noreply
Revision: 8723 Author: gwt.mirror...@gmail.com Date: Tue Sep 7 12:33:00 2010 Log: Rolling back due load test failures. *** Original change description *** Add Late Loading support to xsiframe linker Review at http://gwt-code-reviews.appspot.com/807801

[gwt-contrib] [google-web-toolkit] r8724 committed - Snip an @Override that jdk 1.5 cannot support,...

2010-09-07 Thread codesite-noreply
Revision: 8724 Author: rj...@google.com Date: Tue Sep 7 09:47:45 2010 Log: Snip an @Override that jdk 1.5 cannot support, and fix an unneeded throws warning. http://code.google.com/p/google-web-toolkit/source/detail?r=8724 Modified:

[gwt-contrib] Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-07 Thread pdr
Reviewers: jat, Description: Add SafeHtml support to UI widgets (2) This is a first-pass at adding SafeHtml support to a subset of the widgets. In cases where the class implements HasHTML, HasSafeHtml has been implemented as well. In constructors that accept a string that can be parsed as Html,

[gwt-contrib] Re: RR: Add statistics to optimizers (issue841801)

2010-09-07 Thread scottb
I went back and removed my style nit comments to focus on the substantive stuff. Manually tracking the number of visits in every visitor, and how that data is used, are my primary concerns. http://gwt-code-reviews.appspot.com/841801/diff/1/4 File

[gwt-contrib] Re: Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-07 Thread jat
LGTM with mostly nits. A general concern is inconsistency about naming -- most places, the SafeHtml version is just an overload, and that makes the most sense to me. Some places rename the method to be setSafeHtml instead of setHtml, for example, and I don't think that difference is relevant to

[gwt-contrib] Re: Provides support for fix of (issue841803)

2010-09-07 Thread Ray Ryan
r8725 On Tue, Sep 7, 2010 at 12:20 PM, rj...@google.com wrote: Only real changes in the last patch are in AbstractJsonListRequest and AbstractJsonObjectRequest to work around http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6437894 Submitting. On 2010/09/07 19:14:54, rjrjr wrote:

[gwt-contrib] Re: Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-07 Thread pdr
http://gwt-code-reviews.appspot.com/847801/diff/1/2 File tools/api-checker/config/gwt20_21userApi.conf (right): http://gwt-code-reviews.appspot.com/847801/diff/1/2#newcode115 tools/api-checker/config/gwt20_21userApi.conf:115: # there needs to be: method(SafeHtml html), etc. On 2010/09/07

[gwt-contrib] Re: Add SafeHtml support to UI widgets (2) (issue847801)

2010-09-07 Thread jat
LGTM http://gwt-code-reviews.appspot.com/847801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug 2822942 Remove calls to System.currentTimeMillis in tests (issue849801)

2010-09-07 Thread rice
http://gwt-code-reviews.appspot.com/849801/diff/1/2 File user/test/com/google/gwt/emultest/java/sql/SqlDateTest.java (right): http://gwt-code-reviews.appspot.com/849801/diff/1/2#newcode39 user/test/com/google/gwt/emultest/java/sql/SqlDateTest.java:39: long millis = 100; Perhaps test with

[gwt-contrib] [google-web-toolkit] r8726 committed - Change UiBinder Message generation to use consistent examples for HTML...

2010-09-07 Thread codesite-noreply
Revision: 8726 Author: m...@google.com Date: Tue Sep 7 12:42:09 2010 Log: Change UiBinder Message generation to use consistent examples for HTML and Widget placeholders to facilitate sharing of messages with embedded HTML elements or widgets. Review at

[gwt-contrib] Re: Add SafeHtml support to ui widgets. (issue829801)

2010-09-07 Thread xtof
LGTM http://gwt-code-reviews.appspot.com/829801/diff/8020/24004 File user/src/com/google/gwt/user/client/ui/CheckBox.java (right): http://gwt-code-reviews.appspot.com/829801/diff/8020/24004#newcode265 user/src/com/google/gwt/user/client/ui/CheckBox.java:265: public void setSafeHtml(SafeHtml

[gwt-contrib] Re: Fix ROO-1362 caused by non-public GWT class. (issue835802)

2010-09-07 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/835802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Rolling back r8722 due to test failures (issue851801)

2010-09-07 Thread fredsa
Reviewers: kathrin, Description: Rolling back r8722 due to test failures Please review this at http://gwt-code-reviews.appspot.com/851801/show Affected files: M user/src/com/google/gwt/user/client/ui/FocusWidget.java M user/src/com/google/gwt/user/client/ui/HTMLTable.java M

[gwt-contrib] [google-web-toolkit] r8727 committed - rollback r8722 due to test failure on Chrome

2010-09-07 Thread codesite-noreply
Revision: 8727 Author: k...@google.com Date: Tue Sep 7 14:01:53 2010 Log: rollback r8722 due to test failure on Chrome http://code.google.com/p/google-web-toolkit/source/detail?r=8727 Modified: /trunk/user/src/com/google/gwt/user/client/ui/FocusWidget.java

[gwt-contrib] [google-web-toolkit] r8728 committed - Fix checkstyle error introduced at r8726

2010-09-07 Thread codesite-noreply
Revision: 8728 Author: rj...@google.com Date: Tue Sep 7 14:07:00 2010 Log: Fix checkstyle error introduced at r8726 http://code.google.com/p/google-web-toolkit/source/detail?r=8728 Modified: /trunk/user/src/com/google/gwt/uibinder/elementparsers/HtmlPlaceholderInterpreter.java

[gwt-contrib] Re: Allow Checkbox to accept null as valid. (issue831803)

2010-09-07 Thread rjrjr
LGTM Thanks, Ray. One wording nit. http://gwt-code-reviews.appspot.com/831803/diff/1/3 File user/src/com/google/gwt/user/client/ui/HasValue.java (right): http://gwt-code-reviews.appspot.com/831803/diff/1/3#newcode48 user/src/com/google/gwt/user/client/ui/HasValue.java:48: * p How about:

[gwt-contrib] Re: Public: First pass at generating a GWT Validator. (issue845801)

2010-09-07 Thread nchalko
http://gwt-code-reviews.appspot.com/845801/diff/5001/6008 File user/src/com/google/gwt/validation/rebind/BeanHelper.java (right): http://gwt-code-reviews.appspot.com/845801/diff/5001/6008#newcode24 user/src/com/google/gwt/validation/rebind/BeanHelper.java:24: private final Class? clazz; On

[gwt-contrib] Re: Public: First pass at generating a GWT Validator. (issue845801)

2010-09-07 Thread nchalko
http://gwt-code-reviews.appspot.com/845801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors