Re: Help : Memory Leak Problem

2011-07-06 Thread Alberto Rugnone
In production. I didn't take measurements in development. On Jul 5, 6:12 pm, Marko Vuksanovic markovuksano...@gmail.com wrote: Do you have this problem in development or production mode? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To

strange NPE in datepicker when trying to set a date

2011-07-06 Thread Dennis Haupt
INFO: (TypeError): Cannot call method 'getFullYear' of undefined arguments: getFullYear, type: non_object_property_call stack: TypeError: Cannot call method 'getFullYear' of undefined at $setCurrentMonth (

Aw: Re: Entity version checks / optimistic locking

2011-07-06 Thread Jens
You have to store the lock somehow in the database. For example you can create a database table called locked objects that has columns like id, referenced table name, referenced object id, user id that locked the object, date of lock. Then you put a unique constraint on referenced table name,

SingleSelectionModel not firing for root node (CellTree)

2011-07-06 Thread ecstasy2
Hi there. I'm trying to implement the treeCell Widget in my project, but i'm having an issue since days now... The SElectionModel is not firing for my root nodes for some reason. It get fired thougth for leaf nodes. Here is my node info code. @Override public T NodeInfo?

Re: JPA RequestFactory: Persistence of Foreign Keys

2011-07-06 Thread khiem nguyen
i think the problem lies here: @ManyToOne(fetch = FetchType.LAZY, cascade = CascadeType.ALL) @JoinColumn(nullable = false) private User user; cascadetype.all means when u create new Booking, persist it will also persist the user, which leads to id-conflict On Wed, Jul 6, 2011 at

Re: CellTable updating individual/non-consecutive rows

2011-07-06 Thread Adolfo Panizo Touzon
If I understand you, when you create the CellTable you can add a setFieldUpdater. With this way you have control to update the rows like you want (you have a int index). http://google-web-toolkit.googlecode.com/svn/javadoc/2.1/com/google/gwt/user/cellview/client/CellTable.html See you.

Error when compiling GWT 2.4

2011-07-06 Thread zeroconf
Hello, I'm trying to compile GWT 2.4 (http://google-web- toolkit.googlecode.com/svn/releases/2.4). I followed the instructions from http://code.google.com/webtoolkit/makinggwtbetter.html but this failed with following error messages: compile: [gwt.javac] Compiling 2839 source files to

Re: CellTable updating individual/non-consecutive rows

2011-07-06 Thread Thomas Broyer
You'll call setRowData(int,List) for each set of consecutive rows to update: table.setRowData(2, Collections.singletonList(thirdRow)); table.setRowData(10, Arrays.asList(eleventhRow, twelfthRow)); -- You received this message because you are subscribed to the Google Groups Google Web Toolkit

GWT 2.3.0 + gwt-maven-plugin 2.3.0 tests generate errors

2011-07-06 Thread Eborix13
Hi, I've installed GWT 2.3.0 and I've implemented the StockWatcher sample program. All went fine until I got to the testing part. I have a simple test, one method that does assertTrue(true). When I run it I get a bunch of errors: 1) if I run the tests using maven I get:

adding filter to file upload in gwt

2011-07-06 Thread aman
I am using the basic FileUpload control in gwt and wanted to add the filter on the extensions allowed in the browsing window, which restrict the user to select only specific extensions (like xls,xlsx etc). Tell me how I can achieve this as I want to restrict on the browsing window itself and cant

Anybody has simple way to get Token when implement XRSF protection.

2011-07-06 Thread Joey
Hi All I have a big GWT project, there are many services and methods need to be protected. but I think it a hard work to change all of code what call methods as the following code from google document. So just want to know anybody has any simple way can fix XRSF problem and no need to change so

Re: Google plugin for Eclipse withou WindowBuilder (GWT Designer)

2011-07-06 Thread Sebastian
Hello Vrto, may I ask which Ubuntu Version do you use? Is it 32 or 64 Bit? I am using 11.04 with AMD64 and can´t get the Designer running at all (Eclipse Indigo). I ask beacause it is a clean Installation and I supposed that the failure was on the Ubuntu side. 2011/6/16 Vrto

Re: Error when compiling GWT 2.4

2011-07-06 Thread Thomas Broyer
Actually, nothing. The requestfactory-apt.jar from GWT_TOOLS is not compatible with the releases/2.4 branch. Try setting -proc:none in your JAVA_OPTS to bypass the annotation processors (both RfValidator –which generates the error here– and RfApt, which shouldn't be an issue if skipped), or

Access permutation id inside a generator

2011-07-06 Thread Pierre Coirier
Hi, In my generator, I need to create a unique implementation class name for each permutation. I was thinking using the permutation id, is there a way to access it inside the generator? If I can't have access to this permutation id, what would be the best way to generate a unique class name?

abc wants to chat - what’s the story behind these posts

2011-07-06 Thread pac
Yesterday I saw a similar post in gwt forum from my account (which I didn't post) I thought my account is compromised, I deleted that post and changed my password. But nothing else looked suspicious but just one post in gwt forum. Message itself looks bit promotional from google team. Today, I

Re: abc wants to chat - what’s the story behind these posts

2011-07-06 Thread David Chandler
I think a few folks have accidentally typed the group email address in the Gmail chat box, perhaps with the help of auto-complete. It is definitely not intentional promo from Google. /dmc On Wed, Jul 6, 2011 at 8:54 AM, pac parvez.chau...@gmail.com wrote: Yesterday I saw a similar post in gwt

Re: abc wants to chat - what’s the story behind these posts

2011-07-06 Thread pac
I don't remember when last time I used google chat, so chances of making such typo in my case is bit less. But anyway, if nothing wrong as such then it is reassuring. Thanks David. On Jul 6, 1:57 pm, David Chandler drfibona...@google.com wrote: I think a few folks have accidentally typed the

Re: Error when compiling GWT 2.4

2011-07-06 Thread zeroconf
Dear Thomas, On Jul 6, 1:56 pm, Thomas Broyer t.bro...@gmail.com wrote: or simply revert your GWT_TOOLS to r10417. Seehttp://code.google.com/p/google-web-toolkit/source/detail?r=10417(the changes applied in trunk, not in releases/2.4.0; not how FindRequest has been modified, whcih is the one

Re: New Google theme coming to GWT?

2011-07-06 Thread gadev
I am not referring to the color scheme, but instead if something similar such as the shape of buttons and how they get highlighted etc.. GWT has a number of themes, I currently use inherits name= 'com.google.gwt.user.theme.clean.Clean'/ and I was wondering if something similar or other themes

Re: Anybody has simple way to get Token when implement XRSF protection.

2011-07-06 Thread David Chandler
Hi Joey, The XSRF token is stateless so you only need to call the XsrfTokenService once per server session to obtain it. You can save it as a static variable in a service helper class. Thereafter, you just need to call setRpcToken for each service. Some projects GWT.create() all services in a

Re: gwt maven plugin - Google's or Codehause's?

2011-07-06 Thread David Chandler
Use the latest gwt-maven-plugin from codehaus. 1.3.2.google was a temporary version developed during the GWT 2.1 release, and features from it were contributed to codehaus and appear in 2.2.0. /dmc On Tue, Jul 5, 2011 at 12:09 PM, Marko Vuksanovic markovuksano...@gmail.com wrote: Which

Re: GWT 2.3.0 + gwt-maven-plugin 2.3.0 tests generate errors

2011-07-06 Thread David Chandler
To resolve the GWT errors regarding ConstraintValidation, be sure to add validation-api as a dependency in your POM. This was an oversight in the GWT 2.3 maven push and will be addressed in 2.4. /dmc On Wed, Jul 6, 2011 at 5:15 AM, Eborix13 ebori...@gmail.com wrote: Hi, I've installed GWT

Re: Access permutation id inside a generator

2011-07-06 Thread Thomas Broyer
In most cases, if you generate different things for different permutations, you know the deferred binding property you depend on, so you can use them to build the class name. If you want, you can still use all of the binding properties and their value(s), using a CRC32 or similar (Alder32 is

Re: Access permutation id inside a generator

2011-07-06 Thread Pierre Coirier
Thanks Thomas. I'd like to do this because for mvp4g, I'd like developers to be able to set a gin module thanks to deferred property (http:// groups.google.com/group/mvp4g/browse_thread/thread/87a1cc4a8a683381) so that a different gin module can be used for different type of platform. But,

Re: Aw: Re: Entity version checks / optimistic locking

2011-07-06 Thread Jeffrey Chimene
On 7/6/2011 1:48 AM, Jens wrote: You have to store the lock somehow in the database. For example you can create a database table called locked objects that has columns like id, referenced table name, referenced object id, user id that locked the object, date of lock. Then you put a unique

Re: CellTable updating individual/non-consecutive rows

2011-07-06 Thread Rike255
Thanks guys both answers look like they'll help, I'll read into both. On Jul 6, 5:27 am, Adolfo Panizo Touzon adolfo.pan...@gmail.com wrote: If I understand you, when you create the CellTable you can add a setFieldUpdater. With this way you have control to update the rows like you want (you

Re: Can't install Google Web Toolkit Developer Plugin under Chrome

2011-07-06 Thread Chris Conroy
What OS/distro and architecture are you running on? Are you running stock chrome or chromium, or did you get a repackaging from your distro? (SUSE for example is known to repackage chromium in an incompatible way\) On Mon, Jul 4, 2011 at 5:32 AM, Vlad s.mastre...@gmail.com wrote: I was starting

Re: Google Products using GWT

2011-07-06 Thread David Chandler
Fundamentally, it's because engineering teams at Google are free to choose their own tools. The Architecture Police don't work here. There are many instances where Google tools or products compete with each other like GWT and Closure. In Google culture, that's generally viewed as healthy as it

XML data binding into GWT serializable types

2011-07-06 Thread laolaoyu
Hi, I have some XML data on my web server side (which is received from some web service). At the moment I used Axis2 DataBinding (ADB) framework to generated all the data types in Java. However when I tried to forward these Java objects to the web client side thru GWT-RPC, it failed because all

Re: How to redirect HTML inside a dialogbox

2011-07-06 Thread jhulford
I think you're on a bit of a fools errand here and doing something that's going to greatly annoy the users of your site - especially now that tabbed browsing is ubiquitous. I'd definitely not use your site if you broke links to external pages like that for me. On Jul 4, 9:50 pm, Oscar

Re: Google Products using GWT

2011-07-06 Thread Bala Sankar
*Market for GWT Apps.* Android and iPhone apps have market. Developers build applications and sell their apps. Chrome and other tablets will extensively rely on GWT apps. How do GWT developers get rewards? Regards, Bala On Wed, Jul 6, 2011 at 8:26 AM, David Chandler drfibona...@google.comwrote:

Re: XML data binding into GWT serializable types

2011-07-06 Thread Deepak Singh
You will use these data binding frameworks only on server side. They dont have any role to play on client side. On Wed, Jul 6, 2011 at 9:04 PM, laolaoyu laola...@gmail.com wrote: Hi, I have some XML data on my web server side (which is received from some web service). At the moment I used

Re: Entity version checks / optimistic locking

2011-07-06 Thread J.Ganesan
No. Aldo Neto wants to preclude Edit function being made available to more than one at any point of time. Whereas, a transaction is a postmortem action, still allowing the Edit function to more than one ( though only one will eventually succeed ). J.Ganesan www.DataStoreGwt.com On Jul 6, 8:05 

Application will not run outside dev mode (gwt 2.3)

2011-07-06 Thread Jens
Hi I have an application that i have been working on for a while, but now suddenly the application will not run outside dev mode. If i remove the gwt.codesvr=127.0.0.1:9997 from my url, the application stops working (it will not bootstrap). After digging a bit around i found the following

Re: CellTable updating individual/non-consecutive rows

2011-07-06 Thread Jeff Larsen
Also, rendering the whole table is generally really fast. I would test it out to see if it is worth the effort to selectively update rows. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit

Re: How to redirect HTML inside a dialogbox

2011-07-06 Thread Oscar
Hi jhulford, Thanks again for your time, I agree that the embedded site should be able to open a new tab/window. What I don't want is the iframe to have access to the parent. I guess that what I'm trying to do is something like a sandboxed iframe. Nonetheless, when I try to use sandboxed

Re: Entity version checks / optimistic locking

2011-07-06 Thread Jeff Chimene
On 07/06/2011 09:09 AM, J.Ganesan wrote: No. Aldo Neto wants to preclude Edit function being made available to more than one at any point of time. Whereas, a transaction is a postmortem action, still allowing the Edit function to more than one ( though only one will eventually succeed ).

Aw: Re: Entity version checks / optimistic locking

2011-07-06 Thread Jens
That would imply that a transaction has to live longer than one request (if you use JPA you can only lock an entity inside a transaction and the entity will be unlocked once you commit or rollback). But I think in most common ajax web applications you do one transaction per request and that way

TabLayoutPanel autosize

2011-07-06 Thread gwtomni gwtomni
Hello, Is there any way to make the TabLayoutPanel auto-sizable relative to its content ? thx -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe

Re: Aw: Re: Entity version checks / optimistic locking

2011-07-06 Thread Jeff Chimene
On 07/06/2011 09:39 AM, Jens wrote: That would imply that a transaction has to live longer than one request (if you use JPA you can only lock an entity inside a transaction and the entity will be unlocked once you commit or rollback). OK But I think in most common ajax web applications you

GWT File Save

2011-07-06 Thread Thomas Holmes
I know this question has been asked before, and have researched this group and done a more wide Google search on this question. I have a working GWT Application which works great. From the client I can call a GWT-RPC service to get data which I can bring back to the UI, and all that works

Re: In-place edit (like Google AdWords)

2011-07-06 Thread d95sld95
A college and I created an example of what we are looking for. The sample is a Contacts application that allow you to CREATE and view DETAILS of a person. In DETAIL mode you can edit each property (or group of properties) clicking the edit command. Project:

Re: CellTable updating individual/non-consecutive rows

2011-07-06 Thread Thomas Broyer
Well, actually, I'm not even sure Cell widgets currently re-renders only selected rows. It might very well render the whole thing whatever you do, selective rendering coming in a future release as a performance enhancement. -- You received this message because you are subscribed to the Google

Re: Properties emulation

2011-07-06 Thread Ryan
Thanks for the suggestions, guys. That really helps. Ryan -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send email to

How do I align a GWT application to the center?

2011-07-06 Thread Xavier
I have an html5 canvas element within a flextable and that flextable is in the root panel. I would like to align the application so it is displayed in the center of the page both vertically and horizontally. Currently it is displayed in the upper left hand corner. code: Document document =

Re: Application will not run outside dev mode (gwt 2.3)

2011-07-06 Thread Magno Machado
Did you ran GWT Compiler and are the compiled files (the *.cache.html, module.nocache.js and etc) updated? Or are you simply running devmode and removing the ?gwt.codesvr from the url? On Wed, Jul 6, 2011 at 1:13 PM, Jens djar...@gmail.com wrote: Hi I have an application that i have been

Re: GWT File Save

2011-07-06 Thread Alain Ekambi
what exactly r u trying to do ? Dont really understand the question 2011/7/6 Thomas Holmes thomas.j.hol...@gmail.com I know this question has been asked before, and have researched this group and done a more wide Google search on this question. I have a working GWT Application which works

Re: In-place edit (like Google AdWords)

2011-07-06 Thread d95sld95
A colleague and I created an example of what we are looking for. The sample is a Contacts application that allow you to CREATE and view DETAILS of a person. In DETAIL mode you can edit each property (or group of properties) clicking the edit command. Project:

Re: CellTable updating individual/non-consecutive rows

2011-07-06 Thread Jeff Larsen
There are hooks in HasDataPresenter for rendering a specific subset of rows,but I haven't actually tested it. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit

Re: In-place edit (like Google AdWords)

2011-07-06 Thread d95sld95
A colleague and I created an example of what we are looking for. The sample is a Contacts application that allow you to CREATE and view DETAILS of a person. In DETAIL mode you can edit each property (or group of properties) clicking the edit command. Project:

Can't set styles with GWT Designer / UiBinder

2011-07-06 Thread cri
Using GWT Designer 2.4 beta. When editing a UiBinder file with GWT Designer, there is no styleName property in the property panel for setting the style of a GUI element. Is this intentional or does this indicate a problem, e.g. with GWT Designer, my configuration, etc? Thanks, Chuck -- You

Re: Composite Primary Keys (Many-to-Many relationship)

2011-07-06 Thread Greg Naidu
Aldo Neto tumolin@... writes: Hi, Thanks you all for your help. My problem was that I was mapping my Client side incorrectly - I now understand how to use the ValueProxy. In case someone else is having similar problems, I suggest reading Thomas' post: 

java.lang.Comparable implemented to a inner class but GWT gives compile time error

2011-07-06 Thread saurabh saurabh
Hi all, I have a plugin raphaelgwt and I have made some modification over it to suit my application. I am getting a strange behavior here, these are the inner classes of plugin with modificaton public class Raphael{ public class Set implements MyInterface, ComparableSet{

Re: adding filter to file upload in gwt

2011-07-06 Thread Jim Douglas
Untested, and no guarantees, but try something like this: String mimeList = application/vnd.ms-excel,application/ msexcel,application/x-msexcel,application/x-ms-excel,application/ vnd.ms-excel,application/x-excel,application/x- dos_ms_excel,application/xls,application/vnd.openxmlformats-

Re: java.lang.Comparable implemented to a inner class but GWT gives compile time error

2011-07-06 Thread saurabh saurabh
One more thing I have made jar file of modified plugin by using command line standard JDK jar tool. I tried using eclipse but it make jar of WEB-INF. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to

Re: Google plugin for Eclipse withou WindowBuilder (GWT Designer)

2011-07-06 Thread Eric Clayberg
For the Google I/O presentation I was indeed running Windows 7 via VMWare on my Mac. It was fast because I was using the latest build (basically GPE v2.3.1 at the time) and not because of the OS configuration. If you try the latest release (v2.3.2), I think you will find it to be significantly

Re: java.lang.Comparable implemented to a inner class but GWT gives compile time error

2011-07-06 Thread saurabh saurabh
Oh sorry folks it was silly mistake while using eclipse , too dumb too silly. Anyway I resolved on my own. Sorry for bothering anyone. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to

Re: XML data binding into GWT serializable types

2011-07-06 Thread laolaoyu
I need to forward the data to the client. If not using the data types generated by these frameworks, what else can I use? On Jul 7, 12:06 am, Deepak Singh deepaksingh...@gmail.com wrote: You will use these data binding frameworks only on server side. They dont have any role to play on client

Yes or No: Will Singleton-izing my Resources offer tangible performance gains??

2011-07-06 Thread karthik reddy
I use my Resources.java (it extends ClientBundle and holds references to images etc) in multiple classes and in each class I would create an instance of it class using GWT.create(Resources.class) Would making this class a singleton offer me tangible performance gains or is it not worth the

Re: Yes or No: Will Singleton-izing my Resources offer tangible performance gains??

2011-07-06 Thread Chris McBrien
I believe that GWT.create will by default give you back a shared single instance. karthik reddy karthik.ele...@gmail.com wrote: I use my Resources.java (it extends ClientBundle and holds references to images etc) in multiple classes and in each class I would create an instance of it class

Re: XML data binding into GWT serializable types

2011-07-06 Thread Chris McBrien
I have seen Apache beanutils used to copy from an encumbered object graph such as that provided by Hibernate and JAXB into simple POJOs. Though this DTO use should be carefully managed as it can quickly become an anti-pattern. laolaoyu laola...@gmail.com wrote: I need to forward the data to

Re: JQuery like animation

2011-07-06 Thread dindeman
Yes this progress bar looks really neat indeed, nice. What about gwt-fx ? I have used it in the past and found it pretty good then. I remember that I had to switch to it (coming from using GQuery) because I needed a way to intercept the process of a fading effect in the middle and reverse it.

Re: XML data binding into GWT serializable types

2011-07-06 Thread laolaoyu
Hi Chris, One thing I don't understand in the method you mentioned is that: During this java object conversion/mapping process, 1. I need to have the simple POJOs defined first? 2. Or I only need to have the encumbered objects and define the mapping rules using BeanUtils, and simple POJOs are

Re: adding filter to file upload in gwt

2011-07-06 Thread aman
Hi, Thanks for your help it really worked,but it is also giving me the option in the browsing window to select All files can I remove this option? Thanks, Amandeep On Jul 7, 4:40 am, Jim Douglas jdou...@basis.com wrote: Untested, and no guarantees, but try something like this: String

Re: gwt-servlet.jar size 200KB to 4MB?

2011-07-06 Thread Craig Mitchell
After a lot of trial and error. I have now built a new jar file so my RPCs work (without needing gwt-servlet.jar). If anyone wants to do the same, these are the directories I included to get it to work (all directories were sourced from gwt-servlet.jar): ├───com │ └───google │

Re: adding filter to file upload in gwt

2011-07-06 Thread Jim Douglas
I'm actually surprised that it worked; what browser, and how did it represent that setting to the user? Keep in mind that there's no guarantee that this will work in all browsers; the W3C spec says only that this provides the user agent with a hint of file types to accept. How it does that is up

Re: Yes or No: Will Singleton-izing my Resources offer tangible performance gains??

2011-07-06 Thread Elhanan Maayan
can i use it with my normal classes i'm looking for a way to have a singleton class and obtain it from a shared location, said class will contain, eventsbus,ActivityManager,ActivityMapper etc.. i also rely in many cases on static variable which are androgynous clases, i failed to to see that

Re: adding filter to file upload in gwt

2011-07-06 Thread aman
I did not tested it on other browsers initially, now when I am running it on IE it is not working it works well with google chrome with the option of Custom files and All files in the browsing window.I wanted to remove the All files option but now it seems that it is browser dependent so I am

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

2011-07-06 Thread stephen . haberman
According to the current code structure, if we want to make the variable non-static, we may need to pass the propertyOracle parameter to many methods I downloaded the patch and was able to kill the flaky static variable by changing various methods to take GeneratorContextExt (which has both

[gwt-contrib] Issue 6338

2011-07-06 Thread Jens
Hi, is it a big deal to include a fix for issue 6338 (http://code.google.com/p/google-web-toolkit/issues/detail?id=6338 , complete list with duplicates:

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

2011-07-06 Thread jlabanca
http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java File user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java (right):

[gwt-contrib] [google-web-toolkit] r10419 committed - Remove JSNI paths from RPC deserialization. AKA: Make RPC screaming fa...

2011-07-06 Thread codesite-noreply
Revision: 10419 Author: gwt.mirror...@gmail.com Date: Wed Jul 6 06:50:15 2011 Log: Remove JSNI paths from RPC deserialization. AKA: Make RPC screaming fast in DevMode. Review at http://gwt-code-reviews.appspot.com/1470802

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

2011-07-06 Thread zhuyi
On 2011/07/06 06:22:38, stephenh wrote: According to the current code structure, if we want to make the variable non-static, we may need to pass the propertyOracle parameter to many methods I downloaded the patch and was able to kill the flaky static variable by changing various

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

2011-07-06 Thread rdcastro
Thanks for the review, John. I have some questions for you below. http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java File user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java (right):

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

2011-07-06 Thread rdcastro
http://gwt-code-reviews.appspot.com/1472801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

2011-07-06 Thread rdcastro
http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/RenderableStamper.java File user/src/com/google/gwt/user/client/ui/RenderableStamper.java (right):

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

2011-07-06 Thread rdcastro
http://gwt-code-reviews.appspot.com/1472801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

2011-07-06 Thread rdcastro
http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/RenderableStamper.java File user/src/com/google/gwt/user/client/ui/RenderableStamper.java (right):

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

2011-07-06 Thread stephen . haberman
That would be great. Could you please upload the patch? Thanks! Sure--I can't upload a new patchset to this issue because I'm not the owner. Is it possible to add me? Or would you prefer for me to create a new issue? http://gwt-code-reviews.appspot.com/1380807/ --

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

2011-07-06 Thread jlabanca
http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/Composite.java File user/src/com/google/gwt/user/client/ui/Composite.java (right): http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/Composite.java#newcode111

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

2011-07-06 Thread rdcastro
http://gwt-code-reviews.appspot.com/1472801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

2011-07-06 Thread zhuyi
On 2011/07/06 13:51:57, zhuyi wrote: On 2011/07/06 06:22:38, stephenh wrote: According to the current code structure, if we want to make the variable non-static, we may need to pass the propertyOracle parameter to many methods I downloaded the patch and was able to kill the flaky

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

2011-07-06 Thread rdcastro
http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/Composite.java File user/src/com/google/gwt/user/client/ui/Composite.java (right): http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/Composite.java#newcode111

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

2011-07-06 Thread jbrosenberg
Hey Scott, not sure, did you mean to link to a different issue for the backend issue? The link above points back to this fix for the front-end issue. http://gwt-code-reviews.appspot.com/1470803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

2011-07-06 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/RenderableStamper.java File user/src/com/google/gwt/user/client/ui/RenderableStamper.java (right):

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

2011-07-06 Thread rchandia
LGTM http://gwt-code-reviews.appspot.com/1472801/diff/4004/user/src/com/google/gwt/user/client/ui/RenderableStamper.java File user/src/com/google/gwt/user/client/ui/RenderableStamper.java (right):

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

2011-07-06 Thread scottb
Sorry, the back-end issue is here: http://gwt-code-reviews.appspot.com/1469804/ http://gwt-code-reviews.appspot.com/1470803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

2011-07-06 Thread rdcastro
http://gwt-code-reviews.appspot.com/1472801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

2011-07-06 Thread rdcastro
http://gwt-code-reviews.appspot.com/1472801/diff/4004/user/src/com/google/gwt/user/client/ui/RenderableStamper.java File user/src/com/google/gwt/user/client/ui/RenderableStamper.java (right):

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

2011-07-06 Thread Eric Ayers
So, the tests in the back-end issue are valid, but the GwtAstBuilder patch is superceded. Could you roll the tests into issue 1470803? On Wed, Jul 6, 2011 at 10:54 AM, sco...@google.com wrote: Sorry, the back-end issue is here:

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

2011-07-06 Thread Scott Blum
On Wed, Jul 6, 2011 at 12:07 PM, Eric Ayers zun...@google.com wrote: So, the tests in the back-end issue are valid, but the GwtAstBuilder patch is superceded. Could you roll the tests into issue 1470803? Lemme clarify. The tests in the back-end are valid tests, which fail both with

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

2011-07-06 Thread zundel
http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java File dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java (right):

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

2011-07-06 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java File dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java (right):

[gwt-contrib] Re: Simplify the use of TckCompileTestCase by always using the module named (issue1467811)

2011-07-06 Thread rchandia
http://gwt-code-reviews.appspot.com/1467811/diff/1/user/test/org/hibernate/jsr303/tck/util/TckGeneratorTestUtils.java File user/test/org/hibernate/jsr303/tck/util/TckGeneratorTestUtils.java (right):

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-06 Thread jat
LGTM http://gwt-code-reviews.appspot.com/1469803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

2011-07-06 Thread conroy
supporting older chrome versions seems like a blocker issue to committing this to me. http://gwt-code-reviews.appspot.com/1469803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enhancement to JsDuplicateFunctionRemover to remove duplicate virtual methods as well. That is, ... (issue1454806)

2011-07-06 Thread jbrosenberg
How about some tests? http://gwt-code-reviews.appspot.com/1454806/diff/5001/dev/core/src/com/google/gwt/dev/js/JsDuplicateFunctionRemover.java File dev/core/src/com/google/gwt/dev/js/JsDuplicateFunctionRemover.java (right):

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

2011-07-06 Thread scottb
http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java File dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java (right):

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

2011-07-06 Thread zundel
LGTM http://gwt-code-reviews.appspot.com/1470803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

2011-07-06 Thread jbrosenberg
LGTM http://gwt-code-reviews.appspot.com/1470803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

  1   2   >