Re: Code Split / Prefetching Mechanics

2011-12-07 Thread Watnuss
Okay. Thanks for sharing your experience.=) I think I will just use the prefetching and see how the application is behaving compared to the application without code splitting and choose then. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group.

Calling a method in parent of an iframe

2011-12-07 Thread Shrivallabh
Folks, I have 2 modules - A and B. I have a set of tabs as a part of module A. tab 5 contains and iframe. The contents of the iframe are loaded from module B. I need to find a way to refresh the contents of tab 4 from within the iframe in tab5. It should be somethings like 1. Get my parent.

Re: FTP file upload in gwt

2011-12-07 Thread kim young ill
doesnt work, gwt/web uses HTTP which is not FTP if u want FTP, its enough to use an ftp client, (Window$) Explorer will do the job (if u use it), otherwise use Finder(mac) or Nautilus (Linux) hth On Mon, Dec 5, 2011 at 1:17 PM, Rahul Sharma rahul.sharma1...@gmail.comwrote: Hello, I want to

Re: transfer Objects between GWT and EJB

2011-12-07 Thread Shalin Lazar
Have you tried using Web Sevices? Call web methods receiving the objects via xml? On Fri, Dec 2, 2011 at 12:41 PM, ph09 ph.hei...@googlemail.com wrote: Hi, thank you for your answer, but this isn't my problem. I already know the links you have posted. It wasn't a problem fpr me to send

Re: Server side gwt-validation doesn't work (?)

2011-12-07 Thread Nicolas.Rocca
Hi Nick, unfortunately, this doesn't work. With both jars, I get the same error. I also wonder why the dependencies-list (http://code.google.com/p/gwt- validation/wiki/Dependencies) of gwt-validation doesn't mention any validation framework like hibernate if it is really necessary. Doesn't

GWT + Maven + Eclipse, Error executing maven-processor-plugin

2011-12-07 Thread Antoine DESSAIGNE
Hi everyone, I'm trying to set up a development environment for my application with GWT, Maven and Eclipse. Building with the command line is working fine but I keep having the following error in Eclipse: Error executing

scrollpanel get event when scroll is visible

2011-12-07 Thread Genesis Simpleman
Hi, I need some how to know when the scrollbar is visible or not in the scroll panel. I need to get an event when scrollbar is visible or hidden (so i wont need to check it in several places). Is there a way to do it ? -- You received this message because you are subscribed to the Google Groups

Re: SS0 and GWT

2011-12-07 Thread Thomas Broyer
My first app used in-app authentication (because the client wanted to bake a lock screen after 30 minutes of inactivity in the webapp rather than relying on the OS's built-in mechanism) and it caused us all sorts of issues (disclaimer: at that time, Ray Ryan didn't praise MVP, decoupling via

Re: scrollpanel get event when scroll is visible

2011-12-07 Thread Ed
I don't think this is possible. See the Event class for all events. Maybe the Event.ONSCROLL event is also thrown when the scroll bar is hidden/shown. Test it. You could do it yourself: a timers that will check every X ms if the scrollbar is shown and throw an event if it changed. - Ed On Dec

GWT:How to generate pdf save/open window?

2011-12-07 Thread Sanjay Jain
I am using GWT2.4 version in my application.In this I application I have created Form using GWT control (like textbox,textaera). I have also created preview of form.In that preview I have button of pdf generation. Now I want to create behavior to deal with pdf link same as

Re: Object deep copy or serialization

2011-12-07 Thread Thomas Broyer
Just an additional note to what others said: GWT-RPC serialization is asymmetric, to have the best (but still rather poor) performance on the client; so you cannot use SerializationStreamReader/SerializationStreamWriter to clone an object by roundtripping on the client-side. -- You received

Re: SS0 and GWT

2011-12-07 Thread Ed
An alternative to using a Authentication filter would be to use a Dynamic Proxy that form a central point of access to your public methods (I use this between all my backend layers). The proxy captures all RPC requests and controls authentication and authorisation. I do send a caller id with

Re: scrollpanel get event when scroll is visible

2011-12-07 Thread Ashwin Desikan
You can check for the presence of scrollbar / scroll event inside the OnResize method of your Panel. When the layout is resized OnResize method is called. ~Ashwin On Wednesday 07 December 2011 03:38:13 PM IST, Ed wrote: I don't think this is possible. See the Event class for all events.

Re: Server side method in Transport Object

2011-12-07 Thread Ed
Try it out. I think it will work but I am not sure. In my gwt test releases GWT complaints about not-supported gwt code, but it does run as the code is never used by GWT. But I don't know how this is done during serialization. - Ed On Dec 6, 9:11 pm, joe kolba joekolb...@gmail.com wrote: Is it

Re: History tokens and vertical menu panel

2011-12-07 Thread Ed
If you want end up in a certain application state you have to transfer state information. You can transfer this through the url or by putting it on the dom, etc... It all depends on your details. - Ed On Dec 6, 9:38 pm, JavaCool4Me sascha.monte...@gmail.com wrote: the onValueChange is my menu

Explicitly access GWT serialization logic

2011-12-07 Thread Marc Hacker
I have a class which implements Serializable and GWT knows how to send objects over RPC. But I want to GET such an object from a Servlet (in order to allow browser caching). Is there any way to explicitly access GWT's underlying ability to serialize/unserialize my objects (and the same on the

Re: Server side gwt-validation doesn't work (?)

2011-12-07 Thread Ashwin Desikan
It may be the version of hibernate validator you are using. I have the following def in my project POM and it works fine dependency groupIdorg.hibernate/groupId artifactIdhibernate-validator/artifactId version4.1.0.Final/version exclusions

Re: Explicitly access GWT serialization logic

2011-12-07 Thread Thomas Broyer
Yes; see http://jectbd.com/?p=1174 (I haven't digged into the code, but that one recipe requires you have a RemoteService interface and implementing class) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web

Re: Server side gwt-validation doesn't work (?)

2011-12-07 Thread Nicolas.Rocca
Thanks for your pom snippet. But my problem is not the hibernate validator. I use this just as a workaround. The problem is that in my opinion it shouldn't be necessary to use hibernate-validator at all! I use it just as a replacement for gwt-validation-2.0-BETA-SNAPSHOT- r269.jar which doesn't

Look at GWT Connectors

2011-12-07 Thread PEOPLES, MICHAEL P
Rihab, I'm too new to GWT to offer you any advice. However, you should check the GWT-Connectors code at the following URL. It's a very good implementation. You might wish to provide more details as to what happened with your current code. http://code.google.com/p/gwt-connectors/ Michael

Re: History tokens and vertical menu panel

2011-12-07 Thread David
Anything before the hash # needs to be identical from place to place otherwise you'll be loading the page from the web server and losing state. There are ways to get around this (i.e. servlet session state , cookies, preservation of state as url params...) however if your intention is to not go

Re: GWT:How to generate pdf save/open window?

2011-12-07 Thread Ed
Use the FormPanel.submit() for this. I do exactly what you want: I use iText in the background and use a servlet that generates the pdf. The FormPanel.submit() is used to submit the required info to the servlet. The submit() works like a Form submit. I build a FormBuilder class that makes things a

Re: Server side gwt-validation doesn't work (?)

2011-12-07 Thread Nicolas.Rocca
Further investigations: After some debugging, I found out that in the class com.em.validation.rebind.scan.ClassScanner , this.reflections.getSubTypesOf(ConstraintValidator.class) returns an empty list (while it is filled in hosted mode). But I couldn't find out why. I tried to replace the

Re: Last Page too big in SimplePager

2011-12-07 Thread cybervision
Hi, to avoid this issue, you have to override the setPageStart(int index) method in the AbstractPager class. with the following code: /** * Set the page start index. * * @param index the index * @see #getPageStart() */ protected void setPageStart(int index) { if (display

Re: SS0 and GWT

2011-12-07 Thread Alberto
Thomas, Could you explain what do you check at the filter level? How do you know if a user is authenticated when you make a GWT-RPC call? It is a newbie question, I know, but it is not clear to me if we are identifying the user by a query parameter or a HTTP header. Thanks On Dec 7, 4:01 am,

Re: SS0 and GWT

2011-12-07 Thread Ed Bras
You could check it like this: Normally my RPC calls look something like this: modifyDeclarationOfLoggedInMember(DeclarationDto member); Notice that you don't send the logged in member along as it's known in the backend. The logged in member is present in the session (at least his id). If the is

Re: Canvas, ImageData, and IE9

2011-12-07 Thread Maiku
One thing to mention with this technique is that it is based on the non-negative winding rule. This means that for complex shapes that have paths that intersect internally it will depend on the order that you draw your paths (clockwise or counter-clockwise) whether points are considered inside the

Re: ScrollPanel inside layer of LayoutPanel

2011-12-07 Thread Matt S
Aidan O'Kelly aidanok@... writes: .. I see why this can't work now.. The child Widget of ScrollPanel needs an explicit size. Which kinda begs the question, why does ScrollPanel implement ProvidesResize?! You stated you could see why it won't work, but did you figure out a suitable

Re: SS0 and GWT

2011-12-07 Thread Thomas Broyer
On Wednesday, December 7, 2011 5:03:05 PM UTC+1, Alberto wrote: Thomas, Could you explain what do you check at the filter level? How do you know if a user is authenticated when you make a GWT-RPC call? It is a newbie question, I know, but it is not clear to me if we are identifying the

Re: ScrollPanel inside layer of LayoutPanel

2011-12-07 Thread Aidan O'Kelly
On Wed, Dec 7, 2011 at 4:41 PM, Matt S schef...@gmail.com wrote: You stated you could see why it won't work, but did you figure out a suitable solution? I have a similar deal - how can we allow a whole-screen scroll with ScrollPanel when you have a ResizeCompositeWidget inside? In my case,

Re: ScrollPanel inside layer of LayoutPanel

2011-12-07 Thread Aidan O'Kelly
On Wed, Dec 7, 2011 at 4:41 PM, Matt S schef...@gmail.com wrote: ScrollPanel when you have a ResizeCompositeWidget inside? Also, just to add, if you want the whole page to grow vertically, your content widget should not be ResizeComposites, as they require an explicit size, whereas a regular

Re: SS0 and GWT

2011-12-07 Thread Alberto
Thanks a lot! This gives me a very good head start. On Dec 7, 10:45 am, Thomas Broyer t.bro...@gmail.com wrote: On Wednesday, December 7, 2011 5:03:05 PM UTC+1, Alberto wrote: Thomas,   Could you explain what do you check at the filter level? How do you know if a user is authenticated

null.nullMethod in GWT compiled source

2011-12-07 Thread Felix Scheinost
Hi, I wrote an Application that provides some Javascript methods and their Java dependents. These Javascript functions are working like an API. The problem is that the GWT-Compiler missunderstand my thoughts. Because the Function isn't called in the application itself, but from other applications,

Re: Opera 11.60 + GWT 2.4.0: Code load failed!

2011-12-07 Thread darkflame
I'm using Opera 11.6 as my main browser (WinXP) and https://groups.google.com/forum/ seems to work fine for me. Something rather strange must be happening on your system I think. Maybe something is wrong with the linux version of Opera? I can try that later. On Dec 6, 5:01 pm, Michael

Re: Server side gwt-validation doesn't work (?)

2011-12-07 Thread chris.ruffalo
The Reflections library that gwt-validation uses to mine the classpath for information does not seem to work at all in a containerized environment. See: http://code.google.com/p/gwt-validation/issues/detail?id=52 for more information. On Dec 7, 10:50 am, Nicolas.Rocca nicolas.ro...@t-online.de

Re: GWT Performance Issues

2011-12-07 Thread CSchulz
I created this little app that will generate a bunch of rows for you. Inside of each row is 5 Labels that pull the date. http://acumeta.coryschulz.com/gwttest/ So type in something like 5000 and it should render pretty fast and give you the amount of time it took. For each row it's just

LazyPanel and lazy loading

2011-12-07 Thread Steve C
I believe that LazyPanel in and of itself does not perform lazy loading - that I would still need to use GWT.runAsync to achieve lazy loading. Is this the case? And, if so, does LazyPanel provide any benefit for lazy loading with runAsync? -- You received this message because you are subscribed

DataGrid does not display in a VerticalPanel

2011-12-07 Thread Aaron
Hello all, New to GWT and liking it. Having some issues with my DataGrid not displaying in certain panels. In the simplified example below, if I add the dataGrid directly to the RootLayoutPanel (commented out now), it displays the dataGrid correctly. If I add the dataGrid inside a

Web Scraping

2011-12-07 Thread Gokul
Hi, I have a web site with Ajax calls using GWT to populate the HTML DOM. What I want to do is to crawl the page. I have simulated the httprequest being passed and I've got back a 200 http response from the server. But - of course I can't make sense of the data. I believe - when used in the client

Re: GWT:How to generate pdf save/open window?

2011-12-07 Thread Kanagaraj M
generate PDF in server side and save it. Write an RPC to get the file location. In the client use HyperLink to download the file. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit

how to set the value of the cell in the column

2011-12-07 Thread Pradeep Kumar
Hi, I am struck with a issue and am not able to proceed further. The issue is, I have a CellTable which container columns ot of which one column refers to a ButtonCell which displays an image. The above code for widgets is there in a View class. Now in the presenter I need to change the

captcha problem in gwt

2011-12-07 Thread shipra dhooper
if i create captcha in gwt application then it doesn't show on apache server but it display in hosted modehow can i solve this problem can anybody help me thanks in advance -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To

Re: GWT:How to generate pdf save/open window?

2011-12-07 Thread shipra dhooper
if u want to create pdf document then u can directly create pdf without using iText jar ...u should use apache pdf jar file on serverside code.u can also create by using amazon web services. thanks -- You received this message because you are subscribed to the Google Groups Google Web

Problems with PlaceChangeRequestEvent.setWarning

2011-12-07 Thread R.K.P. Pisters
Hi all, I'm having trouble using the PlaceChangeRequestEvent.setWarning method. I'm trying to implement functionality that is supposed to warn a user about unsaved changes upon a requested place change. This is the code I'm using: eventBus.addHandler(PlaceChangeRequestEvent.TYPE, new

Problem with gwt fileUpload in GWT 2.4

2011-12-07 Thread James Drinkard
Hello All, I have a requirement to get a file, upload it to the server and then get the stream of bytes back in some server-side code. I have to pass an inputStream from the file to a calculator module. So I opted to use the fileUpload widget which appears to work fine on the client-side. I

gwt uibinder in an abstract parent class

2011-12-07 Thread JC Tierney
i'm wondering if there's a way to build the gwt uibinder logic into an abstract parent class so that i don't have to repeat the code in every class i want to bind. for example, i'd like to be able to do something like this: public abstract class BasePanelPanel extends BasePanel extends Composite

Re: History tokens and vertical menu panel

2011-12-07 Thread JavaCool4Me
thanks, I have found examples of how to put params after the #page1, i.e. #page1?dep=Sales and now the page doesn't reload, the params are accepted and the vertical menu (stacklayout) is in the correct state! still have to test in IE ;-) On Dec 8, 2:07 am, David levy...@gmail.com wrote:

How to access javabean in gwt module( client + server) from outside gwt module?

2011-12-07 Thread vaibhav bhalke
I want to access javabean(VO) in gwt module(client server ) from outside module ( non-gwt module). class that we want to re-use, is general business class and not belonging to any GWT module How to access, used that javabean in gwt module? Any solution for this case ? Thanks in advance. --

Deploy GWT app in Tomcat as ROOT

2011-12-07 Thread Xybrek
Hi, I've been trying to deploy my gwt app in Tomcat server but I am having problem running the application rpc in the ROOT, I mean, if the app is deployed like: webapps/mygwapp I works, if the servlet defined in the web.xml is like this: servlet-mapping

Re: Deploy GWT app in Tomcat as ROOT

2011-12-07 Thread Kanagaraj M
The problem is in your @RemoteServiceRelativePath(greet) The above always append(as prefix) your app name with 'greet', so it would expect a servlet mapping /mygwtapp/greet Try using ServiceDefTarget -- You received this message because you are subscribed to the Google Groups Google Web

Re: Deploy GWT app in Tomcat as ROOT

2011-12-07 Thread Xybrek
On Thursday, 08 December, 2011 01:45 PM, Kanagaraj M wrote: The problem is in your @RemoteServiceRelativePath(greet) The above always append(as prefix) your app name with 'greet', so it would expect a servlet mapping /mygwtapp/greet Try using ServiceDefTarget -- You received this message

Re: Deploy GWT app in Tomcat as ROOT

2011-12-07 Thread Xybrek
On Thursday, 08 December, 2011 01:45 PM, Kanagaraj M wrote: The problem is in your @RemoteServiceRelativePath(greet) The above always append(as prefix) your app name with 'greet', so it would expect a servlet mapping /mygwtapp/greet Try using ServiceDefTarget -- You received this message

Re: Deploy GWT app in Tomcat as ROOT

2011-12-07 Thread Kanagaraj M
GreetingServiceAsync serviceAsync= (GreetingServiceAsync)GWT.create(GreetingService.class); ServiceDefTarget endpoint = (ServiceDefTarget) serviceAsync; String moduleRelativeURL = http://localhost:8080/ http://localhost:8080/mygwtapp/greet+ greet;

Re: Deploy GWT app in Tomcat as ROOT

2011-12-07 Thread Kanagaraj M
That is what ServiceDefTarget is doing. You need to have servlet mapping as following servlet-mapping servlet-namegreetServlet/servlet-name url-pattern/greet/url-pattern /servlet-mapping -- You received this message because you are subscribed to the Google Groups Google Web Toolkit

Re: Deploy GWT app in Tomcat as ROOT

2011-12-07 Thread Kanagaraj M
http://stackoverflow.com/questions/5553684/is-it-possible-to-programmatically-change-gwt-rpc-servlet-path -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit

Re: Deploy GWT app in Tomcat as ROOT

2011-12-07 Thread Xybrek
On Thursday, 08 December, 2011 02:01 PM, Kanagaraj M wrote: GreetingServiceAsync serviceAsync= (GreetingServiceAsync)GWT.create(GreetingService.class); ServiceDefTarget endpoint= (ServiceDefTarget) serviceAsync; String moduleRelativeURL=http://localhost:8080/

Re: gwt uibinder in an abstract parent class

2011-12-07 Thread Ashton Thomas
I do something very similar for a very important/complex part of my app. Not out of laziness but just because it's a goo way to keep things DRY. I use an abstract parent class which actually binds the UiBinder and then has some abstract methods that are different for subclasses. I'm not sure

Re: captcha problem in gwt

2011-12-07 Thread Raphael André Bauer
On Wed, Dec 7, 2011 at 2:40 PM, shipra dhooper shipra@gmail.com wrote: if i create captcha in gwt application then it doesn't show on apache server but it display in hosted modehow can i solve this problem can anybody help me What captcha vendor are you using? Most likely you have

Re: How to access javabean in gwt module( client + server) from outside gwt module?

2011-12-07 Thread -sowdri-
Add the jar containing the bean as dependency and use it directly. Being a GWT module doesn't change anything when it comes to server-side. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To view this discussion on the web visit

Re: LazyPanel and lazy loading

2011-12-07 Thread -sowdri-
LazyPanel and runAsync() are for different purpose. LazyPanel is just a container for lazy-*initialization *of widgets. As the widget creation involves dom manipulation, which is relatively costly, you could use LazyPanel to defer it, in case you have a really complex widget. runAsync, is

[gwt-contrib] Re: Fix for ScrollImplTrident leak (issue1601803)

2011-12-07 Thread t . broyer
LGTM http://gwt-code-reviews.appspot.com/1601803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 6331: Let AutoBean serialize dates as numbers when possible. (issue1601805)

2011-12-07 Thread t . broyer
http://gwt-code-reviews.appspot.com/1601805/diff/1/user/src/com/google/web/bindery/autobean/shared/ValueCodex.java File user/src/com/google/web/bindery/autobean/shared/ValueCodex.java (right):

[gwt-contrib] Re: Issue 6331: Let AutoBean serialize dates as numbers when possible. (issue1601805)

2011-12-07 Thread t . broyer
OK, two more runs of the benchmark (using ant benchmark -Dgwt.benchmark.testcase.includes=**/ValueCodexBenchmark.class) scrambled the results (I also slightly modified one of the test, but that's another story). I decided to keep the change in nevertheless (based on the 80/20 rule and the fact

[gwt-contrib] Re: Adding jscomp to the classpath for gwt user and dev projects. (issue1606803)

2011-12-07 Thread jlabanca
committed as r10779 http://gwt-code-reviews.appspot.com/1606803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Document a bug in maven-gae-plugin that prevents gae:unpack goal in mobilewebapp from running if... (issue1607803)

2011-12-07 Thread rchandia
Reviewers: drfibonacci, Description: Document a bug in maven-gae-plugin that prevents gae:unpack goal in mobilewebapp from running if gae.home is set in ~/.m2/settings.xml Please review this at http://gwt-code-reviews.appspot.com/1607803/ Affected files: M

[gwt-contrib] Re: Document a bug in maven-gae-plugin that prevents gae:unpack goal in mobilewebapp from running if... (issue1607803)

2011-12-07 Thread rchandia
http://gwt-code-reviews.appspot.com/1607803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix leak in LayoutImplIE6 (issue1601804)

2011-12-07 Thread t . broyer
As I understand it, there are two cases where createStyleRuler is called, and attached as a __styleRuler expando: - in initParent, the expando then references a child element; I'm not sure this creates a leak, as there's no loop here. It could easily be changed to use an instance variable

[gwt-contrib] Re: Add assert for null provided fields, fixes #7024 (issue1602805)

2011-12-07 Thread rchandia
Ping: rdayal or scheglov On 2011/12/01 08:11:49, tbroyer wrote: LGTM http://gwt-code-reviews.appspot.com/1602805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change SafeHtmlHostedModeUtils.isCompleteHtml() to public. (issue1606804)

2011-12-07 Thread jlabanca
LGTM Just reorder the method alphabetically within the other public methods. In GWT, we sort by visibility first, then alphabetically. http://gwt-code-reviews.appspot.com/1606804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change SafeHtmlHostedModeUtils.isCompleteHtml() to public. (issue1606804)

2011-12-07 Thread skybrian
LGTM http://gwt-code-reviews.appspot.com/1606804/diff/2002/user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java File user/src/com/google/gwt/safehtml/shared/SafeHtmlHostedModeUtils.java (right):

[gwt-contrib] Re: Document a bug in maven-gae-plugin that prevents gae:unpack goal in mobilewebapp from running if... (issue1607803)

2011-12-07 Thread rchandia
http://gwt-code-reviews.appspot.com/1607803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change SafeHtmlHostedModeUtils.isCompleteHtml() to public. (issue1606804)

2011-12-07 Thread xtof
On 2011/12/07 19:38:28, mdempsky wrote: LGTM. http://gwt-code-reviews.appspot.com/1606804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Change SafeHtmlHostedModeUtils.isCompleteHtml() to public. (issue1606804)

2011-12-07 Thread skybrian
LGTM http://gwt-code-reviews.appspot.com/1606804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Introduce a new method onPreviewColumnSortEvent to Header. An AbstractCellTable checks this meth... (issue1605804)

2011-12-07 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1605804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Just wondering about the protocol for code commits.....

2011-12-07 Thread karthik reddy
I have tacitly presumed that a LGTM from the reviewers is kinda mandatory for a commit to be made. However, I have just noticed a commit made today without a explicit LGTM. http://code.google.com/p/google-web-toolkit/source/detail?r=10780 http://gwt-code-reviews.appspot.com/1506802 --

Re: [gwt-contrib] Just wondering about the protocol for code commits.....

2011-12-07 Thread John Tamplin
On Wed, Dec 7, 2011 at 3:58 PM, karthik reddy karthik.ele...@gmail.comwrote: I have tacitly presumed that a LGTM from the reviewers is kinda mandatory for a commit to be made. However, I have just noticed a commit made today without a explicit LGTM. Since GWT code is committed to an

[gwt-contrib] Re: Add assert for null provided fields, fixes #7024 (issue1602805)

2011-12-07 Thread rdayal
LGTM. http://gwt-code-reviews.appspot.com/1602805/diff/1/user/test/com/google/gwt/uibinder/test/client/UiProvidedNullTest.java File user/test/com/google/gwt/uibinder/test/client/UiProvidedNullTest.java (right):

Re: [gwt-contrib] Just wondering about the protocol for code commits.....

2011-12-07 Thread karthik reddy
I see. Thanks for clarifying, John. -- Karthik Reddy https://plus.google.com/103243388366746199136 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Just wondering about the protocol for code commits.....

2011-12-07 Thread Ray Cromwell
Note also that sometimes we have to rollback or patch something in an emergency that has broken important internal apps, so we will often rollback or quickfix these without the regular delay of going through the public issue tracker, but hopefully these are rare instances. -Ray On Wed, Dec 7,

[gwt-contrib] Re: Document a bug in maven-gae-plugin that prevents gae:unpack goal in mobilewebapp from running if... (issue1607803)

2011-12-07 Thread drfibonacci
http://gwt-code-reviews.appspot.com/1607803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Document a bug in maven-gae-plugin that prevents gae:unpack goal in mobilewebapp from running if... (issue1607803)

2011-12-07 Thread drfibonacci
lgtm http://gwt-code-reviews.appspot.com/1607803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adding jscomp to the classpath for gwt user and dev projects. (issue1606803)

2011-12-07 Thread stephen . haberman
http://gwt-code-reviews.appspot.com/1606803/diff/1/eclipse/dev/.classpath File eclipse/dev/.classpath (right): http://gwt-code-reviews.appspot.com/1606803/diff/1/eclipse/dev/.classpath#newcode43 eclipse/dev/.classpath:43: classpathentry kind=var path=GWT_TOOLS/lib/jscomp/sourcemap-rebased.jar/

Re: [gwt-contrib] Re: Fix leak in LayoutImplIE6 (issue1601804)

2011-12-07 Thread Stephen Haberman
- in initParent, the expando then references a child element; I'm not sure this creates a leak, as there's no loop here. If I don't clear the __styleRuler on the parent, doing just this: LayoutPanel p = new LayoutPanel(); RootPanel.get().add(p); RootPanel.get().remove(p); Leaks.