[gwt-contrib] Don't allow enum ordinalization if a custom enum method references values() directly (issue1730804)

-generated clinit or values method, within the enum + * class itself. * * TODO (jbrosenberg): Investigate further whether referencing the * $VALUES array (as well as the values() method) should not block * ordinalization. Instead, convert $VALUES

[gwt-contrib] Re: This patch substantially reduces the overhead of Java types in the output by minimizing vtable s... (issue1447821)

Since this has been submitted, can you close it? http://gwt-code-reviews.appspot.com/1447821/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: scheglov pointed out a leak in compilation units in dev mode after a refresh (issue1490801)

http://gwt-code-reviews.appspot.com/1490801/diff/11002/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java File dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java (right):

[gwt-contrib] Re: scheglov pointed out a leak in compilation units in dev mode after a refresh (issue1490801)

http://gwt-code-reviews.appspot.com/1490801/diff/5002/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java File dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java (left):

[gwt-contrib] Re: The logic to avoid rewriting compilation units into archived units failed in some build environm... (issue1518803)

http://gwt-code-reviews.appspot.com/1518803/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right): http://gwt-code-reviews.appspot.com/1518803/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode194

[gwt-contrib] Re: CachedCompilationUnits were inadvertently writing (issue1517803)

http://gwt-code-reviews.appspot.com/1517803/diff/1/dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java File dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java (right):

[gwt-contrib] Re: The logic to avoid rewriting compilation units into archived units failed in some build environm... (issue1518803)

LGTM w/a comment nit http://gwt-code-reviews.appspot.com/1518803/diff/3002/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right):

[gwt-contrib] Re: Make generator result caching framework api available publically. (issue1468804)

Some responses. I did consider most of your suggestions, and in fact for a while I did have things as you suggest, so great minds think alike :). I'll outline my reasoning: First, IncrementalGenerators have to live in the same ecosystem as all the currently extent non-incremental Generator

[gwt-contrib] Re: Make generator result caching framework api available publically. (issue1468804)

http://gwt-code-reviews.appspot.com/1468804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make generator result caching framework api available publically. (issue1468804)

On 2011/08/03 20:03:28, rjrjr wrote: Oh, and putClientData seems like a better name. Done On Wed, Aug 3, 2011 at 1:02 PM, Ray Ryan mailto:rj...@google.com wrote: I'm still not crazy about having addClientData() and getClientData() on separate objects. It seems to me that you've

[gwt-contrib] Re: Make generator result caching framework api available publically. (issue1468804)

http://gwt-code-reviews.appspot.com/1468804/diff/7001/dev/core/src/com/google/gwt/core/ext/RebindMode.java File dev/core/src/com/google/gwt/core/ext/RebindMode.java (right): http://gwt-code-reviews.appspot.com/1468804/diff/7001/dev/core/src/com/google/gwt/core/ext/RebindMode.java#newcode52

[gwt-contrib] Re: Make generator result caching framework api available publically. (issue1468804)

Well, a generator has to keep it's own state anyway, in practice. In the case of AbstractClientBundleGenerator, it actually creates a ResourceContext and passes that around, along with the GeneratorContext (this was before any IncrementalGenerator enhancements). In the case of RPC, there are 2

[gwt-contrib] Re: Make generator result caching framework api available publically. (issue1468804)

http://gwt-code-reviews.appspot.com/1468804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: After an enum is ordinalized, any static methods generated as staticImpl's should no longer be c... (issue1467815)

http://gwt-code-reviews.appspot.com/1467815/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Re-roll r10435 (issue1474804)

LGTM with a couple questions Are there tests which verify this fixes the issue that caused the first rollback? (if not can you add a TODO)? http://gwt-code-reviews.appspot.com/1474804/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java File

[gwt-contrib] Re: This patch substantially reduces the overhead of Java types in the output by minimizing vtable s... (issue1447821)

http://gwt-code-reviews.appspot.com/1447821/diff/6053/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java (right):

[gwt-contrib] Re: JsoNormalizer did not give unique names to devirtualized (issue1467812)

I'm not sure why the JsNamer classes (e.g. JsPrettyNamer) don't already do the right thing (don't they?). They definitely do have naming disambiguation logic, etc. Is there something more fundamental here?

[gwt-contrib] Re: Fix JsInliner, to properly handle name scope tracking after multi-level inlining. Was causing l... (issue1472803)

I've deleted that comment (it was incorrect). The issue turns out to be an interaction between the JsInliner and JsObfuscateNamer. The issue is with how JsInliner manages the scope for names that are hoisted to new scopes via inlining. This fix solves the test-cases provided in the original

[gwt-contrib] Re: This patch substantially reduces the overhead of Java types in the output by minimizing vtable s... (issue1447821)

LGTM http://gwt-code-reviews.appspot.com/1447821/diff/20001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java (right):

[gwt-contrib] After an enum is ordinalized, any static methods generated as staticImpl's should no longer be c... (issue1467815)

Reviewers: cromwellian, scottb, zundel, Description: After an enum is ordinalized, any static methods generated as staticImpl's should no longer be considered as such, since there is no longer an instantated instance being passed as the first arg to the method (this instance has been transformed

[gwt-contrib] Fix JsInliner, to properly handle name scope tracking after multi-level inlining. Was causing l... (issue1472803)

Reviewers: cromwellian, zundel, scottb, Description: Fix JsInliner, to properly handle name scope tracking after multi-level inlining. Was causing local variable name collisions after obfuscation. Fixes issue 5936. Please review this at http://gwt-code-reviews.appspot.com/1472803/ Affected

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

Hey Scott, not sure, did you mean to link to a different issue for the backend issue? The link above points back to this fix for the front-end issue. http://gwt-code-reviews.appspot.com/1470803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java File dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java (right):

[gwt-contrib] Re: Enhancement to JsDuplicateFunctionRemover to remove duplicate virtual methods as well. That is, ... (issue1454806)

How about some tests? http://gwt-code-reviews.appspot.com/1454806/diff/5001/dev/core/src/com/google/gwt/dev/js/JsDuplicateFunctionRemover.java File dev/core/src/com/google/gwt/dev/js/JsDuplicateFunctionRemover.java (right):

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

LGTM http://gwt-code-reviews.appspot.com/1470803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: This patch substantially reduces the overhead of Java types in the output by minimizing vtable s... (issue1447821)

LGTM (w/minor cleanup + a suggestion) I like the management of class literal rescues much better now! http://gwt-code-reviews.appspot.com/1447821/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java

[gwt-contrib] Re: This patch substantially reduces the overhead of Java types in the output by minimizing vtable s... (issue1447821)

http://gwt-code-reviews.appspot.com/1447821/diff/15001/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java (right):

[gwt-contrib] Re: This patch substantially reduces the overhead of Java types in the output by minimizing vtable s... (issue1447821)

Almost ready to signoff, remaining concern about performance hit in CFA (see comment there). http://gwt-code-reviews.appspot.com/1447821/diff/9006/dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java File dev/core/src/com/google/gwt/dev/jjs/impl/ControlFlowAnalyzer.java (right):

[gwt-contrib] Re: Fix ArrayStoreException in assignments to an element of an array of a single jso interface type. (issue1470801)

HI'm not sure we always know at compile time, how an array was created (they can be passed around and cast to different types, etc.). Did you check out my latest patch set, I came up with a scheme to use negative queryId's to indicate that it's a dual impl interface. It seems to be

[gwt-contrib] Re: Updates the module name validation check for using CompileModule on a project. (issue1467810)

http://gwt-code-reviews.appspot.com/1467810/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right): http://gwt-code-reviews.appspot.com/1467810/diff/1/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java#newcode80

[gwt-contrib] Re: Updates the module name validation check for using CompileModule on a project. (issue1467810)

lgtm http://gwt-code-reviews.appspot.com/1467810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix bug in UnifyAst where non-null array types failed to canonicalize. (issue1469802)

LGTM http://gwt-code-reviews.appspot.com/1469802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix ArrayStoreException in assignments to an element of an array of a single jso interface type. (issue1470801)

http://gwt-code-reviews.appspot.com/1470801/diff/1/user/test/com/google/gwt/dev/jjs/test/SingleJsoImplTest.java File user/test/com/google/gwt/dev/jjs/test/SingleJsoImplTest.java (right):

[gwt-contrib] Re: Handle arrays of generic types, in rpc result cacheability checking (issue1463809)

http://gwt-code-reviews.appspot.com/1463809/diff/1/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java File user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java (right):

[gwt-contrib] Re: Fix ArrayStoreException in assignments to an element of an array of a single jso interface type. (issue1470801)

http://gwt-code-reviews.appspot.com/1470801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix ArrayStoreException in assignments to an element of an array of a single jso interface type. (issue1470801)

I can verify that my new tests for dualImpls fail going way back, at least until last August. The other tests all passed, up until the Overlay overhaul release this last March. http://gwt-code-reviews.appspot.com/1470801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix ArrayStoreException in assignments to an element of an array of a single jso interface type. (issue1470801)

Reviewers: cromwellian, robertvawter, Description: Fix ArrayStoreException in assignments to an element of an array of a single jso interface type. Addresses issue 6448 Please review this at http://gwt-code-reviews.appspot.com/1470801/ Affected files: M

[gwt-contrib] Re: Bug triggered in SourceFileCompilationUnit.asCachedCompilation() (issue1461803)

LGTM http://gwt-code-reviews.appspot.com/1461803/diff/6002/dev/core/test/com/google/gwt/dev/resource/impl/FileResourceTest.java File dev/core/test/com/google/gwt/dev/resource/impl/FileResourceTest.java (right):

[gwt-contrib] Re: Make generator result caching framework api available publically. (issue1468804)

http://gwt-code-reviews.appspot.com/1468804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make generator result caching framework api available publically. (issue1468804)

http://gwt-code-reviews.appspot.com/1468804/diff/2002/dev/core/src/com/google/gwt/core/ext/CachedPropertyInformation.java File dev/core/src/com/google/gwt/core/ext/CachedPropertyInformation.java (right):

[gwt-contrib] Re: Enable generator result caching, by default. (issue1467808)

http://gwt-code-reviews.appspot.com/1467808/diff/1/dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java File dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerEnableGeneratorResultCaching.java (right):

[gwt-contrib] Re: Bug triggered in SourceFileCompilationUnit.asCachedCompilation() (issue1461803)

http://gwt-code-reviews.appspot.com/1461803/diff/4003/dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java File dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java (right):

[gwt-contrib] Re: Bug triggered in SourceFileCompilationUnit.asCachedCompilation() (issue1461803)

http://gwt-code-reviews.appspot.com/1461803/diff/6002/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java (right):

[gwt-contrib] Fix for rpc generator result caching (fix potential NPE) (issue1462809)

Reviewers: tobyr, zundel, Description: Fix for rpc generator result caching (fix potential NPE) Please review this at http://gwt-code-reviews.appspot.com/1462809/ Affected files: M user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java Index:

[gwt-contrib] Re: Fix for rpc generator result caching (fix potential NPE) (issue1462809)

http://gwt-code-reviews.appspot.com/1462809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix for rpc generator result caching (fix potential NPE) (issue1462809)

some background, this issue came up when I first turned on generator result caching as the default, for dev mode tests (which of ended up testing deRPC)... http://gwt-code-reviews.appspot.com/1462809/diff/2003/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java File

[gwt-contrib] Handle arrays of generic types, in rpc result cacheability checking (issue1463809)

Reviewers: zundel, tobyr, Description: Handle arrays of generic types, in rpc result cacheability checking Please review this at http://gwt-code-reviews.appspot.com/1463809/ Affected files: M user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java Index:

[gwt-contrib] Re: Handle arrays of generic types, in rpc result cacheability checking (issue1463809)

This one came up once I turned on assertions with dev mode tests! http://gwt-code-reviews.appspot.com/1463809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Handle arrays of generic types, in rpc result cacheability checking (issue1463809)

http://gwt-code-reviews.appspot.com/1463809/diff/1/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java File user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java (right):

[gwt-contrib] Re: Handle arrays of generic types, in rpc result cacheability checking (issue1463809)

http://gwt-code-reviews.appspot.com/1463809/diff/1/user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java File user/src/com/google/gwt/user/rebind/rpc/CachedRpcTypeInformation.java (right):

[gwt-contrib] Enable generator result caching, by default. (issue1467808)

Reviewers: tobyr, zundel, Description: Enable generator result caching, by default. This initially will allow caching for ClientBundle and RPC generators. Other generators can be updated to support caching. The -XenableGeneratorResultCaching flag is now redundant, but it is still allowed. It

[gwt-contrib] Re: Enable generator result caching, by default. (issue1467808)

This will enable generator result caching by default for both dev mode and dev-mode tests. http://gwt-code-reviews.appspot.com/1467808/diff/1/dev/core/src/com/google/gwt/dev/DevModeBase.java File dev/core/src/com/google/gwt/dev/DevModeBase.java (right):

[gwt-contrib] Make generator result caching framework api available publically. (issue1468804)

Reviewers: tobyr, zundel, Description: Make generator result caching framework api available publically. Removes Experimental comment warnings. Renames the class GeneratorExt to IncrementalGenerator. Merges methods from GeneratorContextExt into GeneratorContext. Please review this at

[gwt-contrib] Re: Last change prevented re-loading modules, but caused it to write too many (issue1464803)

http://gwt-code-reviews.appspot.com/1464803/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right): http://gwt-code-reviews.appspot.com/1464803/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode189

[gwt-contrib] Re: Patch for interim state of incremental compile. (issue1464804)

http://gwt-code-reviews.appspot.com/1464804/diff/4001/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right):

[gwt-contrib] Re: Patch for interim state of incremental compile. (issue1464804)

http://gwt-code-reviews.appspot.com/1464804/diff/4001/dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java File dev/core/src/com/google/gwt/dev/javac/MemoryUnitCache.java (right):

[gwt-contrib] Re: Patch for interim state of incremental compile. (issue1464804)

http://gwt-code-reviews.appspot.com/1464804/diff/5004/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right):

[gwt-contrib] Re: Last change prevented re-loading modules, but caused it to write too many (issue1464803)

http://gwt-code-reviews.appspot.com/1464803/diff/5/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right): http://gwt-code-reviews.appspot.com/1464803/diff/5/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode234

[gwt-contrib] Re: Patch for interim state of incremental compile. (issue1464804)

lgtm w/nit http://gwt-code-reviews.appspot.com/1464804/diff/4003/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right):

[gwt-contrib] Re: Last change prevented re-loading modules, but caused it to write too many (issue1464803)

LGTM w/very minor nit http://gwt-code-reviews.appspot.com/1464803/diff/5/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right):

[gwt-contrib] Update client bundle result caching to track absent resources (issue1466804)

Reviewers: tobyr, zundel, Description: Update client bundle result caching to track absent resources Please review this at http://gwt-code-reviews.appspot.com/1466804/ Affected files: M user/src/com/google/gwt/resources/ext/ResourceGeneratorUtil.java M

[gwt-contrib] Re: Update client bundle result caching to track absent resources (issue1466804)

This change is to correctly respect the default extension search order for resources. So, for example, an image resource is first searched in the order: resourceName.png resourceName.jpg resourceName.gif This change makes sure we verify that if a resolved image is resourceName.jpg, that we

[gwt-contrib] Re: Don't allow DataflowOptimizer to perform constant transformation on expressions with side-effects. (issue1467801)

http://gwt-code-reviews.appspot.com/1467801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Don't allow DataflowOptimizer to perform constant transformation on expressions with side-effects. (issue1467801)

http://gwt-code-reviews.appspot.com/1467801/diff/1/dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java File dev/core/test/com/google/gwt/dev/jjs/impl/gflow/DataflowOptimizerTest.java (right):

[gwt-contrib] Don't allow DataflowOptimizer to perform constant transformation on expressions with side-effects. (issue1467801)

Reviewers: aizatsky, scottb, zundel, Description: Don't allow DataflowOptimizer to perform constant transformation on expressions with side-effects. Please review this at http://gwt-code-reviews.appspot.com/1467801/ Affected files: M

[gwt-contrib] Re: Updated rpc generator result caching to support full cacheability (issue1464802)

http://gwt-code-reviews.appspot.com/1464802/diff/2002/user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java File user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java (right):

[gwt-contrib] Updated rpc generator result caching to support full cacheability (issue1464802)

Reviewers: tobyr, zundel, Description: Updated rpc generator result caching to support full cacheability Also added support for changes to relevant properties and custom field serializers Please review this at http://gwt-code-reviews.appspot.com/1464802/ Affected files: A

[gwt-contrib] Re: Updated rpc generator result caching to support full cacheability (issue1464802)

http://gwt-code-reviews.appspot.com/1464802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Turns on reading from archives by default. (issue1461801)

LGTM w/a couple comments http://gwt-code-reviews.appspot.com/1461801/diff/9/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right):

[gwt-contrib] Re: Fix handling of unlabeled break and continue in gflow. (issue1447824)

LGTM w/some nits it looks like CfgBuild could be made such that individual visit methods are a bit more self-contained. It shouldn't be possible for a visitor to an inner loop to modify the unlabeled break/continue statements of an outer loop, etc. Removing them and replacing them at the end,

[gwt-contrib] Re: Improve GwtAstBuilder output when stack emulation is enabled. (issue1460801)

LGTM w/nit http://gwt-code-reviews.appspot.com/1460801/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (left):

[gwt-contrib] Re: Resolve GWT.create() answers by source name (issue1450818)

LGTM http://gwt-code-reviews.appspot.com/1450818/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updated rpc generator result caching for field serializers to use type signature instead of last... (issue1446818)

http://gwt-code-reviews.appspot.com/1446818/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updated rpc generator result caching for field serializers to use type signature instead of last... (issue1446818)

http://gwt-code-reviews.appspot.com/1446818/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updated rpc generator result caching for field serializers to use type signature instead of last... (issue1446818)

http://gwt-code-reviews.appspot.com/1446818/diff/1/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java File user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java (right):

[gwt-contrib] Re: GwtAstBuilder better handling of JSNI refs to constants (issue1449818)

Can you briefly describe the reason for this change? If I understand correctly, the change is to extend handling of compile time constants to Strings as well as base types? http://gwt-code-reviews.appspot.com/1449818/diff/4001/dev/core/src/com/google/gwt/dev/jjs/impl/BuildTypeMap.java File

[gwt-contrib] Re: GwtAstBuilder better handling of JSNI refs to constants (issue1449818)

LGTM w/a couple questions http://gwt-code-reviews.appspot.com/1449818/diff/2003/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right):

[gwt-contrib] Re: Decreased the log level on a message relating to purging the cache. (issue1447823)

LGTM http://gwt-code-reviews.appspot.com/1447823/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: This patch substantially reduces the overhead of Java types in the output by minimizing vtable s... (issue1447821)

http://gwt-code-reviews.appspot.com/1447821/diff/3001/dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java File dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java (right):

[gwt-contrib] Re: Fix enum switch construction in GwtAstBuilder (issue1450815)

lgtm http://gwt-code-reviews.appspot.com/1450815/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updated rpc generator result caching for field serializers to use type signature instead of last... (issue1446818)

After consulting with Toby, I'm going to rework this patch, to try to only use the strong hash as a fallback, if no timestamp info is available. Try to take advantage of CompilationUnit.getLastModified() http://gwt-code-reviews.appspot.com/1446818/ --

[gwt-contrib] Re: ForeachStatement fix for GwtAstBuilder (issue1450814)

Thanks for adding the test coverage! http://gwt-code-reviews.appspot.com/1450814/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right):

[gwt-contrib] Re: Updated rpc generator result caching for field serializers to use type signature instead of last... (issue1446818)

I guess the explanation is pretty clear, in Scott's comment on that old review. BSM was only concerned about api changes, in terms of whether other java source code would need to be recompiled, that depended on it, etc. RPC and ClientBundle are indeed concerned with internal fields and

[gwt-contrib] Re: ForeachStatement fix for GwtAstBuilder (issue1450814)

LGTM (but I'd love a comment, and a detailed TODO for the test-case which triggered this fix, so that if someone wants to create a unit test, the scenario is clear). Also, I'm curious, if GenerateJavaAST already has this hack, why didn't GwtAstBuilder also have it initially? Any point in going

[gwt-contrib] Re: Updated rpc generator result caching for field serializers to use type signature instead of last... (issue1446818)

http://gwt-code-reviews.appspot.com/1446818/diff/1/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java File user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java (right):

[gwt-contrib] Re: This patch substantially reduces the overhead of Java types in the output by minimizing vtable s... (issue1447821)

I'm about a 3rd of the way through this, but here's some initial comments. I'll be able to spend more time on this evening http://gwt-code-reviews.appspot.com/1447821/diff/3001/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java File

[gwt-contrib] Re: Exercise RunAsyncCode class for prefetching fragments. (issue1453805)

LGTM http://gwt-code-reviews.appspot.com/1453805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add concrete SourceInfo for varargs in method calls (issue1454801)

http://gwt-code-reviews.appspot.com/1454801/diff/4002/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right):

[gwt-contrib] Re: JavaAstConstructor uses UnifyAst. (issue1453810)

LGTM w/nitlets http://gwt-code-reviews.appspot.com/1453810/diff/3001/dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java File dev/core/src/com/google/gwt/dev/jjs/AstConstructor.java (right):

[gwt-contrib] Updated rpc generator result caching for field serializers to use type signature instead of last... (issue1446818)

Reviewers: tobyr, zundel, Description: Updated rpc generator result caching for field serializers to use type signature instead of last modified time. Removed GeneratorContextExt.getSourceLastModifiedTime(). Please review this at http://gwt-code-reviews.appspot.com/1446818/ Affected files:

[gwt-contrib] Re: ForeachStatement fix for GwtAstBuilder (issue1450814)

Do we have a unit test which exercises this (and includes regression for the non-SubIterator case? Is this only a problem in the new GwtAstBuilder? Isn't there a similar issue in the old GenerateJavaAST code?

[gwt-contrib] Re: ForeachStatement fix for GwtAstBuilder (issue1450814)

Do we have a unit test which exercises this (and includes regression for the non-SubIterator case? Is this only a problem in the new GwtAstBuilder? Isn't there a similar issue in the old GenerateJavaAST code? http://gwt-code-reviews.appspot.com/1450814/ --

[gwt-contrib] Re: Updated rpc generator result caching for field serializers to use type signature instead of last... (issue1446818)

http://gwt-code-reviews.appspot.com/1446818/diff/1/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java File user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java (right):

[gwt-contrib] Don't initialize SpeedTracerLogger thread or process time keepers if not enabled. (issue1456801)

Reviewers: Josh Humphries, Description: Don't initialize SpeedTracerLogger thread or process time keepers if not enabled. Please review this at http://gwt-code-reviews.appspot.com/1456801/ Affected files: M dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java

[gwt-contrib] Formatting update for com/google/gwt/user/rebind/rpc/* (issue1454805)

Reviewers: zundel, Description: Formatting update for com/google/gwt/user/rebind/rpc/* Please review this at http://gwt-code-reviews.appspot.com/1454805/ Affected files: M dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java M

[gwt-contrib] Re: Formatting update for com/google/gwt/user/rebind/rpc/* (issue1454805)

http://gwt-code-reviews.appspot.com/1454805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: I don't believe in magic, but as Scott points out, there are consistent (issue1453804)

LGTM w/nits (which you can ignore) http://gwt-code-reviews.appspot.com/1453804/diff/1017/user/super/com/google/gwt/emul/java/lang/Object.java File user/super/com/google/gwt/emul/java/lang/Object.java (right):

[gwt-contrib] Re: Add concrete SourceInfo for varargs in method calls (issue1454801)

http://gwt-code-reviews.appspot.com/1454801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: CompileModule creates a serialized set of compilation units to represent (issue1448808)

Can you describe the motivation for the changes to the *.gwt.xml files? http://gwt-code-reviews.appspot.com/1448808/diff/6001/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right):

[gwt-contrib] Re: Add concrete SourceInfo for varargs in method calls (issue1454801)

http://gwt-code-reviews.appspot.com/1454801/diff/4002/dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java File dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.java (right):

  1   2   3   >