1.6.4 - duplicate onKeyDown events

2009-04-08 Thread jchimene
Hi, Is anybody else seeing duplicate events with a (now deprecated) KeyBoardListener? I get duplicate events even when I replace the deprecated handler with the 1.6 event version. The target/source widget IDs are the same for both events. The problem does not occur using the 1.5.3 library. Thi

Re: 1.6.4 - duplicate onKeyDown events

2009-04-09 Thread jchimene
OK, so I've isolated it to the following routine inside com.google.gwt.user.client.ui.Composite.class @Override public void onBrowserEvent(Event event) { // Fire any handler added to the composite itself. super.onBrowserEvent(event); // Delegate events to the widget. widget.onB

Re: 1.6.4 - duplicate onKeyDown events

2009-04-09 Thread jchimene
Hi, The similar routine from the 1.5.3 library does not have the duplicate calls: com.google.gwt.user.client.ui.Composite.class @Override public void onBrowserEvent(Event event) { // Delegate events to the widget. widget.onBrowserEvent(event); } Was this a bugfix for the 1.6 revi

Re: 1.6.4 - duplicate onKeyDown events

2009-04-09 Thread Jason Essington
I'm guessing don't call super.onBrowserEvent() in composite, just delegate ... -jason On Apr 9, 2009, at 4:20 PM, jchimene wrote: > > Hi, > > The similar routine from the 1.5.3 library does not have the duplicate > calls: > > com.google.gwt.user.client.ui.Composite.class > > @Override > pub

Re: 1.6.4 - duplicate onKeyDown events

2009-04-09 Thread Sumit Chandel
Hi jchimene, Thanks for catching this. What you've discovered is essentially a bug. I reproduced it on my end and can confirm that events will fire twice for pretty much any class extending Composite because of the two onBrowserEvent calls in the Composite class (one to super, the other from the wr

Re: 1.6.4 - duplicate onKeyDown events

2009-04-09 Thread Sumit Chandel
Issue #3533 submitted: http://code.google.com/p/google-web-toolkit/issues/detail?id=3533 Thanks, -Sumit Chandel On Thu, Apr 9, 2009 at 3:36 PM, Sumit Chandel wrote: > Hi jchimene, > Thanks for catching this. What you've discovered is essentially a bug. I > reproduced it on my end and can confirm

Re: 1.6.4 - duplicate onKeyDown events

2009-04-09 Thread Jeff Chimene
On 04/09/2009 03:36 PM, Sumit Chandel wrote: > public class MySuggestBox extends SuggestBox { > �...@override > ��public void onBrowserEvent(Event event) { > �� �getWidget().onBrowserEvent(event); > ��} > } Hi Sumit, Thanks for the follow-up! I'll implement that code. There can be little doubt t

Re: 1.6.4 - duplicate onKeyDown events

2009-04-09 Thread Jeff Chimene
On 04/09/2009 03:36 PM, Sumit Chandel wrote: > Hi jchimene, > > Thanks for catching this. What you've discovered is essentially a bug. > I reproduced it on my end and can confirm that events will fire twice > for pretty much any class extending Composite because of the two > onBrowserEvent call

Re: 1.6.4 - duplicate onKeyDown events

2009-04-09 Thread Vitali Lovich
Regarding the example given in the issue, I don't think you are using the new event system properly, are you? See my note in the issue. As for the bug using the deprecated event system, don't use the deprecated event system. Hence the reason it's called deprecated - you get unsupported behaviour

Re: 1.6.4 - duplicate onKeyDown events

2009-04-09 Thread Jeff Chimene
On 04/09/2009 05:13 PM, Vitali Lovich wrote: > Regarding the example given in the issue, I don't think you are using > the new event system properly, are you? See my note in the issue. > > As for the bug using the deprecated event system, don't use the > deprecated event system. Hence the reas

Re: 1.6.4 - duplicate onKeyDown events

2009-04-09 Thread Vitali Lovich
Please refer to that issue as well where I point out the proper way to use it in the new event system. On Thu, Apr 9, 2009 at 9:05 PM, Jeff Chimene wrote: > > On 04/09/2009 05:13 PM, Vitali Lovich wrote: > > Regarding the example given in the issue, I don't think you are using > > the new event

Re: 1.6.4 - duplicate onKeyDown events

2009-04-09 Thread Jeff Chimene
On 04/09/2009 05:13 PM, Vitali Lovich wrote: > Regarding the example given in the issue, I don't think you are using > the new event system properly, are you? See my note in the issue. > > As for the bug using the deprecated event system, don't use the > deprecated event system. Hence the reas