[gwt-contrib] Re: Looking for Incubator sponsor for AxisPanel (2nd try)

2008-10-27 Thread dflorey
Hi Sony, I never had a problem with nesting widgets manually. AxisPanel looks to me like a helper class that is able to reduce code size, but it's no real addition to gwt. What we really need are components like the ones found in ext: http://extjs.com/examples/layouts/borderlayout.html I'm very

[gwt-contrib] RR: PagingTreeScrollTable + table filters

2008-10-27 Thread dflorey
Hi, I've attached some new classes and a patch here: http://code.google.com/p/google-web-toolkit-incubator/issues/detail?id=82 This patch extends the table framework with table filters and adds a tree table. I tried to stick as close as possible to the given code. There are some weak spots in th

[gwt-contrib] Re: Looking for Incubator sponsor for AxisPanel (2nd try)

2008-10-27 Thread Isaac Truett
-1. You've managed to string together 50 method invocations. This is poor coding practice. You try to improve readability with indentation, but you've just ruined yourself for any sort of IDE formatting. The method names are also highly non-standard. All this seems to be is a new (and, in my opin

[gwt-contrib] [google-web-toolkit commit] r3862 - releases/1.6/user/src/com/google/gwt/user/client/rpc/core/java/util

2008-10-27 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 27 07:50:01 2008 New Revision: 3862 Modified: releases/1.6/user/src/com/google/gwt/user/client/rpc/core/java/util/TreeSet_CustomFieldSerializer.java Log: Minor cleanup -- just using Collection_CustomFieldSerializer code instead of copying it. Modi

[gwt-contrib] Re: PagingScrollTable - setEmptyWidgetVisible()

2008-10-27 Thread Brad Larson
Hi John, That is the heart of the problem, but it might be a little more complicated than it sounds. I am calling insertRow() on the CachedTableModel that my PagingScrollTable uses. This triggers a rowInserted table listener and ends up calling PagingScrollTable.insertAbsoluteRow(). I'm not su

[gwt-contrib] [google-web-toolkit commit] r3863 - tags/1.5.3

2008-10-27 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 27 08:44:06 2008 New Revision: 3863 Added: tags/1.5.3/ - copied from r3776, /releases/1.5/ Log: Tagging the 1.5.3 release. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~

[gwt-contrib] [google-web-toolkit commit] r3866 - in releases: 1.5 1.6

2008-10-27 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 27 09:06:54 2008 New Revision: 3866 Modified: releases/1.5/branch-info.txt releases/1.6/branch-info.txt Log: Recording 1.5 -> 1.6 merge. Modified: releases/1.5/branch-info.txt ===

[gwt-contrib] [google-web-toolkit commit] r3865 - in changes/kprobst/soyc-vis: sampleOutput/Showcase src/com/google/gwt/soyc

2008-10-27 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 27 09:06:23 2008 New Revision: 3865 Modified: changes/kprobst/soyc-vis/sampleOutput/Showcase/SoycDashboard.html changes/kprobst/soyc-vis/sampleOutput/Showcase/booleanLits.html changes/kprobst/soyc-vis/sampleOutput/Showcase/charLits.html chan

[gwt-contrib] Re: RR: Two style guide tweaks proposed

2008-10-27 Thread Ray Ryan
Personally, I'd like to flat out forbid the use of non-single chars, as I haven't seen anyone but us violate that convention. If that doesn't fly, how about falling back to this strawman: • Parameterized type names shall be one letter. Exceptions may be made for classes that require four or more t

[gwt-contrib] [google-web-toolkit commit] r3867 - releases/1.6/user/test/com/google/gwt/i18n/client

2008-10-27 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 27 10:38:53 2008 New Revision: 3867 Modified: releases/1.6/user/test/com/google/gwt/i18n/client/TestAnnotatedMessages.java Log: Fix missing Javadoc and whitespace. Modified: releases/1.6/user/test/com/google/gwt/i18n/client/TestAnnotatedMessages

[gwt-contrib] [google-web-toolkit commit] r3868 - releases/1.6/dev/core/src/com/google/gwt/core/ext/linker/impl

2008-10-27 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 27 10:46:00 2008 New Revision: 3868 Modified: releases/1.6/dev/core/src/com/google/gwt/core/ext/linker/impl/StandardCompilationResult.java Log: Throw an error if the cached JS output cannot be read. Suggested by: bobv Modified: releases/1.6/dev/

[gwt-contrib] [google-web-toolkit commit] r3869 - in branches/1_6_events/user: src/com/google/gwt/event/shared test/com/google/gwt/event/sh...

2008-10-27 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 27 10:48:10 2008 New Revision: 3869 Modified: branches/1_6_events/user/src/com/google/gwt/event/shared/HandlerManager.java branches/1_6_events/user/src/com/google/gwt/event/shared/HandlerRegistration.java branches/1_6_events/user/test/com/

[gwt-contrib] [google-web-toolkit commit] r3870 - releases/1.6/dev/core/src/com/google/gwt/dev

2008-10-27 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 27 10:58:57 2008 New Revision: 3870 Modified: releases/1.6/dev/core/src/com/google/gwt/dev/CompilePerms.java releases/1.6/dev/core/src/com/google/gwt/dev/GWTCompiler.java Log: Finalized a couple of fields that needed it. Suggested by: bobv Modifi

[gwt-contrib] Re: Looking for Incubator sponsor for AxisPanel (2nd try)

2008-10-27 Thread Sony
dflorey, Isaac Thank you for your comments. First off, I want to make sure I am going about this the right way. Was I supposed to post AxisPanel myself or wait for a reply from a sponsor? I didn't join the group itself till after my 2nd email attempt. Thanks again for posting this for me. Reg

[gwt-contrib] Smoketesters wanted: gwt-google-apis Gears, Gadgets, Search libraries

2008-10-27 Thread Eric Ayers
I'm preparing for the next public release of the Google APIs for GWT project, and I have 3 libraries that we've run through their paces. I'd like to offer them up to the developer community for testing before they become the final release. You can find the distributions here: http://code.google.

[gwt-contrib] [google-web-toolkit commit] r3871 - in releases/1.6/user: src/com/google/gwt/i18n/rebind src/com/google/gwt/user/client/rpc/i...

2008-10-27 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 27 13:24:40 2008 New Revision: 3871 Modified: releases/1.6/user/src/com/google/gwt/i18n/rebind/AbstractLocalizableInterfaceCreator.java releases/1.6/user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java releases/1.6/

[gwt-contrib] Re: code review requested, allow i18n class-level annotations to be inherited

2008-10-27 Thread John Tamplin
On Mon, Oct 27, 2008 at 4:22 PM, Ray Ryan <[EMAIL PROTECTED]> wrote: > ** KeyGenerator.java:191 > > Shouldn't you be recursively checking all superclasses? Hmm. Actually, > since these things are interfaces, why check super at all? > You can theoretically have your own concrete implementation for

[gwt-contrib] [google-web-toolkit commit] r3872 - in releases/1.6/user/super/com/google/gwt/emul/java: io lang

2008-10-27 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 27 13:29:12 2008 New Revision: 3872 Added: releases/1.6/user/super/com/google/gwt/emul/java/io/IOException.java (contents, props changed) releases/1.6/user/super/com/google/gwt/emul/java/lang/Appendable.java (contents, props changed) Modifie

[gwt-contrib] Re: code review requested, allow i18n class-level annotations to be inherited

2008-10-27 Thread Ray Ryan
On Mon, Oct 27, 2008 at 1:26 PM, John Tamplin <[EMAIL PROTECTED]> wrote: > On Mon, Oct 27, 2008 at 4:22 PM, Ray Ryan <[EMAIL PROTECTED]> wrote: >> >> ** KeyGenerator.java:191 >> >> Shouldn't you be recursively checking all superclasses? Hmm. Actually, >> since these things are interfaces, why chec

[gwt-contrib] [google-web-toolkit commit] r3873 - releases/1.6/user/src/com/google/gwt/user/client/ui

2008-10-27 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 27 13:50:30 2008 New Revision: 3873 Modified: releases/1.6/user/src/com/google/gwt/user/client/ui/SuggestBox.java Log: Address issue 2330 by adding new property, selectsFirstItem, to turn off autoselect of first item. Does not change default behavior

[gwt-contrib] Re: code review requested, allow i18n class-level annotations to be inherited

2008-10-27 Thread Ray Ryan
** KeyGenerator.java:191 Shouldn't you be recursively checking all superclasses? Hmm. Actually, since these things are interfaces, why check super at all? ** CommonInterfaceAnnotations.java:22 Nit: need to break up 'graphs in javadoc On Fri, Oct 24, 2008 at 1:50 PM, John Tamplin <[EMAIL PROTE

[gwt-contrib] Why does cross-site linking wrap all the code in a function?

2008-10-27 Thread Lex Spoon
I looked today at making the code splitter work with the cross-site linker. I got it working, but I had to undo one aspect of the current implementation, and I'm not sure what the correct change would be. Specifically, the cross-site linker wraps all of the JavaScript code into a function and th

[gwt-contrib] Re: Why does cross-site linking wrap all the code in a function?

2008-10-27 Thread Ray Cromwell
IIRC, this is standard practice in XS JS libraries to prevent accidental leakage of globals as well as a convenient way to have 'package' scoped variables. -Ray On Mon, Oct 27, 2008 at 2:14 PM, Lex Spoon <[EMAIL PROTECTED]> wrote: > > I looked today at making the code splitter work with the cro

[gwt-contrib] Re: table columns

2008-10-27 Thread Charles Fry
Even worse, rowspans effect the coordinates of cells that they overlap, but colspans do not. :-/ On Tue, Oct 21, 2008 at 18:04, Charles Fry <[EMAIL PROTECTED]> wrote: > As a new GWT user (thanks a ton for the awesome toolkit) I have a few > issues with table columns: > > 1) To my surprise, FlexTa

[gwt-contrib] Re: code review requested, allow i18n class-level annotations to be inherited

2008-10-27 Thread John Tamplin
Ok, here is a revised patch which recursively follows the inheritance chains, and the test improved to check for that. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~---

[gwt-contrib] Re: Why does cross-site linking wrap all the code in a function?

2008-10-27 Thread Scott Blum
What Ray said. If you take it out of the function body, you destroy the global scope with GWT-generated identifiers. On Mon, Oct 27, 2008 at 5:14 PM, Lex Spoon <[EMAIL PROTECTED]> wrote: > > I looked today at making the code splitter work with the cross-site > linker. I got it working, but I ha

[gwt-contrib] Re: RR: API change for 1.6, improve default behavior of SuggestBox

2008-10-27 Thread Ray Ryan
When you're right, you're right. I really can't justify the breaking change. I've switched the default to maintain status quo, so this change is now purely a new method. Submitted to 1.6 as r3873. rjrjr On Thu, Oct 16, 2008 at 1:31 PM, Isaac Truett <[EMAIL PROTECTED]> wrote: > The Google home pa

[gwt-contrib] Re: code review requested, allow i18n class-level annotations to be inherited

2008-10-27 Thread John Tamplin
On Mon, Oct 27, 2008 at 6:34 PM, Ray Ryan <[EMAIL PROTECTED]> wrote: > LGTM > Thanks, committed to releases/1.6 at r3874. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--

[gwt-contrib] [google-web-toolkit commit] r3874 - in releases/1.6/user: src/com/google/gwt/i18n/rebind test/com/google/gwt/i18n/client

2008-10-27 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 27 15:36:48 2008 New Revision: 3874 Added: releases/1.6/user/src/com/google/gwt/i18n/rebind/AnnotationUtil.java (contents, props changed) releases/1.6/user/test/com/google/gwt/i18n/client/CommonInterfaceAnnotations.java (contents, props c

[gwt-contrib] [google-web-toolkit commit] r3875 - wiki

2008-10-27 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 27 15:45:49 2008 New Revision: 3875 Modified: wiki/DesignOOPHM.wiki Log: Update documentation to match current branches/oophm. Patch by: t.broyer Review by: jat Modified: wiki/DesignOOPHM.wiki

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-27 Thread Lex Spoon
On Fri, Oct 17, 2008 at 5:40 PM, Lex Spoon <[EMAIL PROTECTED]> wrote: > On Fri, Oct 17, 2008 at 3:46 PM, Ray Cromwell <[EMAIL PROTECTED]> wrote: >> BTW, the code that loads the async fragments must be proxy-aware for >> this to work. The GadgetLinker >> generateScriptInjector/generateStylesheetInj

[gwt-contrib] [google-web-toolkit commit] r3876 - wiki

2008-10-27 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Mon Oct 27 15:58:02 2008 New Revision: 3876 Modified: wiki/DesignOOPHM.wiki Log: Edited wiki page through web user interface. Modified: wiki/DesignOOPHM.wiki == --- wiki/DesignOOPHM.w

[gwt-contrib] Re: code review requested, allow i18n class-level annotations to be inherited

2008-10-27 Thread Ray Ryan
LGTM On Mon, Oct 27, 2008 at 2:47 PM, John Tamplin <[EMAIL PROTECTED]> wrote: > Ok, here is a revised patch which recursively follows the inheritance > chains, and the test improved to check for that. > > -- > John A. Tamplin > Software Engineer (GWT), Google > --~--~-~--~~--

[gwt-contrib] Re: Patch for DesignOOPHM wiki page

2008-10-27 Thread John Tamplin
On Fri, Oct 24, 2008 at 10:31 AM, Thomas Broyer <[EMAIL PROTECTED]> wrote: > Attached is a patch to update the DesignOOPHM wiki page to bring it in > line with the branches/oophm code (re messages and values) > Committed, with some follow-up changes. Thanks. -- John A. Tamplin Software Enginee

[gwt-contrib] Re: review request: JUnit hang "back door" closing

2008-10-27 Thread Scott Blum
Sorry for the delay. Shouldn't we fix the underlying problem, though? On Fri, Oct 17, 2008 at 1:49 PM, Freeland Abbott <[EMAIL PROTECTED] > wrote: > Scott, can you review-or-delegate both this and my earlier "review request: > JUnit hang" > I just sent a patch up to block sending a "bad Test" to

[gwt-contrib] Re: data binding framework for GWT

2008-10-27 Thread Ben Vitale
Have you guys seen the recent UFaceKit proposal? I didn't see mention of it in this thread or any of the other threads listed. http://www.eclipse.org/proposals/ufacekit/ -Ben --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~-

[gwt-contrib] Re: review request: JUnit hang "back door" closing

2008-10-27 Thread Freeland Abbott
r3809, for the specific case of an unnamed test object; that's the "earler 'review request: JUnit hang'" thread I mentioned. I got approval from Bob for that one when I realized you were gone for the week, but left this one on your queue 'cause it was lower-priority given the "front door" fix and

[gwt-contrib] Re: table columns

2008-10-27 Thread John LaBanca
I can see where that would be confusing, and the JavaDoc should be updated. Balancing performance and usability can be very tricky in a web browser. Whereas in a Java world we can use hash maps and some O(n^2) logic (I don't really know if the algorithm is this bad) to keep track of row and cell