[gwt-contrib] Re: Updated WAR design for GWT 1.6

2008-10-30 Thread Bruce Johnson
perhaps the solution to the security concern is just to somehow be more clear what your actual endpoints are as a function of the modules you've inherited. maybe some sort of click-through acknowledgment? the compiler could even dump out the list when you compile. On 10/30/08, Scott Blum <[EMAIL

[gwt-contrib] [google-web-toolkit commit] r3919 - releases/1.6/user

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 18:40:36 2008 New Revision: 3919 Modified: releases/1.6/user/build.xml Log: Reorder deps. Modified: releases/1.6/user/build.xml == --- releases/1.6/user/build.xml (original

[gwt-contrib] [google-web-toolkit commit] r3918 - in releases/1.6/dev/core/test/com/google/gwt: core/ext/typeinfo dev/resource/impl/testdat...

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 18:40:16 2008 New Revision: 3918 Removed: releases/1.6/dev/core/test/com/google/gwt/core/ext/typeinfo/TypeOracleGenericsSupportTest.java Modified: releases/1.6/dev/core/test/com/google/gwt/dev/resource/impl/testdata/cpe1/org/example/foo/clien

[gwt-contrib] [google-web-toolkit commit] r3917 - releases/1.6/user

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 18:24:44 2008 New Revision: 3917 Modified: releases/1.6/user/build.xml Log: Build fix: gwt-user uses the 2.4 servlet API spec. Modified: releases/1.6/user/build.xml == ---

[gwt-contrib] Re: Updated WAR design for GWT 1.6

2008-10-30 Thread Scott Blum
Ray, it's a great point you raise. And it's possible my wanting to deprecate it is in some way related to not wanting to solve the problem of merging into a user's existing web.xml. For parity between hosted and web mode, I feel like if we continue to support servlets, the compiler needs to hand

[gwt-contrib] [google-web-toolkit commit] r3916 - releases/1.6/user/super/com/google/gwt/emul/java/util

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 17:51:19 2008 New Revision: 3916 Modified: releases/1.6/user/super/com/google/gwt/emul/java/util/Collections.java Log: Cache the entry set, key set, and values collection for unmodifiable maps to reduce object creation on repeated calls. Patch by

[gwt-contrib] Re: RR: Patch for ConstantMap

2008-10-30 Thread Scott Blum
w00t, we committed this as r3915. On Thu, Oct 30, 2008 at 1:30 PM, Amit Manjhi <[EMAIL PROTECTED]> wrote: > Updated patch: (a) incorporates ConstantMapTest, (b) Reverts the mappings > change I introduced. > > Amit > > > On Thu, Oct 30, 2008 at 12:38 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > >>

[gwt-contrib] [google-web-toolkit commit] r3915 - in releases/1.6/user: src/com/google/gwt/i18n/client/impl src/com/google/gwt/i18n/rebind ...

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 17:44:52 2008 New Revision: 3915 Modified: releases/1.6/user/src/com/google/gwt/i18n/client/impl/ConstantMap.java releases/1.6/user/src/com/google/gwt/i18n/rebind/ConstantsMapMethodCreator.java releases/1.6/user/src/com/google/gwt/i18n/re

[gwt-contrib] [google-web-toolkit commit] r3914 - releases/1.6/user/test/com/google/gwt/i18n/client

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 16:36:02 2008 New Revision: 3914 Modified: releases/1.6/user/test/com/google/gwt/i18n/client/TestConstants.java Log: Sort & format. Modified: releases/1.6/user/test/com/google/gwt/i18n/client/TestConstants.java ===

[gwt-contrib] [google-web-toolkit commit] r3913 - releases/1.6/dev/core/src/com/google/gwt/dev

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 16:12:46 2008 New Revision: 3913 Modified: releases/1.6/dev/core/src/com/google/gwt/dev/GWTShell.java Log: Fix broken JUnit web mode; we were incorrectly returning the compiler work directory rather than the compiler output directory. Review by:

[gwt-contrib] [google-web-toolkit commit] r3912 - branches/1_6_events/samples/showcase/src/com/google/gwt/sample/showca se/client

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 15:40:08 2008 New Revision: 3912 Modified: branches/1_6_events/samples/showcase/src/com/google/gwt/sample/showcase/client/Showcase.java Log: fix old valuechange method name Modified: branches/1_6_events/samples/showcase/src/com/google/gwt/sampl

[gwt-contrib] Re: RR: Patch for ConstantMap

2008-10-30 Thread Scott Blum
On Thu, Oct 30, 2008 at 1:25 PM, John Tamplin <[EMAIL PROTECTED]> wrote: > On Thu, Oct 30, 2008 at 12:21 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > >> Ahh... hmm. Well, ConstantMapTest isn't doing much right now, because it >> needs to implement makeFullMap() to really do anything. I played aro

[gwt-contrib] RR: The new event system (and its documentation) need your scrutiny

2008-10-30 Thread Ray Ryan
Hello, esteemed contributors! We have gotten to the point that our 1.6 event branch (http://google-web-toolkit.googlecode.com/svn/branches/1_6_events/) is stable enough to be more globally banged on, so this is a call for voluntee

[gwt-contrib] Re: RR: The new event system (and its documentation) need your scrutiny

2008-10-30 Thread Ray Ryan
Another spot for some scrutiny, in addition to the logical events mapping, is event sinking in Composite. Are we doing the right thing there? On Thu, Oct 30, 2008 at 1:18 PM, Ray Ryan <[EMAIL PROTECTED]> wrote: > Hello, esteemed contributors! > > We have gotten to the point that our 1.6 event > b

[gwt-contrib] [google-web-toolkit commit] r3909 - in branches/1_6_events: reference/code-museum/src/com/google/gwt/museum/client/common ref...

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 12:53:54 2008 New Revision: 3909 Added: branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForMenuEvents.java Modified: branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/client/co

[gwt-contrib] RR: runAsync with the leftovers pulled out of the initial download

2008-10-30 Thread Lex Spoon
The version of runAsync that just went into trunk includes a basic code-splitting strategy from a few weeks ago. This patch adds a better strategy. Instead of lumping all non-exclusive code atoms into the initial download, the initial download only includes the initially needed code. Additionall

[gwt-contrib] RR: simple patch for caching of keySet, entrySet, and values in UnmodifiableMap

2008-10-30 Thread Amit Manjhi
Hi Scott, Please review the attached patch. Thanks, Amit Index: user/super/com/google/gwt/emul/java/util/Collections.java === --- user/super/com/google/gwt/emul/java/util/Collections.java (revision 3908) +++ user/super/com/google/

[gwt-contrib] Re: Updated WAR design for GWT 1.6

2008-10-30 Thread Ray Cromwell
On Wed, Oct 29, 2008 at 8:00 AM, BobV <[EMAIL PROTECTED]> wrote: > 3) The GWT module tag is deprecated; it only works in legacy > mode and is ignored (or generates a warning) in WAR mode. Instead, > you should configure servlets in your web.xml. Does WAR mode offer the same inheritance benefit

[gwt-contrib] [google-web-toolkit commit] r3907 - branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/c lient/common

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 11:01:35 2008 New Revision: 3907 Modified: branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/client/common/EventReporter.java Log: Missing file update. Modified: branches/1_6_events/reference/code-museum/src/com/google/gwt/mus

[gwt-contrib] [google-web-toolkit commit] r3908 - branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/c lient/defaultmuseum

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 11:07:49 2008 New Revision: 3908 Modified: branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/Issue1245.java branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/Issue1

[gwt-contrib] [google-web-toolkit commit] r3906 - in branches/1_6_events/reference/code-museum/src/com/google/gwt/museum: . client/defaultm...

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 10:55:14 2008 New Revision: 3906 Modified: branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/SingleIssue.gwt.xml branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForCheckBoxAndR

[gwt-contrib] [google-web-toolkit commit] r3905 - branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/c lient/defaultmuseum

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 10:44:27 2008 New Revision: 3905 Added: branches/1_6_events/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForCheckBoxAndRadioButtonEvents.java Log: Adding test for radio and checkboxes including setValue and ValueCh

[gwt-contrib] Re: RR: Patch for ConstantMap

2008-10-30 Thread Amit Manjhi
Updated patch: (a) incorporates ConstantMapTest, (b) Reverts the mappings change I introduced. Amit On Thu, Oct 30, 2008 at 12:38 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > Sweet. > > > On Thu, Oct 30, 2008 at 12:32 PM, Amit Manjhi <[EMAIL PROTECTED]>wrote: > >> ConcurrentModificationException.

[gwt-contrib] Re: RR: Patch for ConstantMap

2008-10-30 Thread John Tamplin
On Thu, Oct 30, 2008 at 12:21 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > Ahh... hmm. Well, ConstantMapTest isn't doing much right now, because it > needs to implement makeFullMap() to really do anything. I played around > with the idea of subclassing ConstantMap and overriding the JSNI methods

[gwt-contrib] [google-web-toolkit commit] r3903 - changes/spoon/runAsync

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 10:18:48 2008 New Revision: 3903 Modified: changes/spoon/runAsync/branch-info.txt Log: Updating branch-info.txt. Modified: changes/spoon/runAsync/branch-info.txt == --- cha

[gwt-contrib] [google-web-toolkit commit] r3902 - in changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs: . impl

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 10:13:18 2008 New Revision: 3902 Modified: changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java Log: When splitting code, l

[gwt-contrib] Re: Updated WAR design for GWT 1.6

2008-10-30 Thread Scott Blum
Yeah, sorry.. we checked it into the 1.6 branch. On Thu, Oct 30, 2008 at 9:38 AM, Miguel Méndez <[EMAIL PROTECTED]> wrote: > Can we get a patch? > > > On Wed, Oct 29, 2008 at 5:55 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > >> Hearing no objections, we implemented this. :) >> >> >> On Wed, Oct 29

[gwt-contrib] Re: RR: Patch for ConstantMap

2008-10-30 Thread Scott Blum
Sweet. On Thu, Oct 30, 2008 at 12:32 PM, Amit Manjhi <[EMAIL PROTECTED]> wrote: > ConcurrentModificationException. I will handle the exception :). > > On second thoughts, I did see the utility of adding equals check in the > other direction. The most recent patch contains the checks. I also > dis

[gwt-contrib] Re: RR: Patch for ConstantMap

2008-10-30 Thread Amit Manjhi
ConcurrentModificationException. I will handle the exception :). On second thoughts, I did see the utility of adding equals check in the other direction. The most recent patch contains the checks. I also discovered the missing equals and hashCode methods, which I also added in the patch. I will ad

[gwt-contrib] Re: RR: Patch for ConstantMap

2008-10-30 Thread Amit Manjhi
Hi Scott, I have attached the next version of the patch which incorporates all your feedback except changes to Collections.unmodifiableMap. I will send a separate patch for that shortly. Thanks, Amit On Wed, Oct 29, 2008 at 8:59 PM, John Tamplin <[EMAIL PROTECTED]> wrote: > On Wed, Oct 29, 2008

[gwt-contrib] Re: How we plan to break DialogBox in GWT 1.6

2008-10-30 Thread Ray Ryan
Okay, silence in two threads answers affirmative. This is the plan. We r in ur DialogBoxen, breakin ur compaxtibility, rjrjr On Wed, Oct 29, 2008 at 9:55 AM, Ray Ryan <[EMAIL PROTECTED]> wrote: > This isn't really a deprecation policy question, though. We need to know > specifically if this plan

[gwt-contrib] Re: RR: Patch for ConstantMap

2008-10-30 Thread Scott Blum
On Wed, Oct 29, 2008 at 8:45 PM, Amit Manjhi <[EMAIL PROTECTED]> wrote: > Thanks for the feedback, Scott. > > On Wed, Oct 29, 2008 at 8:22 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > >> I18NSuite: why is the test commented out? >> > > Since ConstantMap now uses Jsni, it needs a Gwt environment. Th

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-30 Thread Lex Spoon
On Thu, Oct 30, 2008 at 11:28 AM, BobV <[EMAIL PROTECTED]> wrote: > The cast to (T) is JsVisitor.accept() is necessary for javac 1.5.0_13 > as shipped on OS X to compile the code. > > Otherwise, LGTM. > Excellent. I put back the (T), with a comment, and committed at revision 3901. > What are

[gwt-contrib] Re: why are Hyperlinks divs?

2008-10-30 Thread Alex Rudnick
On Thu, Oct 30, 2008 at 11:35 AM, Ray Ryan <[EMAIL PROTECTED]> wrote: > Maybe, we can hash that out when the time comes. Is there an issue on that > one? If not, can you write it up for milestone_1_6_RC? Sounds like a plan! Entered issue 3061. http://code.google.com/p/google-web-toolkit/issues/d

[gwt-contrib] Re: RPC and Fileuploads

2008-10-30 Thread BobV
> If that kind of functionality is not going to be implemented then I > need at least an API to be able to encode a serializable object into a > Form input field and output field. Since RPC already has serialisation/ > deserialisation it would be great if I could just reuse that code, > without th

[gwt-contrib] Re: RPC and Fileuploads

2008-10-30 Thread John Tamplin
On Thu, Oct 30, 2008 at 11:58 AM, BobV <[EMAIL PROTECTED]> wrote: > MyServiceAsync async = GWT.create(MyRpcService.class); > StreamWriter w = ((SerializationStreamFactory) async).createStreamWriter(); > w.writeObject(any object that the async interface could send to the > server); > String payload

[gwt-contrib] Re: Bug fixes have any priority ?

2008-10-30 Thread John Tamplin
On Thu, Oct 30, 2008 at 11:38 AM, stuckagain <[EMAIL PROTECTED]> wrote: > Yes, I have the same problem with the showcase application. How are > these filenames generated for the ImageBundles ... there must be > something that is platform specific ? > I can't reproduce this problem on Windows or L

[gwt-contrib] [google-web-toolkit commit] r3900 - in releases/1.6: dev/core/src/com/google/gwt/dev/shell user/test/com/google/gwt/user/serv...

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 08:45:11 2008 New Revision: 3900 Modified: releases/1.6/dev/core/src/com/google/gwt/dev/shell/HostedModeServletConfigProxy.java releases/1.6/dev/core/src/com/google/gwt/dev/shell/HostedModeServletContextProxy.java releases/1.6/user/test

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-30 Thread Lex Spoon
On Wed, Oct 29, 2008 at 4:26 PM, Ray Cromwell <[EMAIL PROTECTED]> wrote: > Lex, I can just hack it for now. Long term, I would prefer a solution > that addresses in a general purpose fashion, the needs of GWT to be > aware of the container it is in, such as the ability to fetch external > resource

[gwt-contrib] Re: Bug fixes have any priority ?

2008-10-30 Thread stuckagain
Hi John, Yes, I have the same problem with the showcase application. How are these filenames generated for the ImageBundles ... there must be something that is platform specific ? The RPC problem I was able to circumvent by using my own SerializationPolicy implementation, that is basically the 1

[gwt-contrib] Re: why are Hyperlinks divs?

2008-10-30 Thread Ray Ryan
On Thu, Oct 30, 2008 at 8:15 AM, Alex Rudnick <[EMAIL PROTECTED]> wrote: > I've had to use that same workaround -- I'll put this one on my list. Cool, I've assigned it to you. > > > Also, I'd like to look at folding HyperlinkOverride behavior > (cmd-click and friends do the default browser thin

[gwt-contrib] [google-web-toolkit commit] r3899 - releases/1.6/user/test/com/google/gwt/user/server/rpc

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 08:31:18 2008 New Revision: 3899 Modified: releases/1.6/user/test/com/google/gwt/user/server/rpc/RemoteServiceServletTest.java Log: Build break fix: MockServletConfig needed to implement getServletName() to construct a log message. Review by: b

[gwt-contrib] Re: RR: runAsync merge to trunk

2008-10-30 Thread BobV
The cast to (T) is JsVisitor.accept() is necessary for javac 1.5.0_13 as shipped on OS X to compile the code. Otherwise, LGTM. What are your current thoughts on making runAsync work with XS and SSO linkers, since they use function closures? I'll follow up with an updated SOYC reports CL tha

[gwt-contrib] Re: why are Hyperlinks divs?

2008-10-30 Thread Alex Rudnick
I've had to use that same workaround -- I'll put this one on my list. Also, I'd like to look at folding HyperlinkOverride behavior (cmd-click and friends do the default browser thing, like opening a tab) into Hyperlink. Perhaps that could be a constructor argument too? On Wed, Oct 29, 2008 at 6:

[gwt-contrib] [google-web-toolkit commit] r3898 - changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/impl

2008-10-30 Thread codesite-noreply
Author: [EMAIL PROTECTED] Date: Thu Oct 30 07:47:33 2008 New Revision: 3898 Modified: changes/spoon/runAsync/dev/core/src/com/google/gwt/dev/jjs/impl/ReplaceRunAsyncs.java Log: Fix the log message when specifying where a runAsync loader is assigned. Modified: changes/spoon/runAsync/dev/

[gwt-contrib] Re: Bug fixes have any priority ?

2008-10-30 Thread John Tamplin
On Thu, Oct 30, 2008 at 5:33 AM, stuckagain <[EMAIL PROTECTED]> wrote: > When I run the application in the browser it works. > In hosted mode I see requests for different #MD5#.png files than when > running in the browser. > Do you see this problem when running hosted mode from a sample that uses

[gwt-contrib] Re: Updated WAR design for GWT 1.6

2008-10-30 Thread John Tamplin
On Thu, Oct 30, 2008 at 9:38 AM, Miguel Méndez <[EMAIL PROTECTED]> wrote: > Can we get a patch? svn sw http://google-web-toolkit.googlecode.com/svn/releases/1.6 -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/gr

[gwt-contrib] Re: Updated WAR design for GWT 1.6

2008-10-30 Thread Miguel Méndez
Can we get a patch? On Wed, Oct 29, 2008 at 5:55 PM, Scott Blum <[EMAIL PROTECTED]> wrote: > Hearing no objections, we implemented this. :) > > > On Wed, Oct 29, 2008 at 11:00 AM, BobV <[EMAIL PROTECTED]> wrote: > >> >> Scott, Miguel, Kelly, and I sat down today to try to resolve some of >> the

[gwt-contrib] Re: Bug fixes have any priority ?

2008-10-30 Thread stuckagain
Hi John, When I run the application in the browser it works. In hosted mode I see requests for different #MD5#.png files than when running in the browser. David On Oct 29, 9:21 pm, "John Tamplin" <[EMAIL PROTECTED]> wrote: > On Wed, Oct 29, 2008 at 3:56 PM, David <[EMAIL PROTECTED]> wrote: > >

[gwt-contrib] RPC and Fileuploads

2008-10-30 Thread stuckagain
Hi, Some time ago I reported a request for enhancement about somehow getting FileUploads to be better integrated with RPC. http://code.google.com/p/google-web-toolkit/issues/detail?id=2538&q=fileupload In our project, we need to upload files, expand it and create some records that contain data