Thanks for the great comments!
It turns out that this bug is already reported (and 5 stars as well)
in the issue database.
jlaba is the owner of the bug and priority is medium
Here is the bug report:
http://code.google.com/p/google-web-toolkit/issues/detail?id=1902
David
On Nov 27, 8:51 am
Hi,
Does anyone has any new insights about this issue? We've been
investigating for over a year(!), and we seem to not be the only
ones...
http://tinyurl.com/5rqfp5
Thanks.
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~
This seems like the right philosophy to me, and your point about date
pickers having an optional range is a very persuasive one, so I'm sold on
the "best guess" with the widget being able to throw
IllegalArgumentException as well.
On Mon, Dec 1, 2008 at 11:09 PM, John LaBanca <[EMAIL PROTECTED]> w
This is very cool!
Thanks,
John LaBanca
[EMAIL PROTECTED]
On Fri, Nov 28, 2008 at 2:54 PM, dflorey <[EMAIL PROTECTED]> wrote:
>
> Uuups, only working in hosted mode :-(
>
> On 27 Nov., 13:07, dflorey <[EMAIL PROTECTED]> wrote:
> > Hi,
> > I've used that Generator stuff in gwt for the first time
>
> Thanks for the great comments!
>
I didn't see any comments... oh, sarcasm =)
Since the TabPanel (really the DeckPanel) currently attaches widgets to the
DOM immediately, we might have backward compatibility issues if we attach
them lazily. We could make lazy attachment an optional setting th
Trying to recap, I believe the concrete proposals I just heard are:
1. TextBoxBase should accept setValue(null), and return "" from getValue();
2. It is reasonable for widgets that can't sensibly be cleared to throw
IllegalArgumentException on setValue(null)
3. HasValue's javadoc should be tweaked
>
> 1. TextBoxBase should accept setValue(null), and return "" from getValue();
Correct, and in general getValue() and setValue() do not need to be equal.
> 2. It is reasonable for widgets that can't sensibly be cleared to throw
> IllegalArgumentException on setValue(null)
>
I don't think we nee
Yep.
On Tue, Dec 2, 2008 at 11:23 AM, Ray Ryan <[EMAIL PROTECTED]> wrote:
> Trying to recap, I believe the concrete proposals I just heard are:
> 1. TextBoxBase should accept setValue(null), and return "" from getValue();
> 2. It is reasonable for widgets that can't sensibly be cleared to throw
>
Code review request:
http://code.google.com/p/google-web-toolkit-incubator/source/detail?r=1250
Copying gen2-DropDownPanel over the widgetideas-DropDownPanel rather then
patching the widgetideas version, as this way we only maintain one version
of DropDownPanel, which is going to be depricated as
Is this a good idea? I think we should just deprecate the widgetideas
version now in favor of the gen2 version. I didn't attempt to copy
ScrollTable changes back to the widgetideas version, it would be a
nightmare. IMHO, development on widgetideas code should be closed once a
gen2 replacement is
Is that going to turn into a revolving door of new packages as each
generation of widgets requires it's own namespace? It seems to me that
the gen2 package idea was a mistake of convenience and maybe should
have been a branch (or branches) that got merged back into trunk once
it stabilized.
On T
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 09:12:50 2008
New Revision: 4222
Modified:
releases/1.6/user/src/com/google/gwt/junit/tools/JUnit-hosted.launchsrc
releases/1.6/user/src/com/google/gwt/junit/tools/JUnit-web.launchsrc
releases/1.6/user/src/com/google/gwt/user/tools/App.launch
Per your review feedback, lowered cuteness and explained setVisible(false)
call.
rjrjr
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
less-silly-LazyPanelExample-1.6-r4222
> Is there a plan to make Constants part of ImmutableResourceBundle?
Incubator r1252 includes a new resource type called GwtCreateResource.
interface GwtCreateResource extends ResourcePrototype {
T create();
}
interface Resources extends ImmutableResourceBundle {
// messages().create() invo
Reviewers: rjrjr,
Message:
This looks great to me, Alex. And I think you're doing as right a thing
as you can WRT Chrome. Just a couple of nits noted below.
http://codereview.appspot.com/8696/diff/1/4
File user/src/com/google/gwt/user/client/ui/impl/HyperlinkImplIE.java
(right):
http://coderev
LGTM
Thanks,
John LaBanca
[EMAIL PROTECTED]
On Tue, Dec 2, 2008 at 12:36 PM, Ray Ryan <[EMAIL PROTECTED]> wrote:
> Per your review feedback, lowered cuteness and explained setVisible(false)
> call.
> rjrjr
>
>
--~--~-~--~~~---~--~~
http://groups.google.com/group
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 10:22:02 2008
New Revision: 4223
Modified:
releases/1.6/user/javadoc/com/google/gwt/examples/LazyPanelExample.java
Log:
Per jlabanca's review feedback, lowered cuteness and explained
setVisible(false) call.
reviewed by jlabanca
submitted by rjrjr
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 10:32:41 2008
New Revision: 4224
Modified:
trunk/dev/core/src/com/google/gwt/dev/util/Util.java
Log:
Removing bad import, desk check by spoon.
Modified: trunk/dev/core/src/com/google/gwt/dev/util/Util.java
==
Fantastic, thanks! :) Tweaked to do initialization on the declaration
lines for those static variables.
Committed r4225.
On Tue, Dec 2, 2008 at 12:50 PM, <[EMAIL PROTECTED]> wrote:
> Reviewers: rjrjr,
>
> Message:
> This looks great to me, Alex. And I think you're doing as right a thing
> as yo
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 10:37:04 2008
New Revision: 4225
Added:
releases/1.6/user/src/com/google/gwt/user/Hyperlink.gwt.xml
releases/1.6/user/src/com/google/gwt/user/client/ui/impl/HyperlinkImpl.java
(contents, props changed)
releases/1.6/user/src/com/google
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 11:00:01 2008
New Revision: 4226
Modified:
releases/1.6/user/src/com/google/gwt/user/tools/App.launchsrc
releases/1.6/user/src/com/google/gwt/user/tools/ApplicationCreator.java
releases/1.6/user/src/com/google/gwt/user/tools/project.ant.xmlsr
>
>
> I didn't see any comments... oh, sarcasm =)
>
I'm not going to repeat myself... but there is room for improvement on how
bugs and feature requests are treated!
> Since the TabPanel (really the DeckPanel) currently attaches widgets to the
> DOM immediately, we might have backward compatibi
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 12:12:01 2008
New Revision: 4227
Added:
changes/jat/oophm-plugins-trunk/
Log:
Create change branch for OOPHM XPCOM plugin changes to support FF2/3,
associated build sytem changes, and required libraries/includes.
--~--~-~--~~--
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 12:12:32 2008
New Revision: 4228
Added:
changes/jat/oophm-plugins-trunk/plugins/
- copied from r4227, /branches/oophm/plugins/
Log:
Copy plugins directory from branches/oophm to change branch.
--~--~-~--~~~---~--
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 12:13:50 2008
New Revision: 4229
Added:
changes/jat/oophm-plugins-trunk/sdk/
- copied from r4228, /tools/sdk/
Log:
Copy tools/sdk into change branch.
--~--~-~--~~~---~--~~
http://groups.google.com/group/Googl
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 12:27:03 2008
New Revision: 4230
Modified:
trunk/tools/soyc-vis/src/com/google/gwt/soyc/GlobalInformation.java
trunk/tools/soyc-vis/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
trunk/tools/soyc-vis/src/com/google/gwt/soyc/SoycDashboar
John,
Could you review this change? Unfortunately, HasValue from incubator
directly conflicts with HasValue from gwt-trunk. Therefore creating a nasty
path-dependency problem, the current solution is to remove HasValue from
gwt-incubator:
http://code.google.com/p/google-web-toolkit-incubator/s
LGTM
Thanks,
John LaBanca
[EMAIL PROTECTED]
On Tue, Dec 2, 2008 at 3:46 PM, Emily Crutcher <[EMAIL PROTECTED]> wrote:
> John,
>
> Could you review this change? Unfortunately, HasValue from incubator
> directly conflicts with HasValue from gwt-trunk. Therefore creating a nasty
> path-dependen
The constructor flag is a great idea. David, would you mind logging an issue
to that effect?
On Tue, Dec 2, 2008 at 11:58 AM, David <[EMAIL PROTECTED]> wrote:
>
>> I didn't see any comments... oh, sarcasm =)
>>
>
> I'm not going to repeat myself... but there is room for improvement on how
> bugs
The problem is that both versions on these widgets need to exist
simultaneously for a period of time, to give our users enough space to move
from the deprecated version to the non-deprecated one.
For date picker, in specific, because it will be in the first 1.6 milestone,
it does not seem worth pe
>
> A flag on the TabPanel/DeckPanel would be a better solution, I would just
> subclass and make sure that the lazy attachment is used on all our panels.
> That I could get away with, but still I find it a pitty that it is not the
> default behaviour.
> D
>
Yes, for new widgets that is exactly wh
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 13:39:50 2008
New Revision: 4231
Modified:
trunk/distro-source/windows/build.xml
Log:
Fix distro build file for Windows.
Patch by: amitmanjhi
Review by: jat
Modified: trunk/distro-source/windows/build.xml
=
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 14:14:39 2008
New Revision: 4232
Modified:
branches/1_6_datepicker/user/test/com/google/gwt/user/client/ui/DateValueChangeTester.java
branches/1_6_datepicker/user/test/com/google/gwt/user/client/ui/TextBoxBaseTestBase.java
Log:
Punches up te
[google-web-toolkit] EmilyCrutcher commented on revision r4232.
Details are at
http://code.google.com/p/google-web-toolkit/source/detail?r=4232
Score: Positive
General Comment:
LGTM.
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/detail?r=4232
--
You receive
Per our earlier conversation, softening the requirements on HasValue.
Intended for submission to releases/1.6
rjrjr
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
HasValue
Should we say that IllegalArgumentExceptions should be preferred for invalid
input?
Other then that, LGTM.
On Tue, Dec 2, 2008 at 5:39 PM, Ray Ryan <[EMAIL PROTECTED]> wrote:
> Per our earlier conversation, softening the requirements on HasValue.
> Intended for submission to releases/1.6
> rjrjr
Seeing as we don't actually throw any of those yet, I'd like to stay
ambiguous on that front.
rjrjr
On Tue, Dec 2, 2008 at 2:58 PM, Emily Crutcher <[EMAIL PROTECTED]> wrote:
> Should we say that IllegalArgumentExceptions should be preferred for
> invalid input?
> Other then that, LGTM.
>
>
> On
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 15:22:57 2008
New Revision: 4233
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/GWTCompiler.java
Log:
If there is an error during precompilation, then exit gracefully rather
than causing a null pointer exception.
Review by: scottb (desk c
Submitted r4234
On Tue, Dec 2, 2008 at 3:05 PM, Ray Ryan <[EMAIL PROTECTED]> wrote:
> Seeing as we don't actually throw any of those yet, I'd like to stay
> ambiguous on that front.
> rjrjr
>
>
> On Tue, Dec 2, 2008 at 2:58 PM, Emily Crutcher <[EMAIL PROTECTED]> wrote:
>
>> Should we say that Ille
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 15:38:29 2008
New Revision: 4234
Modified:
releases/1.6/user/src/com/google/gwt/user/client/ui/HasValue.java
Log:
Loosen the contract on HasValue, and encourage (not require)
use of setValue(null) to clear a widget.
reviewer: ecc
submitter: rjrjr
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 16:08:25 2008
New Revision: 4235
Modified:
branches/1_6_datepicker/samples/showcase/src/com/google/gwt/sample/showcase/client/content/widgets/CwDatePicker.java
branches/1_6_datepicker/user/javadoc/com/google/gwt/examples/DatePickerExample.jav
Tweaks in response to review of r4188. Use Labels instead of TextBoxes in
examples, and explain use of VerticalPanel in DatePicker.
http://code.google.com/p/google-web-toolkit/source/detail?r=4235
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Tool
[google-web-toolkit] [EMAIL PROTECTED] commented on revision r4235.
Details are at
http://code.google.com/p/google-web-toolkit/source/detail?r=4235
Score: Positive
General Comment:
Looks sensible to me!
Respond to these comments at
http://code.google.com/p/google-web-toolkit/source/detail?r
Hello Ray :)
Would you take a look at this patch for the 1.6 branch, adding the
InlineHyperlink widget?
It adds a protected constructor to Hyperlink, allowing subclasses to
pass a wrapper element. If that element is null, it calls setElement
with the anchor element. InlineHyperlink then is just a
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 17:08:23 2008
New Revision: 4237
Modified:
releases/1.6/branch-info.txt
Log:
Recording merge into trunk.
Modified: releases/1.6/branch-info.txt
==
--- releases/1.6/branch-i
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 17:34:56 2008
New Revision: 4238
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
Log:
Do not record binary types for units with errors, this can lead to an
invalid state.
Modified:
releases/1.6/dev/core/src/com/go
Reviewers: rjrjr,
Message:
LGTM with the nits below fixed.
http://codereview.appspot.com/8700/diff/1/3
File user/src/com/google/gwt/user/client/ui/Hyperlink.java (right):
http://codereview.appspot.com/8700/diff/1/3#newcode45
Line 45: * CSS Style Rules .gwt-Hyperlink
{ }
Autoformat damage. Pl
I'm working through the big date picker review:
http://groups.google.com/group/Google-Web-Toolkit-Contributors/browse_thread/thread/486babc9bb0863a9
I don't understand why we provide addGlobalStyleToDateand
addStyleToVisibleDates, especially since the latter will explode in your
face if you call i
http://code.google.com/p/google-web-toolkit/source/detail?r=4239
Addresses some of the remaining issues from
http://groups.google.com/group/Google-Web-Toolkit-
Contributors/browse_thread/thread/486babc9bb0863a9
In particular, nukes the unused Iterator class from ElementMapper,
fixes a bug in Dat
Author: [EMAIL PROTECTED]
Date: Tue Dec 2 20:08:01 2008
New Revision: 4239
Modified:
branches/1_6_datepicker/user/src/com/google/gwt/user/datepicker/client/CalendarView.java
branches/1_6_datepicker/user/src/com/google/gwt/user/datepicker/client/DatePicker.java
branches/1_6_date
Reviewers: jgw,
Description:
One of the goals of the new Dom library was proper modularity so that it
would be possible to write apps and libraries that do not depend on
User.gwt.xml. That's not currently possible due to UserAgent. This patch
moves UserAgent.gwt.xml into the dom module and create
51 matches
Mail list logo
