I've working on a branch that allows JavaScriptObjects to implement
interfaces with methods. Due to the lack of polymorphic dispatch of
JSOs, for a given method-bearing interface, there can be exactly one
JSO type implementing the interface. The question at hand is whether
or not to allow
Reviewers: ecc,
Description:
The methods onBeforeSelection() and onSelection() were added to TabPanel
during the event system upgrade, but we have sinced moved away from this
pattern in favor of internal handling.
I removed these methods and verified that they are not used anywhere.
Please
The associated issue:
http://code.google.com/p/google-web-toolkit/issues/detail?id=3235
http://gwt-code-reviews.appspot.com/1804
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I see an underlying philosophical question here related to how GWT helps
developers produce the fastest code.
A) One view is that we only allow constructs that generate fast code (e.g.
your option #1); that is, we disallow flexibility that could harm efficiency
if used.
B) The other view is that
+1 for option #2. An interface that can only ever be implemented once
seems very limited in usefulness.
On Wed, Jan 7, 2009 at 10:30 AM, BobV b...@google.com wrote:
I've working on a branch that allows JavaScriptObjects to implement
interfaces with methods. Due to the lack of polymorphic
We need to add the doc to the old methods on what people should do
instead, assuming that is done, LGTM.
http://gwt-code-reviews.appspot.com/1804/diff/1/2
File user/src/com/google/gwt/user/client/ui/TabPanel.java (left):
http://gwt-code-reviews.appspot.com/1804/diff/1/2#oldcode363
Line 363:
On Wed, Jan 7, 2009 at 10:48 AM, Bruce Johnson br...@google.com wrote:
Does anyone buy that reasoning? An important related question is whether
these things are actually compiler flags or whether they are module
settings. I think they are actually more appropriate as the latter.
If they are
On Tue, Jan 6, 2009 at 4:30 PM, Freeland Abbott
gwt.team.fabb...@gmail.com wrote:
Patch(es) not attached, so this is fairly high-level. ;-)
Doh! Attached for real now, with updates.
So long as your patch puts jarjar into tools, and you're just not including
the binary file 'cause patch
Thanks very much - that helps and I should be able to proceed using
1.6. But one follow-up question: do I have to do it with the latest
1.6 or trunk or is there a way to do it on GWT 1.5? Also, is the
intention to have emma integration be standard in GWT1.6?
Thanks again,
Jon
On Jan 6, 10:17
In the library code we constantly use *Impl to denote a class that users
should not look at, but here we we have *Impl annotations that is part of a
public API. Could we modify the name slightly so we can keep the *Impl
convention consistant throughout the gwt code base?
On Wed, Jan 7, 2009 at
Author: jlaba...@google.com
Date: Wed Jan 7 08:42:41 2009
New Revision: 4393
Modified:
releases/1.6/user/src/com/google/gwt/user/client/ui/TabListener.java
releases/1.6/user/src/com/google/gwt/user/client/ui/TabPanel.java
Log:
Removed TabPanel#onBeforeSelection and TabPanel#onSelection
Author: jlaba...@google.com
Date: Wed Jan 7 07:33:38 2009
New Revision: 4392
Modified:
releases/1.6/dev/core/src/com/google/gwt/core/ext/typeinfo/JClassType.java
Log:
Moves the instance field below static methods to avoid compile errors in
Eclipse.
Patch by: jlabanca
Review by: scottb
This patch does a formatting pass on related files and exposes an new
overload for drawImage().
The API addition is as follows:
/**
* Draws an input image at a given position on the canvas. Resizes image
* according to specified width and height and samples from the specified
* sourceY
Looks good overall, only quibble is it would be nice to use array list
rather then hash set to store the auto hide partners.
http://gwt-code-reviews.appspot.com/2001/diff/1/4
File user/src/com/google/gwt/user/client/ui/PopupPanel.java (right):
On Wed, Jan 7, 2009 at 11:17 AM, John Tamplin j...@google.com wrote:
On Wed, Jan 7, 2009 at 10:48 AM, Bruce Johnson br...@google.com wrote:
Does anyone buy that reasoning? An important related question is whether
these things are actually compiler flags or whether they are module
settings. I
Author: e...@google.com
Date: Wed Jan 7 09:50:37 2009
New Revision: 4395
Modified:
releases/1.6/user/src/com/google/gwt/user/client/ui/ClickListener.java
releases/1.6/user/src/com/google/gwt/user/client/ui/Composite.java
FormPanelImplHost is an example of an impl interface.
I think once users see one *Impl type that has documented useful
functionality for them, they are less likely to ignore the next *Impl
class/interface/annotation they see that looks like it might be useful for
them, regardless of whether the
+1 for option 2. And I think Bob's Person/MutablePerson scenario is a hugely
compelling justification for it.
I also wonder if something as obscure as the monomorphicSingleImpl flag will
ever be found. If the performance issue really is a big enough concern to
warrant its implementation (I can't
Author: jlaba...@google.com
Date: Wed Jan 7 11:49:57 2009
New Revision: 4399
Modified:
releases/1.6/reference/code-museum/src/com/google/gwt/museum/client/defaultmuseum/VisualsForEventsFiring.java
releases/1.6/user/src/com/google/gwt/event/dom/client/MouseWheelEvent.java
Hi all,
We've narrowed down the set of bugs we'd like to fix for GWT 1.6. Our plan
is for a very short release cycle this time, which forces us to fix only a
small set of bugs. Of course, we don't want to miss anything critical.
Here is the current set of Critical 1.6 bugs we intend to fix:
Author: sco...@google.com
Date: Wed Jan 7 14:59:41 2009
New Revision: 4401
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/js/ast/JsRootScope.java
Log:
Adding dispatchEvent which is defined in Mozilla on the window.
Issue: 3226
Modified:
Author: sco...@google.com
Date: Wed Jan 7 17:05:04 2009
New Revision: 4404
Modified:
releases/1.6/eclipse/samples/Hello/Hello compile.launch
releases/1.6/eclipse/samples/Hello/Hello.launch
Log:
Bump VM memory.
Modified: releases/1.6/eclipse/samples/Hello/Hello compile.launch
Author: sco...@google.com
Date: Wed Jan 7 17:19:22 2009
New Revision: 4405
Modified:
releases/1.6/dev/core/src/com/google/gwt/dev/PermutationWorker.java
releases/1.6/dev/core/src/com/google/gwt/dev/PermutationWorkerFactory.java
Log:
Actually fail the compile if a permutation fails
23 matches
Mail list logo
