Revision: 6411
Author: j...@google.com
Date: Fri Oct 16 22:24:33 2009
Log: Remove last traces of dev/oophm.
Patch by: jat
Review by: amitmanjhi (verbal)
http://code.google.com/p/google-web-toolkit/source/detail?r=6411
Deleted:
/trunk/dev/oophm
Modified:
/trunk/dev/build.xml
/trunk/eclipse
Comment by gwtdevel...@gmail.com:
Does OOPHM support
chrome://myextension/content/ext.xul?gwt.hosted=localhost:9997 ?
For more information:
http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM
--~--~-~--~~~---~--~~
http://groups.google.com/group/Googl
Revision: 6409
Author: j...@google.com
Date: Fri Oct 16 20:24:31 2009
Log: Add back a HostedMode entry point that logs a warning and redirects to
DevMode.
Patch by: jat
Review by: amitmanjhi
http://code.google.com/p/google-web-toolkit/source/detail?r=6409
Added:
/trunk/dev/core/src/com/goog
Revision: 6407
Author: jlaba...@google.com
Date: Fri Oct 16 20:20:33 2009
Log: Removing -precompile option from all test targets because it can cause
sporadic failures in timed, asynchronous tests.
Patch by: jlabanca
Review by: jat (TBR)
http://code.google.com/p/google-web-toolkit/source/deta
Revision: 6406
Author: amitman...@google.com
Date: Fri Oct 16 18:12:55 2009
Log: After upgrading HtmlUnit from 2.5 to 2.7-snapshot, sending an explicit
QUIT
message when the module transition happens does not seem to be required.
Patch by: amitmanjhi
Review by: jat (TBR)
http://code.google.co
Bob, Hmm, I just caught this thread. It looks like I should be updating
GWT-Exporter library to use this? GWT exporter can export non-static methods
as well, I'm wondering how that meshes with expectations?
-Ray
On Mon, Oct 12, 2009 at 8:39 AM, wrote:
>
> Reviewers: jgw,
>
> Message:
> I'm l
Revision: 6405
Author: cromwellian
Date: Fri Oct 16 16:19:37 2009
Log: Fix for Issue #4002
Patch by: cromwellian
Review by: scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=6405
Modified:
/trunk/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
==
Revision: 6404
Author: cromwellian
Date: Fri Oct 16 16:16:55 2009
Log: Fix JsInliner improperly inlining array, object, and function literals.
Patch by: cromwellian
Review by: spoon, scottb
http://code.google.com/p/google-web-toolkit/source/detail?r=6404
Modified:
/trunk/dev/core/src/com/googl
Revision: 6403
Author: rj...@google.com
Date: Fri Oct 16 15:58:05 2009
Log: Make StyleInjector use Scheduler API.
Patch by: bobv
Review by: bruce
http://gwt-code-reviews.appspot.com/78816
http://code.google.com/p/google-web-toolkit/source/detail?r=6403
Modified:
/trunk/user/src/com/google/gwt
Reviewers: mmendez,
Description:
Added DevModeServiceServer. Implements request handling for
DevModeService.
Needed to add a skeleton RemoteUI class as well; it still needs to be
filled in.
The implementation of DevModeServiceServer made me realize that I was
missing capability exchange message
Ugh, don't know what Reitveld did here. Ignore the previous two messages; it
somehow merged another code review into this one. Just pay attention to the
first message; the issue 81805 is still valid.
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-To
Actually, this patch won't work, as the other has not been committed as
yet. I'll nix this issue and send you another one that will work
properly.
http://gwt-code-reviews.appspot.com/81806
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Con
Reviewers: mmendez,
Description:
Added DevModeServiceServer. Implements request handling for
DevModeService requests.
Needed to add a skeleton RemoteUI class as well; it still needs to be
filled in.
The implementation of DevModeServiceServer made me realize that I was
missing capability exchang
Revision: 6402
Author: rj...@google.com
Date: Fri Oct 16 15:20:56 2009
Log: Initial add of Scheduler API.
Patch by: bobv
Review by: bruce, jgw
http://gwt-code-reviews.appspot.com/77820
http://code.google.com/p/google-web-toolkit/source/detail?r=6402
Added:
/trunk/user/src/com/google/gwt/core/
http://gwt-code-reviews.appspot.com/77810/diff/1007/30
File user/src/com/google/gwt/core/client/impl/Impl.java (right):
http://gwt-code-reviews.appspot.com/77810/diff/1007/30#newcode166
Line 166: // What is the correct return value here or should we
re-throw?
Additionally, this could be a genera
Revision: 6401
Author: rj...@google.com
Date: Fri Oct 16 14:48:33 2009
Log: Update user code to use $entry.
Patch by: bobv
Review by: jgw
http://gwt-code-reviews.appspot.com/77813
http://code.google.com/p/google-web-toolkit/source/detail?r=6401
Modified:
/trunk/user/src/com/google/gwt/http/cl
Revision: 6400
Author: rj...@google.com
Date: Fri Oct 16 14:04:54 2009
Log: Add $entry magic function to guarantee correct entry and exit of GWT
code from ex
Patch by: bobv
Review by: scottb, bruce, rjrjr, jgw
http://code.google.com/p/google-web-toolkit/source/detail?r=6400
Modified:
/trunk/
Reviewers: mmendez,
Description:
This patch adds the message transport API that users can use to
communicate with the Development Mode Server.
Note that all aspects of this have not been tested as yet (this code is
slightly different than the code that you tested). I'll run it through a
full tes
This contains the wrong patch. I'll send out a new review and delete
this one.
http://gwt-code-reviews.appspot.com/80803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
http://gwt-code-reviews.appspot.com/80803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: mmendez,
Description:
This patch adds the message transport API that users can use to
communicate with the Development Mode Server.
Note that all aspects of this have not been tested as yet (this code is
slightly different than the code that you tested). I'll run it through a
full tes
Revision: 6399
Author: j...@google.com
Date: Fri Oct 16 13:11:56 2009
Log: Adds TabLayoutPanelParser.
Review: http://gwt-code-reviews.appspot.com/81802
http://code.google.com/p/google-web-toolkit/source/detail?r=6399
Added:
/trunk/user/src/com/google/gwt/uibinder/parsers/TabLayoutPanelParser.ja
On 2009/10/16 20:09:18, Ray Ryan wrote:
> LGTM
Thanks. Committed at r6399.
http://gwt-code-reviews.appspot.com/81802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
LGTM
http://gwt-code-reviews.appspot.com/81802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
http://gwt-code-reviews.appspot.com/81802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6398
Author: rj...@google.com
Date: Fri Oct 16 12:49:04 2009
Log: Add unshift(), join(), and setLength() methods to JsArray types.
Patch by: bobv
http://code.google.com/p/google-web-toolkit/source/detail?r=6398
Modified:
/trunk/user/src/com/google/gwt/core/client/JsArray.java
/trun
Comment by claude...@gmail.com:
tested with iceweasel 3.5 from sid... worked well!
For more information:
http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--
http://gwt-code-reviews.appspot.com/81802/diff/1/2
File user/src/com/google/gwt/uibinder/parsers/TabLayoutPanelParser.java
(right):
http://gwt-code-reviews.appspot.com/81802/diff/1/2#newcode47
Line 47: DockLayoutPanelParser.getFullyQualifiedEnumName(unit));
Yup. Much better this than copy paste,
LGTY?
http://gwt-code-reviews.appspot.com/81802/diff/12/15
File user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java (right):
http://gwt-code-reviews.appspot.com/81802/diff/12/15#newcode135
Line 135: tabBar.getElement().getStyle().setWidth(16384, Unit.PX);
This really does have a comment
http://gwt-code-reviews.appspot.com/81802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Thanks. All should be addressed in the next patch.
http://gwt-code-reviews.appspot.com/81802/diff/1/2
File user/src/com/google/gwt/uibinder/parsers/TabLayoutPanelParser.java
(right):
http://gwt-code-reviews.appspot.com/81802/diff/1/2#newcode46
Line 46: .findType(TabLayoutPanel.class.getName()),
Some error message and method name nits, and one weird thing in
TabLayoutPanel by accident?
http://gwt-code-reviews.appspot.com/81802/diff/1/2
File user/src/com/google/gwt/uibinder/parsers/TabLayoutPanelParser.java
(right):
http://gwt-code-reviews.appspot.com/81802/diff/1/2#newcode46
Line 46: .
Revision: 6397
Author: j...@google.com
Date: Fri Oct 16 12:16:25 2009
Log: Initial implementation of TabLayoutPanel.
http://gwt-code-reviews.appspot.com/78820
http://code.google.com/p/google-web-toolkit/source/detail?r=6397
Added:
/trunk/user/javadoc/com/google/gwt/examples/TabLayoutPanelExampl
Committed at r6397.
http://gwt-code-reviews.appspot.com/78820/diff/1/4
File user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java (right):
http://gwt-code-reviews.appspot.com/78820/diff/1/4#newcode61
Line 61: */
On 2009/10/14 21:27:33, Ray Ryan wrote:
> That customizability is my main conc
LGTM.
--
John A. Tamplin
Software Engineer (GWT), Google
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6396
Author: jlaba...@google.com
Date: Fri Oct 16 12:07:20 2009
Log: Disabling tests that cause FF to crash in dev mode on Windows.
Patch by: jlabanca
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6396
Modified:
/trunk/user/test/com/google/gwt/dev/jjs/t
Reviewers: jat,
Description:
Description:
Returning Float.MAX_VALUE or Double.MAX_VALUE from a JSNI method causes
firefox on windows to crash.
Fix:
===
Disabling the failing tests, with a TODO to fix them before shipping
GWT2.0.
Please review this at http://gwt-code-reviews.appspot
Revision: 6393
Author: rda...@google.com
Date: Fri Oct 16 09:44:44 2009
Log: Add license info for the Free BSD License, since we're bundling the
protobuf library in gwt-dev.jar.
http://code.google.com/p/google-web-toolkit/source/detail?r=6393
Modified:
/branches/remote-ui-communication/distro
Comment by claude...@gmail.com:
my previous post...it worked on one machine, but on another, with a fresh
install of iceweasel, it didn't worked! I am really without a clue about
this!
For more information:
http://code.google.com/p/google-web-toolkit/wiki/UsingOOPHM
--~--~-~--~
Revision: 6395
Author: sco...@google.com
Date: Fri Oct 16 10:59:37 2009
Log: Adds com/google/gwt/soyc/** to standalone compiler.
There are now direct code references from the standalone compiler to the
soyc package, fixing the build rules to reflect this dependency.
Review by: kprobst (desk)
Reviewers: ,
Please review this at http://gwt-code-reviews.appspot.com/81802
Affected files:
A user/src/com/google/gwt/uibinder/parsers/TabLayoutPanelParser.java
M user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
M user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java
Reviewers: Ray Ryan,
Please review this at http://gwt-code-reviews.appspot.com/81801
Affected files:
A user/javadoc/com/google/gwt/examples/TabLayoutPanelExample.java
A user/src/com/google/gwt/uibinder/parsers/TabLayoutPanelParser.java
M user/src/com/google/gwt/uibinder/rebind/UiBinde
Revision: 6394
Author: rda...@google.com
Date: Fri Oct 16 09:44:49 2009
Log: Moved protobuf library into a temporary directory as part of this
branch. More discussion is needed before we drop it into GWT_TOOLS proper.
http://code.google.com/p/google-web-toolkit/source/detail?r=6394
Added:
/
Thanks for the review. Final commit rev: r6394
http://gwt-code-reviews.appspot.com/77830
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6392
Author: rda...@google.com
Date: Fri Oct 16 09:44:38 2009
Log: Add protobuf library, which is required by the generated Java files.
http://code.google.com/p/google-web-toolkit/source/detail?r=6392
Added:
/branches/remote-ui-communication/dev/core/src/com/google/gwt/dev/shell/rem
Revision: 6391
Author: jlaba...@google.com
Date: Fri Oct 16 09:36:03 2009
Log: Adding more parallization of test targets, preventing compilation for
each target, and adding option to selectively disable targets.
Patch by: jlabanca
Review by: jat
http://code.google.com/p/google-web-toolkit/sou
LGTM
http://gwt-code-reviews.appspot.com/77830
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: jat,
Description:
Description:
===
The default ant test target in trunk/user/build.xml runs all test
targets by default. Since we generally run the test target in
trunk/build.xml, there isn't a good way to selectively run test targets.
Fix:
Adding disable options to some
Reviewers: mmendez, jat,
Description:
Added the Java file that was generated from running the protobuf
compiler on remotemessage.proto.
Added the Protobuf 2.2.0 library, along with necessary licensing changes
and build changed. I did not add this library to GWT Tools proper as
yet, as some more
Comment by claude...@gmail.com:
After suffering a little to get an OOPHM plugin working on debian
Iceweasel, I've got success and are making my notes here... hope to help
somebody on getting it work too:
On Debian Lenny, with iceweasel (Firefox re-branded) 3.0.6 the .xpi file
from this pag
http://gwt-code-reviews.appspot.com/80801/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/impl/flow/ClInitPruner.java
(right):
http://gwt-code-reviews.appspot.com/80801/diff/1/2#newcode63
Line 63: tracer.inc(Tracing.COUNT_PRUNABLE_CLINIT);
Everything looks beautiful except here. Where is the
51 matches
Mail list logo
