This change appear to have broken all of my scrollable content in
IE6/7. What I see now is the scroll panel with scrollbar and the
content exceeding the bounds of the scrollpanel. Interaction with the
scrollbar has no effect on the content.
The use of the ScrollPanels and their child Widgets
LGTM
http://gwt-code-reviews.appspot.com/78821/diff/2006/1009
File user/src/com/google/gwt/uibinder/parsers/TabPanelParser.java
(right):
http://gwt-code-reviews.appspot.com/78821/diff/2006/1009#newcode33
Line 33: writer.warn(
This pattern keeps reappearing. Would it make sense to move this to
http://gwt-code-reviews.appspot.com/88803/diff/1/2
File dev/core/src/com/google/gwt/dev/js/JsStaticEval.java (right):
http://gwt-code-reviews.appspot.com/88803/diff/1/2#newcode417
Line 417:
Extra whitespace.
http://gwt-code-reviews.appspot.com/88803/diff/1/2#newcode495
Line 495: }
As a sanity
Revision: 6502
Author: jlaba...@google.com
Date: Wed Oct 28 06:47:22 2009
Log: Moving the Plural Forms example from the I18N sample to Showcase.
Patch by: jlabanca
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6502
Added:
Revision: 6503
Author: jlaba...@google.com
Date: Wed Oct 28 06:49:26 2009
Log: Removing I18N sample now that it has been incorporated into Showcase.
Patch by: jlabanca
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6503
Deleted:
/trunk/eclipse/samples/I18N
Todd, can you send a sample that demonstrates the problem? Also, is your
page in standards mode?
On Oct 28, 2009 5:40 AM, todd.sei...@gmail.com todd.sei...@gmail.com
wrote:
This change appear to have broken all of my scrollable content in
IE6/7. What I see now is the scroll panel with
Revision: 6504
Author: b...@google.com
Date: Wed Oct 28 07:06:41 2009
Log: Improve UiBinder+CssResource compile speed by caching results of
GenerateCssAst.exec()
Patch by: bobv
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=6504
Modified:
Revision: 6505
Author: b...@google.com
Date: Wed Oct 28 07:06:55 2009
Log: Prevent duplicate data from being emitted by MhtmlResourceContext.
Patch by: bobv
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=6505
Modified:
Revision: 6506
Author: b...@google.com
Date: Wed Oct 28 07:07:10 2009
Log: Add caching to ImageResourceGenerator to re-use work across
permutations.
Patch by: bobv
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=6506
Modified:
Revision: 6507
Author: b...@google.com
Date: Wed Oct 28 07:24:14 2009
Log: Merge r6504-6506 from trunk to improve ClientBundle code generator
performance.
$ svn merge --ignore-ancestry -c 6504,6505,6506
https://google-web-toolkit.googlecode.com/svn/trunk .
LGTM.
Lex Spoon
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6509
Author: b...@google.com
Date: Wed Oct 28 09:08:06 2009
Log: Edited wiki page through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=6509
Modified:
/wiki/CssResource.wiki
===
--- /wiki/CssResource.wiki Mon
Revision: 6510
Author: sco...@google.com
Date: Wed Oct 28 09:10:53 2009
Log: Fixing svn props on many java files where this was missing.
http://code.google.com/p/google-web-toolkit/source/detail?r=6510
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/soyc/ClassMember.java
Reviewers: jat, mmendez,
Description:
Per request from Miguel, some code cleanups.
Please review this at http://gwt-code-reviews.appspot.com/88805
Affected files:
dev/core/src/com/google/gwt/dev/CompileTaskRunner.java
dev/core/src/com/google/gwt/dev/ModulePanel.java
Revision: 6511
Author: sco...@google.com
Date: Wed Oct 28 09:26:56 2009
Log: IO improvements to DiskCache and UnifiedAST.
- Renamed writeTo to transferToStream to avoid the confusion that it
actually does the opposite of the other write methods, and added its
inverse transferFromStream.
-
LGTM
http://gwt-code-reviews.appspot.com/88805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: jlabanca,
Please review this at http://gwt-code-reviews.appspot.com/88806
Affected files:
dev/core/test/com/google/gwt/core/ext/typeinfo/test/PrimitiveValuesAnnotation.java
user/test/org/apache/commons/collections/TestMap.java
Index:
Reviewers: scottb,
Please review this at http://gwt-code-reviews.appspot.com/89801
Affected files:
dev/core/src/com/google/gwt/core/linker/SingleScriptLinker.java
doc/build.xml
user/src/com/google/gwt/resources/ext/ResourceContext.java
Revision: 6512
Author: sco...@google.com
Date: Wed Oct 28 09:58:30 2009
Log: JUnitShell incorrectly computed numClients due to out-of-order
execution.
We now go ahead and instantiate run styles during arg processing.
Review by: jlabanca (desk)
On Tue, Oct 27, 2009 at 11:54 PM, j...@google.com wrote:
http://gwt-code-reviews.appspot.com/86809/diff/1/2#newcode119
Line 119: echo message= or -Dgwt.selenium.hosts, but that's all./
On 2009/10/28 03:00:56, zundel wrote:
I know this is just temporary, but its too bad the top level test
LGTM
http://gwt-code-reviews.appspot.com/88806
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6513
Author: r...@google.com
Date: Wed Oct 28 10:23:46 2009
Log: Remove two unused imports
Review by: jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=6513
Modified:
/trunk/dev/core/test/com/google/gwt/core/ext/typeinfo/test/PrimitiveValuesAnnotation.java
Mostly questions, and generally speaking you should select the
containing comment blocks and autoformat them into shape (don't
necessarily do the whole file as it generates diff cheese).
http://gwt-code-reviews.appspot.com/89801/diff/1/2
File
Revision: 6514
Author: sco...@google.com
Date: Wed Oct 28 10:56:52 2009
Log: Code cleanup forCompositeTreeLogger, AbstractTreeLogger
- Removes access to AbstractTreeLogger.indexWithinMyParent
- CompositeTreeLogger now extends TreeLogger directly and composes
TreeLoggers, rather than
http://gwt-code-reviews.appspot.com/89801/diff/1/7
File user/src/com/google/gwt/user/client/ui/LayoutPanel.java (right):
http://gwt-code-reviews.appspot.com/89801/diff/1/7#newcode23
Line 23: * A panel that lays its children out in arbitrary {...@link
com.google.gwt.layout.client.Layout.Layer
Revision: 6515
Author: jlaba...@google.com
Date: Wed Oct 28 11:45:03 2009
Log: Fixes a bug where JavaToJavaScriptCompiler assumes
PropertyOracle#getSelectionProperty will return null if a property is not
defined, but it actually throws a BadPropertyException.
Patch by: jlabanca
Review by:
Revision: 6517
Author: jlaba...@google.com
Date: Wed Oct 28 12:36:51 2009
Log: Ensure that MhtmlClientBundleGenerator#createResourceContext generates
unique strong names.
Patch by: jlabanca
Review by: bobv
http://code.google.com/p/google-web-toolkit/source/detail?r=6517
Modified:
Revision: 6518
Author: jlaba...@google.com
Date: Wed Oct 28 12:39:55 2009
Log: tr...@6517 was merged into this branch
Ensure MhtmlClientBundleGenerator#createResourceContext generates unique
strong names
svn merge --ignore-ancestry -c 6517
Reviewers: Ray Ryan,
Description:
The arrow in the DisclosurePanel images isn't flipped in RTL, but it
should be. I added the flipRtl ImageOption and verified it worked in
Showcase.
Please review this at http://gwt-code-reviews.appspot.com/89802
Affected files:
LGTM
Oops, thanks.
http://gwt-code-reviews.appspot.com/89802
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6519
Author: jlaba...@google.com
Date: Wed Oct 28 12:54:20 2009
Log: Flipping DisclosurePanel arrow in RTL.
Patch by: jlabanca
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=6519
Modified:
Revision: 6521
Author: jlaba...@google.com
Date: Wed Oct 28 12:56:30 2009
Log: tr...@6519 was merged into this branch
Flipping DisclosurePanel image in RTL
svn merge --ignore-ancestry -c 6519
http://google-web-toolkit.googlecode.com/svn/trunk/ .
Patch by: jlabanca
Revision: 6522
Author: jlaba...@google.com
Date: Wed Oct 28 13:23:35 2009
Log: tr...@6512 was merged into this branch
JUnitShell incorrectly computed numClients due to out-of-order execution
svn merge --ignore-ancestry -c 6512
http://google-web-toolkit.googlecode.com/svn/trunk/ .
Reviewers: jlabanca,
Description:
Simple patch to adjust timeout based on BatchingStrategy
Please review this at http://gwt-code-reviews.appspot.com/88808
Affected files:
user/src/com/google/gwt/junit/BatchingStrategy.java
user/src/com/google/gwt/junit/JUnitShell.java
Index:
LGTM
http://gwt-code-reviews.appspot.com/88808
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: Ray Ryan,
Please review this at http://gwt-code-reviews.appspot.com/88809
Affected files:
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
Index: user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
Revision: 6523
Author: amitman...@google.com
Date: Wed Oct 28 13:37:33 2009
Log: Adjust test timeout value based on Batching Strategy.
Patch by: amitmanjhi
Review by: jlabanca
http://code.google.com/p/google-web-toolkit/source/detail?r=6523
Modified:
Reviewers: jlabanca,
Please review this at http://gwt-code-reviews.appspot.com/89803
Affected files:
user/build.xml
user/src/com/google/gwt/junit/JUnitShell.java
user/src/com/google/gwt/junit/public/junit-standards.html
Revision: 6524
Author: rj...@google.com
Date: Wed Oct 28 14:01:38 2009
Log: Deprecate panels that have LayoutPanel alternatives.
Fix NPE in TabPanelParser.
Review by jgw, bobv
http://code.google.com/p/google-web-toolkit/source/detail?r=6524
Modified:
Revision: 6525
Author: sco...@google.com
Date: Wed Oct 28 14:05:19 2009
Log: Fixes checkstyle for gwt-dev project.
http://code.google.com/p/google-web-toolkit/source/detail?r=6525
Modified:
/trunk/eclipse/dev/.checkstyle
/trunk/eclipse/dev/.project
===
http://gwt-code-reviews.appspot.com/88809/diff/1/2
File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
(right):
http://gwt-code-reviews.appspot.com/88809/diff/1/2#newcode277
Line 277: die(No implemented interfaces present on type %s,
baseClass.getName());
Did you actually see this
Committed r6524
http://gwt-code-reviews.appspot.com/78821
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
LGTM.
http://gwt-code-reviews.appspot.com/88810
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6526
Author: j...@google.com
Date: Wed Oct 28 14:56:25 2009
Log: Remove use of printf.
http://code.google.com/p/google-web-toolkit/source/detail?r=6526
Modified:
/changes/jat/single-xpi/plugins/common/Debug.cpp
===
---
And merged into releases/2.0 at 6527
http://gwt-code-reviews.appspot.com/78821
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6527
Author: rj...@google.com
Date: Wed Oct 28 14:57:48 2009
Log: Merge tr...@6524 into releases/2.0
Deprecate panels that have LayoutPanel alternatives
svn merge --ignore-ancestry -c 6524
https://google-web-toolkit.googlecode.com/svn/trunk .
Reviewers: robertvawter_google.com,
Message:
Review, please.
Description:
Fix various error reporting issues
Please review this at http://gwt-code-reviews.appspot.com/88811
Affected files:
M user/src/com/google/gwt/uibinder/parsers/CellPanelParser.java
M
Hi Ray,
http://codereview.appspot.com/144046
The only thing controversial is that I'm including only the .client package
for now. It wasn't clear what else should go in there.
-- Bruce
P.S. What's up with these guys: .sample, .testing, and .resources? Seems
like there are already established
LGTM
http://gwt-code-reviews.appspot.com/89803
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Reviewers: Lex, cromwellian_google.com, mike.aizatsky,
Description:
(All the more proof we need better, more intuitive optimization
mechanisms than static impls.)
Fixes a very obscure bug in ControlFlowAnalyzer.
In TypeTightener, we create synthetic references between an instance
method and
Revision: 6529
Author: rj...@google.com
Date: Wed Oct 28 15:52:50 2009
Log: Restore tr...@6519, Flipping DisclosurePanel arrow in RTL., which
didn't break anything at all.
This reverts commit 102f96b9ee3c0d2e53fefe2e67876384efabd935.
On Wed, Oct 28, 2009 at 6:38 PM, Ray Ryan rj...@google.com wrote:
We usually use gwt-code-reviews.appspot.com, but LGTM'd anyway.
Oh yeah -- thanks. Duh.
Testing is on its way out of user/src and into user/testing, review
pending.
'k.
sample isn't really a sample, it's become a test
Revision: 6528
Author: rj...@google.com
Date: Wed Oct 28 15:19:45 2009
Log: Revert tr...@6519, Flipping DisclosurePanel arrow in RTL.,
due to build break on IE7:
Scanning for additional dependencies:
[...]com/google/gwt/user/client/ui/FormPanel.java
[WARN] For the following type(s),
Hmm.
Seeing as this patch already included the move of testing from src to
test, I expanded its scope to include moving the entire test app as
well. Rietveld doesn't seem to understand moves, though.
You okay with the larded up patch, or should I back the moves out?
Nevermind, answered my own question. I'll do the move after this one
lands.
http://gwt-code-reviews.appspot.com/88811
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Passes blaze test.
http://gwt-code-reviews.appspot.com/89804
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
On 2009/10/28 23:11:37, scottb wrote:
Passes blaze test.
LGTM, but it makes me curious if other classes of these bugs exist.
http://gwt-code-reviews.appspot.com/89804
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 6531
Author: sco...@google.com
Date: Wed Oct 28 16:24:29 2009
Log: Adds selenium v1.0.1 to tools, which supports Google Chrome.
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=6531
Added:
/tools/lib/selenium/1.0.1
One more tweak: bad root element is an error, not a warning.
http://gwt-code-reviews.appspot.com/88811
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6532
Author: sco...@google.com
Date: Wed Oct 28 16:53:03 2009
Log: Fixes a very obscure bug in ControlFlowAnalyzer.
In TypeTightener, we create synthetic references between an instance method
and its staticImpl, to guard against the case where the instance method
inlines the static
Revision: 6533
Author: sco...@google.com
Date: Wed Oct 28 16:56:19 2009
Log: Rewrites some if statements into boolean expressions.
if (cond) { expr_stmt; } = cond expr_stmt
if (cond) { then_expr_stmt; } else { else_expr_stmt; } =
cond ? then_expr_stmt : else_expr_stmt
Also supports
The + -0 case won't optimize because there isn't unary operator
optimizer that will treat negative zero as zero.
On 2009/10/28 13:41:31, bobv wrote:
http://gwt-code-reviews.appspot.com/88803/diff/1/2
File dev/core/src/com/google/gwt/dev/js/JsStaticEval.java (right):
Revision: 6535
Author: sco...@google.com
Date: Wed Oct 28 17:30:02 2009
Log: We were failing to close the newly-opened FileInputStream, and
thankfully StandardGeneratorContextTest caught it.
BUILD FIX: r6511
Review by: spoon (TBR)
Revision: 6536
Author: amitman...@google.com
Date: Wed Oct 28 17:37:45 2009
Log: During a module transition, remove all enqueued JS jobs. Seems to fix
the
timeouts in UISuite.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
http://code.google.com/p/google-web-toolkit/source/detail?r=6536
Desk review by Amit, submitting.
http://gwt-code-reviews.appspot.com/88811
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Revision: 6537
Author: amitman...@google.com
Date: Wed Oct 28 19:23:32 2009
Log: Merged c6472, c6476, c6523, and c6536 from trunk
Patch by: amitmanjhi
http://code.google.com/p/google-web-toolkit/source/detail?r=6537
Modified:
/releases/2.0/branch-info.txt
Reviewers: scottb,
Description:
Two issues here, both arguably ant bugs. Although the scripts have
correct perms, and zip creates a non-executable copy unless you
explicitly set fileperm in the zipfileset. That gets you a correct
build/dist/gwt-X.X.X.zip, and unzip will do the right thing with
Reviewers: ,
Description:
Two issues here, both arguably ant bugs. Although the scripts have
correct perms, and zip creates a non-executable copy unless you
explicitly set fileperm in the zipfileset. That gets you a correct
build/dist/gwt-X.X.X.zip, and unzip will do the right thing with it...
Sorry for the double-file; I got a 500 server error so retried, but it
apparently did the right thing.
On Thu, Oct 29, 2009 at 1:38 AM, fabb...@google.com wrote:
Reviewers: ,
Description:
Two issues here, both arguably ant bugs. Although the scripts have
correct perms, and zip creates a
69 matches
Mail list logo
