The Rietveld link does not seem to be working, but LGTM.
On Wed, Nov 18, 2009 at 5:18 PM, mmen...@google.com wrote:
Reviewers: rdayal, jat,
Please review this at http://gwt-code-reviews.appspot.com/103813
Affected files:
M dev/core/src/com/google/gwt/dev/DevModeBase.java
Index:
Thanks. I ended up deleting the issue because Bruce committed a fix
separately. Thanks for looking at it though.
On Thu, Nov 19, 2009 at 9:14 AM, Rajeev Dayal rda...@google.com wrote:
The Rietveld link does not seem to be working, but LGTM.
On Wed, Nov 18, 2009 at 5:18 PM,
Hi all,
I've been writing a GWT library to implement the command pattern for GWT RPC
calls using the same interfaces that traditional GWT RPC uses. Basically,
when an app calls a method of the FooAsync action service interface, an
action object is created from the method arguments, processed by
Hi,
I follow what you are trying to do, it would solve some complexity on
the server side.
But one of the main benefits of using the command pattern is that you
only need one client API call. In case of GWT it means that you write
onesync and async interface with one method... and from there on
Reviewers: Lex,
Description:
Hi Lex,
the previous two patches have implications for SoycTest, which needed to
be updated slightly. This patch does that. Could you review it for me?
Thanks,
kathrin
Please review this at http://gwt-code-reviews.appspot.com/105801
Affected files:
There are errors in the latest version from SVN:
Created dir: C:\Program Files\GWT\gwt\trunk\build\out\dev\bin
gwt.javac
Compiling 5 source files to C:\Program Files\GWT\gwt\trunk\build\out
\dev\bin
gwt.javac
Compiling 675 source files to C:\Program Files\GWT\gwt\trunk\build\out
\dev\bin
I mean #7020
On Nov 19, 12:27 pm, aris ari09845...@gmail.com wrote:
There are errors in the latest version from SVN:
Created dir: C:\Program Files\GWT\gwt\trunk\build\out\dev\bin
gwt.javac
Compiling 5 source files to C:\Program Files\GWT\gwt\trunk\build\out
\dev\bin
gwt.javac
Compiling
http://gwt-code-reviews.appspot.com/103812/diff/5/1003
File dev/core/src/com/google/gwt/dev/DevMode.java (right):
http://gwt-code-reviews.appspot.com/103812/diff/5/1003#newcode234
Line 234: public static boolean isUsingRemoteUI() {
I agree that the code should be in DevModeBase and that we
Bob: you were supposed to review+commit a fix for this a week ago. :)
http://gwt-code-reviews.appspot.com/102808/show
On Thu, Nov 19, 2009 at 4:57 AM, Matt Mastracci matt...@mastracci.comwrote:
Hey all,
I'm in the process of upgrading our really old trunk snapshot to 2.0-
RC1 and I'm
@Matt: IIRC you are hittnig this because you have a parse error in one of
your JSNI methods. Either apply my patch and try it again, or else binary
search for the offending method by commenting hafl of them out at a time.
The good news is the error will likely repro in hosted mode, so it
I think I had this problem, and it was inside this class:
public class FlickrActivityEvent extends JavaScriptObject
{
protected FlickrActivityEvent() {}
public final native String getType() /*-{ return this.[type]; }-
*/;
public final native String getUser() /*-{ return this.user;
Hi,
since a few weeks Avira AntiVir is generating warnings when accessing
gwt-generated files:
When accessing data from the URL, http://
allcontacts.southpolecarbon.com/sharedcontacts/
C7C22E75261E4D2C9C7FAF82B71C40B0.cache.html
a virus or unwanted program 'HTML/Crypted.Gen' [virus] was found.
But one of the main benefits of using the command pattern is that you
only need one client API call.
I guess it's a matter of opinion, but I always saw that as an implementation
detail that gets exposed to any code that wants to use the RPC service. My
goal in writing gwt-remote-action was to
Reviewers: mmendez,
Description:
There were a few user-visible references missed, and I cleaned up
javadoc as well.
Please review this at http://gwt-code-reviews.appspot.com/105802
Affected files:
dev/core/src/com/google/gwt/dev/shell/BrowserChannelServer.java
LGTM with one nit. Consider removing the @param or @throws tags that
have no associated explanation or filling that explanation in.
http://gwt-code-reviews.appspot.com/105802
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7022
Author: amitman...@google.com
Date: Thu Nov 19 10:39:53 2009
Log: Removes the now unnecessary mac-specific scripts.
Patch by: amitmanjhi
Review by: jat (desk review)
http://code.google.com/p/google-web-toolkit/source/detail?r=7022
Deleted:
Revision: 7023
Author: amitman...@google.com
Date: Thu Nov 19 10:43:12 2009
Log: Merge tr...@7022 into this branch -- remove the now unnecessary
mac-specific scripts
Patch by: amitmanjhi
http://code.google.com/p/google-web-toolkit/source/detail?r=7023
Deleted:
Thanks, Scott. I'm applying it now and building GWT. It's been
catching some JSNI refs in the GWT source, possibly some false-
positive (the JSONParser ones seem to be valid?). The build doesn't
actually fail, though:
[java] [WARN] Warnings in 'jar:file:/Users/matthew/
Revision: 7024
Author: j...@google.com
Date: Thu Nov 19 10:58:27 2009
Log: Fix remaining user-visible hosted references, cleanup javadoc.
Patch by: jat
Review by: mmendez
http://code.google.com/p/google-web-toolkit/source/detail?r=7024
Modified:
Reviewers: jat, knorton, bruce,
Description:
Remove distro-source/windows, distro-source/linux and distro-source/mac
dirs and their contents.
There is a libswt-webkit-carbon-3235.jnilib that looks safe to remove,
since I could not find any references to it. I just wanted to confirm
before
Revision: 7025
Author: j...@google.com
Date: Thu Nov 19 11:41:10 2009
Log: Merge trunk r7024 into this branch
Hosted = code server changes
svn merge --ignore-ancestry -c7024 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Reviewers: amitmanjhi,
Please review this at http://gwt-code-reviews.appspot.com/105805
Affected files:
user/src/com/google/gwt/junit/JUnitShell.java
Index: user/src/com/google/gwt/junit/JUnitShell.java
===
---
LGTM, if the tests pass.
http://gwt-code-reviews.appspot.com/105805/diff/1/2
File user/src/com/google/gwt/junit/JUnitShell.java (right):
http://gwt-code-reviews.appspot.com/105805/diff/1/2#newcode751
Line 751: // CHECKSTYLE_ON
Please confirm that this change works.
[Somehow, I got an error from the mail delivery system the first time.
Apologies if you have already received it]
Description:
Remove distro-source/windows, distro-source/linux and distro-source/mac
dirs and their contents.
There is a libswt-webkit-carbon-3235.jnilib that looks safe to remove,
Nearly there.
Do you need me to take this over?
http://gwt-code-reviews.appspot.com/103806/diff/2001/3002
File
user/src/com/google/gwt/uibinder/attributeparsers/AttributeParsers.java
(right):
http://gwt-code-reviews.appspot.com/103806/diff/2001/3002#newcode84
Line 84: addAttributeParser(UNIT,
Revision: 7026
Author: j...@google.com
Date: Thu Nov 19 12:20:58 2009
Log: Fix for bug introduced in r6354. While fixing an
extra-horizontal-overflow bug on IE, we accidentally introduced a bug in
ScrollPanel rendering in IE6/7-quirks. Turns out both divs needed to be
position:relative. Go figure.
Revision: 7027
Author: j...@google.com
Date: Thu Nov 19 12:24:42 2009
Log: Rearrange how module logging is handled.
Patch by: jat
Review by: rdayal
http://code.google.com/p/google-web-toolkit/source/detail?r=7027
Added:
/trunk/dev/core/src/com/google/gwt/dev/ModuleHandle.java
Modified:
Revision: 7028
Author: j...@google.com
Date: Thu Nov 19 12:29:02 2009
Log: Merging trunk c7026 into this branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=7028
Modified:
/releases/2.0/branch-info.txt
/releases/2.0/user/src/com/google/gwt/user/client/ui/ScrollPanel.java
Revision: 7029
Author: fabb...@google.com
Date: Thu Nov 19 12:33:51 2009
Log: merge fix for IE7 standards-mode ScrollPanel overflow bug (r7026)
http://code.google.com/p/google-web-toolkit/source/detail?r=7029
Modified:
/branches/snapshot-2009.10.23-r6446
As per IM review, added tests for AbstractString, and
for graceful fail with conflicting generic return types. That is,
we don't tolerate the following, but at least we don't generated bad
code for it:
@UiFactory
FooBar getFooBar() { ... }
@UiFactory
FooBaz getFooBaze() { ... }
Submitting soon.
Revision: 7030
Author: j...@google.com
Date: Thu Nov 19 12:57:33 2009
Log: Adds parsers for LayoutPanel and Length attributes.
Review: http://gwt-code-reviews.appspot.com/103806
http://code.google.com/p/google-web-toolkit/source/detail?r=7030
Added:
Reviewers: jat,
Please review this at http://gwt-code-reviews.appspot.com/106802
Affected files:
user/src/com/google/gwt/json/client/JSONObject.java
Index: user/src/com/google/gwt/json/client/JSONObject.java
===
---
Revision: 7031
Author: j...@google.com
Date: Thu Nov 19 13:02:01 2009
Log: Merging trunk c7030 into this branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=7031
Added:
/releases/2.0/user/src/com/google/gwt/uibinder/attributeparsers/LengthAttributeParser.java
Thanks for the reviews guys! Updated patch based on both of your
comments. I've ditched the system property in favor of exposing a setter
on JettyLauncher for the base log level. While this is still not ideal,
it's less hacky than the previous solution.
http://gwt-code-reviews.appspot.com/103812
Revision: 7032
Author: rj...@google.com
Date: Thu Nov 19 13:38:23 2009
Log: Improves @UiFactory's handling of generics from catastrophic to
inadequate.
We were generating bad code when @UiFactory was put
on a method with a parameterized return type. The
solution here is simplistic, treating
Mostly LGTM
http://gwt-code-reviews.appspot.com/103812/diff/2002/2003
File dev/core/src/com/google/gwt/dev/DevMode.java (right):
http://gwt-code-reviews.appspot.com/103812/diff/2002/2003#newcode359
Line 359: ((JettyLauncher) scl).setBaseLogLevel(getBaseLogLevelForUI());
What about GAE or other
Revision: 7033
Author: sco...@google.com
Date: Thu Nov 19 13:48:07 2009
Log: Fixes an NPE in JsniChecker; improves test coverage on JsniCollector
and JsniChecker.
Review by: bobv
http://code.google.com/p/google-web-toolkit/source/detail?r=7033
Added:
Reviewers: Ray Ryan,
Description:
CookieTest expects a cookie to expire in 5 seconds based on the host
time with a 1000ms window of error. If the client time is more than
1000ms behind the host time, the cookie will not expire and the test
fails. In our test infrastructure, this is sometimes
Revision: 7034
Author: sco...@google.com
Date: Thu Nov 19 13:48:22 2009
Log: JsniChecker should support the ::new syntax.
Review by: bobv
http://code.google.com/p/google-web-toolkit/source/detail?r=7034
Modified:
/trunk/dev/core/src/com/google/gwt/dev/javac/JsniChecker.java
Revision: 7035
Author: sco...@google.com
Date: Thu Nov 19 13:48:42 2009
Log: In JsniChecker, suppressed warnings should cascade down to nested
members.
FieldSerializerCreator suppresses deprecation warnings on generated field
serializers, which silences warnings regarding the deprecated
Looks right, but questions since I don't know this world.
http://gwt-code-reviews.appspot.com/106803/diff/18/19
File user/src/com/google/gwt/rpc/server/RPC.java (right):
http://gwt-code-reviews.appspot.com/106803/diff/18/19#newcode217
Line 217: throw new SerializationException(
I take it
Revision: 7036
Author: sco...@google.com
Date: Thu Nov 19 13:48:55 2009
Log: JUnit's -noserver option was not actually doing anything useful.
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7036
Modified:
/trunk/dev/core/src/com/google/gwt/dev/GWTShell.java
Yeah, sorry about that,. I just checked a bunch of stuff into trunk that
should fix this.
On Thu, Nov 19, 2009 at 1:50 PM, Matt Mastracci matt...@mastracci.comwrote:
Thanks, Scott. I'm applying it now and building GWT. It's been catching
some JSNI refs in the GWT source, possibly some
LGTM
http://gwt-code-reviews.appspot.com/105807
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7037
Author: sco...@google.com
Date: Thu Nov 19 13:49:05 2009
Log: GWTShell must not link public and autogenerated artifacts into the
shell generated resource directory.
A generated selection script from a previous dev run could be served
instead of a compiled selection script from
Reviewers: Ray Ryan,
http://gwt-code-reviews.appspot.com/106803/diff/18/19
File user/src/com/google/gwt/rpc/server/RPC.java (right):
http://gwt-code-reviews.appspot.com/106803/diff/18/19#newcode217
Line 217: throw new SerializationException(
Yes, this gets handled in the same way as any other
Revision: 7038
Author: j...@google.com
Date: Thu Nov 19 13:50:21 2009
Log: Merge trunk r7027 into this branch
Module logging changes
svn merge --ignore-ancestry -c7027 \
https://google-web-toolkit.googlecode.com/svn/trunk/ .
Revision: 7039
Author: sco...@google.com
Date: Thu Nov 19 13:51:02 2009
Log: Fix up native lines + mime type svn props.
http://code.google.com/p/google-web-toolkit/source/detail?r=7039
Modified:
/trunk/dev/core/test/com/google/gwt/dev/javac/JsniCollectorTest.java
--
Revision: 7041
Author: jlaba...@google.com
Date: Thu Nov 19 14:14:42 2009
Log: Using client time for CookieTest to ensure cookies expire when
expected.
Patch by: jlabanca
Review by: rjrjr
http://code.google.com/p/google-web-toolkit/source/detail?r=7041
Modified:
LGTM
http://gwt-code-reviews.appspot.com/106803
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hey all,
I'm continuing my push forward to GWT 2.0-RC1 and I'm running into
some crashiness in OOPHM. I'm still trying to narrow down exactly
what causes it, but this is a common, reproducible crash that I'm
seeing:
Revision: 7042
Author: jlaba...@google.com
Date: Thu Nov 19 14:17:04 2009
Log: tr...@7041 was merged into this branch
Making CookieTest use client time to set cookie expiration.
svn merge --ignore-ancestry -c 7041
https://google-web-toolkit.googlecode.com/svn/trunk .
Patch by: jlabanca
Revision: 7043
Author: rice+leg...@google.com
Date: Thu Nov 19 14:22:49 2009
Log: Work around Firefox issue where hasOwnProperty(new String(key)) fails
Review by: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7043
Modified:
Thanks for the review.
http://gwt-code-reviews.appspot.com/103812/diff/2002/2003
File dev/core/src/com/google/gwt/dev/DevMode.java (right):
http://gwt-code-reviews.appspot.com/103812/diff/2002/2003#newcode359
Line 359: ((JettyLauncher) scl).setBaseLogLevel(getBaseLogLevelForUI());
On 2009/11/19
Revision: 7044
Author: rice+leg...@google.com
Date: Thu Nov 19 14:23:20 2009
Log: Fix mentions of 'hosted mode' in comments
TBR: jat
http://code.google.com/p/google-web-toolkit/source/detail?r=7044
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/ServletContainerLauncher.java
Reviewers: cramsdale,
Description:
The IE plugin installer currently installs some files in the Program
Files directory, and it is generally not setup to run without elevation
to Administrator.
Fix:
This patch allows the installer to install for the current user without
elevation. It does
Revision: 7045
Author: sco...@google.com
Date: Thu Nov 19 14:34:20 2009
Log: trunk c7033-c7039 were merged into this branch
Fixes an NPE in JsniChecker; improves test coverage on JsniCollector and
JsniChecker.
JsniChecker should support the ::new syntax.
In JsniChecker, suppressed
On Thu, Nov 19, 2009 at 5:23 PM, Matt Mastracci matt...@mastracci.comwrote:
I'm continuing my push forward to GWT 2.0-RC1 and I'm running into
some crashiness in OOPHM. I'm still trying to narrow down exactly
what causes it, but this is a common, reproducible crash that I'm
seeing:
Revision: 7046
Author: rda...@google.com
Date: Thu Nov 19 14:35:03 2009
Log: Drop Request/Response Logging Levels down to TRACE when using the
Remote UI. A bit of a hack had to be added to achieve this; we'll have to
think of an improved way to pass this type of information to other areas of
Committed as tr...@r7406 and cherry-picked into releases/2.0 at r7407.
http://gwt-code-reviews.appspot.com/103812
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 7047
Author: rda...@google.com
Date: Thu Nov 19 14:41:30 2009
Log: Merge tr...@r7046 into releases/2.0. Command used to perform this
merge was:
svn merge -c7046 --ignore-ancestry
http://google-web-toolkit.googlecode.com/svn/trunk .
Revision: 7048
Author: rda...@google.com
Date: Thu Nov 19 14:43:14 2009
Log: Updated branch-info.txt to reflect the merge of tr...@r7406 into this
branch at r7407.
http://code.google.com/p/google-web-toolkit/source/detail?r=7048
Modified:
/releases/2.0/branch-info.txt
Revision: 7049
Author: b...@google.com
Date: Thu Nov 19 14:53:22 2009
Log: Don't attempt to throw random RuntimeExceptions over the wire to the
client in deRPC.
- The client probably doesn't have that RuntimeException compiled into it.
- RuntimeExceptions from backend code might leak data
Reviewers: rice+legacy,
Description:
Hi Dan, small review: this is what I was getting at about merging the
module pinning and no refresh on first load together.
Please review this at http://gwt-code-reviews.appspot.com/106805
Affected files:
dev/core/src/com/google/gwt/dev/DevMode.java
Thanks for the quick fix. The stricter JSNI parser caught some pretty
brain-dead JSNI generation errors on my part, which I'm happy to see.
Matt.
On Thu, Nov 19, 2009 at 3:01 PM, Scott Blum sco...@google.com wrote:
Yeah, sorry about that,. I just checked a bunch of stuff into trunk that
w00t! I'm so happy you said that, I was really hoping the possible
annoyance factor of some false alarms would be outweighed by actually
helping people catch errors more quickly.
On Thu, Nov 19, 2009 at 6:17 PM, Matthew Mastracci matt...@mastracci.comwrote:
Thanks for the quick fix. The
I assume that uninstallation is handled by the .msi that installed the
components in the first place, and as such this patch does not need to
account for uninstallation of the RC plugin. Correct?
http://gwt-code-reviews.appspot.com/106804
--
I believe that is correct, but we should try it.
Thanks,
John LaBanca
jlaba...@google.com
On Thu, Nov 19, 2009 at 7:11 PM, cramsd...@google.com wrote:
I assume that uninstallation is handled by the .msi that installed the
components in the first place, and as such this patch does not need to
Just to be clear:
In the case at hand, where the shared CSS file has nothing in it but @def
values, there is nothing to be gained by an approach that is any more
complicated than:
ui:style src='colors.css'
.foo { color: yellow; }
/ui:style
But if you want to share actual class definitions,
Hey all,
Sorry to keep spamming GWT 2.0 issues.
I've run into a difference in how TypeOracle works that seems to have
changed in GWT 2.0. In previous versions, calling
context.getTypeOracle().getTypes() from a generator would limit itself
to types available on the source paths. I have
Revision: 7050
Author: br...@google.com
Date: Thu Nov 19 19:49:52 2009
Log: Makes the -remoteUI flag undocumented. Cleans up the help text a
little for a variety of flags.
Change by: bruce
Review by: spoon (TBR)
http://code.google.com/p/google-web-toolkit/source/detail?r=7050
Modified:
Revision: 7051
Author: fabb...@google.com
Date: Thu Nov 19 20:23:38 2009
Log: Merge 6916, fix for soyc artifacts to be private
http://code.google.com/p/google-web-toolkit/source/detail?r=7051
Modified:
/branches/snapshot-2009.10.23-r6446/branch-info.txt
Revision: 7052
Author: br...@google.com
Date: Thu Nov 19 20:36:53 2009
Log: Merged in tr...@7050 to make -remoteUI flag to DevMode undocumented
and clean up other flag help text in the compiler.
http://code.google.com/p/google-web-toolkit/source/detail?r=7052
Modified:
Just wanted to update this example by noting that with the recent
changes this workaround no longer works. This is because the calls to
layout() are now delayed and scheduled after the current code
executes. I had to do this to get the map to layout correctly:
root.animate(0,
On 2009/11/20 00:10:32, bobv wrote:
Review requested.
LGTM.
My only question is anything required for STOB to handle declared
RuntimeExceptions, or is this only for deRPC?
http://gwt-code-reviews.appspot.com/106806
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
75 matches
Mail list logo
