Ping?
On 2010/04/19 19:48:53, rchandia wrote:
http://gwt-code-reviews.appspot.com/363801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/363801/diff/1/3
File bikeshed/src/com/google/gwt/collections/MutableArray.java (right):
http://gwt-code-reviews.appspot.com/363801/diff/1/3#newcode118
bikeshed/src/com/google/gwt/collections/MutableArray.java:118: int
oldLen = elems.length;
Why was the
Reviewers: jgw,
Description:
Fixes a bug in SplitLayoutPanel where calling setWidgetMinSize() on the
center widget, the last widget, or a widget that is not a child results
in an NPE or IndexOutOfBoundsException. The occured because
getAssocatedSplitter() had an off by one bug and didn't check
http://gwt-code-reviews.appspot.com/378802/diff/1/3
File user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java
(right):
http://gwt-code-reviews.appspot.com/378802/diff/1/3#newcode251
user/src/com/google/gwt/user/client/ui/SplitLayoutPanel.java:251:
assertIsChild(child);
This assertion is
LGTM
http://gwt-code-reviews.appspot.com/378802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jlabanca,
Description:
Reorganizes styles in bikeshed to use CssResource and ClientBundle.
Moves all styles in stock and cookbook samples to one place.
Removes the hovering boxes we stole from Wave for a slightly flatter
look.
Please review this at
Also removed spaces in blank lines
http://gwt-code-reviews.appspot.com/363801/diff/1/3
File bikeshed/src/com/google/gwt/collections/MutableArray.java (right):
http://gwt-code-reviews.appspot.com/363801/diff/1/3#newcode118
bikeshed/src/com/google/gwt/collections/MutableArray.java:118: int
Reviewers: jgw,
Description:
Refactoring Tree code. SideBySideTreeView now uses SimpleCellList,
which a protected method that allows users to use any ListView.
SideBySideTreeNodeView shares a lot of code with SimpleCellList. Added
animations to SideBySideTreeView. NodeInfo now includes a
http://gwt-code-reviews.appspot.com/390801/diff/1/3
File
bikeshed/src/com/google/gwt/bikeshed/cells/client/CompositeCell.java
(right):
http://gwt-code-reviews.appspot.com/390801/diff/1/3#newcode32
bikeshed/src/com/google/gwt/bikeshed/cells/client/CompositeCell.java:32:
public class
Reviewers: Ray Ryan,
Message:
Review requested.
Description:
This patch changes how UiBinder's compile-time DOM structure is
generated so that we can provide accurate location information to the
developer when logging errors. Instead of using a DOM parser, this
patch builds a DOM using a SAX
Reviewers: Ray Ryan,
Message:
Review requested.
Description:
This patch builds on the first by reworking callers of MortalLogger to
include a contextual XMLElement.
Please review this at http://gwt-code-reviews.appspot.com/395801/show
Affected files:
M
Thank you!
http://gwt-code-reviews.appspot.com/394801/diff/1/2
File user/src/com/google/gwt/uibinder/rebind/MortalLogger.java (right):
http://gwt-code-reviews.appspot.com/394801/diff/1/2#newcode102
user/src/com/google/gwt/uibinder/rebind/MortalLogger.java:102: +
location.getLineNumber() + ));
Holy cow!
Given this pass, and the fact that XMLElement#toString still sometimes
reaches the error log, I think you should get the line number and (huge)
file name out of XMLElement#toString
http://gwt-code-reviews.appspot.com/395801/show
--
Reviewers: jlabanca,
Description:
This patch
- Adds to webAppCreator the ability to create maven configuration file:
Issue_4878
- Fixes the Issue_4652 build.xml: compiles test classes in the same
directory as the source
- Adds tests to WebAppCreator
Please review this at
Mostly LGTM
A couple of nits, and one more significant.
http://gwt-code-reviews.appspot.com/397801/diff/1/3
File user/src/com/google/gwt/user/tools/README.txtsrc (right):
http://gwt-code-reviews.appspot.com/397801/diff/1/3#newcode75
user/src/com/google/gwt/user/tools/README.txtsrc:75: have
LGTM
WOOO HOO
http://gwt-code-reviews.appspot.com/379802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
16 matches
Mail list logo
