You're right, I didn't notice a record was being passed into the
constructor, just that the id was not longer being passed in.
For create, we would inject everything into the constructor and pass
0L to super.
For create, injection is still possible because we pass in an newly
created record to sup
I've been working on a patch that improves test integration when using
CssResource. The gist of the patch is that CssResource will have a
getDebugInfo() method that provides additional metadata about the
CssResource and all class selectors used in the input to a CssResource
will be available on a
http://gwt-code-reviews.appspot.com/750801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wed, Aug 4, 2010 at 6:10 AM, Moocar wrote:
> I'm trying to generate a bunch of ClientBundles with the associated
> images in the same directory. I can't figure out how to write the
> image files to the same directory as the java files generated with
> GeneratorContext.tryCreate(...).
UiBinder
Revision: 8543
Author: amitman...@google.com
Date: Mon Aug 16 06:28:43 2010
Log: Minor formatting fixes.
Patch by: amitmanjhi
http://code.google.com/p/google-web-toolkit/source/detail?r=8543
Modified:
/trunk/bikeshed/src/com/google/gwt/sample/expenses/gwt/client/ExpensesMobile.java
===
Reviewers: jat, knorton,
Description:
Added all safehtml packages.
Added new safehtml test suites.
Several changes for migration:
* Split EscapeUtils into EscapeUtils and UriUtils
* Added .equals() and .hashCode() to SafeHtmlString
* Updated comments, formatted code
* Removed i18n references
* Re
Revision: 8545
Author: gwt.mirror...@gmail.com
Date: Mon Aug 16 10:52:40 2010
Log: Exclude javax/validation files from eclipse-checkstyle check. Pattern
can be improved but this suffices.
Patch by: amitmanjhi
Review by: conroy
http://code.google.com/p/google-web-toolkit/source/detail?r=8545
http://gwt-code-reviews.appspot.com/770801/diff/1/5
File
user/src/com/google/gwt/resources/client/impl/CssResourceObserver.java
(right):
http://gwt-code-reviews.appspot.com/770801/diff/1/5#newcode32
user/src/com/google/gwt/resources/client/impl/CssResourceObserver.java:32:
private static final C
Reviewers: Ray Ryan, kjin,
Message:
Kevin, thanks for looking at this. Are there any other CSS testing
use-cases that you can think of that the DebugInfo API should support?
http://gwt-code-reviews.appspot.com/770801/diff/1/5
File
user/src/com/google/gwt/resources/client/impl/CssResourceObserv
Revision: 8546
Author: amitman...@google.com
Date: Mon Aug 16 07:37:50 2010
Log: Submitting a fix for the NPE introduced by
http://code.google.com/p/google-web-toolkit/source/detail?r=8541
Patch by: amitmanjhi
Review by: cromwellian (tbr)
http://code.google.com/p/google-web-toolkit/source/detail
On 2010/08/16 18:03:23, bobv wrote:
Kevin, thanks for looking at this. Are there any other CSS testing
use-cases
that you can think of that the DebugInfo API should support?
http://gwt-code-reviews.appspot.com/770801/diff/1/5
File
user/src/com/google/gwt/resources/client/impl/CssResourceOb
New patch set, addresses ICE that could occur in previous version of
patch.
http://gwt-code-reviews.appspot.com/752801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jlabanca,
Description:
First cut at keyboard navigation for CellTree
Please review this at http://gwt-code-reviews.appspot.com/758802/show
Affected files:
M user/src/com/google/gwt/user/cellview/client/CellTree.css
M user/src/com/google/gwt/user/cellview/client/CellTree.java
M
LGTM
You can submit for M3, but I'm curious if this works in IE because blur
and focus don't bubble. Also, add a TODO to add tests after M3.
http://gwt-code-reviews.appspot.com/758802/diff/1/3
File user/src/com/google/gwt/user/cellview/client/CellTree.java (right):
http://gwt-code-reviews.app
http://gwt-code-reviews.appspot.com/756802/diff/1/8
File dev/core/src/com/google/gwt/dev/javac/Dependencies.java (right):
http://gwt-code-reviews.appspot.com/756802/diff/1/8#newcode50
dev/core/src/com/google/gwt/dev/javac/Dependencies.java:50:
this.myPackage = myPackage + '.';
When the incoming
Reviewers: Dan Rice,
Description:
Makes the terminology used by AbstractListViewAdapter and AbstractPager
consistent with HasData. HasData#setRowValues() is now
HasData#setRowData(). Also renames ListViewAdapter to ListDataProvider
so it is more obvious that the class provides data to a Cell wi
http://gwt-code-reviews.appspot.com/756802/diff/1/8
File dev/core/src/com/google/gwt/dev/javac/Dependencies.java (right):
http://gwt-code-reviews.appspot.com/756802/diff/1/8#newcode50
dev/core/src/com/google/gwt/dev/javac/Dependencies.java:50:
this.myPackage = myPackage + '.';
Good call, thanks.
http://gwt-code-reviews.appspot.com/756802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM.
http://gwt-code-reviews.appspot.com/756802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I really like the interface/generator idea but not really the
implementation (XML parsing –even though I could live with this–,
generating XML –the HTML5 serialization algorithm [1] is fortunately
easy enough and interoperable–)
The HtmlSanitizer is a good idea, but the implementation is very wea
LGTM
http://gwt-code-reviews.appspot.com/752801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8547
Author: sco...@google.com
Date: Mon Aug 16 15:00:16 2010
Log: Re-rolling r8522: For synthetic this refs, use params rather than
fields while in constructors
http://gwt-code-reviews.appspot.com/752801
Review by: tobyr
http://code.google.com/p/google-web-toolkit/source/detail?r=8
Revision: 8548
Author: jbrosenb...@google.com
Date: Mon Aug 16 17:56:17 2010
Log: Removed use of a global table (typeIdArray) for testing castability
between types. This information is now stored per class prototype as a
castableMap.
Review at http://gwt-code-reviews.appspot.com/750801
htt
23 matches
Mail list logo
