Don't worry, I'm sure it will come back next time we need to do something
"big" that needs time to settle. This ended up being a much, much better
pattern than the incubator, which just became a dumping ground with
version-skew hell...
Le 10 septembre 2010 03:28, a écrit :
> Amen, nevertheless B
I think you can still lose the explicit removeHandler.
http://gwt-code-reviews.appspot.com/841804/diff/11002/17020
File user/src/com/google/gwt/event/shared/EventBus.java (right):
http://gwt-code-reviews.appspot.com/841804/diff/11002/17020#newcode34
user/src/com/google/gwt/event/shared/EventBus
http://gwt-code-reviews.appspot.com/827802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Sep 9, 11:50 pm, Sebastian wrote:
> I wanted to provide a patch for JsArray* to support common methods
> like sort and reverse. I found the
> issuehttp://code.google.com/p/google-web-toolkit/issues/detail?id=2793
> which is not completed and wants to provide all ECMA methods.
>
> I had a loo
http://gwt-code-reviews.appspot.com/847801/diff/8002/13005
File user/src/com/google/gwt/user/client/ui/Anchor.java (right):
http://gwt-code-reviews.appspot.com/847801/diff/8002/13005#newcode117
user/src/com/google/gwt/user/client/ui/Anchor.java:117:
this(html.asString(), true);
On 2010/09/10 02:
Revision: 8745
Author: b...@google.com
Date: Fri Sep 10 03:21:10 2010
Log: Move the packages to include in the javadoc out of the build.xml file
and into a properties file.
Patch by: bobv
Review by: rjrjr
Review at http://gwt-code-reviews.appspot.com/856801
http://code.google.com/p/google-web
Love it. Sold.
On Sep 10, 2010 5:27 AM, wrote:
> I think you can still lose the explicit removeHandler.
>
>
> http://gwt-code-reviews.appspot.com/841804/diff/11002/17020
> File user/src/com/google/gwt/event/shared/EventBus.java (right):
>
> http://gwt-code-reviews.appspot.com/841804/diff/11002/17
http://gwt-code-reviews.appspot.com/841804/diff/11002/17020
File user/src/com/google/gwt/event/shared/EventBus.java (right):
http://gwt-code-reviews.appspot.com/841804/diff/11002/17020#newcode34
user/src/com/google/gwt/event/shared/EventBus.java:34: public void removeHandler(GwtEvent.Type type,
Hi,
I managed to finally factor our the incubator widgets from my medium
sized application and now that I have no dependencies left I saw the
compile time decrease with 66%. Which is an amazing.
We were only using 2 widgets yet this library had such a huge impact.
Are there any plans to improve
http://gwt-code-reviews.appspot.com/827802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
derpc changes LGTM
http://gwt-code-reviews.appspot.com/827802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/827802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Wait, are you saying that your compile time went down *by* 2/3 (meaning to
1/3 of its original duration)?
And this is a result of pulling the incubator off of the classpath (and
hoisting out a couple of widgets)?
That would seem to be a pretty big difference!
@Eric: This might be interesting fodde
Revision: 8748
Author: jbrosenb...@google.com
Date: Fri Sep 10 06:27:47 2010
Log: Enum name obfuscation. Added configuration property
(compiler.enum.obfuscate.names) to optionally obfuscatate enum names from
production output.
Review at http://gwt-code-reviews.appspot.com/827802
http://code.goo
On Friday, September 10, 2010, wrote:
> One of the reasons to delegate to setHTML() is to support external
> implementations that have overridden setHTML(). Your suggestion makes a
> lot of sense, but to support the external users, I think we should stick
> with the setHTML() version.
SGTM.
>
>
Revision: 8749
Author: gwt.mirror...@gmail.com
Date: Fri Sep 10 07:02:13 2010
Log: Update HistoryTest to ensure that non-safari browsers also:
- run testHistory
- verify the current hash value as part of testTokenEscaping and
testTokenNonescaping
Review at http://gwt-code-reviews.appspot.com/8
Revision: 8750
Author: fre...@google.com
Date: Fri Sep 10 07:37:39 2010
Log: Resubmitting r8722, which was a continuation of r8542, with changes to
the way Image is tested in DoubleClickEventSinkTest.
Fixes double click where it was broken and adds tests to ensure that events
are sunk.
Fix
Why did you remove classes/marker? Its needed by Eclipse or it throws
an error because it can't find the classes/ directory where it is
supposed to dump compiled files.
http://gwt-code-reviews.appspot.com/845801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Add the option to use JSON rather than GWT RPC in remote logging
Please review this at http://gwt-code-reviews.appspot.com/830802/show
Affected files:
M user/src/com/google/gwt/logging/Logging.gwt.xml
A user/src/com/google/gwt/logging/client/JsonLogRecordClie
http://gwt-code-reviews.appspot.com/830802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Bob, can you take this one?
http://gwt-code-reviews.appspot.com/830802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
lgtm.
When the codegen code is hard to read, it's useful to add some example
comments showing what the generated code might look at. It would pull
up your code:comment ratio :-)
http://gwt-code-reviews.appspot.com/831801/diff/7013/9009
File user/src/com/google/gwt/user/rebind/rpc/FieldSerializ
Unintentional. I am OOO today, so I can't fix it till at least tonight. I
will be happy to review a CL.
On Fri, Sep 10, 2010 at 10:54 AM, wrote:
> Why did you remove classes/marker? Its needed by Eclipse or it throws
> an error because it can't find the classes/ directory where it is
> suppos
Hi David,
Are you using the -draftCompile option? The reason I ask is that using this
option cuts out the optimization steps to make the compile run faster. The
end result i that running the JDT compiler takes dominates the compile time
when using it. Everything on the sourcepath is compiled at
I can confirm the 2/3 drop in compile time, did the same a few months
ago...
On 10 sep, 18:06, Joel Webber wrote:
> Wait, are you saying that your compile time went down *by* 2/3 (meaning to
> 1/3 of its original duration)?
> And this is a result of pulling the incubator off of the classpath (and
Thanks for the feedback. I'm in a good functional state, so I'm going
to go ahead and commit this as-is, and add comments in a follow-up
change.
http://gwt-code-reviews.appspot.com/831801/diff/7013/9009
File user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java
(right):
http://g
http://gwt-code-reviews.appspot.com/841804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
How's that? Remove is dead (yaaay!), and I've put the too-many-removes
assert back in place. Restored the tests for that as well.
On 2010/09/10 18:58:57, rjrjr wrote:
http://gwt-code-reviews.appspot.com/841804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/841804/diff/11002/17020
File user/src/com/google/gwt/event/shared/EventBus.java (right):
http://gwt-code-reviews.appspot.com/841804/diff/11002/17020#newcode34
user/src/com/google/gwt/event/shared/EventBus.java:34: public void removeHandler(GwtEvent.Type type,
Oh, damn. Forgot to put John's null check back. One more moment.
http://gwt-code-reviews.appspot.com/841804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 8751
Author: j...@google.com
Date: Fri Sep 10 08:58:12 2010
Log: Update i18n Messages to include:
- SafeHtml support
- extended plurals support
- list rendering
- static placeholders
- format arguments
Patch by: jat, xtof
Review by: pdr, xtof
Review at http://gwt-code-reviews.appspot.c
Revision: 8752
Author: gwt.mirror...@gmail.com
Date: Fri Sep 10 09:02:53 2010
Log: TypeSerializerCreator generates pure Java code path for DevMode.
http://gwt-code-reviews.appspot.com/831801/show
http://code.google.com/p/google-web-toolkit/source/detail?r=8752
Added:
/trunk/user/src/com/google
Revision: 8753
Author: amitman...@google.com
Date: Fri Sep 10 09:06:14 2010
Log: Renamed getStableId() to stableId()
Patch by: amitmanjhi
Review (and suggested) by: rjrjr
Review at http://gwt-code-reviews.appspot.com/857801
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit
http://gwt-code-reviews.appspot.com/841804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Null checks are in place, and tested. Found some stray garbage and bugs
along the way, including a redundant fire method (oops).
I think it's done, but I'm getting sloppy.
http://gwt-code-reviews.appspot.com/841804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Message:
Review requested.
Description:
Initial add of IsEditor interface to allow views to work in an Editor
hierarchy without being an Editor.
This patch will serve as a base for an error-aware Editor decorator
panel.
Patch by: bobv
Review by: rjrjr
Please review this at ht
http://gwt-code-reviews.appspot.com/841804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Commited as http://code.google.com/p/google-web-toolkit/source/detail?r=8749
Filed HtmlUnit bug
https://sourceforge.net/tracker/?func=detail&aid=3063896&group_id=47038&atid=448266
On Thu, Sep 9, 2010 at 5:37 PM, wrote:
> Still LGTM. May want to file a bug against HtmlUnit.
>
>
> http://gwt-co
LGTM
http://gwt-code-reviews.appspot.com/858801/diff/1/6
File user/src/com/google/gwt/editor/rebind/model/EditorAccess.java
(right):
http://gwt-code-reviews.appspot.com/858801/diff/1/6#newcode76
user/src/com/google/gwt/editor/rebind/model/EditorAccess.java:76:
TypeOracle oracle = classType.getO
Reviewers: bobv,
Description:
Minor refactor of ClientBundles used in Cell Widgets. Ensures that all
method names in ClientBundle and CssResource are globally unique. Adds
missing flipRtl tags to ImageResources. Adds @ImportedWithPrefix
annotation to CssResources. Breaks out the path to the defau
LGTM
Just take a look at the assertsOn thing in the tests.
http://gwt-code-reviews.appspot.com/841804/diff/58001/45043
File user/test/com/google/gwt/event/shared/HandlerManagerTest.java
(right):
http://gwt-code-reviews.appspot.com/841804/diff/58001/45043#newcode197
user/test/com/google/gwt/eve
LGTM, just some minor suggestions.
http://gwt-code-reviews.appspot.com/841804/diff/31001/3028
File user/src/com/google/gwt/requestfactory/client/impl/ProxySchema.java
(right):
http://gwt-code-reviews.appspot.com/841804/diff/31001/3028#newcode81
user/src/com/google/gwt/requestfactory/client/impl
Reviewers: rjrjr,
Description:
Fixed the firing of events on changes to EntityProxy. Added an ACQUIRE
event and implemented the copy-on-write semantics.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Please review this at http://gwt-code-reviews.appspot.com/860801/show
Affected files:
http://gwt-code-reviews.appspot.com/851802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Add stack trace display to the rest of the log handlers in dev mode
Please review this at http://gwt-code-reviews.appspot.com/861801/show
Affected files:
M user/src/com/google/gwt/logging/client/ConsoleLogHandler.java
M user/src/com/google/gwt/logging/client/
http://gwt-code-reviews.appspot.com/853801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Those two changes are made now. It's ready for another round of review.
http://gwt-code-reviews.appspot.com/853801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Asking Fred to pick up the 2 logging CL's since they're fairly
independent of vega stuff and you guys sound swamped
- Unnur
On Fri, Sep 10, 2010 at 11:24 AM, wrote:
> Bob, can you take this one?
>
> http://gwt-code-reviews.appspot.com/830802/show
>
--
http://groups.google.com/group/Google-Web-
Revision: 8754
Author: b...@google.com
Date: Fri Sep 10 12:29:13 2010
Log: Initial add of IsEditor interface to allow views to work in an Editor
hierarchy without being an Editor.
This patch will serve as a base for an error-aware Editor decorator panel.
Patch by: bobv
Review by: rjrjr
Review at
http://gwt-code-reviews.appspot.com/841804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Last changes made, submitting.
On 2010/09/10 23:21:27, rjrjr wrote:
http://gwt-code-reviews.appspot.com/841804/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/841804/diff/58001/45022
File
user/src/com/google/gwt/event/shared/DefaultHandlerRegistration.java
(right):
http://gwt-code-reviews.appspot.com/841804/diff/58001/45022#newcode22
user/src/com/google/gwt/event/shared/DefaultHandlerRegistration.java:22:
* @depreca
Reviewers: fredsa,
Description:
Fix the logging sample - somehow the client and shared directories got
deleted. Also a minor fix for devmode, so that LogRecords with no
logger name set are handled gracefully
Please review this at http://gwt-code-reviews.appspot.com/842802/show
Affected files:
LGTM
http://gwt-code-reviews.appspot.com/860801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM. Just nits, no need to re-review if you decide to fix them.
http://gwt-code-reviews.appspot.com/853801/diff/4001/5008
File user/test/com/google/gwt/dev/StrictModeTest.java (right):
http://gwt-code-reviews.appspot.com/853801/diff/4001/5008#newcode45
user/test/com/google/gwt/dev/StrictMode
Reviewers: bobv,
http://gwt-code-reviews.appspot.com/862801/diff/2001/3001
File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(left):
http://gwt-code-reviews.appspot.com/862801/diff/2001/3001#oldcode372
dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:37
Revision: 8755
Author: amitman...@google.com
Date: Fri Sep 10 13:31:52 2010
Log: Fixed the firing of events on changes to EntityProxy. Added an ACQUIRE
event and implemented the copy-on-write semantics.
Patch by: amitmanjhi
Review by: rjrjr (desk review)
Review at http://gwt-code-reviews.apps
Reviewers: robertvawter, jlabanca,
Description:
Public: Restore the samples/validation classes/marker
Its needed by Eclipse or it throws
an error because it can't find the classes/ directory where it is
supposed to dump compiled files.
Please review this at http://gwt-code-reviews.appspot.com/8
Reviewers: robertvawter,
Description:
Public: First take at GWT validation that actually validates on the
client side.
Please review this at http://gwt-code-reviews.appspot.com/863801/show
Affected files:
M eclipse/samples/Validation/.classpath
M eclipse/user/.classpath
M
samples/vali
This is not ready for a full review yet. But I want to get some early
feed back.
I am using using the HibernateValidator during the compile.
To do this I created
user/src/org/hibernate/validator/HibernateValidator.gwt.xml and
associated files.
It might be better if this actually lived in the hib
http://gwt-code-reviews.appspot.com/863801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
61 matches
Mail list logo
