Revision: 9583
Author: gwt.mirror...@gmail.com
Date: Thu Jan 20 17:38:25 2011
Log: Public(t.bro...@gmail.com):
Adds a unit-test to explicitly check that redundant calls to
showActivityWidget are okay. The test is needed because
AcceptsOneWidget passed to the Activity by ActivityManager is not
dir
lgtm, in it goes
http://gwt-code-reviews.appspot.com/999802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1293801/diff/1/2
File
user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java
(right):
http://gwt-code-reviews.appspot.com/1293801/diff/1/2#newcode41
user/src/com/google/gwt/place/rebind/PlaceHistoryGeneratorContext.java:41:
static PlaceHistoryG
Bob, did this land?
On Mon, Jan 10, 2011 at 2:45 PM, wrote:
> LGTM
>
>
> http://gwt-code-reviews.appspot.com/1260801/show
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted at r9582
On Thu, Jan 20, 2011 at 6:36 PM, wrote:
> Awesome, thanks for getting this committed.
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks for doing this, Rodrigo. I think people will find it very
helpful.
Since it's sample code, I think it would be fine to add it to the 2.2
branch if you can get through this feedback in time.
http://gwt-code-reviews.appspot.com/1299801/diff/1/2
File
samples/dynatablerf/src/com/google/gwt/s
Awesome, thanks for getting this committed.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: cromwellian,
Message:
Hi Ray,
Doing a little refactoring to lead to a more decoupled AST. Part of
this involves removing certain 'global' references, like the Object
reference in each Array type currently. This is the first of a series
of patches that will de-emphasize JProgram even
Revision: 9582
Author: rj...@google.com
Date: Thu Jan 20 14:28:08 2011
Log: Public (larse...@gmail.com):
Adds the ability to set a DialogBox caption widget.
Review by jlba...@google.com, rj...@google.com
http://gwt-code-reviews.appspot.com/1149803
Review by: jlaba...@google.com
http://code.goog
Revision: 9581
Author: gwt.mirror...@gmail.com
Date: Thu Jan 20 16:12:04 2011
Log: Code cleanup after "Fix handling of null passed into varargs."
http://gwt-code-reviews.appspot.com/1309801/show
Review by: cromwell...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9581
M
LGTM
http://gwt-code-reviews.appspot.com/1311801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks. JDT agress with the JLS that Bar[] counts as a Foo[].
http://gwt-code-reviews.appspot.com/1309801/diff/4002/9001
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
(right):
http://gwt-code-reviews.appspot.com/1309801/diff/4002/9001#newcode2063
dev/core/src/com/google/gw
Looks good! I'll try to get it in today.
http://gwt-code-reviews.appspot.com/1149803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002
File
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java
(right):
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002#newcode47
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java:47:
} else i
implemented rjrjr's changes.
http://gwt-code-reviews.appspot.com/1149803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1311802/diff/1/2
File plugins/config.mk (left):
http://gwt-code-reviews.appspot.com/1311802/diff/1/2#oldcode75
plugins/config.mk:75: OMARCH=i386
OMARCH wasn't being used anywhere.
http://gwt-code-reviews.appspot.com/1311802/diff/1/3
File plugins/xpcom/Makefil
Reviewers: jat, fabiomfv,
Description:
Update the mac xpcom plugin for Gecko 2.0 (FF4). This is a platform
switch for
mac: ppc+i386 to i386+x86_64 to mirror Firefox's platform shift.
Also, fixup the linux libxul linkage: we had been getting lucky with
-rdynamic
on linux for the JS symbols which
LGTM, but I wonder about the Foo[] vs Bar[] case where Bar extends Foo.
What does the JLS say?
http://gwt-code-reviews.appspot.com/1309801/diff/4002/9001
File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaAST.java
(right):
http://gwt-code-reviews.appspot.com/1309801/diff/4002/9001#newc
http://gwt-code-reviews.appspot.com/1310802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I think you could reuse the original rietveld issue, if you haven't closed
it yet.
On Thu, Jan 20, 2011 at 1:17 PM, Daniel Rice (דניאל רייס)
wrote:
> Here's a manual diff. Is there some slick way to upload it to
> Mondrian or Rietveld that won't make them confused?
>
> Dan
>
> On Thu, Jan 20, 2
Revision: 9580
Author: con...@google.com
Date: Thu Jan 20 13:17:38 2011
Log: Add Mac Gecko 2.0 SDK files
http://code.google.com/p/google-web-toolkit/source/detail?r=9580
Added:
/plugin-sdks/gecko-sdks/gecko-2.0.0/Darwin-gcc3
/plugin-sdks/gecko-sdks/gecko-2.0.0/Darwin-gcc3/README.txt
/plugin-sd
Here's a manual diff. Is there some slick way to upload it to
Mondrian or Rietveld that won't make them confused?
Dan
On Thu, Jan 20, 2011 at 3:52 PM, wrote:
> Can you upload a diff relative to what you checked in before you rolled
> it back? I just want to see what you fixed relative to th
Oh, didn't see the patch, thought you were advising me that you were
going to upload a patch. :)
Ok, ill take a looksie.
On Thu, Jan 20, 2011 at 12:53 PM, Scott Blum wrote:
> Is that SGTM or LGTM? I uploaded a patch.
>
> --
> http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
Is that SGTM or LGTM? I uploaded a patch.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Can you upload a diff relative to what you checked in before you rolled
it back? I just want to see what you fixed relative to that.
http://gwt-code-reviews.appspot.com/1311801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9579
Author: gwt.mirror...@gmail.com
Date: Thu Jan 20 09:39:05 2011
Log: Turn on the null groups tests, now that the gwt null varargs bug is
fixed.
[JSR 303 TCK Result] 64 of 257 (24.90%) Pass with 26 Failures and 4 Errors.
Review at http://gwt-code-reviews.appspot.com/1288803
Revi
Nice! Nearly there.
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002
File
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java
(left):
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002#oldcode72
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxPars
LGTM
On 2011/01/20 05:31:31, Nick Chalko wrote:
http://gwt-code-reviews.appspot.com/1288803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
SGTM
On Thu, Jan 20, 2011 at 12:12 PM, wrote:
> Ray: I want to follow up the previous commit with some little
> refactoring that a) makes the code more clear and b) will be useful for
> some other changes I'm working on.
>
> http://gwt-code-reviews.appspot.com/1309801/show
>
> --
> http://groups
http://gwt-code-reviews.appspot.com/1310802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: scottb,
Description:
Optimize redundant 'switch' statements
Fix bug caused by using short idents when matching case bodies
Please review this at http://gwt-code-reviews.appspot.com/1311801/show
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
A
Ray: I want to follow up the previous commit with some little
refactoring that a) makes the code more clear and b) will be useful for
some other changes I'm working on.
http://gwt-code-reviews.appspot.com/1309801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9577
Author: j...@google.com
Date: Thu Jan 20 10:34:11 2011
Log: Create javadoc directory for 2.2.
http://code.google.com/p/google-web-toolkit/source/detail?r=9577
Added:
/javadoc/2.2
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: scottb,
Description:
Remove list of JavaScriptException object properties when
compiler.stackTrace = emulated
Fixes Issues: 3974
Please review this at http://gwt-code-reviews.appspot.com/1310802/show
Affected files:
M user/src/com/google/gwt/core/client/JavaScriptException.java
committed as r9576
http://gwt-code-reviews.appspot.com/1301801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9576
Author: gwt.mirror...@gmail.com
Date: Thu Jan 20 06:21:05 2011
Log: Adding a new widget ResizeLayoutPanel that can trigger a resize event
when it changes size. The widget uses hidden scrollable divs to detect
resize on non-IE browsers. This allow users to embed widgets that
Re
Revision: 9575
Author: gwt.mirror...@gmail.com
Date: Thu Jan 20 09:22:57 2011
Log: Implement an isDirty() method for Editor framework drivers.
Issue 5881.
Patch by: bobv
Review by: rjrjr
Review at http://gwt-code-reviews.appspot.com/1306801
http://code.google.com/p/google-web-toolkit/source/deta
http://gwt-code-reviews.appspot.com/1301801/diff/5001/6001
File user/src/com/google/gwt/user/ResizeLayoutPanel.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1301801/diff/5001/6001#newcode23
user/src/com/google/gwt/user/ResizeLayoutPanel.gwt.xml:23:
On 2011/01/20 16:22:26, pdr wrote:
Ins
LGTM
http://gwt-code-reviews.appspot.com/1301801/diff/5001/6001
File user/src/com/google/gwt/user/ResizeLayoutPanel.gwt.xml (right):
http://gwt-code-reviews.appspot.com/1301801/diff/5001/6001#newcode23
user/src/com/google/gwt/user/ResizeLayoutPanel.gwt.xml:23:
Instead of explicitly listing out
committed as r9572
http://gwt-code-reviews.appspot.com/1300801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1301801/diff/1/4
File user/src/com/google/gwt/user/client/ui/HeaderPanel.java (right):
http://gwt-code-reviews.appspot.com/1301801/diff/1/4#newcode135
user/src/com/google/gwt/user/client/ui/HeaderPanel.java:135: public
Iterator iterator() {
All Panels must def
http://gwt-code-reviews.appspot.com/1301801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1301801/diff/1/4
File user/src/com/google/gwt/user/client/ui/HeaderPanel.java (right):
http://gwt-code-reviews.appspot.com/1301801/diff/1/4#newcode37
user/src/com/google/gwt/user/client/ui/HeaderPanel.java:37:
Rendering bug: vertical scrollbars will be hidden
44 matches
Mail list logo
