[gwt-contrib] Re: Add missing CSS_ATTRIBUTE_START case in SafeHtmlTemplates code generator. (issue1395803)

LGTM Thanks for adding the test http://gwt-code-reviews.appspot.com/1395803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9914 committed - Add missing CSS_ATTRIBUTE_START case in SafeHtmlTemplates code generat...

Revision: 9914 Author: x...@google.com Date: Tue Mar 29 14:59:28 2011 Log: Add missing CSS_ATTRIBUTE_START case in SafeHtmlTemplates code generator. Review at: http://gwt-code-reviews.appspot.com/1395803 http://code.google.com/p/google-web-toolkit/source/detail?r=9914 Modified:

[gwt-contrib] Add missing CSS_ATTRIBUTE_START case in SafeHtmlTemplates code generator. (issue1395803)

Reviewers: jlabanca, rjrjr, pdr, Description: Add missing CSS_ATTRIBUTE_START case in SafeHtmlTemplates code generator. Please review this at http://gwt-code-reviews.appspot.com/1395803/ Affected files: M user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java M

[gwt-contrib] Re: Supress errors when building the Type Oracle. (issue1385810)

LGTM, just nits. http://gwt-code-reviews.appspot.com/1385810/diff/8012/dev/core/src/com/google/gwt/dev/cfg/DeferredBindingQuery.java File dev/core/src/com/google/gwt/dev/cfg/DeferredBindingQuery.java (right): http://gwt-code-reviews.appspot.com/1385810/diff/8012/dev/core/src/com/google/gwt/dev/

[gwt-contrib] Re: Add tests of nesting semantics for ResettableEventBus (issue1395802)

submitted at r9913 http://gwt-code-reviews.appspot.com/1395802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9913 committed - Add tests of nesting semantics for ResettableEventBus...

Revision: 9913 Author: rj...@google.com Date: Tue Mar 29 12:31:22 2011 Log: Add tests of nesting semantics for ResettableEventBus Review at http://gwt-code-reviews.appspot.com/1395802 Review by: jlaba...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=9913 Modi

[gwt-contrib] Adding table rendering tests to micro benchmarks. Table rendering tests are multiple orders of m... (issue1394802)

Reviewers: rjrjr, Description: Adding table rendering tests to micro benchmarks. Table rendering tests are multiple orders of magnitude slower than the existing basic tests, so I seperated them into a seperate mirco benchmark. I modified WidgetCreation so it could be used for both instead of cop

[gwt-contrib] [google-web-toolkit] r9912 committed - Adds support for the CSS_ATTRIBUTE_START parse context to HtmlTemplate...

Revision: 9912 Author: x...@google.com Date: Tue Mar 29 12:27:56 2011 Log: Adds support for the CSS_ATTRIBUTE_START parse context to HtmlTemplateParser. Review at http://gwt-code-reviews.appspot.com/1392801 http://code.google.com/p/google-web-toolkit/source/detail?r=9912 Modified:

[gwt-contrib] Re: Supress errors when building the Type Oracle. (issue1385810)

http://gwt-code-reviews.appspot.com/1385810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Supress errors when building the Type Oracle. (issue1385810)

Updated patch. sorry about the missing file in last patch. http://gwt-code-reviews.appspot.com/1385810/diff/1/dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java File dev/core/src/com/google/gwt/dev/javac/ProblemReporter.java (right): http://gwt-code-reviews.appspot.com/1385810/diff/1/d

[gwt-contrib] Re: Supress errors when building the Type Oracle. (issue1385810)

http://gwt-code-reviews.appspot.com/1385810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add tests of nesting semantics for ResettableEventBus (issue1395802)

I wasn't trying to catch the bug, I was trying to illustrate the bits that work already. On Tue, Mar 29, 2011 at 3:18 PM, wrote: > > > http://gwt-code-reviews.appspot.com/1395802/diff/1/user/test/com/google/gwt/event/shared/ResettableEventBusTest.java > File user/test/com/google/gwt/event/shared

[gwt-contrib] [google-web-toolkit] r9911 committed - Roll-back due to test breakage....

Revision: 9911 Author: rchan...@google.com Date: Tue Mar 29 12:09:40 2011 Log: Roll-back due to test breakage. Review at http://gwt-code-reviews.appspot.com/1396801 Review by: p...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=9911 Modified: /trunk/user/src/

[gwt-contrib] Re: Add tests of nesting semantics for ResettableEventBus (issue1395802)

LGTM http://gwt-code-reviews.appspot.com/1395802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Roll-back due to test breakage. (issue1396801)

On 2011/03/29 21:54:47, rchandia wrote: LGTM http://gwt-code-reviews.appspot.com/1396801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Roll-back due to test breakage. (issue1396801)

Reviewers: pdr, Description: Roll-back due to test breakage. Please review this at http://gwt-code-reviews.appspot.com/1396801/ Affected files: M user/src/com/google/gwt/user/tools/WebAppCreator.java M user/test/com/google/gwt/user/tools/WebAppCreatorTest.java Index: user/src/com/google/

[gwt-contrib] Re: Public (issue1394801)

Correction submitted as r9909 On 2011/03/29 21:13:15, rchandia wrote: Submitted as r9908 On 2011/03/29 19:15:10, jlabanca wrote: > LGTM http://gwt-code-reviews.appspot.com/1394801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9910 committed - Recursively creates directories for the persistent unit cache....

Revision: 9910 Author: zun...@google.com Date: Tue Mar 29 11:29:33 2011 Log: Recursively creates directories for the persistent unit cache. Review at http://gwt-code-reviews.appspot.com/1395801 http://code.google.com/p/google-web-toolkit/source/detail?r=9910 Modified: /trunk/dev/cor

[gwt-contrib] Add tests of nesting semantics for ResettableEventBus (issue1395802)

Reviewers: jlabanca, Description: Add tests of nesting semantics for ResettableEventBus Please review this at http://gwt-code-reviews.appspot.com/1395802/ Affected files: M user/test/com/google/gwt/event/shared/ResettableEventBusTest.java Index: user/test/com/google/gwt/event/shared/Resett

[gwt-contrib] [google-web-toolkit] r9909 committed - Public...

Revision: 9909 Author: rchan...@google.com Date: Tue Mar 29 11:24:05 2011 Log: Public Fixes new project template to use 'clean' style. Issue 6208. Review at http://gwt-code-reviews.appspot.com/1394801 Review by: jlaba...@google.com http://code.google.com/p/google-web-toolkit/source/de

[gwt-contrib] Re: Recursively creates directories for the persistent unit cache. (issue1395801)

LGTM http://gwt-code-reviews.appspot.com/1395801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public (issue1394801)

Submitted as r9908 On 2011/03/29 19:15:10, jlabanca wrote: LGTM http://gwt-code-reviews.appspot.com/1394801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes issue 6189. WebAppCreator was not scanning war/WEB-INF/lib to fill up .classpath (issue1393801)

Submitted as r9908 On 2011/03/29 18:25:08, rchandia wrote: http://gwt-code-reviews.appspot.com/1393801/diff/1/user/test/com/google/gwt/user/tools/WebAppCreatorTest.java File user/test/com/google/gwt/user/tools/WebAppCreatorTest.java (right): http://gwt-code-reviews.appspot.com/1393801/diff/1/

[gwt-contrib] Recursively creates directories for the persistent unit cache. (issue1395801)

Reviewers: tobyr, scottb, Description: Recursively creates directories for the persistent unit cache. Please review this at http://gwt-code-reviews.appspot.com/1395801/ Affected files: M dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java Index: dev/core/src/com/google/gwt/dev/j

[gwt-contrib] Re: Issue 1054 (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java File user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/1001/user/src/com/google/gwt/user/rebind/rp

[gwt-contrib] Re: Issue 1054 (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add SafeUri type, similar to SafeHtml but for values in a URL attribute context. (issue1380806)

On Tue, Mar 29, 2011 at 13:30, wrote: > I totally agree with your analysis and ENTIRE_URL_ATTRIBUTE state (I had > similar concerns, but couldn't find a use case where it would be > problematic: I didn't think about the javascript: URLs; and there > actually are similar issues with data: URLs). >

[gwt-contrib] Re: Issue 5700 (issue1388804)

On Fri, Mar 25, 2011 at 7:26 AM, wrote: > I have a simple question on one of the test. As I was making this > correction I noticed that one of my test case comment is wrong. > > The last remove test is actually incorrect (my comment). My question is > what is the expected output of the last test.

[gwt-contrib] Re: Add SafeUri type, similar to SafeHtml but for values in a URL attribute context. (issue1380806)

I totally agree with your analysis and ENTIRE_URL_ATTRIBUTE state (I had similar concerns, but couldn't find a use case where it would be problematic: I didn't think about the javascript: URLs; and there actually are similar issues with data: URLs). Should I wait for the ENTIRE_URL_ATTRIBUTE stat

[gwt-contrib] Re: Adds support for the CSS_ATTRIBUTE_START parse context to HtmlTemplateParser. (issue1392801)

http://gwt-code-reviews.appspot.com/1392801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds support for the CSS_ATTRIBUTE_START parse context to HtmlTemplateParser. (issue1392801)

On 2011/03/29 19:30:16, jlabanca wrote: LGTM I don't actually see the TODO though. You can add it before submitting. Oops, forgot to export git before uploading. Done. Thanks! --xtof http://gwt-code-reviews.appspot.com/1392801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contri

[gwt-contrib] Re: Supress errors when building the Type Oracle. (issue1385810)

CompilationProblemReporter isn't showing up for me in patch set 2. http://gwt-code-reviews.appspot.com/1385810/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right): http://gwt-code-reviews.appsp

[gwt-contrib] Re: Add SafeUri type, similar to SafeHtml but for values in a URL attribute context. (issue1380806)

Thanks for your changes! There's one more thing: In the past couple of days we've had some discussions around the "in URL valued attribute" context. The main issue discussed is that unlike SafeHtml, SafeUri is not generally composable: Two SafeHtmls concatenated together make another SafeHtml,

[gwt-contrib] [google-web-toolkit] r9908 committed - Fixes issue 6189. WebAppCreator was not scanning war/WEB-INF/lib to fi...

Revision: 9908 Author: rchan...@google.com Date: Tue Mar 29 09:58:14 2011 Log: Fixes issue 6189. WebAppCreator was not scanning war/WEB-INF/lib to fill up .classpath Review at http://gwt-code-reviews.appspot.com/1393801 Review by: jlaba...@google.com http://code.google.com/p/google

[gwt-contrib] Re: Adds support for the CSS_ATTRIBUTE_START parse context to HtmlTemplateParser. (issue1392801)

On Tue, Mar 29, 2011 at 12:14, wrote: > I think the entire attribute state could be useful, and I think thats a > good reason to use state booleans instead of more enums. The number of > enums could grow exponentially (CSS_ATTRIBUTE_START_ENTIRE?). > Right. > > Since this is implementation code

[gwt-contrib] Re: Adds support for the CSS_ATTRIBUTE_START parse context to HtmlTemplateParser. (issue1392801)

LGTM I don't actually see the TODO though. You can add it before submitting. On 2011/03/29 19:28:17, xtof wrote: On Tue, Mar 29, 2011 at 12:14, wrote: > I think the entire attribute state could be useful, and I think thats a > good reason to use state booleans

[gwt-contrib] Re: Adds support for the CSS_ATTRIBUTE_START parse context to HtmlTemplateParser. (issue1392801)

http://gwt-code-reviews.appspot.com/1392801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: ie9 bug fixes. (issue1383809)

LGTM As long as you put a more description comment in the IE9 tabIndex impl http://gwt-code-reviews.appspot.com/1383809/diff/4001/user/src/com/google/gwt/dom/client/DOMImplIE9.java File user/src/com/google/gwt/dom/client/DOMImplIE9.java (right): http://gwt-code-reviews.appspot.com/1383809/diff

[gwt-contrib] Re: Public (issue1394801)

LGTM http://gwt-code-reviews.appspot.com/1394801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds support for the CSS_ATTRIBUTE_START parse context to HtmlTemplateParser. (issue1392801)

I think the entire attribute state could be useful, and I think thats a good reason to use state booleans instead of more enums. The number of enums could grow exponentially (CSS_ATTRIBUTE_START_ENTIRE?). Since this is implementation code and we can change it as needed, I'll LGTM if you want to

[gwt-contrib] Re: Adds support for the CSS_ATTRIBUTE_START parse context to HtmlTemplateParser. (issue1392801)

FWIW, I think I will also want to add another state that indicates that the template variable comprises the entire attribute, for URLs (i.e. , but not ). So there will be at least one more state coming. On Tue, Mar 29, 2011 at 11:37, Christoph Kern wrote: > I could do that. One concern I have t

[gwt-contrib] Re: Supress errors when building the Type Oracle. (issue1385810)

Updated patch addresses issue of logging errors in DevMode, updated JavaToJavaScriptCompiler to re-use the reportErrors() method and incorporated most feedback. http://gwt-code-reviews.appspot.com/1385810/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src

[gwt-contrib] Re: Public (issue1394801)

http://gwt-code-reviews.appspot.com/1394801/diff/1/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc File user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc (right): http://gwt-code

[gwt-contrib] Re: Adds support for the CSS_ATTRIBUTE_START parse context to HtmlTemplateParser. (issue1392801)

I could do that. One concern I have though with this approach is that the state exposed in HtmlContext would get more complicated. Right now, code using the parser can simply do a switch statement over the contexts (see SafeHtmlTemplatesImplMethodCreator#emitParameterExpression); if we make the st

[gwt-contrib] Re: Supress errors when building the Type Oracle. (issue1385810)

http://gwt-code-reviews.appspot.com/1385810/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public (issue1394801)

http://gwt-code-reviews.appspot.com/1394801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public (issue1394801)

http://gwt-code-reviews.appspot.com/1394801/diff/1/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc File user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc (right): http://gwt-code

[gwt-contrib] Re: Adds support for the CSS_ATTRIBUTE_START parse context to HtmlTemplateParser. (issue1392801)

Knowing that you are at the start of a context type seems generally useful for all context types, including TEXT/ATTRIBUTE/URL (we already have URL_START). Instead of adding CSS_ATTRIBUTE_START, would it be better to add HtmlContext#isStart(), or event HtmlContext#getValueIndex()? http://gwt-cod

[gwt-contrib] Re: Fixes issue 6189. WebAppCreator was not scanning war/WEB-INF/lib to fill up .classpath (issue1393801)

http://gwt-code-reviews.appspot.com/1393801/diff/1/user/test/com/google/gwt/user/tools/WebAppCreatorTest.java File user/test/com/google/gwt/user/tools/WebAppCreatorTest.java (right): http://gwt-code-reviews.appspot.com/1393801/diff/1/user/test/com/google/gwt/user/tools/WebAppCreatorTest.java#new

[gwt-contrib] Re: Fixes issue 6189. WebAppCreator was not scanning war/WEB-INF/lib to fill up .classpath (issue1393801)

http://gwt-code-reviews.appspot.com/1393801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Public (issue1394801)

Reviewers: jlabanca, Description: Public Fixes new project template to use 'clean' style. Issue 6208. Please review this at http://gwt-code-reviews.appspot.com/1394801/ Affected files: M user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xm

[gwt-contrib] Re: Fixes issue 6189. WebAppCreator was not scanning war/WEB-INF/lib to fill up .classpath (issue1393801)

LGTM http://gwt-code-reviews.appspot.com/1393801/diff/1/user/test/com/google/gwt/user/tools/WebAppCreatorTest.java File user/test/com/google/gwt/user/tools/WebAppCreatorTest.java (right): http://gwt-code-reviews.appspot.com/1393801/diff/1/user/test/com/google/gwt/user/tools/WebAppCreatorTest.ja

[gwt-contrib] Fixes issue 6189. WebAppCreator was not scanning war/WEB-INF/lib to fill up .classpath (issue1393801)

Reviewers: jlabanca, Description: Fixes issue 6189. WebAppCreator was not scanning war/WEB-INF/lib to fill up .classpath Please review this at http://gwt-code-reviews.appspot.com/1393801/ Affected files: M user/src/com/google/gwt/user/tools/WebAppCreator.java M user/test/com/google/gwt/use

[gwt-contrib] [google-web-toolkit] r9907 committed - Cherry picking r9880 into releases/2.3m1

Revision: 9907 Author: rchan...@google.com Date: Fri Mar 25 07:04:13 2011 Log: Cherry picking r9880 into releases/2.3m1 http://code.google.com/p/google-web-toolkit/source/detail?r=9907 Modified: /releases/2.3/user/src/com/google/gwt/requestfactory/server/LocatorServiceLayer.java

[gwt-contrib] Adds support for the CSS_ATTRIBUTE_START parse context to HtmlTemplateParser. (issue1392801)

Reviewers: jlabanca, pdr, Description: Adds support for the CSS_ATTRIBUTE_START parse context to HtmlTemplateParser. Please review this at http://gwt-code-reviews.appspot.com/1392801/ Affected files: M user/src/com/google/gwt/safehtml/rebind/HtmlTemplateParser.java M user/src/com/google/gw

[gwt-contrib] Re: Issue 5129: Accomodate RunAsync in ActivityManager (issue1383802)

It's still unclear to me that your AbstractAsyncActivity actually works. It seems like it will just produce a single split point, as Thomas suggested of my first patch here. Have you seen it make multiple fragments? On Tue, Mar 29, 2011 at 2:36 AM, Antoine DESSAIGNE < antoine.dessai...@gmail.com>

Re: [gwt-contrib] Re: LongLibBase improperly stomps on global 'a' variable. This patch reuses globalTemp (_) instead. (issue1389803)

Sounds good. Now that I think about it, it may not make much performance difference if time tends to be dominated by the actual math ops, but I suppose every bit helps? On Tue, Mar 29, 2011 at 10:35 AM, Daniel Rice (דניאל רייס) wrote: > I did the reimplementation. Being less familiar with the i

[gwt-contrib] Re: ie9 bug fixes. (issue1383809)

http://gwt-code-reviews.appspot.com/1383809/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Comment on ProtocolBuffers in google-web-toolkit

Comment by yegor.jb...@gmail.com: Oh, I forgot. This will probably come with AutoBean, but it might be good to mention how code splitting would work. The framework should guarantee that a single protobuf module is "code-splittable", i.e. not compiled in its entirety to all code fragments.

[gwt-contrib] Comment on ProtocolBuffers in google-web-toolkit

Comment by yegor.jb...@gmail.com: Well detailed and well scoped. I think this spec is great. Except I think protobuf compiler command is protoc, not protocc (one 'c' at the end). For more information: http://code.google.com/p/google-web-toolkit/wiki/ProtocolBuffers -- http://groups.google.co

Re: [gwt-contrib] Re: LongLibBase improperly stomps on global 'a' variable. This patch reuses globalTemp (_) instead. (issue1389803)

I did the reimplementation. Being less familiar with the intricacies of JavaScript, it seems likely that I missed an opportunity to preserve the nativeness of the array. I'd be happy to take a look at this after the 2.3 release. On Mon, Mar 28, 2011 at 5:52 PM, Scott Blum wrote: > Something sm

[gwt-contrib] Re: Issue 5129: Accomodate RunAsync in ActivityManager (issue1383802)

Hi, Should I modify my patch and repost it or do you go with the http://gwt-code-reviews.appspot.com/1386806/ option ? Again I truely think that it's not necessary to add anything other than the simple AbstractAsyncActivity class (we may call it otherwise though). Antoine. 2011/3/25 > This st