Hi,
unfortunately I did not manage to reproduce the issue in a clean project.
But I'd like to show the issue to someone with my existing projects.
I've been able to find a workaround by adding the module classes to a fake
rpc service.
I could setup a TeamViewer session to show the issue on my
WidgetInterpreter and WidgetPlaceholderInterpreter shouldn't output
LazyDomElement. Rafa, do you remember why? I don't think this aggregates any
performance gain for us, am I missing something?
And I vote for #1
On Tue, Aug 16, 2011 at 10:10 PM, Rafael Castro rdcas...@google.com wrote:
http://gwt-code-reviews.appspot.com/1499808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
A patch is coming that modifies the TableBuilder API to make it more
flexible. TableBuilder.Utility is going away completely, and the event
handling implementation is moved from AbstractCellTable into
AbstractTableBuilder. This will allow users to implement a simple grid
based TableBuilder with
LGTM. Just nits.
http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java
File
user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java
(right):
LGTM
On Wed, Aug 17, 2011 at 7:32 AM, jlaba...@google.com wrote:
A patch is coming that modifies the TableBuilder API to make it more
flexible. TableBuilder.Utility is going away completely, and the event
handling implementation is moved from AbstractCellTable into
AbstractTableBuilder.
I like #1 too. I think we should try to narrow the visibility of
PotentialElement as much as we can.
So #1 means two things , right?
• Widgets are seated in their @UiFields immediately
• In an IsRenderable owner, Element and subclasses are only available via
LazyDomElement, and @UiField Element
Revision: 10538
Author: mrruss...@google.com
Date: Wed Aug 17 06:37:04 2011
Log: Cherry picking r10489 into release/2.4 for public issue 1508802
http://code.google.com/p/google-web-toolkit/source/detail?r=10538
Added:
/releases/2.4/dev/core/src/com/google/gwt/util/tools/shared
Reviewers: rjrjr,
Description:
Fixes issue where UiRenderer breaks when a field is referenced more than
once
Please review this at http://gwt-code-reviews.appspot.com/1525805/
Affected files:
M user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
M
Awesome, I like #1 too. I was driving to work this morning and thinking
about it: #2 actually encourages bad behavior, because it'll seem it's OK to
fiddle with the elements between calling bind and attaching, and it's really
not. We _could_ make an effort to make it work, but it's much better to
Cool, I've filed
http://code.google.com/p/google-web-toolkit/issues/detail?id=6701.
Can I get an LGTM and submit this thing?
On Wed Aug 17 09:58:03 GMT-700 2011, Rafael Castro wrote:
Awesome, I like #1 too. I was driving to work this morning and thinking
about it: #2 actually encourages bad
http://gwt-code-reviews.appspot.com/1527804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
Got too tangled up in the discussion and forgot the review :-)
http://gwt-code-reviews.appspot.com/1527804/diff/3001/user/test/com/google/gwt/uibinder/test/client/IsRenderableIntegrationTest.java
File
user/test/com/google/gwt/uibinder/test/client/IsRenderableIntegrationTest.java
(right):
Revision: 10539
Author: scheg...@google.com
Date: Wed Aug 17 06:52:30 2011
Log: Tweak to allow parent ClassLoader at design time.
Review at http://gwt-code-reviews.appspot.com/1529803
Review by: to...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10539
LGTM
http://gwt-code-reviews.appspot.com/1525805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
That's a generous offer, but I don't know that anyone is going to be able to
take you up on it. We'll keep an eye out for it here. And if you do manage
to trim your failing code down to something you can share, we'll jump.
Are you building against trunk? If not, you might try and see if the
Revision: 10540
Author: rj...@google.com
Date: Wed Aug 17 10:09:20 2011
Log: Provides an integration test for IsRenderable
Review at http://gwt-code-reviews.appspot.com/1527804
http://code.google.com/p/google-web-toolkit/source/detail?r=10540
Added:
Hi Ray,
thanks a lot.
I'll try to check if building against trunk will change things. I've tried
with 2.3 and 2.4rc and both produce the error - it worked fine with 2.04.
After running into the error several times I've not disabled the runAsync
and download everything in a single module. This
Submitted as r10541
http://gwt-code-reviews.appspot.com/1525805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1526803/diff/3/user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java
File
user/src/com/google/web/bindery/event/shared/testing/CountingEventBus.java
(right):
http://gwt-code-reviews.appspot.com/1522803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Nits knitted. Hermes, you still planning to take another look?
http://gwt-code-reviews.appspot.com/1522803/diff/3001/user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java
File
user/src/com/google/gwt/uibinder/attributeparsers/FieldReferenceConverter.java
(right):
http://gwt-code-reviews.appspot.com/1522803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: mrosett_google.com,
Description:
Fix http://code.google.com/p/google-web-toolkit/issues/detail?id=6161
by warning on suspicious looking namespaces. Also keep
StackLayoutPanelParser from generating bad code for such things.
Please review this at
Comment by asolov...@gmail.com:
'Object' type can't be (de)encoded via AutoBean framework. You should read
this section again
http://code.google.com/p/google-web-toolkit/wiki/AutoBean#Property_types
For more information:
http://code.google.com/p/google-web-toolkit/wiki/AutoBean
--
25 matches
Mail list logo
