[gwt-contrib] Re: Fix issue 6710: entities referenced from list of value proxies (issue1646803)

2012-04-10 Thread t . broyer
https://gwt-code-reviews.appspot.com/1646803/diff/1/user/src/com/google/web/bindery/requestfactory/server/Resolver.java File user/src/com/google/web/bindery/requestfactory/server/Resolver.java (right):

[gwt-contrib] Re: Issue 6331: Let AutoBean accept numbers for dates and longs (issue1601805)

2012-04-10 Thread t . broyer
I've added similar changes to BigDecimal and BigInteger so you can have those Big* types in your autobeans/RF-proxies and accept numeric values in the JSON (allows changing from Double to BigDecimal, for instance, in an interface without the need to change the server-side code / JSON

[gwt-contrib] Re: Fix for issue 5952: RequestContext#isChanged. (issue1601806)

2012-04-10 Thread t . broyer
http://gwt-code-reviews.appspot.com/1601806/diff/1015/user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java File user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java (right):

[gwt-contrib] Issue 7175: isBodyLoaded is called instantly if xsiframe linker is used (issue1647803)

2012-04-10 Thread rdayal
Alan, can you review this one? http://gwt-code-reviews.appspot.com/1647803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Avoid Java bottleneck by using explicit Charset for byte[]-String conversions (issue1588803)

2012-04-10 Thread rdayal
On 2012/01/23 23:43:12, rdayal wrote: LGTM. Submitted. http://gwt-code-reviews.appspot.com/1588803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Move more classes from client to shared, so they can be used on the (issue1681803)

2012-04-10 Thread jat
This isn't completely ready for review, as UiBinder still has a reference to the old DateTimeFormat.PredefinedFormat that I haven't tracked down yet. In particular, I am interested in feedback on API changes in c.g.g.i18n.shared as part of moving from client: - introducing Locales for

[gwt-contrib] Re: Issue 7175: isBodyLoaded is called instantly if xsiframe linker is used (issue1647803)

2012-04-10 Thread acleung
LGTM http://gwt-code-reviews.appspot.com/1647803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors