John A. Tamplin has posted comments on this change.
Change subject: Update to use ICU4J 50.1.1
..
Patch Set 2:
(1 comment)
@Brian - the differences a user would likely see from just this update (not
including the shared i18
Brian Slesinsky has abandoned this change.
Change subject: Fix an infinite loop in RPC deserialization due to type
variable cycles.
..
Abandoned
Submitted.
--
To view, visit https://gwt-review.googlesource.com/1410
To unsu
John A. Tamplin has posted comments on this change.
Change subject: Fix an infinite loop in RPC deserialization due to type
variable cycles.
..
Patch Set 4: Code-Review+1
--
To view, visit https://gwt-review.googlesource.co
LGTM
And thanks for the patch. Let's give little bit more time for other
reviewers to comment then we can submit it internally.
On 2013/01/22 23:05:27, arobison wrote:
I originally thought the cell parent way was a little cleaner, but
after another
look I don't really have any preference betw
Roberto Lublinerman has posted comments on this change.
Change subject: Fix an infinite loop in RPC deserialization due to type
variable cycles.
..
Patch Set 4: Code-Review+1
(1 comment)
...
James Nelson has posted comments on this change.
Change subject: Fix an infinite loop in RPC deserialization due to type
variable cycles.
..
Patch Set 4: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/1
Brian Slesinsky has posted comments on this change.
Change subject: Fix an infinite loop in RPC deserialization due to type
variable cycles.
..
Patch Set 3:
(6 comments)
Hello John A. Tamplin, Roberto Lublinerman, Thomas Broyer, James Nelson,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/1410
to look at the new patch set (#4).
Change subject: Fix an infinite loop in RPC deserialization due to type
variable cycles.
http://gwt-code-reviews.appspot.com/1879803/diff/6004/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
File user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
(right):
http://gwt-code-reviews.appspot.com/1879803/diff/6004/user/src/com/google/gwt/user/cellview/
(my comments didn't go through before)
http://gwt-code-reviews.appspot.com/1879803/diff/5001/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
File user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
(right):
http://gwt-code-reviews.appspot.com/1879803/diff/500
Please also follow tbroyer's suggestion for the change description.
Basically idea is to put following as your CL description:
... A one liner description of the change ...
... Add additional longer description in multiple lines(if needed) ...
... Add 'Fixes issue ' as last line (if the
I can`t seem to get source maps working with Chrome 24.
Is it just me or is there still something off?
On Friday, November 30, 2012 2:15:31 AM UTC+1, Ray Cromwell wrote:
>
> https://gwt-review.googlesource.com/#/c/1300/1
>
> On Wed, Nov 28, 2012 at 11:02 AM, Stephen Haberman
> > wrote:
> >
>
John A. Tamplin has posted comments on this change.
Change subject: Fix an infinite loop in RPC deserialization due to type
variable cycles.
..
Patch Set 3: Code-Review+1
(2 comments)
LGTM with nits
..
> What do you mean by "too harsh"? I haven't tested yet, but it seems
> unlikely that any users would care if we dropped a few frames in a dialog
> animation in an enterprise app. (Yes, of course gamers would care, but
> that's a separate audience.)
>
Sorry but if you choose to animate things
Am 21.01.2013 um 06:17 schrieb Brian Slesinsky :
>
> On Sun, Jan 20, 2013 at 7:35 PM, John A. Tamplin wrote:
> I agree, plus I think if we are going to do this there should be a more
> global deferred binding property like "useExperimentalApis" in core.
>
> What do you think about flags to tu
Matthew Dempsky has posted comments on this change.
Change subject: Emit a warning if (some) incompatible options are used.
..
Patch Set 5: Code-Review+1
(1 comment)
File d
James Nelson has posted comments on this change.
Change subject: Fix an infinite loop in RPC deserialization due to type
variable cycles.
..
Patch Set 3: Code-Review+1
(4 comments)
.
Matthew Dempsky has posted comments on this change.
Change subject: Emit a warning if (some) incompatible options are used.
..
Patch Set 5: Code-Review-1
(1 comment)
File d
Roberto Lublinerman has posted comments on this change.
Change subject: Emit a warning if (some) incompatible options are used.
..
Patch Set 4:
(1 comment)
File dev/core/sr
Hello Brian Slesinsky,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/1760
to look at the new patch set (#5).
Change subject: Emit a warning if (some) incompatible options are used.
.
Roberto Lublinerman has posted comments on this change.
Change subject: Fix an infinite loop in RPC deserialization due to type
variable cycles.
..
Patch Set 3: Code-Review+1
(1 comment)
...
Matthew Dempsky has posted comments on this change.
Change subject: Emit a warning if (some) incompatible options are used.
..
Patch Set 4:
(1 comment)
File dev/core/src/co
On 2013/01/22 15:46:27, arobison wrote:
Removed the new cell table builder and reworked to make the change in
AbstractCellTable instead. Removed the isKeyboardSelectable stuff.
Can you update the description to match the actual changes? (I must say
I'm a bit lost).
If it indeed is a fix for is
23 matches
Mail list logo
