[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-05-24 Thread John Ahlroos
John Ahlroos has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 3: (2 comments)

[gwt-contrib] Change in gwt[master]: RequestFactory: Enabling support for interfaces in @ProxyFor.

2013-05-24 Thread Manuel Carrasco Moñino
Manuel Carrasco Moñino has uploaded a new change for review. https://gwt-review.googlesource.com/2961 Change subject: RequestFactory: Enabling support for interfaces in @ProxyFor. .. RequestFactory: Enabling support for

[gwt-contrib] Change in gwt[master]: RequestFactory: Enabling support for interfaces in @ProxyFor.

2013-05-24 Thread Manuel Carrasco Moñino
Manuel Carrasco Moñino has uploaded a new patch set (#2). Change subject: RequestFactory: Enabling support for interfaces in @ProxyFor. .. RequestFactory: Enabling support for interfaces in @ProxyFor. Fixes issues #7509 and

[gwt-contrib] Trouble with gwt push (contributor agreement)

2013-05-24 Thread Matic Petek
Hi, I update Books section on gwtproject.org and I would like to send updates to Gerrit for review. I Sign Electronically cont. agreement (by filling the form). Should I do something alse? Thank you. Regards, Matic -- -- git push origin HEAD:refs/for/master Username for

[gwt-contrib] Change in gwt[master]: Removed unnecessary whitespace in JSONObject.toString.

2013-05-24 Thread Manuel Carrasco Moñino
Manuel Carrasco Moñino has posted comments on this change. Change subject: Removed unnecessary whitespace in JSONObject.toString. .. Patch Set 2: Code-Review+1 LGTM -- To view, visit https://gwt-review.googlesource.com/2430

[gwt-contrib] Change in gwt[master]: Cut circular dependency between c.g.g.core.linker and c.g.g....

2013-05-24 Thread Manuel Carrasco Moñino
Manuel Carrasco Moñino has posted comments on this change. Change subject: Cut circular dependency between c.g.g.core.linker and c.g.g.dev.js .. Patch Set 1: Code-Review+1 (2 comments) LGTM

[gwt-contrib] Change in gwt[master]: Cut circular dependency between c.g.g.core.linker and c.g.g....

2013-05-24 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Cut circular dependency between c.g.g.core.linker and c.g.g.dev.js .. Patch Set 1: (1 comment) File

[gwt-contrib] Change in gwt[master]: Cut circular dependency between c.g.g.core.linker and c.g.g....

2013-05-24 Thread Manuel Carrasco Moñino
Manuel Carrasco Moñino has posted comments on this change. Change subject: Cut circular dependency between c.g.g.core.linker and c.g.g.dev.js .. Patch Set 1: (1 comment)

Re: [gwt-contrib] Re: Generator, get method body

2013-05-24 Thread Manuel Carrasco Moñino
It seems that the eclipse-jdt-core included in GWT doesnt have certain classes like ASTParser. I would give a try including the eclipse dependency in my pom.xml. On Fri, May 24, 2013 at 2:35 AM, John A. Tamplin j...@jaet.org wrote: On Thu, May 23, 2013 at 7:56 PM, Manuel Carrasco Moñino

Re: [gwt-contrib] Re: Generator, get method body

2013-05-24 Thread Manuel Carrasco Moñino
Good to know. thanks. On Fri, May 24, 2013 at 6:54 AM, Roberto Lublinerman rlu...@google.comwrote: Even if it were accessible to the generators the GWT AST does not contain javadocs nor comments. Roberto Lublinerman | Software Engineer | rlu...@google.com | 408-500-9148 On Thu, May 23,

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-05-24 Thread John Ahlroos
Hello Leeroy Jenkins, Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2900 to look at the new patch set (#4). Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload

[gwt-contrib] Change in gwt[master]: Add History.getUrl(String token) which returns the correspon...

2013-05-24 Thread Johannes Barop
Johannes Barop has uploaded a new patch set (#2). Change subject: Add History.getUrl(String token) which returns the corresponding URL for a history token. .. Add History.getUrl(String token) which returns the corresponding

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-05-24 Thread John Ahlroos
John Ahlroos has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 4: Patch Set 4 now bumps the default version number and changes the

Re: [gwt-contrib] Re: Generator, get method body

2013-05-24 Thread Roberto Lublinerman
ASTParser should be in eclipse-jdt-core, although there seems to be different AST representation, GWT uses the one in org.eclipse.jdt.internal.compiler.ast whereas the ASTParser works in org.eclipse.jdt.core.dom. JDT has a very thick api to support the eclipse editor and some simple tasks might

[gwt-contrib] Change in gwt[master]: Add History.getUrl(String token) which returns the correspon...

2013-05-24 Thread Jens Nehlmeier
Jens Nehlmeier has posted comments on this change. Change subject: Add History.getUrl(String token) which returns the corresponding URL for a history token. .. Patch Set 2: (2 comments)

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-05-24 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 4: (6 comments) Looking at the history, I stumbled on another case

Re: [gwt-contrib] Re: Generator, get method body

2013-05-24 Thread John A. Tamplin
On Fri, May 24, 2013 at 6:33 AM, Roberto Lublinerman rlu...@google.comwrote: ASTParser should be in eclipse-jdt-core, although there seems to be different AST representation, GWT uses the one in org.eclipse.jdt.internal.compiler.ast whereas the ASTParser works in org.eclipse.jdt.core.dom. JDT

[gwt-contrib] Re: Trouble with gwt push (contributor agreement)

2013-05-24 Thread Patrick Tucker
On there left there is a link HTTP Password. If you haven't already, you have to click that to get the password that you will use for authentication. On Thursday, May 23, 2013 6:51:55 PM UTC-4, Matic Petek wrote: Hi, I update Books section on gwtproject.org and I would like to send

[gwt-contrib] Change in gwt[master]: working on issue 8063, ie10 permutation and ms pointer events

2013-05-24 Thread Manuel Carrasco Moñino
Manuel Carrasco Moñino has posted comments on this change. Change subject: working on issue 8063, ie10 permutation and ms pointer events .. Patch Set 4: Matti the patch looks good to me, but I dont understand why you

[gwt-contrib] Re: Trouble with gwt push (contributor agreement)

2013-05-24 Thread Matic Petek
Hi, I already obtain this password and use it for username and password. And I also try with .netrc file. No luck. I'm still getting the some error message. On Friday, May 24, 2013 2:49:50 PM UTC+2, Patrick Tucker wrote: On there left there is a link HTTP Password. If you haven't

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-05-24 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 4: (1 comment)

[gwt-contrib] Re: Trouble with gwt push (contributor agreement)

2013-05-24 Thread Patrick Tucker
Is your contact info filled in? The error indicates that it isn't... On Friday, May 24, 2013 10:37:07 AM UTC-4, Matic Petek wrote: Hi, I already obtain this password and use it for username and password. And I also try with .netrc file. No luck. I'm still getting the some error

[gwt-contrib] Change in gwt[master]: working on issue 8063, ie10 permutation and ms pointer events

2013-05-24 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: working on issue 8063, ie10 permutation and ms pointer events .. Patch Set 5: Gerrit has minimal formatting support (only paragraphs, preformatted text

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-05-24 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 4: (4 comments) To add to the versioning mess, there are Google

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-05-24 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 4: (1 comment) We need to take a decision re. supporting version 7 in

[gwt-contrib] Change in gwt[master]: Add History.getUrl(String token) which returns the correspon...

2013-05-24 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Add History.getUrl(String token) which returns the corresponding URL for a history token. .. Patch Set 2: I'm still not sure how we want to move forward

[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...

2013-05-24 Thread Roberto Lublinerman
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2910 to look at the new patch set (#5). Change subject: Chooses a default GWT source level to match the current java runtime.

[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...

2013-05-24 Thread Roberto Lublinerman
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2910 to look at the new patch set (#6). Change subject: Chooses a default GWT source level to match the current java runtime.

[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...

2013-05-24 Thread Roberto Lublinerman
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2910 to look at the new patch set (#7). Change subject: Chooses a default GWT source level to match the current java runtime.

[gwt-contrib] Change in gwt[master]: Fix module unloading with multiple modules on a page

2013-05-24 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Fix module unloading with multiple modules on a page .. Patch Set 1: (Hm, I thought I already posted this as a comment last night.) I agree this is

[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...

2013-05-24 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Chooses a default GWT source level to match the current java runtime. .. Patch Set 4: (2 comments) Argh, apparently these comments didn't get posted when

[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...

2013-05-24 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Chooses a default GWT source level to match the current java runtime. .. Patch Set 7: Code-Review+2 Nice. -- To view, visit

[gwt-contrib] Doing migrations one step at a time

2013-05-24 Thread Brian Slesinsky
Following up on discussion in: https://gwt-review.googlesource.com/#/c/2900/ There's been some talk about dropping IE 6/7 and it's confused the conversation a bit. I'd like to distinguish between what happens short term and how things will look by our next stable release. I expect that by GWT

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-05-24 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 4: Okay, I started a discussion in contrib:

[gwt-contrib] Change in gwt[master]: Fixes ISSUE 7079 - Add support for the newer bindery Handler...

2013-05-24 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Fixes ISSUE 7079 - Add support for the newer bindery HandlerRegistration .. Patch Set 2: (1 comment)

[gwt-contrib] Change in gwt[master]: Removes the static book keeping in the Timer class.

2013-05-24 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Removes the static book keeping in the Timer class. .. Patch Set 1: Verified+1 -- To view, visit https://gwt-review.googlesource.com/2851 To unsubscribe,

[gwt-contrib] Change in gwt[master]: Removes the static book keeping in the Timer class.

2013-05-24 Thread Goktug Gokdogan
Goktug Gokdogan has submitted this change and it was merged. Change subject: Removes the static book keeping in the Timer class. .. Removes the static book keeping in the Timer class. This changes removes code that keeps

[gwt-contrib] Change in gwt[master]: Add History.getUrl(String token) which returns the correspon...

2013-05-24 Thread Johannes Barop
Johannes Barop has posted comments on this change. Change subject: Add History.getUrl(String token) which returns the corresponding URL for a history token. .. Patch Set 2: The first alternative is HyperlinkImpl. But this

[gwt-contrib] Change in gwt[master]: Add History.getUrl(String token) which returns the correspon...

2013-05-24 Thread Johannes Barop
Johannes Barop has uploaded a new patch set (#3). Change subject: Add History.getUrl(String token) which returns the corresponding URL for a history token. .. Add History.getUrl(String token) which returns the corresponding

[gwt-contrib] Re: Doing migrations one step at a time

2013-05-24 Thread Thomas Broyer
On Saturday, May 25, 2013 12:57:09 AM UTC+2, Brian Slesinsky wrote: Following up on discussion in: https://gwt-review.googlesource.com/#/c/2900/ There's been some talk about dropping IE 6/7 and it's confused the conversation a bit. I'd like to distinguish between what happens short term

Re: [gwt-contrib] Re: Doing migrations one step at a time

2013-05-24 Thread Brian Slesinsky
On Fri, May 24, 2013 at 5:53 PM, Thomas Broyer t.bro...@gmail.com wrote: On Saturday, May 25, 2013 12:57:09 AM UTC+2, Brian Slesinsky wrote: Following up on discussion in: https://gwt-review.** googlesource.com/#/c/2900/https://gwt-review.googlesource.com/#/c/2900/ There's been some talk

Re: [gwt-contrib] Re: Doing migrations one step at a time

2013-05-24 Thread John A. Tamplin
On Fri, May 24, 2013 at 8:53 PM, Thomas Broyer t.bro...@gmail.com wrote: BTW, disabling the IE6/7 permutation is only a matter of set-property name=user.agent value=ie8,ie9,gecko1_8,safari,opera/ right? Removing support would start by removing the ie6 permutation and then cleaning up the code