Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3611
Change subject: Let ValueListBox implement HasEnabled
..
Let ValueListBox implement HasEnabled
fixes issue 6112
Change-Id:
Jens Nehlmeier has posted comments on this change.
Change subject: Let ValueListBox implement HasEnabled
..
Patch Set 1: Code-Review+1
Nit-pick: You might want to use assertTrue/assertFalse instead of
assertEquals
--
To
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3612
Change subject: Making DialogBox clear handlers on auto hide
..
Making DialogBox clear handlers on auto hide
fixes issue 6356
Daniel Kurka has uploaded a new patch set (#2).
Change subject: Making DialogBox clear handlers on auto hide
..
Making DialogBox clear handlers on auto hide
fixes issue 6356
Change-Id:
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3613
Change subject: Add wrap method to Canvas
..
Add wrap method to Canvas
fixes issue 6683
Change-Id:
Thomas Broyer has posted comments on this change.
Change subject: Let ValueListBox implement HasEnabled
..
Patch Set 1: Code-Review+2
I'd too prefer assertTrue/assertFalse but otherwise LGTM.
--
To view, visit
Thomas Broyer has posted comments on this change.
Change subject: Making DialogBox clear handlers on auto hide
..
Patch Set 2: Code-Review+1
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Add wrap method to Canvas
..
Patch Set 1: Code-Review+1
(2 comments)
File
Thomas Broyer has posted comments on this change.
Change subject: Fix javadoc in JsDate to list correct number for december
..
Patch Set 1: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3610
To
Thomas Broyer has submitted this change and it was merged.
Change subject: Fix javadoc in JsDate to list correct number for december
..
Fix javadoc in JsDate to list correct number for december
fixes issue 8212
Change-Id:
Daniel Kurka has posted comments on this change.
Change subject: Add wrap method to Canvas
..
Patch Set 1:
(2 comments)
File
Hello Leeroy Jenkins, Thomas Broyer,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3613
to look at the new patch set (#2).
Change subject: Add wrap method to Canvas
..
Add wrap
Hello Leeroy Jenkins, Thomas Broyer, Jens Nehlmeier,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3611
to look at the new patch set (#2).
Change subject: Let ValueListBox implement HasEnabled
Thomas Broyer has posted comments on this change.
Change subject: Add wrap method to Canvas
..
Patch Set 2:
(1 comment)
File
Thomas Broyer has submitted this change and it was merged.
Change subject: Let ValueListBox implement HasEnabled
..
Let ValueListBox implement HasEnabled
fixes issue 6112
Change-Id: Ib866657960d0a3d41e0b3b1f08fa9a97091149a9
Thomas Broyer has posted comments on this change.
Change subject: Let ValueListBox implement HasEnabled
..
Patch Set 2: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3611
To unsubscribe, visit
Daniel Kurka has posted comments on this change.
Change subject: Add wrap method to Canvas
..
Patch Set 2:
(1 comment)
File
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3614
Change subject: Add toString to SafeHtmlString to help debuging
..
Add toString to SafeHtmlString to help debuging
Change-Id:
Hello Thomas Broyer, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3612
to look at the new patch set (#3).
Change subject: Making DialogBox clear handlers on auto hide
Daniel Kurka has posted comments on this change.
Change subject: Making DialogBox clear handlers on auto hide
..
Patch Set 3:
I think not duplicating code, but adding a test is the best way to go here.
--
To view, visit
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3615
Change subject: Undeprecate setMultipleSelect in ListBox
..
Undeprecate setMultipleSelect in ListBox
Changing ListBox from multi
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3616
Change subject: Add Object.clone as throwing implementation
..
Add Object.clone as throwing implementation
fixes issue 5068
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3616
to look at the new patch set (#2).
Change subject: Add Object.clone as throwing implementation
..
Add
John A. Tamplin has posted comments on this change.
Change subject: Add Object.clone as throwing implementation
..
Patch Set 2: Code-Review+1
(1 comment)
File
Daniel Kurka has posted comments on this change.
Change subject: Add Object.clone as throwing implementation
..
Patch Set 2:
(1 comment)
File
Hello John A. Tamplin, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3616
to look at the new patch set (#3).
Change subject: Add Object.clone as throwing implementation
Hello John A. Tamplin, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3616
to look at the new patch set (#4).
Change subject: Add Object.clone as throwing implementation
Daniel Kurka has posted comments on this change.
Change subject: changes for 5113
..
Patch Set 1:
Could you update the commit message (git commit --amend) to say something
like:
Fix os detection in I18NCreater
John A. Tamplin has posted comments on this change.
Change subject: Add Object.clone as throwing implementation
..
Patch Set 4: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/3616
To unsubscribe, visit
Thomas Broyer has posted comments on this change.
Change subject: changes for 5113
..
Patch Set 1:
(1 comment)
File user/src/com/google/gwt/i18n/tools/I18NCreator.java
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3617
Change subject: Make DateCell use non deprecated DateTimeFormat
..
Make DateCell use non deprecated DateTimeFormat
fixes issue
Daniel Kurka has uploaded a new patch set (#2).
Change subject: Make DateCell use non deprecated DateTimeFormat
..
Make DateCell use non deprecated DateTimeFormat
fixes issue 8201
Change-Id:
Thomas Broyer has posted comments on this change.
Change subject: Making DialogBox clear handlers on auto hide
..
Patch Set 3: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3612
To unsubscribe, visit
Thomas Broyer has posted comments on this change.
Change subject: Undeprecate setMultipleSelect in ListBox
..
Patch Set 1: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/3615
To unsubscribe, visit
Thomas Broyer has posted comments on this change.
Change subject: Add toString to SafeHtmlString to help debuging
..
Patch Set 1: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3614
To unsubscribe, visit
Thomas Broyer has posted comments on this change.
Change subject: Add Object.clone as throwing implementation
..
Patch Set 4: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/3616
To unsubscribe, visit
Thomas Broyer has posted comments on this change.
Change subject: Make DateCell use non deprecated DateTimeFormat
..
Patch Set 2: Code-Review-1
This seems overly convoluted: client.DateTimeFormat extends
Hello Thomas Broyer, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3617
to look at the new patch set (#3).
Change subject: Make DateCell use non deprecated DateTimeFormat
Daniel Kurka has posted comments on this change.
Change subject: Make DateCell use non deprecated DateTimeFormat
..
Patch Set 3:
You are right Thomas, I missed the inheritance since I only took a look at
shared...
--
To
Thomas Broyer has posted comments on this change.
Change subject: Make DateCell use non deprecated DateTimeFormat
..
Patch Set 3: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/3617
To unsubscribe, visit
40 matches
Mail list logo
