Re: [gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread Manuel Carrasco Moñino
I agree 100%, the friction for contributing this project is huge. Not only the setup of the project, but the review process, tools, build, etc. We are trying to improve the process, right now contribution to the documentation has been enormously simplified (please don't hesitate improve to the

Re: [gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread Richard Wallis
Thanks Thomas Manuel for the handholding :) Managed to find git bash and create the cookie. If anyone has the time, please can the contribution process be made more standardized. On Mon, Feb 9, 2015 at 5:11 PM, Manuel Carrasco Moñino man...@apache.org wrote: On Mon, Feb 9, 2015 at 2:47 PM,

Re: [gwt-contrib] What constitutes an acceptable emulated String.format implementation?

2015-02-09 Thread Colin Alworth
Its not that 3k is huge, its that it would be (to a developer, accustomed to GWT's policies) massively larger than normally expected for built-in methods. Just ran SOYC on a project (OBF but not closure), and the largest java.lang.String method is 466 bytes, greater than twice the size of the next

[gwt-contrib] Javascript Exceptions in SDM about classes not being defined

2015-02-09 Thread Ali Akhtar
I'm using 2.8.0-SNAPSHOT, from https://github.com/manolo/gwt-snapshot/raw/master/ When I try to invoke the following method: public ClerkD setEvents(HasValue?... fields) { for (HasValue? f : fields) { f.addValueChangeHandler( e - validate() ); }

Re: [gwt-contrib] GWT 2.8.0-SNAPSHOT

2015-02-09 Thread Ali Akhtar
Hey Manuel, I'm using your linked repo, but I'm not sure if its updating. Defender methods were added a few days ago, however when I try to use them within client code, I get an 'undefined' javascript error. -- You received this message because you are subscribed to the Google Groups GWT

Re: [gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread Manuel Carrasco Moñino
On Mon, Feb 9, 2015 at 4:15 PM, Richard Wallis rdwal...@gmail.com wrote: Thanks Thomas Manuel for the handholding :) Managed to find git bash and create the cookie. If anyone has the time, please can the contribution process be made more standardized. What do you mean as standard, accept

Re: [gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread Richard Wallis
I know it's too much to ask to move the project to github. But even the authentication on this project is not done in the standard way. Last time I tried to submit a patch I was stuck for days because I'd done the checkout with --depth 1. There's a lot of friction to contributing to this

Re: [gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread Manuel Carrasco Moñino
On Mon, Feb 9, 2015 at 2:47 PM, Richard Wallis rdwal...@gmail.com wrote: Thanks for the help. I've contributed before, so everything is setup. I just need the password (Is this not possible?). It's a bit too much to ask Windows users to install cygwin, I'll setup a vm if it's not possible

Re: [gwt-contrib] GWT 2.8.0-SNAPSHOT

2015-02-09 Thread Manuel Carrasco Moñino
It was updated yesterday with all the stuff in master, so those changes should be there. Today is going to be run in a couple of hours, although there are no changes in the repo. Try to force your maven cache to be updated: mvn -U On Tue, Feb 10, 2015 at 7:39 AM, Ali Akhtar ali.rac...@gmail.com

Re: [gwt-contrib] Javascript Exceptions in SDM about classes not being defined

2015-02-09 Thread 'Daniel Kurka' via GWT Contributors
This looks like the same compiler bug we are currently investigating, for now you can clear your SDM cache (button on its page) and you should be able to continue. On Tue, Feb 10, 2015 at 7:16 AM, Ali Akhtar ali.rac...@gmail.com wrote: I'm using 2.8.0-SNAPSHOT, from

Re: [gwt-contrib] What constitutes an acceptable emulated String.format implementation?

2015-02-09 Thread 'Goktug Gokdogan' via GWT Contributors
Also Daniel's point about compile-time errors are important. That could be potentially handled with error-prone checkers. On Mon, Feb 9, 2015 at 9:39 AM, Goktug Gokdogan gok...@google.com wrote: On Fri, Feb 6, 2015 at 8:31 PM, Benjamin DeLillo bpd9...@gmail.com wrote: For an implementation

Re: [gwt-contrib] What constitutes an acceptable emulated String.format implementation?

2015-02-09 Thread 'Goktug Gokdogan' via GWT Contributors
On Fri, Feb 6, 2015 at 8:31 PM, Benjamin DeLillo bpd9...@gmail.com wrote: For an implementation to be accepted would it have to conform to the entire Java Formater spec? http://docs.oracle.com/javase/7/docs/api/java/util/Formatter.html We may have 'known' limitations. Would an

Re: [gwt-contrib] What constitutes an acceptable emulated String.format implementation?

2015-02-09 Thread 'Daniel Kurka' via GWT Contributors
Hi Benjamin, thanks for reaching out to us. Answers are inline. On Sat, Feb 7, 2015 at 5:31 AM, Benjamin DeLillo bpd9...@gmail.com wrote: For an implementation to be accepted would it have to conform to the entire Java Formater spec?

[gwt-contrib] A little change on two http.client.Request modifiers

2015-02-09 Thread Danilo Reinert
Currently I'm using the http.client.Request class without the RequestBuilder for a project I'm working on, and I need to change the access level of two members from package to public: L148 https://gwt.googlesource.com/gwt/+/master/user/src/com/google/gwt/http/client/Request.java#148 (Ctor

Re: [gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread Richard Wallis
Sorry, spoke to soon. Daniel obtain password under HTTP password also redirects to the create a cookie page. Can I not read the password out of the cookie somehow? On Mon, Feb 9, 2015 at 3:52 PM, Richard Wallis rdwal...@gmail.com wrote: Thanks Daniel, maybe the gerrit failed authentication

Re: [gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread Julien Dramaix
I don't think you can read the password. During the contributor workshop, several people have had this problem and resetting the password using: https://gwt.googlesource.com/new-password solve the issue. Julien On Mon Feb 09 2015 at 2:54:44 PM Richard Wallis rdwal...@gmail.com wrote: Sorry,

Re: [gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread Richard Wallis
https://gwt.googlesource.com/new-password is the page that everything else directs to. It tells me how to setup a cookie. On Mon, Feb 9, 2015 at 3:59 PM, Julien Dramaix julien.dram...@gmail.com wrote: I don't think you can read the password. During the contributor workshop, several people

Re: [gwt-contrib] What constitutes an acceptable emulated String.format implementation?

2015-02-09 Thread Benjamin DeLillo
Dan, Thanks for the response. sprintf.js is 3kB minified and 7.5kB uncompressed weighing in at just under 200 LoC, you mention this would be too big. Just how small would an implementation have to be to be acceptable? How large are other JRE emulation implementations by comparison? I spoke

Re: [gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread Manuel Carrasco Moñino
You cannot submit your patch via github. In windows, probably your git installation comes with a terminal where you can copy and paste the instructions google give you to setup your cookies. Otherwise I recommend to install cygwin, it comes with a terminal which almost emulates a unix system

Re: [gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread Richard Wallis
Thanks Daniel, maybe the gerrit failed authentication prompt should point there: At the moment it reads: Please generate a new password at: https://gwt.googlesource.com/new-password Anyway thanks for the help everyone. On Mon, Feb 9, 2015 at 3:49 PM, 'Daniel Kurka' via GWT Contributors

Re: [gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread Richard Wallis
Thanks for the help. I've contributed before, so everything is setup. I just need the password (Is this not possible?). It's a bit too much to ask Windows users to install cygwin, I'll setup a vm if it's not possible to get a password. Julien, I've read through the slides and they seem to have

Re: [gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread 'Daniel Kurka' via GWT Contributors
Here is how you do it: 1. Go to http://gwt-review.googlesource.com 2. Upper left corner press on the arrow right of our login name 3. Press preferences 4. Press HTTP Password 5. Press Obtain password -Daniel On Mon, Feb 9, 2015 at 2:47 PM, Richard Wallis rdwal...@gmail.com wrote: Thanks for

[gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread Richard Wallis
Hi, trying to submit a patch and I can't authenticate. I go to https://gwt.googlesource.com I click generate password and I get instructions on how to generate a cookie on a Unix system. I'm on Windows. I have signed the contributor agreement. Can I submit my patch via github? -- You

Re: [gwt-contrib] A little change on two http.client.Request modifiers

2015-02-09 Thread Julien Dramaix
Hi Danilo, The best is to propose the change by submitting a CL in gerrit and start the discussion there. Julien On Mon Feb 09 2015 at 12:37:01 PM Danilo Reinert danilorein...@gmail.com wrote: Currently I'm using the http.client.Request class without the RequestBuilder for a project I'm

Re: [gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread Julien Dramaix
Richard, You could find interesting information on how to contribute by reading the documents we've written for the contributor workshop at gwtcreate this year: Preparation step for the workshop: http://goo.gl/F4pk0V Workshop slides:

Re: [gwt-contrib] Where do I find my password for gerrit?

2015-02-09 Thread Thomas Broyer
On Monday, February 9, 2015 at 3:04:34 PM UTC+1, Richard Wallis wrote: https://gwt.googlesource.com/new-password is the page that everything else directs to. It tells me how to setup a cookie. When I open that page, I see a Windows Users ↴ yellow box. Clicking on it, it then says “We