Yep.
Dan
On Sun, May 1, 2011 at 8:00 PM, wrote:
> @rice -
>
> Will you have time to review this on Monday? I'd like to get it
> submitted this week.
>
> On 2011/04/27 18:14:47, Jeff Larsen wrote:
>>
>> On 2011/04/26 21:10:21, jlabanca wrote:
>> > On Tue, Apr 26, 2011 at 4:57 PM, Jeff Larsen
I did the reimplementation. Being less familiar with the intricacies of
JavaScript, it seems likely that I missed an opportunity to preserve the
nativeness of the array. I'd be happy to take a look at this after the 2.3
release.
On Mon, Mar 28, 2011 at 5:52 PM, Scott Blum wrote:
> Something sm
I spent a few days attempting this -- it's not so simple. For example:
1) Enums can't extend Enums. Several public types contain nested Enums.
2) If a type oldA extends newA, and a method in it returns an instance of
oldA, you cant simply delegate to the implementation in newA since that will
Here's a manual diff. Is there some slick way to upload it to
Mondrian or Rietveld that won't make them confused?
Dan
On Thu, Jan 20, 2011 at 3:52 PM, wrote:
> Can you upload a diff relative to what you checked in before you rolled
> it back? I just want to see what you fixed relative to th
I saw 4.5% on the uncompressed size.
Dan
On Tue, Jan 18, 2011 at 4:39 PM, Ray Cromwell wrote:
> I'm curious, has there been any measurement/data as to the effect this
> has on output size?
>
> On Mon, Jan 17, 2011 at 1:18 PM, wrote:
>> LGTM, just nits. No need to re-review.
>>
>>
>> http://
That would work for this package, but other HTML5 stuff involves
additions to core GWT classes, unlike the situation we had with cell
widgets last time. It seems like it would be tough for stuff in
gwt-user to have dependencies on bikeshed, and even tougher to avoid
such dependencies while still
Sure, consistency Я we
On Mon, Oct 18, 2010 at 6:13 PM, Ray Ryan wrote:
> If you're really up for it Dan, us ♥ consistency.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I'm wiling to switch everything over to package-info.java. FYI,
right now I see only 12 instances of package-info.java.
Dan
On Mon, Oct 18, 2010 at 4:59 PM, wrote:
> We have been using package-info.java instead, where we can also use
> annotations and get refactoring support. Why do we want
Made changes and re-uploaded to rietveld
On Thu, Oct 14, 2010 at 12:58 PM, wrote:
> Thanks for doing this.
>
> LGTM, with nits.
>
>
> http://gwt-code-reviews.appspot.com/1002801/diff/1/2
> File user/src/com/google/gwt/editor/client/AutoBean.java (right):
>
> http://gwt-code-reviews.appspot.com/1
LGTM
Can you add a comment to that effect
On Thu, Oct 14, 2010 at 10:09 AM, wrote:
>
> http://gwt-code-reviews.appspot.com/997801/diff/1/3
> File user/src/com/google/gwt/user/cellview/client/CellTree.java (right):
>
> http://gwt-code-reviews.appspot.com/997801/diff/1/3#newcode479
> user/src/com
I do plan to rewrite it, but this should unbreak the windows build
for the time being.
On Mon, Oct 11, 2010 at 4:14 PM, wrote:
> Why not just rewrite the shell script as a Java app, like we did for
> WebAppCreator/etc?
>
> If not, I would prefer to just have the static file used everywhere so
This emulates JRE behavior, as pointed out in
http://code.google.com/p/google-web-toolkit/issues/detail?id=5297.
Dan
On Tue, Oct 5, 2010 at 5:11 PM, wrote:
>
> http://gwt-code-reviews.appspot.com/962801/diff/1/2
> File user/super/com/google/gwt/emul/java/util/AbstractCollection.java
> (right)
Somehow a class like "P extends BlahBlahBlah" was being treated as
real class, resulting in a generated "PImpl" class which broke all
kinds of ways. I need to put a breakpoint at that line to see if it
still happens and try to deal with the issue further upstream.
Dan
On Wed, Sep 29, 2010 at 7:5
You got it.
On Tue, Sep 21, 2010 at 8:47 PM, Ray Cromwell wrote:
>
> I'll review this after my patch lands, please don't commit it before then.
>
> On Tue, Sep 21, 2010 at 5:46 PM, wrote:
>>
>> Reviewers: rjrjr, cromwellian,
>>
>> Description:
>> Rename RequestObject->Request and pull the 'with'
Fixed and re-uploaded.
On Fri, Sep 17, 2010 at 12:36 PM, wrote:
> no suffix, please. It should be PlaceChangeRequest
>
> On 2010/09/17 16:32:11, rice wrote:
>
>
>
>
> http://gwt-code-reviews.appspot.com/894801/show
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Sorry, I took the lead from the pre-existing comment on line 35...
Dan
On Fri, Sep 17, 2010 at 12:36 PM, wrote:
> no suffix, please. It should be PlaceChangeRequest
>
> On 2010/09/17 16:32:11, rice wrote:
>
>
>
>
> http://gwt-code-reviews.appspot.com/894801/show
>
--
http://groups.google.co
Make sure you are changing all the users of the interface as well.
Dan
On Tue, Sep 7, 2010 at 5:23 PM, wrote:
> In this case, setSafeHtml() is the method defined in the interface
> HasSafeHtml. I am changing this to setHTML(SafeHtml), and the interface
> as well.
>
> http://gwt-code-reviews.ap
This isn't really working in prod mode so you can hold off on reviewing if
you'd prefer.
Dan
On Fri, Sep 3, 2010 at 4:16 PM, wrote:
> Reviewers: jlabanca,
>
> Description:
> Implement keyboard navigation for CellBrowser
>
>
> Please review this at http://gwt-code-reviews.appspot.com/843801/sh
Fortunately, we never actually extend Cell in any of the bikeshed code.
Dan
On Mon, Aug 30, 2010 at 2:55 PM, wrote:
> I'm pretty sure we extend Cell in the Expenses sample, and in the
> Scaffold and Cookbook (what remains) in bikeshed. Please make sure to
> update these too.
>
>
> http://gwt
I've had it off but I noticed in one of the changes this morning that an
@Override tag was (correctly) added and was curious enough to check the
setting. I would like to be able to enable warnings in my own Eclipse since
there are benefits to getting it right (namely avoiding accidental
non-over
LGTM
On Fri, Aug 6, 2010 at 10:00 AM, wrote:
> Reviewers: Dan Rice,
>
> Description:
> Adding missing keyboardSelected styles to CellTable.css sub classes used
> by ExpenseList and ExpenseDetails.
>
>
> Please review this at http://gwt-code-reviews.appspot.com/713803/show
>
> Affected files:
>
Yes, I'll upload it in a sec.
Dan
On Thu, Aug 5, 2010 at 1:12 PM, Ray Ryan wrote:
> Ready for re-review?
>
>
> On Wed, Aug 4, 2010 at 1:39 PM, wrote:
>
>> http://gwt-code-reviews.appspot.com/722802/show
>>
>
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Actually CellTreeNodeView is still work in progress and won't be submitted
as part of the current CL. Sorry for the confusion.
On Mon, Aug 2, 2010 at 12:14 PM, wrote:
> LGTM
>
>
> http://gwt-code-reviews.appspot.com/710802/diff/1013/10009
> File user/src/com/google/gwt/user/cellview/client/Cell
We probably don't need these tests to run in full for every test cycle.
They would be useful, though, to run as smoke tests when new browser
versions are released. If there is a way to keep the test code around but
only invoke it infrequently I would be in favor of that.
Dan
On Tue, Jun 29, 2
On Fri, Jun 25, 2010 at 6:18 PM, wrote:
>
> Just like in "plain JavaScript", the following would actually create an
> "ab" property with no trace of (tested in Safari 5 on Windows):
> var o = {};
> o['a\u2028b'] = 'c';
> That's a bug in JavaScriptCore that can hardly be worked around, so I
>
Looks like the code is still the same as what he is seeing -- I
haven't seen the stack trace and don't know how to repo it but the fix
seems reasonable.
Dan
On Mon, Jun 21, 2010 at 3:22 PM, Joel Webber wrote:
> Thanks, Stephen.
> @Dan: Is this still applicable, or has it been fixed already?
>
Currently it's made by stripping things out of gwt-user.jar. I'll look
into how to add a class from dev to it.
Dan
On Thu, Jun 17, 2010 at 4:50 PM, John Tamplin wrote:
> On Thu, Jun 17, 2010 at 4:19 PM, Daniel Rice (דניאל רייס) > wrote:
>
>> Is there any place t
Is there any place that can be shared between dev and gwt-servlet.jar?
Dan
On Thu, Jun 17, 2010 at 4:18 PM, wrote:
> LGTM, though the code duplication is ugly.
>
>
>
> http://gwt-code-reviews.appspot.com/639801/show
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
wrote:
> Why not change deRPC?
>
> On Thu, Jun 17, 2010 at 9:11 AM, Daniel Rice (דניאל רייס) > wrote:
>
>> We thought about this, but the conclusion was that it would be better
>> not to expose yet another internal format. We do use this format for the
>> deRPC
We thought about this, but the conclusion was that it would be better not
to expose yet another internal format. We do use this format for the deRPC
implementation.
Dan
On Thu, Jun 17, 2010 at 12:08 PM, wrote:
>
> If they're being eval'ed, why not transmit the long as a JSON triple,
> like [
d).
I can give #4 a whirl. The only issue I have is whether this requires an
RPC version bump, and if it needs to maintain backwards compatibility.
Dan
On Fri, Jun 11, 2010 at 3:11 PM, John Tamplin wrote:
> On Fri, Jun 11, 2010 at 3:07 PM, Daniel Rice (דניאל רייס) > wrote:
>
>>
Right now, the standard RPC format hasn't changed (although deRPC has,
since the whole point if to be able to eval the payload into the client).
So anyone who has a custom RPC system needs a way to generate a double[2]
from a long.
Longer term, I'd like to transmit longs as an int[3] instead,
LGTM
On Tue, Apr 20, 2010 at 4:39 AM, wrote:
> Reviewers: Dan Rice,
>
> Description:
> Two small fixes:
> - on my work laptop I would get lines way too big for the font size,
> and on my home machine the underscores would get dropped because the
> lines weren't quite large enough. I'm not posi
FYI this still needs review for the changes in IFrameLinker
(checkstyle) and PrecompressLinkerTest (removing use of
String.getBytes(Charset)).
Dan
On Mon, Mar 29, 2010 at 12:29 PM, wrote:
> Reviewers: Lex,
>
> Description:
> Remove JDK 1.6-isms; fix a checkstyle warning
>
>
> Please review th
implementation could still manage to share state between created instances
in some cases.
Dan
On Thu, Mar 25, 2010 at 1:58 PM, Bruce Johnson wrote:
> On 3/25/10, Daniel Rice (דניאל רייס) wrote:
> > I disagree with point (1). The APIs are not the same, just almost the
> > same. I
I disagree with point (1). The APIs are not the same, just almost the
same. IMHO the builder should have a freeze method while the MutableArray
should not. This makes it clear that freezing is a build-time process. It
seems to me that this could be done with a little interface inheritance and
LGTM
On Tue, Mar 16, 2010 at 9:54 PM, wrote:
> Can you look again? I've made a few updates.
>
>
> http://gwt-code-reviews.appspot.com/224801
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I did, checkstyle runs out of memory on the old version!
Dan
On Tue, Mar 16, 2010 at 4:13 PM, wrote:
> LGTM, presuming that you meant to include the symbols change in this
> patch
>
>
> http://gwt-code-reviews.appspot.com/218801
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contrib
What is 'com.google.gwt.*' in the file/dir list referring to?
Dan
On Tue, Mar 16, 2010 at 3:00 PM, wrote:
> Reviewers: Dan Rice,
>
> Description:
> Update bikeshed/eclipse.README based on feedback from Dan
> Review by: r...@google.com
>
> Please review this at http://gwt-code-reviews.appspot.
LGTM
On Tue, Jan 26, 2010 at 12:26 PM, wrote:
> Reviewers: Dan Rice,
>
> Description:
> As the title says.
> http://code.google.com/p/google-web-toolkit/issues/detail?id=3757
>
> Fix:
> I swapped the row and column.
>
> Testing:
> I added a unit test to test this.
>
> Please review this at http:
Agreed, the worst case is that the error message will be less than fully
helpful.
On Thu, Jan 14, 2010 at 12:01 PM, wrote:
> On 2010/01/14 16:02:34, Dan Rice wrote:
>
>> LGTM
>>
>
> I'm trying to think if this will encounter a problem in the Turkish
>>
> locale but I
>
>> think it should be O
No, I thought it would avoid a warning in Eclipse but Eclipse seems
fine with it.
Dan
On Tue, Dec 22, 2009 at 11:55 AM, wrote:
> LGTM
>
>
> http://gwt-code-reviews.appspot.com/126816/diff/1/7
> File user/src/com/google/gwt/core/client/GWT.java (right):
>
> http://gwt-code-reviews.appspot.com/
No, what do I need to do for that?
Dan
On Thu, Dec 3, 2009 at 11:09 AM, wrote:
> Did you test this case with the deRPC code base?
>
> http://gwt-code-reviews.appspot.com/118802
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Window.setIconImages was introduced in Java 1.6. This doesn't compile on 1.5.
Dan
On Tue, Nov 17, 2009 at 5:52 PM, wrote:
> Revision: 6973
> Author: j...@google.com
> Date: Tue Nov 17 14:51:47 2009
> Log: Adds additional icon sizes so Alt-Tab (etc) doesn't try and scale up
> the 16x16
> icon
A quick and dirty test on Mac/Safari shows that the output of "Hello
World! " + 3.1415926535E-20 + " " + 123456789 is not sensitive to the system
locale setting. The numerical output uses a '.' and a lower-case 'e'.
Dan
On Tue, Nov 17, 2009 at 8:09 PM
My thinking is that unless we provide an implementation of Double.toString,
we are best off trying to be consistent with the implementation at hand. If
we use Double.toString (i.e., just Javascript native double-to-string
conversion) some of the time, and use arithmetic ops to extract fractional
> // "future reserved words"
> "abstract", "int", "short", "boolean", "interface", "static", "byte",
> "long", "char", "final", "native", "synchronized", "float", "package",
> "throws", "goto", "private", "transient", "implements", "protected",
> "volatile", "double", "public",
What a future it
LGTM
On Wed, Nov 4, 2009 at 12:22 PM, wrote:
> Reviewers: Ray Ryan, bruce, Dan Rice,
>
> Description:
> SwingWorker uses a pool of threads to run background tasks, and we
> weren't actually using the background portion of this. Having multiple
> threads processing SwingWorker calls made orderin
What is an SSW?
Dan
On Wed, Nov 4, 2009 at 2:24 PM, wrote:
> LGTM, just nits.
>
>
> http://gwt-code-reviews.appspot.com/90802/diff/1004/2001
> File user/super/com/google/gwt/emul/java/util/Date.java (right):
>
> http://gwt-code-reviews.appspot.com/90802/diff/1004/2001#newcode110
> Line 110: *
They show up as severity="info" which doesn't break the build. But at
least the @param names seem worth fixing...
Dan
On Tue, Nov 3, 2009 at 3:21 PM, wrote:
> Thanks.
>
> Why is ant checkstyle passing for me?
>
>
> http://gwt-code-reviews.appspot.com/89816
>
--~--~-~--~~
I'm not sure how to so this -- my testing involved manually setting the
machine's time zone. Ultimately the bug is in the fact that the native
Javascript Date functions deal with the missing hour differently that Java's
Date class, and I don't know that I can coerce the Javascript functions into
Is there something smaller than a full JDK-compatible String.format that
would work?
Dan
On Tue, Oct 20, 2009 at 11:32 AM, John Tamplin wrote:
> On Tue, Oct 20, 2009 at 11:21 AM, Ray Ryan wrote:
>
>> I'll bet a lot that the cross section of "40+ languages" and "nuanced
>> pluralized translati
O.K., I'll stick with the one-line version for non-Mac platforms.
On Tue, Sep 22, 2009 at 3:39 PM, John Tamplin wrote:
> On Tue, Sep 22, 2009 at 3:27 PM, Daniel Rice (דניאל רייס) > wrote:
>
>> You say "more generic" but your comment seems to be suggesting greate
Hi John -
You say "more generic" but your comment seems to be suggesting greater
specificity ("use" versus ""). Do you have some language in
mind?
Dan
On Tue, Sep 22, 2009 at 3:18 PM, wrote:
> LGTM assuming you have tested it on all platforms, with minor nits.
>
>
> http://gwt-code-reviews.a
I think this turned out not to be necessary:
1) The script uses the gwt install path to decide whether to generate the
mac stuff
2) Because the ant script now uses , it no longer differs between
platforms;
only the Eclipse files differ.
Dan
On Mon, Sep 21, 2009 at 5:45 PM, wrote:
>
> http://g
document how to deal with the interaction
between custom field serialization and subclassing?
Dan
On Mon, Aug 3, 2009 at 2:43 PM, BobV wrote:
>
> On Mon, Aug 3, 2009 at 2:24 PM, Daniel Rice (דניאל רייס)
> wrote:
> > That could still theoretically fail if removeEldestEntry did s
That could still theoretically fail if removeEldestEntry did something
weird that mutated the entries. But that seems pretty unlikely to be the
case.
Dan
On Mon, Aug 3, 2009 at 2:17 PM, John Tamplin wrote:
> On Mon, Aug 3, 2009 at 2:13 PM, Daniel Rice (דניאל רייס)
> wrote:
>
>&
What sort of opt-in mechanisms do you have in mind?
Dan
On Mon, Aug 3, 2009 at 2:02 PM, wrote:
> As much as I hate to say it, this approach isn't suitable for general
> use. We should never mutate objects passed into the serialization
> system, especially since the mutation isn't completely
Hi Ray -
You can take a look at my work-in-progress at
https://mondrian.corp.google.com/changelist/10864395. It's a retained-mode
API that translates into SVG or VML depending on browser
type. Retained-mode drawing uses a Graphics interface:
public interface Graphics {
ShapeElement circle(dou
econd point, I agree with you that storing the extra-data on
> the client is better to ensure that you are stateless architecture
> compliant. You will probably get complains coming from people that have a
> pretty complex object graph to serialize.
>
> Sami
>
>
>
> On Mon,
ry and impl you have used) ->
> https://www.hibernate.org/hib_docs/v3/api/org/hibernate/proxy/ProxyFactory.html.
> Serializing those data in a String based representation could be potentially
> harmful in term of bandwith and payload. Why not providing a way to store
> this client
nstance
> > b) the client data is populated using setXXX() method invocations
> rather
> > than by directly setting field values
>
> Is this introducing a requirement that all serializable fields have
> setters? Or will direct field access be used where a setter can
Hi all -
I've been working on a patch to improve support for RPC of
persistence-enhanced objects that would replace the one I recently submitted
as trunk revision 5672. I'd like to give those of you who are interested in
the interaction between RPC and persistence a chance to help me validate th
I'll give it a shot.
Dan
On Thu, Jul 16, 2009 at 4:17 PM, Ray Ryan wrote:
> Dan, can you add the test that would have caught that for you?
>
>
> On Thu, Jul 16, 2009 at 10:47 AM, Daniel Rice (דניאל רייס) <
> r...@google.com> wrote:
>
>> Sorry, fixed.
>
Please ignore this, I now see that there is not a problem with the
existing code.
Dan
On Thu, Jul 16, 2009 at 2:20 PM, wrote:
> Reviewers: robertvawter_google.com,
>
>
>
> Please review this at http://gwt-code-reviews.appspot.com/47819
>
> Affected files:
>
>
> user/src/com/google/gwt/user/c
Sorry, fixed.
Dan
On Thu, Jul 16, 2009 at 1:35 PM, Joel Webber wrote:
> Seems I'm blind; thanks Ian. Mind changing that, Dan? We really need tests
> for this stuff sometime soon -- of course, other than syntax bugs like this,
> it's damned near impossible to test this sort of thing, because so
Hi Bruno -
I've uploaded a new patch that's more along these lines. Hopefully it
will do what you are looking for. Thanks,
Dan
On Tue, Jun 30, 2009 at 4:15 AM, bruno wrote:
>
> Hi Bod and Dan,
>
> Very happy to see that this issue is on its way to be solved :)
> Nevertheless, I think it wou
1) According to Bob, the extra field shouldn't cost anything unless it's
used.
2) The code sets the 'modified' bits when the data is deserialized on the
server, i.e., it marks all the fields as dirty so the object will be fully
updated when the user calls makePersistent on it.
I think this is suffi
day and age still
> impose such performance overhead.
>
> -Ray
>
>
> On Fri, Jun 5, 2009 at 8:16 PM, Daniel Rice (דניאל רייס)
> wrote:
>> It would not be easy to force all of these lists to have some
>> particular concrete implementation ("FinalArrayList") alth
In this case, the code is the GWT compiler itself, so it doesn't get
translated ot JavaScript.
Dan
On Fri, Jun 5, 2009 at 10:15 AM, TazmanianD wrote:
>
> There is an additional benefit to this optimization that goes beyond
> speeding up the compiler. It should produce faster Javascript as
> w
It would not be easy to force all of these lists to have some
particular concrete implementation ("FinalArrayList") although some
could. I can repeat the analysis with a larger number of runs just to
be sure, but the speedup was seen in the context of the actual
compiler rather than a microbenc
: ints)
> i.intValue();
>
> What am I missing? Probably just some super naive testing on my part. :)
>
> On Thu, Jun 4, 2009 at 12:32 PM, Daniel Rice (דניאל רייס)
> wrote:
>>
>> The speedup was measured over 3 non-JProfiler runs, invoked within
>> Eclipse. It&#x
The speedup was measured over 3 non-JProfiler runs, invoked within
Eclipse. It's certainly possible that some of the difference is
normal runtime fluctuation but each optimized run was faster than any
of the non-optimized runs.
Dan
On Thu, Jun 4, 2009 at 3:28 PM, Scott Blum wrote:
> On Thu,
I have verified that the xml files for a single-permutation Showcase
build are identical modulo whitespace to a set of "golden" xml files.
I would be happy to run the dashboard on a larger compile -- how do I
run it?
I already submitted a CL, so I will make this changes in a follow-up CL.
Da
I think simply because they were unreferenced. I'll restore them.
Dan
On Mon, Jun 1, 2009 at 12:29 PM, Scott Blum wrote:
> Dan, can you shed some light? I think you removed them in r5410.
>
> On Sun, May 31, 2009 at 9:40 PM, Amir wrote:
>>
>> It looks like the following constructors were r
I see around 2x for the story generation phase. It's hard to measure at
the moment because I haven't been able to get a working "before" build so I
am estimating based on some numbers jotted down earlier.
Dan
On Tue, May 26, 2009 at 2:27 PM, Bruce Johnson wrote:
> Any numbers on the amount o
The point of removing the calls was correctness (for future subclasses),
not performance.
Dan
On Thu, May 14, 2009 at 10:57 AM, John Tamplin wrote:
> On Thu, May 14, 2009 at 10:31 AM, Lex Spoon wrote:
>
>> Any compile error about overriding a final method indicates that we
>> need to call th
77 matches
Mail list logo
