Some comments.
http://gwt-code-reviews.appspot.com/703801/diff/1/2
File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
(right):
http://gwt-code-reviews.appspot.com/703801/diff/1/2#newcode2
user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:2: *
Copyright 2009 Googl
/154810/diff/63002/70003
File user/src/com/google/gwt/user/client/ui/Grid.java (right):
http://gwt-code-reviews.appspot.com/154810/diff/63002/70003#newcode35
user/src/com/google/gwt/user/client/ui/Grid.java:35: * Grid widget
consists of <g:row> elements. Each <g:row> element
On 2010/07
ping...
http://gwt-code-reviews.appspot.com/154810/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I just found one small typo - but I won't commit a new patch now just in
case something else needs to be fixed as well.
@rjrjr: If everything else is ok, I'll commit an updated patch.
http://gwt-code-reviews.appspot.com/154810/diff/63002/70003
File user/src/com/google/gwt/user/client/ui/Grid.ja
I just found one small typo - but I won't commit a new patch now just in
case something else needs to be fixed as well.
@rjrjr: If everything else is ok, I'll commit an updated patch.
http://gwt-code-reviews.appspot.com/154810/diff/63002/70003
File user/src/com/google/gwt/user/client/ui/Grid.ja
Changed the way in which uibinder xml file is parsed.
http://gwt-code-reviews.appspot.com/154810/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Here's the reverted patch set.
http://gwt-code-reviews.appspot.com/612802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ok, I had a look and just remembered why I used more calls to resize
methods.
The GridParser walks through the Grid and on the fly calculates the
size. So if it comes to an element that doesn't fit into the current
grid element it expands it (either by number of columns, or rows -
depends which o
Yeah, I do remember. I will make the change later today.
On 2010/07/02 14:40:57, Ray Ryan wrote:
Remember this? It's really close, I think just one more change is
needed
(below).
http://gwt-code-reviews.appspot.com/154810/diff/22003/54004
File
user/test/com/google/gwt/uibinder/elementpars
Here's what I think...
What's the purpose of RawWebSocketImpl vs. WebSocket? that you could
do a new WebSocket() instead of WebSocket.newInstance() ? (I don't
dispute the interface+implementation, which is more-than-useful for
mockability).
Different browsers might have a slightly different Web
http://gwt-code-reviews.appspot.com/646803/diff/1/16
File user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java
(right):
http://gwt-code-reviews.appspot.com/646803/diff/1/16#newcode22
user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java:22: void
onClose(CloseEvent event);
I thin
http://gwt-code-reviews.appspot.com/646803/diff/1/16
File user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java
(right):
http://gwt-code-reviews.appspot.com/646803/diff/1/16#newcode22
user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java:22: void
onClose(CloseEvent event);
I must
http://gwt-code-reviews.appspot.com/646803/diff/1/16
File user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java
(right):
http://gwt-code-reviews.appspot.com/646803/diff/1/16#newcode22
user/src/com/google/gwt/dom/client/WebSocketCloseHandler.java:22: void
onClose(CloseEvent event);
I must
http://gwt-code-reviews.appspot.com/646803/diff/1/15
File user/src/com/google/gwt/dom/client/WebSocket.java (right):
http://gwt-code-reviews.appspot.com/646803/diff/1/15#newcode48
user/src/com/google/gwt/dom/client/WebSocket.java:48: };
Just forget my last comment :) I misinterpreted the code he
http://gwt-code-reviews.appspot.com/646803/diff/1/10
File user/src/com/google/gwt/dom/client/Event.java (right):
http://gwt-code-reviews.appspot.com/646803/diff/1/10#newcode23
user/src/com/google/gwt/dom/client/Event.java:23: public class Event
extends JavaScriptObject {
Could somebody verify th
http://gwt-code-reviews.appspot.com/646803/diff/1/15
File user/src/com/google/gwt/dom/client/WebSocket.java (right):
http://gwt-code-reviews.appspot.com/646803/diff/1/15#newcode48
user/src/com/google/gwt/dom/client/WebSocket.java:48: };
Is it really necessary to remove all the listeners once the
http://gwt-code-reviews.appspot.com/620802/diff/4002/19001
File user/super/com/google/gwt/emul/java/util/AbstractList.java (right):
http://gwt-code-reviews.appspot.com/620802/diff/4002/19001#newcode166
user/super/com/google/gwt/emul/java/util/AbstractList.java:166:
@rice I have overridden this m
Thanks for the explanations. I'll add some tests and if necessary
override the remove method.
http://gwt-code-reviews.appspot.com/620802/diff/8001/9002
File user/test/com/google/gwt/emultest/java/util/ListTestBase.java
(right):
http://gwt-code-reviews.appspot.com/620802/diff/8001/9002#newcode19
Here are some more comments about the things that rice pointed out.
http://gwt-code-reviews.appspot.com/620802/diff/8001/9002
File user/test/com/google/gwt/emultest/java/util/ListTestBase.java
(right):
http://gwt-code-reviews.appspot.com/620802/diff/8001/9002#newcode199
user/test/com/google/gwt
I have one question...
in javadoc is says
The semantics of the list returned by this method become undefined if
the backing list (i.e., this list) is structurally modified in any way
other than via the returned list. (Structural modifications are those
that change the size of this list, or other
@jat, Any news about this?
http://gwt-code-reviews.appspot.com/620802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I think that .project, .classpath and .checkstyle files should be
included. All the other samples have those files imported. It is
possible to create the eclipse project from sources but I think it would
be much more convenient if the project was already created for the user.
I also think that thi
Here is a patch set with a minor fix, and a few more tests.
http://gwt-code-reviews.appspot.com/620802/diff/8001/9002
File user/test/com/google/gwt/emultest/java/util/ListTestBase.java
(right):
http://gwt-code-reviews.appspot.com/620802/diff/8001/9002#newcode324
user/test/com/google/gwt/emultes
http://gwt-code-reviews.appspot.com/620802/diff/1/2
File user/super/com/google/gwt/emul/java/util/AbstractList.java (right):
http://gwt-code-reviews.appspot.com/620802/diff/1/2#newcode141
user/super/com/google/gwt/emul/java/util/AbstractList.java:141:
wrapped.add(toIndex, element);
You might be
Reviewers: Ray Ryan, jat,
Message:
I hope this solves the issue
http://code-google-com/p/google-web-toolkit/issues/detail?id=4993.
Description:
Fixes problem with List.subList() method described in issue 4993 -
http://code-google-com/p/google-web-toolkit/issues/detail?id=4993
Please review this
The last patchset seems to be working (both dev and web mode tests have
passed).
http://gwt-code-reviews.appspot.com/612802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/612802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hopefully there will be no problems with this last patch. :)
http://gwt-code-reviews.appspot.com/612802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I place the equivalent tests to the RootPanelTest? If they are
found only here there is a small chance that some change might get into
RootPanel undetected?
On 2010/06/16 19:26:31, markovuksanovic wrote:
right :-)
http://gwt-code-reviews.appspot.com/612802/show
--
http://groups.google.com/group
http://gwt-code-reviews.appspot.com/612802/diff/8001/9002
File user/test/com/google/gwt/user/client/ui/PanelTestBase.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/8001/9002#newcode35
user/test/com/google/gwt/user/client/ui/PanelTestBase.java:35: public
void testClear() {
right :-
I have moved the test to PanelTestBase class. I have also tried to
subclass the RootPanelTest from the PanelTestClass but got the following
error
estcase: testAttachDetachOrder took 301.037 sec
Caused an ERROR
The browser did not complete the test method
com.google.gwt.user.User.JUnit:com.
http://gwt-code-reviews.appspot.com/612802/diff/1/2
File user/src/com/google/gwt/user/client/ui/Panel.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/1/2#newcode231
user/src/com/google/gwt/user/client/ui/Panel.java:231: private static
native void eraseDom(Element element) /*-{
I ju
Reviewers: Ray Ryan, scottb, Lex, jat,
Description:
If class path context is changed UiBinderGenerator isn't able to fetch
resources found in the new class path context.
Please review this at http://gwt-code-reviews.appspot.com/579801/show
Affected files:
user/src/com/google/gwt/uibinder/rebi
http://gwt-code-reviews.appspot.com/579801/diff/1/2
File user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
(right):
http://gwt-code-reviews.appspot.com/579801/diff/1/2#newcode147
user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java:147:
Resource[] resources = (resourceOrac
Reviewers: fabbott, jta_google.com,
Description:
Replaced junit3 jars with junit4 ones.
Please review this at http://gwt-code-reviews.appspot.com/334803/show
Affected files:
lib/junit/junit-3.8.1-src.zip
lib/junit/junit-3.8.1.jar
lib/junit/junit-4.8.2-src.jar
lib/junit/junit-4.8.2.jar
ping...
http://gwt-code-reviews.appspot.com/153812/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe, reply using "remove me" as the subject.
Reviewers: Ray Ryan,
Description:
Fix for issue 1483
(http://code.google.com/p/google-web-toolkit/issues/detail?id=1483)
Please review this at http://gwt-code-reviews.appspot.com/320802/show
Affected files:
user/src/com/google/gwt/user/client/ui/CheckBox.java
Index: user/src/com/google/gwt/
Reviewers: Ray Ryan,
Description:
Fix for issue
http://code.google.com/p/google-web-toolkit/issues/detail?id=719
Please review this at http://gwt-code-reviews.appspot.com/325801/show
Affected files:
user/src/com/google/gwt/xml/XML.gwt.xml
user/src/com/google/gwt/xml/client/impl/XMLParserImp
Reviewers: ,
Description:
foo
bar
foo
foo
Please review this at http://gwt-code-reviews.appspot.com/154810
Affected files:
user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
user/src/com/google
http://gwt-code-reviews.appspot.com/153812
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Ray Ryan,
Description:
Fixes problem with not being able to launch showcase example using
Showcase.launch file.
Please review this at http://gwt-code-reviews.appspot.com/153812
Affected files:
eclipse/samples/Showcase/Showcase.launch
Index: eclipse/samples/Showcase/Showcase.launc
http://gwt-code-reviews.appspot.com/153804
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I'll do that as well...
On 2010/02/25 19:27:10, Ray Ryan wrote:
LGTM
And this time I've actually remembered to cc contrib.
One last nit below.
http://gwt-code-reviews.appspot.com/153804/diff/1027/39
File
user/test/com/google/gwt/uibinder/elementparsers/ListBoxParserTest.java
(right):
http://gwt-code-reviews.appspot.com/153804
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: ,
Description:
Enables support for adding items into a ListBox using UiBinder.
For example:
first item
second item
Please review this at http://gwt-code-reviews.appspot.com/153804
Affected files:
user/src/com/google/gwt/uibinder/elementparsers/ListBoxParser.j
45 matches
Mail list logo
