Did the changes... Will post the patch a little later... I need to convert it from git to svn format first...
http://gwt-code-reviews.appspot.com/154810/diff/63002/70001 File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java (right): http://gwt-code-reviews.appspot.com/154810/diff/63002/70001#newcode86 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:86: writer.getOracle().findType(Grid.class.getName()), "0", "0"); You should be right about this.... http://gwt-code-reviews.appspot.com/154810/diff/63002/70001#newcode86 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:86: writer.getOracle().findType(Grid.class.getName()), "0", "0"); On 2010/07/12 17:07:40, Ray Ryan wrote:
This line serves no purpose that I can see.
Done. http://gwt-code-reviews.appspot.com/154810/diff/63002/70001#newcode130 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:130: writer.die("Grid's <g:row> tag in %s may only contain %s or %s element.", On 2010/07/12 17:07:40, Ray Ryan wrote:
No need for < here, and "g:" shouldn't be hard coded
Done. http://gwt-code-reviews.appspot.com/154810/diff/63002/70001#newcode149 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:149: throws UnableToCompleteException { Done. Also made sure that cells have the same prefix as parent. http://gwt-code-reviews.appspot.com/154810/diff/63002/70001#newcode152 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:152: String tagName = child.getLocalName(); On 2010/07/12 17:07:40, Ray Ryan wrote:
Compare prefix too
Done. http://gwt-code-reviews.appspot.com/154810/diff/63002/70001#newcode154 user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:154: writer.die("Invalid Grid child element: " + tagName); On 2010/07/12 17:07:40, Ray Ryan wrote:
"%1$s:Grid elements must contain only %1$s:%2$s children, found
%3$s:%4$s",
elem.getPrefix(), ROW_TAG, child.getPrefix(), tagName
Done. http://gwt-code-reviews.appspot.com/154810/diff/63002/70003 File user/src/com/google/gwt/user/client/ui/Grid.java (right): http://gwt-code-reviews.appspot.com/154810/diff/63002/70003#newcode35 user/src/com/google/gwt/user/client/ui/Grid.java:35: * Grid widget consists of <g:row> elements. Each <g:row> element On 2010/07/03 20:46:51, markovuksanovic wrote:
One small typo - "can contain on or more" - should be - "can contain
one or
more"
Done. http://gwt-code-reviews.appspot.com/154810/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
