Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3690
Change subject: Update DockLayoutPanel to match implementation
..
Update DockLayoutPanel to match implementation
Change-Id:
Daniel Kurka has submitted this change and it was merged.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Move arrow key functions from Tree to KeyCodes
remove handling for old Webkit keycodes (version 525)
Daniel Kurka has submitted this change and it was merged.
Change subject: Utility to store multiple HandlerRegistrations
..
Utility to store multiple HandlerRegistrations
fixes issue 8246
Change-Id:
Thomas Broyer has posted comments on this change.
Change subject: Update DockLayoutPanel to match implementation
..
Patch Set 1: Code-Review+1
(2 comments)
Commit Message
Matthew Dempsky has submitted this change and it was merged.
Change subject: Use Double.isNaN(d) instead of d != d to test for NaN.
..
Use Double.isNaN(d) instead of d != d to test for NaN.
Satisfies upcoming error-prone
Daniel Kurka has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 5:
(3 comments)
File
Hello Matthew Dempsky, Thomas Broyer, Leeroy Jenkins, Goktug Gokdogan,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3662
to look at the new patch set (#6).
Change subject: Move arrow key functions from Tree to KeyCodes
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 5:
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 6: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3662
To unsubscribe, visit
Daniel Kurka has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 3:
(3 comments)
File
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3661
to look at the new patch set (#4).
Change subject: Utility to store multiple HandlerRegistrations
..
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3661
to look at the new patch set (#5).
Change subject: Utility to store multiple HandlerRegistrations
..
Hello Matthew Dempsky, Thomas Broyer, Leeroy Jenkins, Goktug Gokdogan,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3662
to look at the new patch set (#7).
Change subject: Move arrow key functions from Tree to KeyCodes
Thomas Broyer has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 5: Code-Review+1
(2 comments)
Nits only. I think I like that approach better than the previous one
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 7: Code-Review+2
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Add static is(...) to complement as as(...).
..
Patch Set 6: Code-Review+2
(1 comment)
I find it strange that CheckStyle didn't flag more whitespace
Hello Matthew Dempsky, Thomas Broyer, Leeroy Jenkins, Goktug Gokdogan,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3662
to look at the new patch set (#8).
Change subject: Move arrow key functions from Tree to KeyCodes
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 8: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3662
To unsubscribe, visit
Jens Nehlmeier has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 5: Code-Review+1
Beside the JavaDoc nits pointed out by Thomas: LGTM
--
To view, visit
Hello Thomas Broyer, Leeroy Jenkins, Jens Nehlmeier,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3661
to look at the new patch set (#6).
Change subject: Utility to store multiple HandlerRegistrations
Daniel Kurka has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 5:
(2 comments)
File
Thomas Broyer has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 6: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3661
To unsubscribe, visit
Matthew Dempsky has uploaded a new change for review.
https://gwt-review.googlesource.com/3680
Change subject: Fix SingleSelectionModel.getSelectedSet()
..
Fix SingleSelectionModel.getSelectedSet()
Ensure that if recent
Goktug Gokdogan has posted comments on this change.
Change subject: Fixes Exception wrapping/unwrapping in compiler
..
Patch Set 3:
Actually, I briefly discussed this issue with you before when I asked you
putting try/catch
Goktug Gokdogan has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 8: Code-Review+1
(1 comment)
File
Goktug Gokdogan has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 6: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/3661
To unsubscribe, visit
Goktug Gokdogan has posted comments on this change.
Change subject: Fix SingleSelectionModel.getSelectedSet()
..
Patch Set 1:
(2 comments)
File
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3680
to look at the new patch set (#2).
Change subject: Fix SingleSelectionModel.getSelectedSet()
..
Fix
Matthew Dempsky has posted comments on this change.
Change subject: Fix SingleSelectionModel.getSelectedSet()
..
Patch Set 1:
(2 comments)
File
Goktug Gokdogan has posted comments on this change.
Change subject: Fix SingleSelectionModel.getSelectedSet()
..
Patch Set 2: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3680
To unsubscribe, visit
Matthew Dempsky has submitted this change and it was merged.
Change subject: Fix SingleSelectionModel.getSelectedSet()
..
Fix SingleSelectionModel.getSelectedSet()
Ensure that if recent changes have been made to the model,
Manuel Carrasco Moñino has posted comments on this change.
Change subject: Fix binary vs. internal variable names, remove unused Name
code.
..
Patch Set 1:
(2 comments)
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3661
Change subject: Utility to store multiple HandlerRegistrations
..
Utility to store multiple HandlerRegistrations
fixes issue 8246
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3661
to look at the new patch set (#2).
Change subject: Utility to store multiple HandlerRegistrations
..
Thomas Broyer has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 1:
(3 comments)
Maybe ResettableEventBus should be retrofitted to use this class.
Thomas Broyer has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 2:
(1 comment)
File
Daniel Kurka has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 2:
(1 comment)
File
Daniel Kurka has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 1:
(3 comments)
File
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3661
to look at the new patch set (#3).
Change subject: Utility to store multiple HandlerRegistrations
..
Daniel Kurka has posted comments on this change.
Change subject: Log warning when wrongly using RootPanel
..
Patch Set 1:
(2 comments)
I think we should go with adding a comment to add (since all other adds
calls this one
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3662
Change subject: Move arrow key functions from Tree to KeyCodes
..
Move arrow key functions from Tree to KeyCodes
remove handling
Jens Nehlmeier has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 3:
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Log warning when wrongly using RootPanel
..
Patch Set 1: Code-Review-1
(2 comments)
I can't count the number of times I had to point to “the Using a
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 1:
(4 comments)
File
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3662
to look at the new patch set (#2).
Change subject: Move arrow key functions from Tree to KeyCodes
..
Move
Matthew Dempsky has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 2:
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 2:
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 2: Code-Review+1
(1 comment)
File
Hello Thomas Broyer, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3662
to look at the new patch set (#3).
Change subject: Move arrow key functions from Tree to KeyCodes
Daniel Kurka has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 3:
(1 comment)
File
Hello Matthew Dempsky, Thomas Broyer, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3662
to look at the new patch set (#4).
Change subject: Move arrow key functions from Tree to KeyCodes
Matthew Dempsky has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 4: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/3662
To unsubscribe, visit
Goktug Gokdogan has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 3:
(3 comments)
File
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 3:
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 4: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3662
To unsubscribe, visit
Goktug Gokdogan has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 4: Code-Review+1
(3 comments)
Looks good to me API wise.
Daniel Kurka has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 4:
(2 comments)
File
Hello Matthew Dempsky, Thomas Broyer, Leeroy Jenkins, Goktug Gokdogan,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3662
to look at the new patch set (#5).
Change subject: Move arrow key functions from Tree to KeyCodes
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 5: Code-Review+1
(3 comments)
Nits only (I'd still add an experimental note to maybeSwap; this
Ray Cromwell has uploaded a new change for review.
https://gwt-review.googlesource.com/3670
Change subject: Makes some private implementation classes of
StackTraceCreator public to enable custom implementations. Useful for other
Javascript VMs, as well as integration with non-GWT code,
Ray Cromwell has posted comments on this change.
Change subject: Fixes Exception wrapping/unwrapping in compiler
..
Patch Set 3:
Is there a bug/issue somewhere for this? What is the overall goal it is
trying to accomplish?
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3637
Change subject: Log warning when wrongly using RootPanel
..
Log warning when wrongly using RootPanel
fixes issue 5874
Change-Id:
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3639
Change subject: Remove deprecated use of isChecked in javadoc
..
Remove deprecated use of isChecked in javadoc
fixes issue 6232
Thomas Broyer has posted comments on this change.
Change subject: Remove deprecated use of isChecked in javadoc
..
Patch Set 1: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3639
To unsubscribe, visit
Thomas Broyer has submitted this change and it was merged.
Change subject: Remove deprecated use of isChecked in javadoc
..
Remove deprecated use of isChecked in javadoc
fixes issue 6232
Change-Id:
John A. Tamplin has posted comments on this change.
Change subject: Add NavigableSet, NavigableMap to GWT and retrofit TreeMap
and TreeSet to implement it.
..
Patch Set 2: Code-Review-1
(10 comments)
Generally good, but a
Thomas Broyer has uploaded a new change for review.
https://gwt-review.googlesource.com/3650
Change subject: Add NavigableSet, NavigableMap to GWT and retrofit TreeMap
and TreeSet to implement it.
..
Add NavigableSet,
Thomas Broyer has posted comments on this change.
Change subject: Add NavigableSet, NavigableMap to GWT and retrofit TreeMap
and TreeSet to implement it.
..
Patch Set 1:
Moved from
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3650
to look at the new patch set (#2).
Change subject: Add NavigableSet, NavigableMap to GWT and retrofit TreeMap
and TreeSet to implement it.
Julien Dramaix has posted comments on this change.
Change subject: FileUpload: extending FocusWidget instead of Widget so as
it exposes many features which already are in the file-input element:
click(), focus(), mouseevents, keyevents, etc.
Roberto Lublinerman has posted comments on this change.
Change subject: Adds support for unwrapping of thrown non-jso objects from
JavaScriptException.
..
Patch Set 1: Code-Review+1
I am not familiar with this code, it
Roberto Lublinerman has posted comments on this change.
Change subject: Optimize initializing fields at the top scope.
..
Patch Set 9: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3440
To unsubscribe,
Roberto Lublinerman has posted comments on this change.
Change subject: replaces stale jProgram runAsync references and fixes
JRunAsync method inlining to occasionally benefit from tighter types
..
Patch Set 1:
Stephen Haberman has submitted this change and it was merged.
Change subject: Optimize initializing fields at the top scope.
..
Optimize initializing fields at the top scope.
Change-Id:
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Fixes Exception wrapping/unwrapping in compiler
..
Fixes Exception wrapping/unwrapping in compiler
Change-Id:
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/3640
Change subject: Adds support for unwrapping of thrown non-jso objects from
JavaScriptException.
..
Adds support for
Roberto Lublinerman has posted comments on this change.
Change subject: Fixes Exception wrapping/unwrapping in compiler
..
Patch Set 1:
(2 comments)
File
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3601
to look at the new patch set (#2).
Change subject: Fixes Exception wrapping/unwrapping in compiler
..
Fixes
Roberto Lublinerman has posted comments on this change.
Change subject: Fixes Exception wrapping/unwrapping in compiler
..
Patch Set 2: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3601
To unsubscribe,
Roberto Lublinerman has posted comments on this change.
Change subject: Optimize initializing fields at the top scope.
..
Patch Set 6:
(1 comment)
File
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3440
to look at the new patch set (#9).
Change subject: Optimize initializing fields at the top scope.
..
Stephen Haberman has posted comments on this change.
Change subject: Optimize initializing fields at the top scope.
..
Patch Set 6:
(1 comment)
Okay, I went with the conservative approach. I'll look forward to hearing
Thomas Broyer has posted comments on this change.
Change subject: Fix os detection in I18NCreater.I18NCreater failed to
detect windows properly.Fixes issue 5113.
..
Patch Set 1:
You should have amended your previous
Matthew Dempsky has posted comments on this change.
Change subject: changes for 5113
..
Patch Set 1:
(1 comment)
File user/src/com/google/gwt/i18n/tools/I18NCreator.java
Matthew Dempsky has posted comments on this change.
Change subject: Issue 8220: Support for java.lang.reflect.Type - fixed
..
Patch Set 3:
(1 comment)
File
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/3601
Change subject: Fixes Exception wrapping/unwrapping in compiler
..
Fixes Exception wrapping/unwrapping in compiler
Change-Id:
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3611
Change subject: Let ValueListBox implement HasEnabled
..
Let ValueListBox implement HasEnabled
fixes issue 6112
Change-Id:
Jens Nehlmeier has posted comments on this change.
Change subject: Let ValueListBox implement HasEnabled
..
Patch Set 1: Code-Review+1
Nit-pick: You might want to use assertTrue/assertFalse instead of
assertEquals
--
To
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3612
Change subject: Making DialogBox clear handlers on auto hide
..
Making DialogBox clear handlers on auto hide
fixes issue 6356
Daniel Kurka has uploaded a new patch set (#2).
Change subject: Making DialogBox clear handlers on auto hide
..
Making DialogBox clear handlers on auto hide
fixes issue 6356
Change-Id:
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3613
Change subject: Add wrap method to Canvas
..
Add wrap method to Canvas
fixes issue 6683
Change-Id:
Thomas Broyer has posted comments on this change.
Change subject: Let ValueListBox implement HasEnabled
..
Patch Set 1: Code-Review+2
I'd too prefer assertTrue/assertFalse but otherwise LGTM.
--
To view, visit
Thomas Broyer has posted comments on this change.
Change subject: Making DialogBox clear handlers on auto hide
..
Patch Set 2: Code-Review+1
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Add wrap method to Canvas
..
Patch Set 1: Code-Review+1
(2 comments)
File
Thomas Broyer has posted comments on this change.
Change subject: Fix javadoc in JsDate to list correct number for december
..
Patch Set 1: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3610
To
Thomas Broyer has submitted this change and it was merged.
Change subject: Fix javadoc in JsDate to list correct number for december
..
Fix javadoc in JsDate to list correct number for december
fixes issue 8212
Change-Id:
Daniel Kurka has posted comments on this change.
Change subject: Add wrap method to Canvas
..
Patch Set 1:
(2 comments)
File
Hello Leeroy Jenkins, Thomas Broyer,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3613
to look at the new patch set (#2).
Change subject: Add wrap method to Canvas
..
Add wrap
Hello Leeroy Jenkins, Thomas Broyer, Jens Nehlmeier,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3611
to look at the new patch set (#2).
Change subject: Let ValueListBox implement HasEnabled
Thomas Broyer has posted comments on this change.
Change subject: Add wrap method to Canvas
..
Patch Set 2:
(1 comment)
File
1 - 100 of 2012 matches
Mail list logo
