Thomas Broyer has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
@Andrey: thanks; but no need to create a new issue here, it's the
continuity of the original issue (and fixing
Matthew Dempsky has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
Gerrit is a bit different than Google practices internally, because
internally only the CL author can actually
Thomas Broyer has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
Tests are failing: http://build.gwtproject.org/job/gwt/261/testReport/
@Andrey: can you provide a patch quickly, or
Thomas Broyer has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
Filed issue 8191. I think we need someone with a deep understanding of the
compiler internals; Ray maybe?
--
To
Andrey Korzhevskiy has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
@Thomas: I'll submit fixes for failing tests asap
--
To view, visit https://gwt-review.googlesource.com/3184
To
Andrey Korzhevskiy has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
Filed
Matthew Dempsky has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
@Thomas: I think it depends on how quickly we can resolve the issue and how
confident we are there won't still be
Goktug Gokdogan has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 9:
A good rule of thumb is; if you can't fix it in 5 min, you should revert.
More time the trunk is left broken,
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Emulate java.util.Objects
..
Emulate java.util.Objects
Fixes issue 8173
Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
---
M
Hello John A. Tamplin,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3184
to look at the new patch set (#8).
Change subject: Emulate java.util.Objects
..
Emulate java.util.Objects
John A. Tamplin has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 8: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit
Ray Cromwell has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 8: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit
Hello John A. Tamplin,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3184
to look at the new patch set (#7).
Change subject: Emulate java.util.Objects
..
Emulate java.util.Objects
Andrey Korzhevskiy has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 3:
(2 comments)
File
John A. Tamplin has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 7:
(2 comments)
LGTM with a couple of nits.
File
Hello John A. Tamplin,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3184
to look at the new patch set (#4).
Change subject: Emulate java.util.Objects
..
Emulate java.util.Objects
John A. Tamplin has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 4: Code-Review+1
(2 comments)
LGTM with minor nits
File
Hello John A. Tamplin,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3184
to look at the new patch set (#5).
Change subject: Emulate java.util.Objects
..
Emulate java.util.Objects
John A. Tamplin has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 5: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit
Ray Cromwell has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 5:
I hadn't thought of this, but the copyright message for new files should
probably be different. I will bring this up
John A. Tamplin has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 5:
I think that is no reason to hold this up -- we can use the same license,
and then change all of them at once.
Goktug Gokdogan has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 3:
(2 comments)
File
Goktug Gokdogan has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 5:
(1 comment)
File
Hello John A. Tamplin,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3184
to look at the new patch set (#6).
Change subject: Emulate java.util.Objects
..
Emulate java.util.Objects
John A. Tamplin has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 6: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit
Thomas Broyer has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 6:
(4 comments)
File
Andrey Korzhevskiy has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 6:
@Thomas: Objects.equals has the same code as Objects.equals in JDK 7 and
Google Guava library. May be we
Thomas Broyer has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 6:
OK then (in the absence of reply to the comment, I assumed you missed it)
--
To view, visit
Andrey Korzhevskiy has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 6:
Oh, I'm sorry, I just dont know why gerrit doesn't show you my comments. I
replied and saved comments. After
Thomas Broyer has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 6:
Hit the Review button for the patch set where you made your comments
(reviews go with a score, so they're scoped to
Andrey Korzhevskiy has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 3:
(3 comments)
File
Andrey Korzhevskiy has uploaded a new change for review.
https://gwt-review.googlesource.com/3184
Change subject: Emulate java.util.Objects
..
Emulate java.util.Objects
Fixes issue 8173
Change-Id:
Andrey Korzhevskiy has uploaded a new patch set (#2).
Change subject: Emulate java.util.Objects
..
Emulate java.util.Objects
Fixes issue 8173
Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
---
M
Andrey Korzhevskiy has uploaded a new patch set (#3).
Change subject: Emulate java.util.Objects
..
Emulate java.util.Objects
Fixes issue 8173
Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
---
M
John A. Tamplin has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 3: Code-Review-1
(1 comment)
Need tests as well.
File
Ray Cromwell has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 3:
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 3:
(3 comments)
File
37 matches
Mail list logo
