Daniel Kurka has submitted this change and it was merged.
Change subject: Utility to store multiple HandlerRegistrations
..
Utility to store multiple HandlerRegistrations
fixes issue 8246
Change-Id:
Daniel Kurka has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 3:
(3 comments)
File
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3661
to look at the new patch set (#4).
Change subject: Utility to store multiple HandlerRegistrations
..
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3661
to look at the new patch set (#5).
Change subject: Utility to store multiple HandlerRegistrations
..
Thomas Broyer has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 5: Code-Review+1
(2 comments)
Nits only. I think I like that approach better than the previous one
Jens Nehlmeier has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 5: Code-Review+1
Beside the JavaDoc nits pointed out by Thomas: LGTM
--
To view, visit
Hello Thomas Broyer, Leeroy Jenkins, Jens Nehlmeier,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3661
to look at the new patch set (#6).
Change subject: Utility to store multiple HandlerRegistrations
Daniel Kurka has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 5:
(2 comments)
File
Thomas Broyer has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 6: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3661
To unsubscribe, visit
Goktug Gokdogan has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 6: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/3661
To unsubscribe, visit
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3661
Change subject: Utility to store multiple HandlerRegistrations
..
Utility to store multiple HandlerRegistrations
fixes issue 8246
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3661
to look at the new patch set (#2).
Change subject: Utility to store multiple HandlerRegistrations
..
Thomas Broyer has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 1:
(3 comments)
Maybe ResettableEventBus should be retrofitted to use this class.
Thomas Broyer has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 2:
(1 comment)
File
Daniel Kurka has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 2:
(1 comment)
File
Daniel Kurka has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 1:
(3 comments)
File
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3661
to look at the new patch set (#3).
Change subject: Utility to store multiple HandlerRegistrations
..
Jens Nehlmeier has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 3:
(1 comment)
File
Goktug Gokdogan has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 3:
(3 comments)
File
19 matches
Mail list logo