Some feedback on the final patch.
http://gwt-code-reviews.appspot.com/81805/diff/2011/3011
File
dev/core/src/com/google/gwt/dev/shell/remoteui/MessageTransport.java
(right):
http://gwt-code-reviews.appspot.com/81805/diff/2011/3011#newcode70
Line 70: pendingRequestMap.put(requestId, this);
The p
LGTM
http://gwt-code-reviews.appspot.com/81805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
And here is the patch...
2009/10/20 Miguel Méndez
> I can't attach a new patch to the issue since I don't own it, but here is
> the updated patch that we pair programed. It fixes the problems uncovered
> by the unit test. This patch should be applied over patch set 3.
>
>
> On Tue, Oct 20, 200
I can't attach a new patch to the issue since I don't own it, but here is
the updated patch that we pair programed. It fixes the problems uncovered
by the unit test. This patch should be applied over patch set 3.
On Tue, Oct 20, 2009 at 11:06 AM, wrote:
> I found a couple of failures on my OSX
I found a couple of failures on my OSX box last night. Let's look at
them together.
http://gwt-code-reviews.appspot.com/81805/diff/2003/2007
File
dev/core/test/com/google/gwt/dev/shell/remoteui/MessageTransportTest.java
(right):
http://gwt-code-reviews.appspot.com/81805/diff/2003/2007#newcode1
I've uploaded the updated patch set. This patch contains the pair
programming work that you and I did to re-work MessageTransport to use
the JRE's higher-level concurrency constructs. This patch also has unit
tests for the MessageTransport class.
Patch sets #2 and #3 are identical; I think the se
Sorry that it took me a little while to review this code. I had to
refresh my memory on some of the JRE's built-in concurrency features.
That said, I think that I have two overall comments:
1) We should be able to simplify MessageProcessor if we reused some of
the JRE concurrency support.
2) Sho
Ugh, don't know what Reitveld did here. Ignore the previous two messages; it
somehow merged another code review into this one. Just pay attention to the
first message; the issue 81805 is still valid.
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-To
Actually, this patch won't work, as the other has not been committed as
yet. I'll nix this issue and send you another one that will work
properly.
http://gwt-code-reviews.appspot.com/81806
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Con
