Nice! Nearly there.
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002
File
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java
(left):
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002#oldcode72
implemented rjrjr's changes.
http://gwt-code-reviews.appspot.com/1149803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002
File
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java
(right):
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002#newcode47
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java:47:
} else
Looks good! I'll try to get it in today.
http://gwt-code-reviews.appspot.com/1149803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Awesome, thanks for getting this committed.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Submitted at r9582
On Thu, Jan 20, 2011 at 6:36 PM, larse...@gmail.com wrote:
Awesome, thanks for getting this committed.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/01/18 16:02:21, jlabanca wrote:
Also, can you sign a CLA so we can accept patch. If you scroll down
to the
bottom of the link below, you can sign it electronically.
http://code.google.com/legal/individual-cla-v1.0.html
Done.
http://gwt-code-reviews.appspot.com/1149803/show
--
I know this isn't 100% perfect, but this was my first time looking at
the ui:binder code. See comments below on some areas that I know need
improvement.
http://gwt-code-reviews.appspot.com/1149803/diff/40001/41002
File
user/src/com/google/gwt/uibinder/elementparsers/DialogBoxParser.java
(left):
Addresses rjrjr's comments and fixed a bug with CustomButton in the
Caption
http://gwt-code-reviews.appspot.com/1149803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1149803/diff/1/3
File user/src/com/google/gwt/user/client/ui/DialogBox.java (right):
http://gwt-code-reviews.appspot.com/1149803/diff/1/3#newcode116
user/src/com/google/gwt/user/client/ui/DialogBox.java:116: * your own
risk.
On 2011/01/04 18:41:53, rjrjr
http://gwt-code-reviews.appspot.com/1149803/show
Thanks so much for reviewing this guys.
@Ray,
Do you want me to go back to allowing a setter for the caption?
http://gwt-code-reviews.appspot.com/1149803/diff/22001/23001
File user/src/com/google/gwt/user/client/ui/DialogBox.java (right):
Recreated patch from trunk
http://gwt-code-reviews.appspot.com/1149803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Added UiBinder support + tests. Also made changes to the javadoc
http://gwt-code-reviews.appspot.com/1149803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Implemented most of John's changes
http://gwt-code-reviews.appspot.com/1149803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
@jeff -
Can you upload a patch relative to trunk/ instead of trunk/user? I have
some comments, but I'm getting a 500 error when I try to publish them.
I think its because the patch isn't relative to trunk/.
http://gwt-code-reviews.appspot.com/1149803/show
--
Great work. I found a few nitpicks that should be easy to fix.
http://gwt-code-reviews.appspot.com/1149803/diff/22001/23001
File user/src/com/google/gwt/user/client/ui/DialogBox.java (right):
http://gwt-code-reviews.appspot.com/1149803/diff/22001/23001#newcode113
Also, can you sign a CLA so we can accept patch. If you scroll down to
the bottom of the link below, you can sign it electronically.
http://code.google.com/legal/individual-cla-v1.0.html
http://gwt-code-reviews.appspot.com/1149803/show
--
I take your point about UiBinder support. You can have your invariant and
bind it too by updating DialogBoxParser (and DialogBoxParserTest) to
optionally handle the new constructor argument.
On Tue, Jan 18, 2011 at 8:02 AM, jlaba...@google.com wrote:
Also, can you sign a CLA so we can accept
http://gwt-code-reviews.appspot.com/1149803/diff/22001/23001
File user/src/com/google/gwt/user/client/ui/DialogBox.java (right):
http://gwt-code-reviews.appspot.com/1149803/diff/22001/23001#newcode113
user/src/com/google/gwt/user/client/ui/DialogBox.java:113: public
interface Caption extends
On Tue, Jan 18, 2011 at 10:29 AM, larse...@gmail.com wrote:
http://gwt-code-reviews.appspot.com/1149803/show
Thanks so much for reviewing this guys.
@Ray,
Do you want me to go back to allowing a setter for the caption?
I certainly wouldn't want to see both the setter and the constructor.
I'll hopefully have a chance to poke around at that code tonight and make a
decision then as to what I have time to implement.
On Tue, Jan 18, 2011 at 12:41 PM, Ray Ryan rj...@google.com wrote:
On Tue, Jan 18, 2011 at 10:29 AM, larse...@gmail.com wrote:
@Jeff -
I'm a little behind this week because of the snow in Atlanta (all four
inches it took to shutdown the city for four days), but I'll review this
patch next week. Thanks for submitting it.
http://gwt-code-reviews.appspot.com/1149803/show
--
Hey, Jeff.
Happy New Year, and thanks for your patience. I'm looking at this now.
On Thu, Dec 9, 2010 at 7:23 AM, Jeff Larsen larse...@gmail.com wrote:
bump.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
cc'ing John L, who actually understands this code
http://gwt-code-reviews.appspot.com/1149803/diff/1/3
File user/src/com/google/gwt/user/client/ui/DialogBox.java (right):
http://gwt-code-reviews.appspot.com/1149803/diff/1/3#newcode116
user/src/com/google/gwt/user/client/ui/DialogBox.java:116:
bump.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks for taking the time to look at it.
Bumping this because it seems like things have gotten really busy with
commits in the past few days. I know this isn't complete fix. I want
to add a default implementation for the header that accepts widgets
and modify the uibinder support for dialogbox
26 matches
Mail list logo
