We thought about this, but the conclusion was that it would be better not
to expose yet another internal format. We do use this format for the deRPC
implementation.
Dan
On Thu, Jun 17, 2010 at 12:08 PM, cromwell...@gmail.com wrote:
If they're being eval'ed, why not transmit the long as a
Why not change deRPC?
On Thu, Jun 17, 2010 at 9:11 AM, Daniel Rice (דניאל רייס)
r...@google.comwrote:
We thought about this, but the conclusion was that it would be better not
to expose yet another internal format. We do use this format for the deRPC
implementation.
Dan
On Thu, Jun
deRPC eval's the entire payload in one shot, so the long values need to be
represented exactly in their runtime representation, namely
{l=number,m=number,h=number}. Standard RPC has the opportunity to
process each value before it is available to user code.
Dan
On Thu, Jun 17, 2010 at 1:49 PM,
Oh, duh. I mis-read what you wrote, which was exactly what I wanted to hear:
deRPC is already doing the {l=number,m=number,h=number} trick, so
RequestFactory can too. Could you point us at the relevant code?
rjrjr
On Thu, Jun 17, 2010 at 11:11 AM, Daniel Rice (דניאל רייס)
r...@google.comwrote:
LGTM with nits.
http://gwt-code-reviews.appspot.com/626801/diff/1/2
File dev/core/super/com/google/gwt/lang/LongLib.java (right):
http://gwt-code-reviews.appspot.com/626801/diff/1/2#newcode58
dev/core/super/com/google/gwt/lang/LongLib.java:58: sb.append('\'');
Why do we need quotes?
http://gwt-code-reviews.appspot.com/626801/diff/1/2
File dev/core/super/com/google/gwt/lang/LongLib.java (right):
http://gwt-code-reviews.appspot.com/626801/diff/1/2#newcode58
dev/core/super/com/google/gwt/lang/LongLib.java:58: sb.append('\'');
Fields in the RPC stream are JS literals that get
http://gwt-code-reviews.appspot.com/626801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/626801/diff/1/2
File dev/core/super/com/google/gwt/lang/LongLib.java (right):
http://gwt-code-reviews.appspot.com/626801/diff/1/2#newcode58
dev/core/super/com/google/gwt/lang/LongLib.java:58: sb.append('\'');
On 2010/06/16 20:13:28, Dan Rice wrote:
