[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

zhuyi, do you have time to look at Scott and Rajeev's feedback? If not, let me know and I can take a crack at it sometime in the next few days. http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

Hi Stephen, I am very busy with my current project. Sorry I do not think I have time to work on it right now. Thanks! Yi On Tue, Jun 12, 2012 at 8:24 AM, wrote: > zhuyi, do you have time to look at Scott and Rajeev's feedback? If not, > let me know and I can take a crack at it sometime in the

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2012/06/11 22:56:06, scottb wrote: Rajeev and I went through and made some rough comments Damn invalid XSRF token. You don't get as nice of a comment this time. Since I can't write to this issue, I made a new issue here, with patchset 1 being Yi's work that you reviewed, rebased against tru

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

Ping. Is this going to be submitted? http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java File user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java File user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/4001/user/src/com/google/gwt/

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java File user/src/com/google/gwt/user/rebind/rpc/Shared.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java#newcode56 user/s

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java File user/src/com/google/gwt/user/rebind/rpc/Shared.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java#newcode56 user/s

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On Mon, Apr 18, 2011 at 10:39 AM, wrote: > > > http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/google/gwt/user/rebind/rpc/Shared.java > File user/src/com/google/gwt/user/rebind/rpc/Shared.java (right): > > > http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/src/com/g

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java File user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/clie

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

I don't have the full context, but adding flakiness is not a good idea. According to the current code structure, if we want to make the variable non-static, we may need to pass the propertyOracle parameter to many methods, because shouldConsiderFieldsForSerialization method in SerializableTypeOr

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/04/18 18:56:30, Stephen Chenney wrote: http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java File user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java (right): http://gwt-code-reviews.appspot.com/1

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/05/09 21:06:01, zhuyi wrote: On 2011/04/18 18:56:30, Stephen Chenney wrote: > http://gwt-code-reviews.appspot.com/1380807/diff/11003/user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java > File user/test/com/google/gwt/user/client/rpc/FinalFieldsTestService.java > (rig

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

Is this going to be submitted? Sounds like everything was fine, except for changing the test object back to IsSerializable? http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/07/05 19:51:52, stephenh wrote: Is this going to be submitted? Sounds like everything was fine, except for changing the test object back to IsSerializable? Hi Bob and Ray, Any comments about my response below? I don't have the full context, but adding flakiness is not a good idea.

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

According to the current code structure, if we want to make the variable non-static, we may need to pass the propertyOracle parameter to many methods I downloaded the patch and was able to kill the "flaky" static variable by changing various methods to take GeneratorContextExt (which has bot

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/07/06 06:22:38, stephenh wrote: > According to the current code structure, if we want to make the > variable non-static, we may need to pass the propertyOracle parameter to many > methods I downloaded the patch and was able to kill the "flaky" static variable by changing various me

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

That would be great. Could you please upload the patch? Thanks! Sure--I can't upload a new patchset to this issue because I'm not the owner. Is it possible to add me? Or would you prefer for me to create a new issue? http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/g

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/07/06 13:51:57, zhuyi wrote: On 2011/07/06 06:22:38, stephenh wrote: > > According to the current code structure, if we want to make the > > variable non-static, we may need to pass the propertyOracle parameter to many > > methods > > I downloaded the patch and was able to kill the "fla

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/07/06 14:05:05, stephenh wrote: > That would be great. Could you please upload the patch? Thanks! Sure--I can't upload a new patchset to this issue because I'm not the owner. Is it possible to add me? Or would you prefer for me to create a new issue? Could you please create a new i

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

Could you please create a new issue? Yeah, np: http://gwt-code-reviews.appspot.com/1463813/ I'll reiterate my previous disclaimer that I didn't do any clean up for formatting/line-length/etc. as it was just a proof of concept. If you'd like me to clean it up to be directly submit-able, let me

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1463813/ I deleted this issue and made a new one: http://gwt-code-reviews.appspot.com/1463814/ That has better context between the last patch set of this issue and the changes I made to kill the static field. http://gwt-code-reviews.appspot.com/1380807/

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

Thanks. I'll look through and incorporate your changes. On Thu, Jul 7, 2011 at 6:33 PM, wrote: > > http://gwt-code-reviews.**appspot.com/1463813/ >> > > I deleted this issue and made a new one: > > http://gwt-code-reviews.**appspot.com/1463814/

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

Thanks. I'll look through and incorporate your changes. zhuyi, any updates on this? http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

I am integrating it. Sorry that I haven't worked on it for a while due to other jobs. On Fri, Aug 26, 2011 at 8:24 AM, wrote: > >> Thanks. I'll look through and incorporate your changes. > > zhuyi, any updates on this? > > http://gwt-code-reviews.appspot.com/1380807/ > -- http://groups.google.

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

I am integrating it. Sorry that I haven't worked on it for a while due to other jobs. Awesome, no problem. Was just wondering if I should try and pick it up if you weren't working on it. http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contribut

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/09/01 00:10:12, zhuyi wrote: Hi Stephen, I've integrated your changes, also synced the changes. Sorry for the delay. Could you please review it? Thanks. Yi http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/RemoteServiceFinalFields.gwt.xml File user/src/com/google/gwt/user/RemoteServiceFinalFields.gwt.xml (right): http://gwt-code-reviews.appspot.com/1380807/diff/40002/user/src/com/google/gwt/user/RemoteServiceFinalF

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

I've integrated your changes, also synced the changes. Thanks! Could you please review it? Sure. I understand a bit more about how it works now. Previously, the server-side ignored all final fields. You understandably had to change that, but since the server-side doesn't have access to th

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

Thinking about it some more; it would be the easiest if GWT just started serializing final fields across the board, and only skipped them if they were marked with a GwtTransient. That is basically what the current patch does (except for ignoring sets on the client-side). Anything else requires m

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

Uploaded my changes respect to the review comments, but have not addressed the issue of getting opt-in information in server side. On Thu, Sep 1, 2011 at 5:26 PM, wrote: > http://gwt-code-reviews.appspot.com/1380807/ > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/diff/50002/user/test/com/google/gwt/user/RPCSuite.java File user/test/com/google/gwt/user/RPCSuite.java (right): http://gwt-code-reviews.appspot.com/1380807/diff/50002/user/test/com/google/gwt/user/RPCSuite.java#newcode110 user/test/com/google/gwt/user

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

Here is my take on putting the final field switch into the policy file: https://github.com/stephenh/scalagwt-gwt/commit/35535b2f36cb196792a411430567a7a9aeb8adb1 Now final fields only go across the wire if the user opts in, and the server-side behaves accordingly. http://gwt-code-reviews.appspot

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/09/03 01:04:50, zhuyi wrote: Integrated Stephen's change on SerializationPolicy. Individual test cases works fine, but test cases were broken when they were put together (e.g. run RPCSuite.java). That is caused by the caches in SerializabilityUtil.java. I've temporary disabled two caches

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

caused by the caches in SerializabilityUtil.java Huh, good catch. Any good suggestion on the cache structure improvement? Using a Pair seems to work: https://github.com/stephenh/scalagwt-gwt/commit/9dd82d23d6bdf904e92af5502a3eba450c615c63 http://gwt-code-reviews.appspot.com/1380807/ --

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

Looks good to me. http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/09/07 18:00:10, zhuyi wrote: I test this through the entire test suite. It still broke one case (testEnumArray): http://code.google.com/p/google-web-toolkit/source/browse/trunk/user/test/com/google/gwt/user/client/rpc/CollectionsTest.java?r=8394#268 It seems that something is not correc

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/09/07 18:03:04, zhuyi wrote: On 2011/09/07 18:00:10, zhuyi wrote: I test this through the entire test suite. It still broke one case (testEnumArray): http://code.google.com/p/google-web-toolkit/source/browse/trunk/user/test/com/google/gwt/user/client/rpc/CollectionsTest.java?r=8394#

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

Ray, John and others: I and Stephen have been working on this for a while to make the option of serializing final fields in RPC be a non-static variable to eliminate flakiness, and pass this option to server side by serialization policy file. Please let us know if the change is in good shape and

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/09/14 17:45:17, zhuyi wrote: Ray, John and others: I and Stephen have been working on this for a while to make the option of serializing final fields in RPC be a non-static variable to eliminate flakiness, and pass this option to server side by serialization policy file. Please le

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

I meant to comment; this would all be a lot simpler if GWT-RPC could serialize final fields as the default/only behavior (basically remove any configuration variables to turn it on/off). I understand this isn't viable for the next release, as it's a breaking change, and users might be putting val

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

Not really practical. On Tue, Oct 4, 2011 at 10:35 AM, wrote: > I meant to comment; this would all be a lot simpler if GWT-RPC could > serialize final fields as the default/only behavior (basically remove > any configuration variables to turn it on/off). > > I understand this isn't viable for th

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

Was debating whether this one should go in for GWT 2.5, but my inclination is to skip it. Please let me know if anyone feels strongly about this. http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On Fri, May 4, 2012 at 12:15 PM, wrote: > Was debating whether this one should go in for GWT 2.5, but my > inclination is to skip it. Please let me know if anyone feels strongly > about this. > > http://gwt-code-reviews.**appspot.com/1380807/ > It ha

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

If it's important enough, we should land it, but my impression is that it isn't It is the 7th-ranked bug in the issue tracker (by number of stars). But, as John said, it's had 5 years to get all those votes. http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/group/Goog

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

it looks like there's disagreement on the implementation My recollection is that zhuyi's original patch used a static variable to store the "do we serialize final fields or not" state. However, the variable is a per-module configuration, so putting it as static could have lead to non-determinism

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On Fri, May 4, 2012 at 2:44 PM, wrote: > it looks like there's disagreement on the implementation >> > > My recollection is that zhuyi's original patch used a static variable to > store the "do we serialize final fields or not" state. However, the > variable is a per-module configuration, so put

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

(and perhaps needing more tests, but I don't remember when that was relative to later development). Yeah, seems like that may have initially been the case, but by the time I got involved, I think he had some good tests in place. I see a number of "FinalFieldsXxxTest" in the review that I remembe

Re: [gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On Thu, Sep 1, 2011 at 11:56 AM, wrote: > Thinking about it some more; it would be the easiest if GWT just started > serializing final fields across the board, and only skipped them if they > were marked with a GwtTransient. > That is basically what the current patch does (except for ignoring s

Re: [gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

> There is a risk that existing users were relying on current behavior > to not send sensitive data in final fields across the wire Agreed, that is the worst case scenario. > such as the serialization policy file. Yeah, my concern would be that the policy file is still somewhat optional, right?