Re: C Strings and String Literals. (Was: Pascal rides again)

(2 years later...) Hi Doug! On 11/13/22 23:39, Douglas McIlroy wrote: > > Wouldn't it be nice to use -Wunterminated-strings and let the > > compiler yell at me if I write a string literal [that's too long]? > > A good idea. Assuming you use gcc, please propose it at > https://gcc.gnu.org/bugzilla

Re: YS .

On Sat, Jul 13, 2024 at 10:46:17AM GMT, G. Branden Robinson wrote: > Hi Alex, Hi Branden, > At 2024-07-13T17:38:17+0200, Alejandro Colomar wrote: > > > Try the attached patches. > > > > They don't seem to apply. > > Alas, that's life when you're

Re: YS .

Hi Branden, On Sat, Jul 13, 2024 at 10:12:32AM GMT, G. Branden Robinson wrote: > Hi Alex, > > At 2024-07-13T09:32:10-0500, G. Branden Robinson wrote: > > Yes, sort of--it seems I managed to screw it up. On top of that I > > wrote a particularly dumb test for it. :) > Try the attached patches.

YS .

Hi Branden, Was the trailing dummy string for YS to allow alignment finally merged? I built groff(1) from git HEAD and lost that functionality. Below is the head of a manual page for libs, a string library that I'm writing: $ cat stpeprintf.3 .\" Copyright 2024

Re: [PATCH v5 00/10] strtol(3)-related fixes

Hi Branden, On Fri, Jul 12, 2024 at 01:48:39PM GMT, G. Branden Robinson wrote: > Hi Alex, > > At 2024-07-10T11:41:15+0200, Alejandro Colomar wrote: > > How is that? I would expect git-am(1) to work. > [...] > > What I do is on neomutt(1), while reading the email --and

Re: [PATCH v5 00/10] strtol(3)-related fixes

If you supply directories, they will be treated as Maildirs. Please let me know if this doesn't work for you. Have a lovely day! Alex > > Regards, > Branden > > At 2024-03-16T13:34:28+0100, Alejandro Colomar wrote: > > This v5 further documents which commits i

Re: -Thtml double free in tcache 2; Abort

On Thu, Jun 20, 2024 at 01:54:57PM GMT, G. Branden Robinson wrote: > Hi Alex, Hi Branden, > At 2024-06-17T23:23:03+0200, Alejandro Colomar wrote: > > On Mon, Jun 17, 2024 at 01:43:38PM GMT, G. Branden Robinson wrote: > > > Until grohtml's putatively sloppy handli

Re: -Thtml double free in tcache 2; Abort

Hi Branden, On Mon, Jun 17, 2024 at 01:43:38PM GMT, G. Branden Robinson wrote: > Me neither. > > I bisected it down to this. > > 0951ff53e47cfc8dda792e23f2111268bd3dd81b is the first bad commit > commit 0951ff53e47cfc8dda792e23f2111268bd3dd81b > Author: G. Branden Robinson > Date: Thu Aug 10

Re: man: EX/EE nested within nf/fi

On Sun, Jun 16, 2024 at 05:16:25PM GMT, G. Branden Robinson wrote: > Hi Alex, > > At 2024-06-16T23:14:56+0200, Alejandro Colomar wrote: > > Branden, how about using some register in EX/EE so that it can nest > > within nf/fi? > > In your scenario I would advise the

Re: man: EX/EE nested within nf/fi

On Sun, Jun 16, 2024 at 05:16:25PM GMT, G. Branden Robinson wrote: > Hi Alex, Hi Branden, > At 2024-06-16T23:14:56+0200, Alejandro Colomar wrote: > > Branden, how about using some register in EX/EE so that it can nest > > within nf/fi? > > In your scenario I would advi

Re: man: EX/EE nested within nf/fi

Hi Doug, Branden, On Tue, Jun 11, 2024 at 07:58:51PM GMT, Douglas McIlroy wrote: > > I'd structure what you have like this: > > > > .nf > > .EX > > ... > > .EE > > .fi > > .EX/.EE is too dumb for this. Anything between .EE and .fi will get > filled, which is almost certainly contrary to the purp

Re: -Thtml double free in tcache 2; Abort

On Sun, Jun 16, 2024 at 10:10:38PM GMT, Alejandro Colomar wrote: > Hi Branden, > > In the git HEAD of the man pages repository, I can reproduce a bug in > groff -Thtml: > > alx@debian:~/tmp/groff$ cat keyrings.7 > .TH a s d f > .SH foo > .TP > foobar > alx@debi

-Thtml double free in tcache 2; Abort

Hi Branden, In the git HEAD of the man pages repository, I can reproduce a bug in groff -Thtml: alx@debian:~/tmp/groff$ cat keyrings.7 .TH a s d f .SH foo .TP foobar alx@debian:~/tmp/groff$ troff -man -Thtml <./keyrings.7 >/dev/null free(): double free detected in tcache 2 Aborted alx@debian:~/

Re: prepare.pl looping forever

On Thu, Jun 13, 2024 at 05:11:15PM GMT, Alejandro Colomar wrote: > Hi Deri! > > I've triggered a forever loop in the scripts that produce the Linux > man-pages PDF book. Whoops! I created a page which is a .so to itself, accidentally. Never mind. Cheers, Alex -- <h

prepare.pl looping forever

Hi Deri! I've triggered a forever loop in the scripts that produce the Linux man-pages PDF book. I think the problem is in prepare.pl, since top(1) shows it stuck at around 100% CPU. It doesn't call anything groff internally, so it's just an issue in the perl code. However, it might be interest

Re: man: EX/EE nested within nf/fi

On Tue, Jun 11, 2024 at 07:52:30AM GMT, G. Branden Robinson wrote: > Hi Alex, Hi Branden, > At 2024-06-10T21:24:54+0200, Alejandro Colomar wrote: > > Hi Branden, > > > > Is it correct to nest EX/EE within nf/fi? > > It's harmless. "Correct" is a qu

man: EX/EE nested within nf/fi

Hi Branden, Is it correct to nest EX/EE within nf/fi? $ cat nfi.man .TH EXE 7 2024-06-10 alx .SH Name nf \- EX .SH SYNOPSIS .nf .B #include .P .EX struct { int a; int b; };

Re: Proposed v2: revised man(7) synopsis macros

Hi Branden, On Sun, May 05, 2024 at 04:11:21PM +0200, Alejandro Colomar wrote: > On Sun, May 05, 2024 at 08:54:53AM -0500, G. Branden Robinson wrote: > > Hi Alex, > > Hi Branden, > > > At 2024-05-05T14:41:44+0200, Alejandro Colomar wrote: > > > Thanks! >

Re: Proposed v2: revised man(7) synopsis macros

You did s/vger/lore/ and now the mail is bouncing. :-) -- signature.asc Description: PGP signature

Re: Proposed v2: revised man(7) synopsis macros

On Sun, May 05, 2024 at 08:54:53AM -0500, G. Branden Robinson wrote: > Hi Alex, Hi Branden, > At 2024-05-05T14:41:44+0200, Alejandro Colomar wrote: > > Thanks! > > > > I'm trying it already in liba2i, since it's a project that I don't > > expec

Re: Proposed v2: revised man(7) synopsis macros

On Sun, May 05, 2024 at 02:41:44PM +0200, Alejandro Colomar wrote: > Hi Branden, > > On Fri, May 03, 2024 at 03:31:26PM -0500, G. Branden Robinson wrote: > > At 2024-04-26T11:32:06+0200, Alejandro Colomar wrote: > > > > My questions: > > > > > > >

Re: Proposed v2: revised man(7) synopsis macros

Hi Branden, On Fri, May 03, 2024 at 03:31:26PM -0500, G. Branden Robinson wrote: > At 2024-04-26T11:32:06+0200, Alejandro Colomar wrote: > > > My questions: > > > > > > A. Does anyone object to me committing this change to groff's > > > master br

Re: man(7) <-> mdoc(7) (approximate) correspondence table?

Hi Alexis, On Sat, Apr 27, 2024 at 04:17:28PM +1000, Alexis wrote: > [ Not subscribed to the linux-man list, so please cc me if replying there. ] > > Hi all, > > As someone who's much more familiar with mdoc(7) than man(7), is there an > approximate 'correspondence table' somewhere that gives at

Re: Proposed v2: revised man(7) synopsis macros

t; `in` and `ti` requests. > * An example document, renderable with groff Git HEAD, 1.23.0, 1.22.4, > and 1.22.3 (at least), illustrating use of these macros. View it with > "nroff -man". > > My questions: > > A. Does anyone object to me committing this change to

Re: Proposed: revised man(7) synopsis macros

On Tue, Apr 23, 2024 at 08:19:55PM -0500, G. Branden Robinson wrote: > Hi folks, Hi folk, > I have been dissatisfied with groff man(7)'s SY and YS macros for a long > time. My primary grievance is one that has frustrated its uptake by > documenters of libraries: the macros are designed for synop

Re: Problems building the unifont PFA and DIT files for the PDF book

Hi Dave, On Sat, Apr 20, 2024 at 11:19:24PM -0500, Dave Kemper wrote: > Would you be willing to open a savannah request for this feature? > > https://savannah.gnu.org/bugs/?group=groff&func=additem > > afmtodit falls under category "Utilities." Thanks! Done.

Re: Problems building the unifont PFA and DIT files for the PDF book

Hi Brian, On Sat, Apr 20, 2024 at 02:11:55PM -0600, Brian Inglis wrote: > On 2024-04-20 09:52, G. Branden Robinson wrote: > > At 2024-04-20T14:26:17+0200, Alejandro Colomar wrote: > > > First problem: > > > > > > In the Unifont, I don't see a "Reg

Re: Problems building the unifont PFA and DIT files for the PDF book

Hi Branden, On Sat, Apr 20, 2024 at 10:52:31AM -0500, G. Branden Robinson wrote: > Since (I believe I saw you say that) you're using GNU Unifont only to > patch up missing code point coverage from other fonts, in your > application it probably makes sense to specify it as a "special" font. > > af

Problems building the unifont PFA and DIT files for the PDF book

Hi, I've tried groff-ifying the Unifont, in the same way I do it with the Tinos font. However, I've had a few problems. Here's the Tinos font that's packaged with Debian: $ apt-file find tinos | grep ttf texlive-fonts-extra-links: /usr/share/texlive/texmf-dist/fonts/truetype/go

Re: A primer on font installation for groff (was: gropdf(1)'s 'Font installation' section is opaque to me)

On Fri, Apr 19, 2024 at 12:36:39PM -0500, G. Branden Robinson wrote: > At 2024-04-19T19:34:19+0200, Alejandro Colomar wrote: > > On Thu, Apr 18, 2024 at 08:33:39PM -0500, G. Branden Robinson wrote: > > > B. afmtodit(1) must be run to produce a groff font description file >

Re: A primer on font installation for groff (was: gropdf(1)'s 'Font installation' section is opaque to me)

Hi Branden, On Thu, Apr 18, 2024 at 08:33:39PM -0500, G. Branden Robinson wrote: > B. afmtodit(1) must be run to produce a groff font description file > from the AFM file. BTW, what does 'dit' mean in afmtodit(1)? It seems like a very weird way to spell fdf. :) Cheers, Alex > > C. The

Re: A primer on font installation for groff (was: gropdf(1)'s 'Font installation' section is opaque to me)

> On Fri, Apr 19, 2024 at 04:43:49AM +0200, Jan Eden wrote: > > The process is explained in detail by Walter Alejandro Iglesias on the > > blog I referenced earlier[1], > > and he also provides a shell script > > (similar to Peter's explanation and script[2]). > > > > [1] https://technicallywewri

Re: A primer on font installation for groff (was: gropdf(1)'s 'Font installation' section is opaque to me)

On Fri, Apr 19, 2024 at 04:43:49AM +0200, Jan Eden wrote: > Hi Alejandro, Hi Jan, > On 2024-04-18 20:33, G. Branden Robinson wrote: [...] > > The process is explained in detail by Walter Alejandro Iglesias on the > blog I referenced earlier[1], I must have missed it. I don't find any mails fr

Re: A primer on font installation for groff (was: gropdf(1)'s 'Font installation' section is opaque to me)

Hi Branden, On Thu, Apr 18, 2024 at 08:33:39PM -0500, G. Branden Robinson wrote: > Hi Alex, > > At 2024-04-19T00:29:37+0200, Alejandro Colomar wrote: > > While the above is interesting, I've already read similar explanations > > from you in related threads. However, I

Re: gropdf(1)'s 'Font installation' section is opaque to me

Hi Branden, On Thu, Apr 18, 2024 at 02:03:50PM -0500, G. Branden Robinson wrote: > Hi Alex, > > At 2024-04-18T18:00:09+0200, Alejandro Colomar wrote: > > Hi, > > > > I find the following section very opaque. > > > > Font installation > >

gropdf(1)'s 'Font installation' section is opaque to me

Hi, I find the following section very opaque. Font installation The following is a step‐by‐step font installation guide for gropdf. • Convert your font to something groff understands. This is a PostScript Type 1 font in PFA or PFB format, together with an

Re: [PATCH v2] tzfile.5: Fix indentation

gt; when filling is disabled. (This would be kin to TeX's notoriously > discouraging "overfull hbox" warnings, but if I can't write a diagnostic > message more intelligible than that, I'll put in for retirement.) Since manual pages often have a few levels of indent

Re: [PATCH v2] tzfile.5: Fix indentation

Hi Paul, Branden, On Sun, Apr 07, 2024 at 11:33:38PM -0700, Paul Eggert wrote: > On 2024-03-18 01:35, Alejandro Colomar wrote: > > > Hmm, while Ossana's indents might be a bit excessive, TZDB's might be > > too short. Maybe I would RS 4 spaces instead of 2 before

Re: Running the grohtml pipeline as a pipeline

Hi Branden, On Fri, Mar 22, 2024 at 05:45:14PM -0500, G. Branden Robinson wrote: > Hi Alex, > > At 2024-03-22T21:24:10+0100, Alejandro Colomar wrote: > > Heh, we're comparing different things. I'm comparing `eqn -Tps` to > > nothing at all, while you're compa

Re: Running the grohtml pipeline as a pipeline

On Fri, Mar 22, 2024 at 03:15:11PM -0500, G. Branden Robinson wrote: > At 2024-03-22T20:56:28+0100, Alejandro Colomar wrote: > > I'm quite surprised that you aren't even getting the warning due to > > `eqn -Thtml`. > > I did. I elided it. I also elided nearly all

Re: Running the grohtml pipeline as a pipeline

Hi Branden, On Fri, Mar 22, 2024 at 02:44:26PM -0500, G. Branden Robinson wrote: > At 2024-03-22T20:10:51+0100, Alejandro Colomar wrote: > > It reduces the base paragraph inset (did I use the right term? :) to > > almost nothing. > > I have to say I regard this as a pretty m

Re: Running the grohtml pipeline as a pipeline

Hi Branden, On Fri, Mar 22, 2024 at 01:53:51PM -0500, G. Branden Robinson wrote: > Hi Alex, > > At 2024-03-18T12:38:30+0100, Alejandro Colomar wrote: > > I'm considering using grohtml(1) in the Linux man-pages, to replace > > man2html(1), which crashes on tzfile(5)

Re: Milestone reached: hyperlinked mdoc(7) documents in PDF

On Fri, Mar 22, 2024 at 05:56:58PM +, Deri wrote: > On Friday, 22 March 2024 16:59:14 GMT Alejandro Colomar wrote: > > ow, how am I supposed to > > get that patch without anyone tampering it during its trip to my > > computer? :( > > derij@ws:~$ md5sum

Re: Milestone reached: hyperlinked mdoc(7) documents in PDF

Hi Branden! On Fri, Mar 22, 2024 at 11:30:11AM -0500, G. Branden Robinson wrote: > Hi Alex, > > At 2024-03-17T23:44:07+0100, Alejandro Colomar wrote: > > On Sun, Mar 17, 2024 at 05:23:20PM -0500, G. Branden Robinson wrote: > > > Following up my earlier announcement r

Running the grohtml pipeline as a pipeline

Hi Branden, I'm considering using grohtml(1) in the Linux man-pages, to replace man2html(1), which crashes on tzfile(5) --which has correct man(7)--. Currently, I'm running groff(1) as its separate constituents: $ make build-ps -Wman2/membarrier.2 PRECONV .tmp/man/man2/me

Re: Milestone reached: hyperlinked mdoc(7) documents in PDF

Hi Branden! On Sun, Mar 17, 2024 at 05:23:20PM -0500, G. Branden Robinson wrote: > Hi folks, > > Following up my earlier announcement regarding man(7),[1], I'm pleased > to report that we have a functioning PDF hyperlink story for the mdoc > package. > > * The Mt macro hyperlinks email addresses

Re: [PATCH v2] tzfile.5: Fix indentation

On Sun, Mar 17, 2024 at 08:53:22PM +0100, Alejandro Colomar wrote: > Hi Branden, > > On Sun, Mar 17, 2024 at 08:31:55PM +0100, Alejandro Colomar wrote: > > Hmmm, I was about to say inset, but double-checked groff_man(7) to be > > sure of the exact term, and then I g

Re: [PATCH v2] tzfile.5: Fix indentation

Hi Branden, On Sun, Mar 17, 2024 at 08:31:55PM +0100, Alejandro Colomar wrote: > Hmmm, I was about to say inset, but double-checked groff_man(7) to be > sure of the exact term, and then I got confused even more: > > $ man groff_man | grep ' \.\(IP\|RS\) \[' > .RS

Re: [PATCH v2] tzfile.5: Fix indentation

On Sun, Mar 17, 2024 at 02:24:29PM -0500, G. Branden Robinson wrote: > [looping in groff mailing list to pitch a terminological reform] > > Hi Alex, Hi Banden, > At 2024-03-17T19:56:10+0100, Alejandro Colomar wrote: > > You already gained the first two spaces from the pre

Bug#1067022: man2html: Segmentation fault with tzfile(5)

Package: man2html Version: 1.6g-16 Severity: normal Tags: upstream X-Debbugs-Cc: Alejandro Colomar , Paul Eggert , "G. Branden Robinson" , linux-...@vger.kernel.org, groff@gnu.org, t...@iana.org Dear Maintainer, The page tzfile(5) from tzdb-2024a manages to consistently produce a Se

Re: Use public inbox in groff [was: Remove redundant tests]

Hi Branden, On Sat, Mar 16, 2024 at 08:37:00PM +0100, Andreas Schwab wrote: > Please contact overse...@sourceware.org. Branden, I guess it's you who'd need to ask them to do it. Would you mind doing the honours? Have a lovely night! Alex -- signature.asc

Re: Use public inbox in groff [was: Remove redundant tests]

On Sat, Mar 16, 2024 at 08:37:00PM +0100, Andreas Schwab wrote: > Please contact overse...@sourceware.org. Thanks! Have a lovely night! Alex > -- > Andreas Schwab, sch...@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completel

Use public inbox in groff [was: Remove redundant tests]

[CC += groff@] Hi Andreas, Dave, [This sub-thread started here: <https://lists.gnu.org/archive/html/bug-groff/2024-03/msg00054.html>] On Sat, Mar 16, 2024 at 12:11:08PM -0500, Dave Kemper wrote: > On Sat, Mar 16, 2024 at 5:44 AM Alejandro Colomar wrote: > > Where do I need to

[PATCH v5 09/10] [indxbib]: Collapse related tests

Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar

[PATCH v5 03/10] src/: Remove redundant checks after strtol(3).

<https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/devices/grodvi/dvi.cpp | 4 ++-- src/devices/grolbp/lbp.cpp

[PATCH v5 08/10] [indxbib]: Remove dead code

gt; Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/indxbib/

[PATCH v5 10/10] [grolbp]: Fix range check after strtol(3)

nk: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/devices/grolbp/lbp.cpp | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH v5 02/10] [libgroff]: Remove dead code

ot; Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/libgroff/curtime.cpp b/src/libs/libgroff/curtime.cpp index 490fc3018..4623ad9a0 100644 --- a/src

[PATCH v5 01/10] [libgroff]: Remove redundant checks.

owden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libs/libgroff/curtime.cpp b/src/libs/libgroff/curtime.cpp index 277755cab..490fc3018 100644

[PATCH v5 07/10] [indxbib]: Clear errno before calling strtol(3)

ner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/utils/indxbib/indxbib.cpp b/src/utils/indxbib/indxbib.cpp index c5996c279..6253e4782 100644 --- a/src/utils/indxbib/indxbib.cpp +++ b/src/utils/

[PATCH v5 04/10] [grolbp]: Remove bogus (and redundant) check

`str == end` can only happen if strtol(3) returns 0. Fixes: 98608a8ba037 ("grolbp output device") Link: <https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Cla

[PATCH v5 05/10] src/: ceil_prime(): Add function to get the lowest prime not less than n

lt;https://lists.gnu.org/archive/html/groff/2024-03/msg00065.html> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar --- src/include/lib.h | 2 +- src/libs/li

[PATCH v5 00/10] strtol(3)-related fixes

Hi, This v5 further documents which commits introduced some issues being fixed, and with it, I found James also wrote some of this, so I've also CCed him. See range-diff below. Cheers, Alex Alejandro Colomar (10): [libgroff]: Remove redundant checks. [libgroff]: Remove dead code

[PATCH v5 06/10] [indxbib]: Don't else after [[noreturn]]

Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Cc: James Clark Signed-off-by: Alejandro Colomar

Re: [PATCH v4 10/10] [grolbp]: Fix range check after strtol(3)

On Sat, Mar 16, 2024 at 12:55:07PM +0100, Alejandro Colomar wrote: > In case INT_MAX==LONG_MAX, we need to check for ERANGE to reject > high values. The test 'n > INT_MAX' would never be true. > > Fixes: d21a9dbc7a83 ("Werner LEMBERG ") Oops, this shou

[PATCH v4 10/10] [grolbp]: Fix range check after strtol(3)

ot;G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/devices/grolbp/lbp.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/devices/grolbp/lbp.cpp b/src/devices/gro

[PATCH v4 09/10] [indxbib]: Collapse related tests

Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/utils/in

[PATCH v4 01/10] [libgroff]: Remove redundant checks.

owden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libs/libgroff/curtime.cpp b/src/libs/libgroff/curtime.cpp index 277755cab..490fc3018 100644 --- a/src/libs/lib

[PATCH v4 06/10] [indxbib]: Don't else after [[noreturn]]

Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 20 1 file changed, 8 i

[PATCH v4 08/10] [indxbib]: Remove dead code

gt; Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/indxbib/indxbib.cpp b/src/

[PATCH v4 07/10] [indxbib]: Clear errno before calling strtol(3)

Otherwise, errno may hold ERANGE from before. See strtol(3). Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Wern

[PATCH v4 03/10] src/: Remove redundant checks after strtol(3).

`str == end` can only happen if strtol(3) returns 0. Link: <https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/devices/grodvi/dvi.cpp

[PATCH v4 02/10] [libgroff]: Remove dead code

ot; Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/libgroff/curtime.cpp b/src/libs/libgroff/curtime.cpp index 490fc3018..4623ad9a0 100644 --- a/src/libs/lib

[PATCH v4 00/10] strtol(3)-related fixes

no known bugs (admittedly, it's too new for that, but hey, it's just a thin wrapper around strtoi(3), which I fixed recently). Have a lovely day! Alex Alejandro Colomar (10): [libgroff]: Remove redundant checks. [libgroff]: Remove dead

[PATCH v4 05/10] src/: ceil_prime(): Add function to get the lowest prime not less than n

Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/include/lib.h | 2 +- src/libs/libbib/index.cpp | 4 +--- src/libs/libgroff/prime.cpp | 18 +- src/utils/ind

[PATCH v4 04/10] [grolbp]: Remove bogus (and redundant) check

`str == end` can only happen if strtol(3) returns 0. Closes: <https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Cc: Colin Watson Cc: Werner LEMBERG Signed-off-by: Alejandro Colomar --- src/devices/grolbp/lbp.cpp

[PATCH v3 7/9] [indxbib]: Clear errno before calling strtol(3)

Otherwise, errno may hold ERANGE from before. See strtol(3). Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Aleja

[PATCH v3 1/9] [libgroff]: Remove redundant checks.

ERANGE can only happen if strtol(3) returns either LONG_MIN or LONG_MAX. Link: <https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 3 +-- 1 file

[PATCH v3 4/9] [grolbp]: Remove bogus (and redundant) check

`str == end` can only happen if strtol(3) returns 0. Closes: <https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/devices/grolbp/lbp.cpp | 2 +- 1 file changed, 1 inserti

[PATCH v3 5/9] src/: ceil_prime(): Add function to get the lowest prime not smaller than n

Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/include/lib.h | 2 +- src/libs/libbib/index.cpp | 4 +--- src/libs/libgroff/prime.cpp | 18 +- src/utils/indxbib/indxbib.cpp | 6 +-

[PATCH v3 9/9] [indxbib]: Collapse related tests

Fixes: d7b36a45fc3f ("[indxbib]: Mitigate Savannah #65452.") Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 6 +- 1 file

[PATCH v3 6/9] [indxbib]: Don't else after [[noreturn]]

Link: <https://savannah.gnu.org/bugs/?65452> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff

[PATCH v3 8/9] [indxbib]: Remove dead code

gt; Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/utils/indxbib/indxbib.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/indxbib/indxbib.cpp b/src/utils/indxbib/indxbib.cpp index 6253

[PATCH v3 3/9] src/: Remove redundant checks after strtol(3).

`str == end` can only happen if strtol(3) returns 0. Link: <https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/devices/grodvi/dvi.cpp | 4 ++-- src/devices/grolbp/lbp.cp

[PATCH v3 0/9] strtol(3)-related fixes

Hi Branden, Here's a patch set that includes the patches that Dave reminded, the ceil_prime() one, and the fixes for the problems I noticed in your recent commit. I've rebased everything on top of git HEAD. Below is a range-diff. Have a lovely day! Alex Alejandro Colomar (9):

[PATCH v3 2/9] [libgroff]: Remove dead code

strtol(3) can only report ERANGE, if the base is valid (and it is). Link: <https://savannah.gnu.org/bugs/?65451> Cc: "G. Branden Robinson" Cc: Dave Kemper Cc: "James K. Lowden" Signed-off-by: Alejandro Colomar --- src/libs/libgroff/curtime.cpp | 2 +- 1 file

Re: Unable to generate glyphs for chinese letters

On Wed, Mar 13, 2024 at 02:25:51PM +0100, Alejandro Colomar wrote: > Hi Deri, > > I've noticed another similar issue, this time with Chinese. You can find the PDF here: <https://www.alejandro-colomar.es/share/dist/shadow/git/HEAD/man/shadow-HEAD_zh_CN.pdf> -- <https://w

Unable to generate glyphs for chinese letters

Hi Deri, I've noticed another similar issue, this time with Chinese. I see chinese letters in the bookmarks, but they don't appear in the PDF body. If I read the manual page in the terminal, I do see them. When generating the PDF, I get a bunch of warnings about special characters not defined.

Re: [PATCH v2] src/: ceil_prime(): Add function to get the lowest prime not smaller than n

Hi Branden, On Wed, Mar 13, 2024 at 06:52:10AM -0500, G. Branden Robinson wrote: > Hi Alex, > > At 2024-03-13T12:01:32+0100, Alejandro Colomar wrote: > > I didn't write an exploit, as that would be a little bit more work > > (including learning what is indxbib at all

Re: [PATCH v2] src/: ceil_prime(): Add function to get the lowest prime not smaller than n

Hi Branden, On Wed, Mar 13, 2024 at 05:46:38AM -0500, G. Branden Robinson wrote: > Forgot to attach my working copy, of course. You could have attached/inlined a diff; it would be smaller. :) > /* Copyright (C) 1989-2020 Free Software Foundation, Inc. > Written by James Clark (j...@jclark.

Re: [PATCH v2] src/: ceil_prime(): Add function to get the lowest prime not smaller than n

On Wed, Mar 13, 2024 at 05:45:10AM -0500, G. Branden Robinson wrote: > Hi Alex, Hi Branden, > At 2024-03-13T11:21:55+0100, Alejandro Colomar wrote: > > And use it where the same logic was being open-coded. > > > > While at it, fix the logic, which was incorrect in the o

[PATCH v2] src/: ceil_prime(): Add function to get the lowest prime not smaller than n

o the first prime, 2. Cc: "G. Branden Robinson" Signed-off-by: Alejandro Colomar --- Range-diff against v1: 1: 124bbe1ae ! 1: 9432f7f87 src/: ceil_prime(): Add function to get the lowest prime not smaller than n @@ Commit message And use it where the same logic was b

[PATCH] src/: ceil_prime(): Add function to get the lowest prime not smaller than n

And use it where the same logic was being open-coded. Cc: "G. Branden Robinson" Signed-off-by: Alejandro Colomar --- Hi Branden, Now this looks better. After this change, it seems to me more clear that using 1 as the minimum is fine, since it only results in a warning, and not i

Re: Possibly incomplete bounds check after strtol(3)

On Wed, Mar 13, 2024 at 12:27:33AM +0100, Alejandro Colomar wrote: > On Tue, Mar 12, 2024 at 11:22:32PM +0100, Alejandro Colomar wrote: > > On Tue, Mar 12, 2024 at 05:05:31PM -0500, G. Branden Robinson wrote: > > > 147 case 'h': > > > 148 { > >

Re: Possibly incomplete bounds check after strtol(3)

On Tue, Mar 12, 2024 at 11:22:32PM +0100, Alejandro Colomar wrote: > On Tue, Mar 12, 2024 at 05:05:31PM -0500, G. Branden Robinson wrote: > > Hi Alex, > > > > I forgot about this; fortunately, Dave reminded me. > > Hi Branden! (Hi Dave!) > > > At 2024-01

Re: Possibly incomplete bounds check after strtol(3)

On Tue, Mar 12, 2024 at 05:05:31PM -0500, G. Branden Robinson wrote: > Hi Alex, > > I forgot about this; fortunately, Dave reminded me. Hi Branden! (Hi Dave!) > At 2024-01-14T20:19:18+0100, Alejandro Colomar wrote: > > I see some code calling strtol(3) that I suspect wo

Re: [PATCH] [grotrin] Add post-processor for groff input.

Hi Lennart, On Sun, Mar 10, 2024 at 12:13:34AM +, Lennart Jablonka wrote: > This is useless. And also not what Alejandro wanted, presumably. > > Suggested-By: Alejandro Colomar > --- > I don’t wanna wait for April 1st. Lol! It's not exactly what I wanted, but it&#x

Re: Warnings in groff's manual pages

Hi Branden, On Mon, Feb 26, 2024 at 04:25:53PM -0600, G. Branden Robinson wrote: > These are documented, expected, and relatively harmless. > > https://git.savannah.gnu.org/cgit/groff.git/tree/PROBLEMS#n959 Good. > > ! (troff -man -wbreak -Tutf8 -rLL=78n -rCHECKSTYLE=3 -ww > > &1 > > >/tmp/

Warnings in groff's manual pages

Hi Branden, I've been linting groff's manual pages, as of $ git describe 1.23.0-902-g1fce75f6b and got some warnings. You may want to have a look at them, just in case any of those is legit. Have a lovely day! Alex --- $ make -k --debug=print \ -C /home/alx/src/linu

Re: special character 'mc' not defined

Hi Branden, On Sun, Feb 25, 2024 at 03:01:42PM -0600, G. Branden Robinson wrote: > I suspect the problem is a matter of locale or selected output device. Hmmm, it was the locale. Which itself was due to SSH (the locale was set as C.utf8, but when SSHing it was POSIX). I set now LANG in .profile

  1   2   3   4   5   6   >