Re: pc.mod -> part_msdos.mod (etc)

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
On Mon, Aug 24, 2009 at 1:43 AM, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 24, 2009 at 12:59 AM, Robert Millan wrote: >> On Sun, Aug 23, 2009 at 11:05:47PM +0200, Vladimir 'phcoder' Serbinenko >> wrote: >>> It broke grub-install. I already fixed it. >> >> Sorry, and thanks! :-) >> > Actua

Re: pc.mod -> part_msdos.mod (etc)

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
On Mon, Aug 24, 2009 at 12:59 AM, Robert Millan wrote: > On Sun, Aug 23, 2009 at 11:05:47PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> It broke grub-install. I already fixed it. > > Sorry, and thanks! :-) > Actually my first fix wasn't ok for efi and LVM users. New fix opens new door: currently

Re: [PATCH] Clean up struct grub_module_header

2009-08-23 Thread Robert Millan
On Sun, Aug 23, 2009 at 01:08:05PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Aug 23, 2009 at 12:50 PM, Robert Millan wrote: > > On Sat, Aug 22, 2009 at 02:10:12AM -0400, Pavel Roskin wrote: > >> +enum > >> +{ > >> +  OBJ_TYPE_ELF, > >> +  OBJ_TYPE_MEMDISK, > >> +  OBJ_TYPE_CONFIG > >> +

Re: [PATCH] Split big and little endian BeFS and AtheFS

2009-08-23 Thread Robert Millan
On Sun, Aug 23, 2009 at 01:04:30PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Aug 23, 2009 at 12:40 PM, Robert Millan wrote: > > On Thu, Aug 20, 2009 at 06:16:24PM -0400, Pavel Roskin wrote: > >> I don't think we should rename "byte_order" to "unused".  Just because > >> we doesn't use i

Re: [PATCH] Optimised 1bit blitters

2009-08-23 Thread Robert Millan
On Sun, Aug 23, 2009 at 01:05:45PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Aug 23, 2009 at 12:48 PM, Robert Millan wrote: > > On Fri, Aug 21, 2009 at 05:33:30PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > >> +  for (j = 0; j < height; j++) > >> +    { > >> +      for (i = 0; i

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
On Mon, Aug 24, 2009 at 1:03 AM, Robert Millan wrote: > On Mon, Aug 24, 2009 at 01:00:06AM +0200, Vladimir 'phcoder' Serbinenko wrote: >> On Mon, Aug 24, 2009 at 12:56 AM, Robert Millan wrote: >> > On Mon, Aug 24, 2009 at 12:46:29AM +0200, Vladimir 'phcoder' Serbinenko >> > wrote: >> >> Why is it

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-23 Thread Robert Millan
On Mon, Aug 24, 2009 at 01:00:06AM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 24, 2009 at 12:56 AM, Robert Millan wrote: > > On Mon, Aug 24, 2009 at 12:46:29AM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > >> Why is it still asm? It can be done easily in C. > >> Actually here we

Re: Some ideas about new features of grub

2009-08-23 Thread Robert Millan
On Sun, Aug 23, 2009 at 06:58:43PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> But I know both Marco and Pavel feel strongly about this.  Please can you > >> comment? > >> > > > > I am against a configure flag (if configure is the one from configure, make, > > make install) but a configure fla

Re: pc.mod -> part_msdos.mod (etc)

2009-08-23 Thread Robert Millan
On Sun, Aug 23, 2009 at 11:05:47PM +0200, Vladimir 'phcoder' Serbinenko wrote: > It broke grub-install. I already fixed it. Sorry, and thanks! :-) -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threaten

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
On Mon, Aug 24, 2009 at 12:56 AM, Robert Millan wrote: > On Mon, Aug 24, 2009 at 12:46:29AM +0200, Vladimir 'phcoder' Serbinenko wrote: >> Why is it still asm? It can be done easily in C. >> Actually here we have 2 extremes: nice code (C, transform to nice >> flags (only one shift or 2 conrols and

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-23 Thread Robert Millan
On Mon, Aug 24, 2009 at 12:41:38AM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 24, 2009 at 12:27 AM, Robert Millan wrote: > > On Wed, Aug 12, 2009 at 04:35:21PM +0100, Colin Watson wrote: > >> +static int > >> +grub_at_keyboard_keystatus (void) > >> +{ > >> +  /* FIXME: I don't know i

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-23 Thread Robert Millan
On Mon, Aug 24, 2009 at 12:46:29AM +0200, Vladimir 'phcoder' Serbinenko wrote: > Why is it still asm? It can be done easily in C. > Actually here we have 2 extremes: nice code (C, transform to nice > flags (only one shift or 2 conrols and alts)) or small code (asm, > crude value). Where we choose t

Re: pc.mod -> part_msdos.mod (etc)

2009-08-23 Thread Robert Millan
On Sun, Aug 23, 2009 at 08:42:52PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> As was discussed in > >> http://www.mail-archive.com/grub-devel@gnu.org/msg06210.html > >> I intend to prefix all partmap modules with "part_" and rename "pc" to > >> "part_msdos". > This partition scheme is "PC-st

Re: [PATCH 2/2] "auto" keyword in gfxmode and gfxpayload specification

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
> I would interpret "keep" as "keep what we have now".  If we're in text mode, > then "keep text mode". Yes. But loader may put constraints like "I don't accept text mode". In this case if we're in text mode then "keep" is rejected as unacceptable. > > I think native resolution detection is an oppo

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
>> Constants are i386-pc specific. In particular left and right shift are >> distinguished but not ctrl or alt. We should either distinguish them >> all or none. > > The values I picked for the constants were convenient for i386-pc, but > that's because it's the only architecture that currently nee

Re: [PATCH 2/2] "auto" keyword in gfxmode and gfxpayload specification

2009-08-23 Thread Robert Millan
On Sun, Aug 23, 2009 at 01:01:16PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > > > Ah, I see.  Yeah, we really should contemplate into detecting native > > resolutions. > > > > But is there any reason we don't want this behaviour when gfxmode was > > not set?  If we can avoid an additional keyw

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
On Mon, Aug 24, 2009 at 12:27 AM, Robert Millan wrote: > On Wed, Aug 12, 2009 at 04:35:21PM +0100, Colin Watson wrote: >> +static int >> +grub_at_keyboard_keystatus (void) >> +{ >> +  /* FIXME: I don't know if getting key modifier status is possible without >> +   * BIOS help.  */ >> +  return 0; >

Re: [PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
> > Then I don't understand what > >  grub_video_set_mode ("1024x768;800x600;640x480", > GRUB_VIDEO_MODE_TYPE_PURE_TEXT) > > could mean.  Are you requesting a graphical mode or a text one?  If it's a > text one, why the list of resolutions? Actually it's grub_video_set_mode ("auto", GRUB_VIDEO_MOD

Re: pc.mod -> part_msdos.mod (etc)

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
On Sun, Aug 23, 2009 at 8:42 PM, Vladimir 'phcoder' Serbinenko wrote: >>> As was discussed in >>> http://www.mail-archive.com/grub-devel@gnu.org/msg06210.html >>> I intend to prefix all partmap modules with "part_" and rename "pc" to >>> "part_msdos". > This partition scheme is "PC-style" ans call

Re: [PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode

2009-08-23 Thread Robert Millan
On Sun, Aug 23, 2009 at 12:58:46PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > Btw, please include a ChangeLog entry next time. > Ok. I will from now one but it will also mean a delay sending patches ;) I know it's a PITA, but consider that it needs to be done anyway. When you think about tha

Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

2009-08-23 Thread Robert Millan
On Wed, Aug 12, 2009 at 04:35:21PM +0100, Colin Watson wrote: > +static int > +grub_at_keyboard_keystatus (void) > +{ > + /* FIXME: I don't know if getting key modifier status is possible without > + * BIOS help. */ > + return 0; > +} > + What we do in these cases is leave the function pointe

Re: pc.mod -> part_msdos.mod (etc)

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
It broke grub-install. I already fixed it. On Sun, Aug 23, 2009 at 2:01 PM, Robert Millan wrote: > > Done. > > On Tue, Aug 18, 2009 at 07:57:51PM +0200, Robert Millan wrote: >> >> Hi, >> >> As was discussed in >> http://www.mail-archive.com/grub-devel@gnu.org/msg06210.html >> I intend to prefix a

[PATCH] BSD fixes (make OpenBSD work again)

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git diff --git a/ChangeLog b/ChangeLog index a00842c..f1a0447 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,19 @@ 2009-08-23 Vladimir Serbinenko + Fix OpenBSD and NetBSD support. +

Re: pc.mod -> part_msdos.mod (etc)

2009-08-23 Thread Colin Watson
On Sun, Aug 23, 2009 at 08:42:52PM +0200, Vladimir 'phcoder' Serbinenko wrote: > This partition scheme is "PC-style" ans calling it "msdos" effectively > means miscrediting IBM's work to Microsoft. I don't believe this to be > correct. It's consistent with GNU Parted though ... -- Colin Watson

Re: pc.mod -> part_msdos.mod (etc)

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
>> As was discussed in >> http://www.mail-archive.com/grub-devel@gnu.org/msg06210.html >> I intend to prefix all partmap modules with "part_" and rename "pc" to >> "part_msdos". This partition scheme is "PC-style" ans calling it "msdos" effectively means miscrediting IBM's work to Microsoft. I don

[PATCH] Add --root=DEVICE parameter support when boot NetBSD.

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
Currently grub2 tries to guess root device name in OS notation basing on BIOS number. This fails in multiple cases. This patch lets user specify root device. -- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git diff --git a/ChangeLog b/ChangeLog

Re: Some ideas about new features of grub

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
>> But I know both Marco and Pavel feel strongly about this.  Please can you >> comment? >> > > I am against a configure flag (if configure is the one from configure, make, > make install) but a configure flag (as something specified in grub.cfg) is > ok. Writing to filesystems is dangerous. Curre

Re: Grub2 LUA API?

2009-08-23 Thread adrian15
Bean escribió: Hi, You can use grub.enum_device, which pass the uuid to the callback function, then you can store the device->uuid mapping in a table. Thank you. I will check your advice. If you're looking for source code, check out script/lua/grub_lib.c I would have prefered documentation b

Re: Some ideas about new features of grub

2009-08-23 Thread adrian15
Robert Millan escribió: On Thu, Jul 02, 2009 at 04:48:56PM +0800, Bean wrote: LUA integration. LUA is quite powerful, it's more suitable to do complicated task than sh script. For example, we can use it to detect os at runtime, implement simple commands, or draw the graphic menu. I feel simila

Re: [PATCH] fix an infinite loop with a corrupted pc partition table

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
On Tue, Jul 28, 2009 at 7:55 PM, Robert Millan wrote: > On Sun, Jul 26, 2009 at 12:58:59AM +0200, Vladimir 'phcoder' Serbinenko wrote: >> +      /* This is our loop-detection algorithm. It works the following way: >> +      It saves last position which was a power of two. Then it compares the >> +

Re: Configuration option to disable os-prober?

2009-08-23 Thread Felix Zielcke
Am Sonntag, den 23.08.2009, 15:31 +0100 schrieb Colin Watson: > On Sun, Aug 23, 2009 at 03:22:41PM +0200, Felix Zielcke wrote: > > Doestn't grub-mkconfig need to export it so it's actually usable > > in /etc/default/grub? > > Yes, that seems likely. Sorry about that. > Commited. -- Felix Zielc

Re: Configuration option to disable os-prober?

2009-08-23 Thread Colin Watson
On Sun, Aug 23, 2009 at 03:22:41PM +0200, Felix Zielcke wrote: > Doestn't grub-mkconfig need to export it so it's actually usable > in /etc/default/grub? Yes, that seems likely. Sorry about that. 2009-08-23 Colin Watson * util/grub-mkconfig.in: Export GRUB_DISABLE_OS_PROBER. Index: u

Re: Configuration option to disable os-prober?

2009-08-23 Thread Felix Zielcke
Am Sonntag, den 23.08.2009, 14:59 +0200 schrieb Robert Millan: > Looks like this one was forgotten. I've committed it. > > Btw, in the future please include ChangeLog entries when submitting patches. > > On Wed, Jul 08, 2009 at 04:38:23PM +0100, Colin Watson wrote: > > Hi, > > > > Some people s

Re: [PATCH] Eliminate script line length limit

2009-08-23 Thread Robert Millan
On Sat, Aug 22, 2009 at 04:30:08PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Making GNU GRUB more GNU ;) Good! But please could you use NULL for pointers? :-) Also, remember to include a ChangeLog entry. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide

Re: [PATCH] Clear out gfxterm's virtual text_buffer - fixes junk at end of lines

2009-08-23 Thread Robert Millan
On Wed, Jul 22, 2009 at 10:42:54AM -0700, Joe Auricchio wrote: >> >> So perhaps this can be solved simpler by replacing grub_malloc with >> grub_zalloc ? > > I saw the zalloc commit and thought the same thing! :D I'll test it. But > fg_color and bg_color must be set to the screen's current colors,

Re: Configuration option to disable os-prober?

2009-08-23 Thread Robert Millan
Looks like this one was forgotten. I've committed it. Btw, in the future please include ChangeLog entries when submitting patches. On Wed, Jul 08, 2009 at 04:38:23PM +0100, Colin Watson wrote: > Hi, > > Some people seem to want to disable os-prober for various reasons (e.g. > they have lots of

Re: Some ideas about new features of grub

2009-08-23 Thread Robert Millan
On Thu, Jul 02, 2009 at 04:48:56PM +0800, Bean wrote: > > LUA integration. > LUA is quite powerful, it's more suitable to do complicated task than > sh script. For example, we can use it to detect os at runtime, > implement simple commands, or draw the graphic menu. I feel similarly about LUA as

Re: Some ideas about new features of grub

2009-08-23 Thread Robert Millan
On Thu, Jul 02, 2009 at 04:48:56PM +0800, Bean wrote: > > Read/Write file system support > We can implement two kind of fs drivers. The boot time driver is > read-only, but after entering normal mode, we can optionally load > another driver for write support. This approach has been used by EFI. >

Re: [WIP PATCH 2/2] SDL support

2009-08-23 Thread Robert Millan
Hi, IIRC this was waiting for the video split patch to go in. I assume it'll need some update for current head? On Mon, Jun 15, 2009 at 05:21:38PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello here I have a preliminary SDL support. With this WIP patch you > have to add LD_FLAGS=-lSDL to

Re: please try to remember to update NEWS

2009-08-23 Thread Robert Millan
On Fri, Jun 05, 2009 at 11:08:44AM +0200, Felix Zielcke wrote: > Hello all, > > it would be very nice if you could remember to add a NEWS entry if you > add some fancy new feature which end users would like. > For examples just look in NEWS ;) > > Yesterday I added again a few things but probable

Re: Nightly build script

2009-08-23 Thread Robert Millan
On Mon, Apr 13, 2009 at 11:46:12AM +0200, phcoder wrote: > Hello, here is a first proposition of a script for nightly builds. On > IRC Yoshinori K. Okuji said that grub.enbug.org could be used to host > these files. Can this server do the builds too? If not can someone setup > build factory?

Re: My implementation of the grub2 boot rom

2009-08-23 Thread Robert Millan
Hi Bean, It appears this has been overlooked for quite a while. If you could resync and re-send it as a patch, I'll be glad to review and see about getting it merged. On Mon, Dec 03, 2007 at 04:19:12AM +0800, Bean wrote: > Hi, > > I've written my own code for grub2 boot rom, the steps are: >

Re: ISA Option ROM booting capability

2009-08-23 Thread Robert Millan
Hi, Are you still interested in getting this merged? If you are, please let us know. We'd need you to submit a patch to the list in that case (external URLs are problematic). Don't worry if it's not up-to-date, for initial review it should be OK. On Sun, Nov 25, 2007 at 09:10:29PM +0200, UrJi

Re: pc.mod -> part_msdos.mod (etc)

2009-08-23 Thread Robert Millan
Done. On Tue, Aug 18, 2009 at 07:57:51PM +0200, Robert Millan wrote: > > Hi, > > As was discussed in > http://www.mail-archive.com/grub-devel@gnu.org/msg06210.html > I intend to prefix all partmap modules with "part_" and rename "pc" to > "part_msdos". > > If anyone has an objection, please s

[PATCH] NetBSD64 support

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git diff --git a/ChangeLog b/ChangeLog index 6cf11a6..6c36901 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,12 @@ 2009-08-23 Vladimir Serbinenko + Support for 64-bit NetBSD. + +

[PATCH] Support --no-smp and --no-acpi for NetBSD

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
-- Regards Vladimir 'phcoder' Serbinenko Personal git repository: http://repo.or.cz/w/grub2/phcoder.git diff --git a/ChangeLog b/ChangeLog index 6cf11a6..92d8d80 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,14 @@ 2009-08-23 Vladimir Serbinenko + Support --no-smp and --no-acpi for

Re: [GITGRUB] FB driver for EFI

2009-08-23 Thread Robert Millan
On Wed, Aug 19, 2009 at 05:22:24PM +0200, Robert Millan wrote: > On Tue, Aug 18, 2009 at 09:26:45PM +0800, Bean wrote: > > Hi, > > > > Here is the raw patch. > > Thanks. Was efi_fb.c written from scratch, or copied/refurbished from another > part of GRUB ? It's ok either way, but we need to kno

Re: [PATCH] Fix hfsplus.

2009-08-23 Thread Robert Millan
On Sat, Aug 22, 2009 at 09:43:24PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. In multiple places hfsplus aborts if read_file returns 0. But > in this case grub_error isn't set so the errors aren't propagated. > Here is fix. Please go ahead. -- Robert Millan The DRM opt-in fallacy: "

Re: [PATCH] Replace ad-hoc format in efiemu (for variables) and XNU (for device tree) by environment variables

2009-08-23 Thread Robert Millan
On Sat, Aug 22, 2009 at 04:33:13PM +0200, Vladimir 'phcoder' Serbinenko wrote: > [...] > + > +pkglib_MODULES += utf.mod > +utf_mod_SOURCES = lib/utf.c > +utf_mod_CFLAGS = $(COMMON_CFLAGS) > +utf_mod_LDFLAGS = $(COMMON_LDFLAGS) > [...] > +#include > + > +grub_ssize_t > +grub_utf8_to_utf16 (grub_uin

Re: Report: compil error on OSX for target=i386

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
>> What about following compromise: >> [...] > > I'm not sure what's the problem here.  AFAIK inline assembly had this syntax > with GCC 4.0 already.  Did Apple cripple it in their version of GCC ? Yes. They don't allow usage of %ebx/%rbx in constraints and clobbered registers > > -- > Robert Milla

Re: grub-mkconfig fails on every non i386-pc because of gfxterm/vbe

2009-08-23 Thread Robert Millan
On Sun, Aug 23, 2009 at 10:22:49AM +0200, Felix Zielcke wrote: > Am Donnerstag, den 20.08.2009, 18:18 -0400 schrieb Pavel Roskin: > > On Wed, 2009-08-19 at 17:18 +0200, Robert Millan wrote: > > > > > The eye candy is nice but not so important. For me, gfxterm should be > > > default on platforms

Re: [PATCH] Optimised 1bit blitters

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
On Sun, Aug 23, 2009 at 12:48 PM, Robert Millan wrote: > On Fri, Aug 21, 2009 at 05:33:30PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> +  for (j = 0; j < height; j++) >> +    { >> +      for (i = 0; i < width; i++) >> +        { > > It's a bit odd, but GCC doesn't seem to optimize those in a si

Re: [PATCH 2/2] "auto" keyword in gfxmode and gfxpayload specification

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
> > Ah, I see.  Yeah, we really should contemplate into detecting native > resolutions. > > But is there any reason we don't want this behaviour when gfxmode was > not set?  If we can avoid an additional keyword, what we do fits better > with what the user would expect. When gfxmode wasn't set it's

Re: [PATCH] Clean up struct grub_module_header

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
On Sun, Aug 23, 2009 at 12:50 PM, Robert Millan wrote: > On Sat, Aug 22, 2009 at 02:10:12AM -0400, Pavel Roskin wrote: >> +enum >> +{ >> +  OBJ_TYPE_ELF, >> +  OBJ_TYPE_MEMDISK, >> +  OBJ_TYPE_CONFIG >> +}; > > Do we actually use OBJ_TYPE_CONFIG ?  I think it's there in the framework, > but we don'

Re: Report: compil error on OSX for target=i386

2009-08-23 Thread Robert Millan
On Sat, Aug 22, 2009 at 08:00:10PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 10, 2009 at 1:41 PM, Robert Millan wrote: > > On Sat, Aug 08, 2009 at 10:44:25PM +0800, Bean wrote: > >> Hi, > >> > >> I also encounter this problem with apple gcc 4.0, the fix is to replace: > >> > >> asm

Re: pc.mod -> part_msdos.mod (etc)

2009-08-23 Thread Robert Millan
On Tue, Aug 18, 2009 at 08:11:10PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Tue, Aug 18, 2009 at 7:57 PM, Robert Millan wrote: > > > > Hi, > > > > As was discussed in > > http://www.mail-archive.com/grub-devel@gnu.org/msg06210.html > > I intend to prefix all partmap modules with "part_" an

Re: [PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
On Sun, Aug 23, 2009 at 12:30 PM, Robert Millan wrote: > > I've only one comment, the rest looks fine. > > Btw, please include a ChangeLog entry next time. Ok. I will from now one but it will also mean a delay sending patches ;) > People usually associate "pure text" mode with a managed mode like 8

Re: [GITGRUB] FB driver for EFI

2009-08-23 Thread Robert Millan
On Sun, Aug 23, 2009 at 01:07:55PM +0200, Robert Millan wrote: > > Btw, the patch itself looks fine to me. When you commit it, please make sure > its ChangeLog entry documents whether this was moved from another part of GRUB > or is new code. Erm, sorry I didn't notice that Vladimir raised some

Re: [PATCH] Split big and little endian BeFS and AtheFS

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
On Sun, Aug 23, 2009 at 12:40 PM, Robert Millan wrote: > On Thu, Aug 20, 2009 at 06:16:24PM -0400, Pavel Roskin wrote: >> I don't think we should rename "byte_order" to "unused".  Just because >> we doesn't use it now to determine the endianess, > > Shouldn't we be checking for it?  (and error out

Re: [PATCH] Use extcmd to handle bsd arguments.

2009-08-23 Thread Robert Millan
On Sat, Aug 22, 2009 at 02:22:24PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. Currently bsd loaders inspects argv[1] for boot options but the > treat argv[1] as if it always was prefixed by dash ('-') and > completely ignores options in argv[n], n>1. This leads to unexpected > results lik

Re: [PATCH] Replace ad-hoc format in efiemu (for variables) and XNU (for device tree) by environment variables

2009-08-23 Thread Vladimir 'phcoder' Serbinenko
On Sun, Aug 23, 2009 at 12:57 PM, Robert Millan wrote: > On Sat, Aug 22, 2009 at 04:33:13PM +0200, Vladimir 'phcoder' Serbinenko wrote: >> [...] >> + >> +pkglib_MODULES += utf.mod >> +utf_mod_SOURCES = lib/utf.c >> +utf_mod_CFLAGS = $(COMMON_CFLAGS) >> +utf_mod_LDFLAGS = $(COMMON_LDFLAGS) >> [...]

Re: [PATCH] Clean up struct grub_module_header

2009-08-23 Thread Robert Millan
On Sat, Aug 22, 2009 at 02:10:12AM -0400, Pavel Roskin wrote: > +enum > +{ > + OBJ_TYPE_ELF, > + OBJ_TYPE_MEMDISK, > + OBJ_TYPE_CONFIG > +}; Do we actually use OBJ_TYPE_CONFIG ? I think it's there in the framework, but we don't provide any means to use it. Instead, grub-mkrescue puts grub.cfg

Re: [PATCH] Optimised 1bit blitters

2009-08-23 Thread Robert Millan
On Fri, Aug 21, 2009 at 05:33:30PM +0200, Vladimir 'phcoder' Serbinenko wrote: > + for (j = 0; j < height; j++) > +{ > + for (i = 0; i < width; i++) > +{ It's a bit odd, but GCC doesn't seem to optimize those in a single loop. Could you use "i = 0; i < height * width; i++" inste

Re: [PATCH] Split big and little endian BeFS and AtheFS

2009-08-23 Thread Robert Millan
On Thu, Aug 20, 2009 at 06:16:24PM -0400, Pavel Roskin wrote: > I don't think we should rename "byte_order" to "unused". Just because > we doesn't use it now to determine the endianess, Shouldn't we be checking for it? (and error out if mismatch). -- Robert Millan The DRM opt-in fallacy: "Y

Re: [PATCH] import multiboot1 specification in grub trunk

2009-08-23 Thread Robert Millan
On Thu, Aug 20, 2009 at 10:56:09PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Thu, Aug 20, 2009 at 6:28 PM, Robert Millan wrote: > > On Wed, Aug 19, 2009 at 05:38:58PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > >> On Wed, Aug 19, 2009 at 5:34 PM, Robert Millan wrote: > >> > On Wed, Au

Re: [PATCH 2/2] "auto" keyword in gfxmode and gfxpayload specification

2009-08-23 Thread Robert Millan
On Fri, Aug 21, 2009 at 02:57:45PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 17, 2009 at 3:49 PM, Robert Millan wrote: > > > > > > Please could you include a description on what this does? > > > when gfxmode=auto the driver is allowed to pick best mode in its > opinion among the mod

Re: [PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode

2009-08-23 Thread Robert Millan
I've only one comment, the rest looks fine. Btw, please include a ChangeLog entry next time. On Sun, Aug 16, 2009 at 08:51:06PM +0200, Vladimir 'phcoder' Serbinenko wrote: > diff --git a/commands/videotest.c b/commands/videotest.c > index 6fe4b9b..07f61bd 100644 > --- a/commands/videotest.c > ++

Re: [PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode

2009-08-23 Thread Robert Millan
On Fri, Aug 21, 2009 at 02:54:32PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 17, 2009 at 3:51 PM, Robert Millan wrote: > > On Sun, Aug 16, 2009 at 08:51:06PM +0200, Vladimir 'phcoder' Serbinenko > > wrote: > >> After discussion on IRC it revealed that hook-based approach is > >> un

Re: Re[2]: 'password' command in GRUB 2?

2009-08-23 Thread Robert Millan
On Fri, Aug 21, 2009 at 01:30:14PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > > >> +grub_err_t > >> +grub_auth_check_authentication (const char *userlist) > >> +{ > >> +  char login[1024] = {0}; > > > > Please avoid arbitrary limits.  If the grub_cmdline_get() API is enforcing > > them, then t

Re: grub-mkconfig fails on every non i386-pc because of gfxterm/vbe

2009-08-23 Thread Felix Zielcke
Am Donnerstag, den 20.08.2009, 18:18 -0400 schrieb Pavel Roskin: > On Wed, 2009-08-19 at 17:18 +0200, Robert Millan wrote: > > > The eye candy is nice but not so important. For me, gfxterm should be > > default on platforms where it's available, because it implements UTF-8, > > which is necessary

Re: [GITGRUB] Support new object format for powerpc-ieee1275

2009-08-23 Thread Bean
Hi, Update: Support ppc mach-o object file, now you can compile grub2 powerpc-ieee1275 in OSX. As Xcode have included powerpc cross compiler, you don't need to install extra software, just use the following configure command: ./configure --with-platform=ieee1275 --target=powerpc TARGET_CC=power