Re: [PATCH] grub_video_fbrender_target

2009-11-23 Thread Robert Millan
On Sun, Nov 22, 2009 at 02:01:00PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Robert Millan wrote: According to its description, struct grub_video_fbrender_target is a driver-specific structure. video_fb.c is generic code and shouldn't be using this struct to define its function

Re: [ISSUE SOLVED] Re: bazaar

2009-11-23 Thread Robert Millan
On Mon, Nov 23, 2009 at 02:40:28AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: I managed to unmerge our mainstream by using raw revid (visible with bzr log -n0 --show-ids) by bzr branch -r revid:..revid.. mainline mainline-real If you comitted recently please check if nothing is

Re: [ISSUE SOLVED] Re: bazaar

2009-11-23 Thread Robert Millan
On Mon, Nov 23, 2009 at 02:40:28AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: I managed to unmerge our mainstream by using raw revid (visible with bzr log -n0 --show-ids) by bzr branch -r revid:..revid.. mainline mainline-real Btw with mainstream and mainline, I assume you refer to

Re: [ISSUE SOLVED] Re: bazaar

2009-11-23 Thread Robert Millan
On Mon, Nov 23, 2009 at 10:59:34AM +0100, Carles Pina i Estany wrote: bzr checkout of trunk (fresh checkout) 1.- cd grub 2.- bzr merge sftp://. people/carles/gettext (as I understood from you in IRC) These two by themselves don't modify the remote tree (you'd need bzr commit) After

UGA FB driver (Re: [GITGRUB] FB driver for EFI)

2009-11-23 Thread Robert Millan
I merged this patch, with some adjustments. GOP is intentionally left out. It depends on missing struct definitions not present in the patch, which would be easy to reconstruct based reusing UGA ones but I don't have the hardware to test it. And in any case, our future direction are

Re: errno handling

2009-11-23 Thread Robert Millan
On Sun, Nov 22, 2009 at 11:24:14PM +, Carles Pina i Estany wrote: discussed in irc with phcoder: no changes here because would be a caller bug. Some day I will take a look on a possible callers that are not resetting grub_errno after functions that are setting up (so can lead to problems

Re: gettextizing

2009-11-23 Thread Robert Millan
On Sun, Nov 22, 2009 at 10:28:22PM +, Carles Pina i Estany wrote: This one needs some cleanup before it can be gettextized. Translators should receive complete messages with no kludges in them. See info gettext Preparing Strings for more details on that. For example, these shouldn't be

Re: gettext order

2009-11-23 Thread Robert Millan
On Mon, Nov 23, 2009 at 01:18:18AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Carles Pina i Estany wrote: Hello, Tomorrow Monday I will probably gettextize the help of the all grub_register_command. Is it all right? In general, I would translate mainly all grub_printf

Re: gettext order

2009-11-23 Thread Robert Millan
On Mon, Nov 23, 2009 at 12:15:18AM +, Carles Pina i Estany wrote: From the utilities, something that would be good to priorize? I think that, barring the obvious strings we'd like to translate (which you already spotted), utilities should be the top priority. The other non-util strings need

Re: gettextize normal/menu_text.c (print_timeout)

2009-11-23 Thread Robert Millan
On Sun, Nov 22, 2009 at 11:50:13PM +, Carles Pina i Estany wrote: === modified file 'normal/menu_text.c' --- normal/menu_text.c2009-11-22 22:24:54 + +++ normal/menu_text.c2009-11-22 23:40:20 + @@ -262,12 +262,34 @@ return entry; } +static char*

Re: [ISSUE SOLVED] Re: bazaar

2009-11-23 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Robert Millan wrote: On Mon, Nov 23, 2009 at 02:40:28AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: I managed to unmerge our mainstream by using raw revid (visible with bzr log -n0 --show-ids) by bzr branch -r revid:..revid.. mainline mainline-real If you comitted recently

Re: gettext order

2009-11-23 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Robert Millan wrote: On Mon, Nov 23, 2009 at 01:18:18AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: Carles Pina i Estany wrote: Hello, Tomorrow Monday I will probably gettextize the help of the all grub_register_command. Is it all right? In general, I would translate

Re: Just a cosmetic question about grub_vprintf()?

2009-11-23 Thread Robert Millan
On Sun, Nov 22, 2009 at 01:10:11PM +, rubisher wrote: But as far as the 1st parameter of grub_vsprintf is a pointer, wouldn't it be better to write: --- kern/misc.c.orig 2009-11-22 13:07:22.0 + +++ kern/misc.c 2009-11-22 13:07:51.0 + @@ -160,7 +160,7 @@ {

Contents of PO file 'grub-1.97+20091122.zh_CN.po'

2009-11-23 Thread Translation Project Robot
grub-1.97+20091122.zh_CN.po.gz Description: Binary data The Translation Project robot, in the name of your translation coordinator. coordina...@translationproject.org

New Chinese (simplified) PO file for 'grub' (version 1.97+20091122)

2009-11-23 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'grub' has been submitted by the Chinese (simplified) team of translators. The file is available at: http://translationproject.org/latest/grub/zh_CN.po (This file,

Re: [RFC][PATCH] Basic unit testing support for GRUB

2009-11-23 Thread BVK
Hi, I have been busy last week, so I couldn't reply :-( But I am able to complete most of the framework. It has support for logging multiple testcase failures and reporting them at the end of test execution. Please go through the attached patch and let me know your suggestions. Attached

Re: gettextizing

2009-11-23 Thread Jordi Mallach
On Mon, Nov 23, 2009 at 12:56:15PM +0100, Robert Millan wrote: + grub_printf (_(\ [ Minimal BASH-like line editing is supported. For the first word, TAB\n\ ^ lists possible command completions. Anywhere else TAB lists possible\n\

Re: gettextizing

2009-11-23 Thread Robert Millan
On Mon, Nov 23, 2009 at 05:28:51PM +0100, Jordi Mallach wrote: - grub_printf (\nPress any key to continue...); + grub_printf (_(\nPress any key to continue...)); I'm not sure if the spaces and newlines here would be a problem. Jordi, any comment? Not a big issue in this case.

should i18n.h include misc.h if internal ?

2009-11-23 Thread Carles Pina i Estany
Hello, Imagine that I'm going to gettexttize commands/true.c . I need to add #include grub/i18n.h , but this include defines: # define _(str) grub_gettext(str) so I need #include grub/misc.h Any problem with this patch: === modified file 'include/grub/i18n.h' --- include/grub/i18n.h

Re: gfxmenu available in experimental

2009-11-23 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Colin D Bennett wrote: On Fri, 20 Nov 2009 23:17:51 +0100 Vladimir 'φ-coder/phcoder' Serbinenko phco...@gmail.com wrote: Hello, all. After various delays with various cause I'm proud to announce the availability of Colin's gfxmenu into experimental branch of grub2. Thanks for