Re: [PATCH] Enable the datetime module for the emu platform

2020-03-06 Thread Javier Martinez Canillas
Hello Mike, On 3/5/20 10:52 PM, Mike Gilbert wrote: > Fixes a build failure: > > grub-core/commands/date.c:49: undefined reference to `grub_get_weekday_name' > grub-core/commands/ls.c:155: undefined reference to `grub_unixtime2datetime' > > Bug: https://bugs.gentoo.org/711512 > Signed-off-by: Mi

Re: [PATCH v2] docs: Update for stopping small mbr gap support

2020-03-06 Thread Javier Martinez Canillas
Hello Michael, On 3/6/20 7:53 AM, Michael Chang wrote: > Further to the discussion about disabling btrfs zstd support for > i386-pc[1], this paragraph in manual about mbr gap size doesn't seem to > hold true any longer. > > "You must ensure that the first partition starts at least 31 KiB (63 > se

Re: [PATCH] Enable the datetime module for the emu platform

2020-03-06 Thread Daniel Kiper
On Fri, Mar 06, 2020 at 11:09:08AM +0100, Javier Martinez Canillas wrote: > Hello Mike, > > On 3/5/20 10:52 PM, Mike Gilbert wrote: > > Fixes a build failure: > > > > grub-core/commands/date.c:49: undefined reference to `grub_get_weekday_name' > > grub-core/commands/ls.c:155: undefined reference to

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Javier Martinez Canillas
Hello Vladimir, Thanks a lot for your feedback. On 3/5/20 3:22 PM, Vladimir 'phcoder' Serbinenko wrote: > Please evaluate size increase for this. In the past passing file and line > number to grub_dprintf was a huge source of increased Kern and core size > > Le mer. 4 mars 2020 à 13:01, Javier M

Re: [PATCH v2] docs: Update for stopping small mbr gap support

2020-03-06 Thread Daniel Kiper
On Fri, Mar 06, 2020 at 11:38:49AM +0100, Javier Martinez Canillas wrote: > Hello Michael, > > On 3/6/20 7:53 AM, Michael Chang wrote: > > Further to the discussion about disabling btrfs zstd support for > > i386-pc[1], this paragraph in manual about mbr gap size doesn't seem to > > hold true any l

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir 'phcoder' Serbinenko
Le ven. 6 mars 2020 à 12:38, Javier Martinez Canillas a écrit : > Hello Vladimir, > > Thanks a lot for your feedback. > > On 3/5/20 3:22 PM, Vladimir 'phcoder' Serbinenko wrote: > > Please evaluate size increase for this. In the past passing file and line > > number to grub_dprintf was a huge sou

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Daniel Kiper
On Thu, Mar 05, 2020 at 03:22:31PM +0100, Vladimir 'phcoder' Serbinenko wrote: > Please evaluate size increase for this. In the past passing file and line > number to grub_dprintf was a huge source of increased Kern and core size I think it does not matter much if we stop pretending that we suppor

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Javier Martinez Canillas
On 3/6/20 12:41 PM, Vladimir 'phcoder' Serbinenko wrote: > Le ven. 6 mars 2020 à 12:38, Javier Martinez Canillas > a écrit : > >> Hello Vladimir, >> >> Thanks a lot for your feedback. >> >> On 3/5/20 3:22 PM, Vladimir 'phcoder' Serbinenko wrote: >>> Please evaluate size increase for this. In the

Re: [PATCH v2 1/2] exfat: Save the matching directory entry when iterating

2020-03-06 Thread Daniel Kiper
On Tue, Mar 03, 2020 at 02:40:54PM -0500, David Michael wrote: > This provides the node's attributes outside the search function. > > Signed-off-by: David Michael Reviewed-by: Daniel Kiper ...except one nit... > --- > > I had to copy an extra struct to support exfat mtimes, so I put it in a >

Re: [PATCH v2 2/2] fat: Support file modification times

2020-03-06 Thread Daniel Kiper
On Tue, Mar 03, 2020 at 02:41:08PM -0500, David Michael wrote: > This allows comparing file ages on EFI system partitions. > > Signed-off-by: David Michael > --- > > Changes since v1: > - Added the previous patch to help support exfat > - Added exfat timestamp conversion + setting > - Switch

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Daniel Kiper
Re-adding grub-devel@gnu.org... On Fri, Mar 06, 2020 at 12:44:05PM +0100, Vladimir 'phcoder' Serbinenko wrote: > Le ven. 6 mars 2020 à 12:42, Daniel Kiper a écrit : > > > On Thu, Mar 05, 2020 at 03:22:31PM +0100, Vladimir 'phcoder' Serbinenko > > wrote: > > > Please evaluate size increase for thi

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir 'phcoder' Serbinenko
Le ven. 6 mars 2020 à 13:43, Daniel Kiper a écrit : > Re-adding grub-devel@gnu.org... > > On Fri, Mar 06, 2020 at 12:44:05PM +0100, Vladimir 'phcoder' Serbinenko > wrote: > > Le ven. 6 mars 2020 à 12:42, Daniel Kiper a écrit > : > > > > > On Thu, Mar 05, 2020 at 03:22:31PM +0100, Vladimir 'phcod

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Didier Spaier
Le 06/03/2020 à 13:43, Daniel Kiper a écrit : > If we go that way then we have to care about them by the end of the > universe. And this means more and more issues like [1]. If somebody > wants to use new GRUB then he/she have to reinstall the machine or > something like that. IMO we should not car

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir 'phcoder' Serbinenko
On Fri, Mar 6, 2020 at 3:02 PM Didier Spaier wrote: > > Le 06/03/2020 à 13:43, Daniel Kiper a écrit : > > If we go that way then we have to care about them by the end of the > > universe. And this means more and more issues like [1]. If somebody > > wants to use new GRUB then he/she have to reinst

Re: [PATCH v2 2/2] fat: Support file modification times

2020-03-06 Thread David Michael
On Fri, Mar 6, 2020 at 7:19 AM Daniel Kiper wrote: > On Tue, Mar 03, 2020 at 02:41:08PM -0500, David Michael wrote: > > This allows comparing file ages on EFI system partitions. > > > > Signed-off-by: David Michael > > --- > > > > Changes since v1: > > - Added the previous patch to help support

Re: [PATCH v2 2/2] fat: Support file modification times

2020-03-06 Thread Daniel Kiper
On Fri, Mar 06, 2020 at 10:48:07AM -0500, David Michael wrote: > On Fri, Mar 6, 2020 at 7:19 AM Daniel Kiper wrote: > > On Tue, Mar 03, 2020 at 02:41:08PM -0500, David Michael wrote: > > > This allows comparing file ages on EFI system partitions. > > > > > > Signed-off-by: David Michael > > > ---

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Didier Spaier
Le 06/03/2020 à 15:38, Vladimir 'phcoder' Serbinenko a écrit : > What's the problem with having bios boot partition? You can put it > exactly in the spot you describe (in fact I do so) and it works as > well, just additionally it marks this space as occupied That'd be just one less thing to care a

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Lennart Sorensen
On Fri, Mar 06, 2020 at 05:30:23PM +0100, Didier Spaier wrote: > That'd be just one less thing to care about for the Slint installer > in case of an 'automatic' installation, nothing major. > > Do you confirm that a Bios Boot partition starting at 1 KiB > and ending at 1 MiB won't overlap the GPT

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread David Michael
On Fri, Mar 6, 2020 at 9:02 AM Didier Spaier wrote: > Le 06/03/2020 à 13:43, Daniel Kiper a écrit : > > If we go that way then we have to care about them by the end of the > > universe. And this means more and more issues like [1]. If somebody > > wants to use new GRUB then he/she have to reinstal

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Didier Spaier
Le 06/03/2020 à 17:39, Lennart Sorensen a écrit : > On Fri, Mar 06, 2020 at 05:30:23PM +0100, Didier Spaier wrote: >> That'd be just one less thing to care about for the Slint installer >> in case of an 'automatic' installation, nothing major. >> >> Do you confirm that a Bios Boot partition star

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Bruce Dubbs
On 3/6/20 11:03 AM, David Michael wrote: On Fri, Mar 6, 2020 at 9:02 AM Didier Spaier wrote: Le 06/03/2020 à 13:43, Daniel Kiper a écrit : If we go that way then we have to care about them by the end of the universe. And this means more and more issues like [1]. If somebody wants to use new GR

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Lennart Sorensen
On Fri, Mar 06, 2020 at 11:12:14AM -0600, Bruce Dubbs wrote: > Just a terminology issue here. Please don't call it a boot partition. It > conflicts with those who mount /boot as a separate partition. Please call > it a grub partition. Well the official name is "BIOS boot partition", so I can see

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Lennart Sorensen
On Fri, Mar 06, 2020 at 06:10:58PM +0100, Didier Spaier wrote: > My mistake, I should have written starting at 24 KiB as that is the > start address of the first usable LBA if I read correctly the UEFI > specification. Am I wrong? > > Thanks for the heads-up. I was wrong about 32KB, it is 32 sect

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Didier Spaier
Le 06/03/2020 à 18:03, David Michael a écrit : > On Fri, Mar 6, 2020 at 9:02 AM Didier Spaier wrote: >> Le 06/03/2020 à 13:43, Daniel Kiper a écrit : >>> If we go that way then we have to care about them by the end of the >>> universe. And this means more and more issues like [1]. If somebody >>>

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose

2020-03-06 Thread Vladimir 'phcoder' Serbinenko
> It would be best to use a boot partition so the core.img space is > reserved by the GPT, but I once wanted to tack i386-pc GRUB onto an > existing UEFI GPT disk, so I wrote the commands that do what you're > describing here: > > https://github.com/dm0-/installer/blob/master/examples/systems/fitpc

[PATCH v3 1/2] exfat: Save the matching directory entry struct when searching

2020-03-06 Thread David Michael
This provides the node's attributes outside the iterator function so the file modification time can be accessed and reported. Signed-off-by: David Michael --- Changes since v2: * Updated commit message grub-core/fs/fat.c | 31 --- 1 file changed, 16 insertions(+),

[PATCH v3 2/2] fat: Support file modification times

2020-03-06 Thread David Michael
This allows comparing file ages on EFI system partitions. Signed-off-by: David Michael --- Changes since v2: * Added comments referencing the specs * Set errno when the timestamp is invalid I set errno rather than print to the console since it looks like most other file systems don't tend t